activerecord-mysqlspatial-adapter 0.3.2 → 0.4.0

data/History.rdoc

@@ -1,3 +1,15 @@
+=== 0.4.0 / 2011-08-15
+
+* Various fixes towards Rails 3.1 compatibility. However, this adapter is not yet actually Rails 3.1 compatible because of a bug in the mysql gem. Use activerecord-mysql2-adapter for now if you need Rails 3.1 support.
+* Now requires rgeo-activerecord 0.4.0.
+* INCOMPATIBLE CHANGE: simple queries (e.g. MyClass.where(:latlon => my_point)) use an objective rather than spatial equality test. Earlier versions transformed this form to use st_equals, but now if you need to test for spatial equality, you'll need to call st_equals explicitly. I'm still evaluating which direction we want to go with this in the future, but we may be stuck with the current behavior because the hack required to transform these queries to use spatial equality was egregious and broke in Rails 3.1 with no clear workaround.
+
+=== 0.3.3 / 2011-06-21
+
+* Require latest rgeo-activerecord to get some fixes.
+* Support hex format for attribute setting.
+* No longer raises exceptions if parse fails on attribute setting. (Reported by Daniel Hackney)
+
 === 0.3.2 / 2011-04-11
 
 * A .gemspec file is now available for gem building and bundler git integration.

data/README.rdoc

@@ -77,7 +77,7 @@ Now you can interact with the data using the RGeo types:
 
 === Spatial Queries
 
-You can create simple queries based on spatial equality in the same way
+You can create simple queries based on objective equality in the same way
 you would on a scalar column:
 
   rec = MySpatialTable.where(:latlon => RGeo::Geos.factory.point(-122, 47)).first
@@ -94,6 +94,11 @@ write more complex queries in SQL.
 
 == Installation And Configuration
 
+IMPORTANT: This adapter is currently *not* compatible with Rails 3.1.
+This is due to an apparent bug in the mysql gem (as of version 2.8.1),
+which does not appear to recognize MYSQL_TYPE_GEOMETRY in the binary
+protocol.
+
 === Installing The Adapter Gem
 
 This adapter has the following requirements:
@@ -102,8 +107,8 @@ This adapter has the following requirements:
 * MySQL server 5.0 or later required for spatial extensions.
 * \ActiveRecord 3.0.3 or later. Earlier versions will not work.
 * mysql gem 2.8 or later.
-* rgeo gem 0.2.8 or later.
-* rgeo-activerecord gem 0.3.3 or later.
+* rgeo gem 0.3.2 or later.
+* rgeo-activerecord gem 0.4.0 or later.
 
 Install this adapter as a gem:
 
@@ -156,6 +161,8 @@ Contributions are welcome. Fork the project on Github.
 
 Report bugs on Github issues at http://github.org/dazuma/activerecord-mysqlspatial-adapter/issues
 
+Support available on the rgeo-users google group at http://groups.google.com/group/rgeo-users
+
 Contact the author at dazuma at gmail dot com.
 
 === Acknowledgments

data/Version

@@ -1 +1 @@
-0.3.2
+0.4.0

data/lib/active_record/connection_adapters/mysqlspatial_adapter/main_adapter.rb

@@ -49,6 +49,11 @@ module ActiveRecord
         NATIVE_DATABASE_TYPES = MysqlAdapter::NATIVE_DATABASE_TYPES.merge(:spatial => {:name => "geometry"})
         
         
+        def set_rgeo_factory_settings(factory_settings_)
+          @rgeo_factory_settings = factory_settings_
+        end
+        
+        
         def adapter_name
           MysqlSpatialAdapter::ADAPTER_NAME
         end
@@ -73,6 +78,38 @@ module ActiveRecord
         end
         
         
+        def substitute_at(column_, index_)
+          if column_.spatial?
+            ::Arel.sql('GeomFromText(?,?)')
+          else
+            super
+          end
+        end
+        
+        
+        def type_cast(value_, column_)
+          if column_.spatial? && ::RGeo::Feature::Geometry.check_type(value_)
+            ::RGeo::WKRep::WKTGenerator.new.generate(value_)
+          else
+            super
+          end
+        end
+        
+        
+        def exec_stmt(sql_, name_, binds_)
+          real_binds_ = []
+          binds_.each do |bind_|
+            if bind_[0].spatial?
+              real_binds_ << bind_
+              real_binds_ << [bind_[0], bind_[1].srid]
+            else
+              real_binds_ << bind_
+            end
+          end
+          super(sql_, name_, real_binds_)
+        end
+        
+        
         def type_to_sql(type_, limit_=nil, precision_=nil, scale_=nil)
           if (info_ = spatial_column_constructor(type_.to_sym))
             type_ = limit_[:type] || type_ if limit_.is_a?(::Hash)
@@ -100,7 +137,8 @@ module ActiveRecord
           result_ = execute("SHOW FIELDS FROM #{quote_table_name(table_name_)}", :skip_logging)
           columns_ = []
           result_.each do |field_|
-            columns_ << SpatialColumn.new(field_[0], field_[4], field_[1], field_[2] == "YES")
+            columns_ << SpatialColumn.new(@rgeo_factory_settings, table_name_.to_s,
+              field_[0], field_[4], field_[1], field_[2] == "YES")
           end
           result_.free
           columns_

data/lib/active_record/connection_adapters/mysqlspatial_adapter/spatial_column.rb

@@ -46,18 +46,14 @@ module ActiveRecord
       class SpatialColumn < ConnectionAdapters::MysqlColumn
         
         
-        def initialize(name_, default_, sql_type_=nil, null_=true)
+        def initialize(factory_settings_, table_name_, name_, default_, sql_type_=nil, null_=true)
+          @factory_settings = factory_settings_
+          @table_name = table_name_
           super(name_, default_, sql_type_, null_)
           @geometric_type = ::RGeo::ActiveRecord.geometric_type_from_name(sql_type_)
           if type == :spatial
             @limit = {:type => @geometric_type.type_name.underscore}
           end
-          @ar_class = ::ActiveRecord::Base
-        end
-        
-        
-        def set_ar_class(val_)
-          @ar_class = val_
         end
         
         
@@ -75,12 +71,21 @@ module ActiveRecord
         
         
         def type_cast(value_)
-          type == :spatial ? SpatialColumn.convert_to_geometry(value_, @ar_class, name) : super
+          if type == :spatial
+            SpatialColumn.convert_to_geometry(value_, @factory_settings, @table_name, name)
+          else
+            super
+          end
         end
         
         
         def type_cast_code(var_name_)
-          type == :spatial ? "::ActiveRecord::ConnectionAdapters::MysqlSpatialAdapter::SpatialColumn.convert_to_geometry(#{var_name_}, self.class, #{name.inspect})" : super
+          if type == :spatial
+            "::ActiveRecord::ConnectionAdapters::MysqlSpatialAdapter::SpatialColumn.convert_to_geometry("+
+              "#{var_name_}, self.class.rgeo_factory_settings, self.class.table_name, #{name.inspect})"
+          else
+            super
+          end
         end
         
         
@@ -91,19 +96,27 @@ module ActiveRecord
         end
         
         
-        def self.convert_to_geometry(input_, ar_class_, column_)
+        def self.convert_to_geometry(input_, factory_settings_, table_name_, column_)
           case input_
           when ::RGeo::Feature::Geometry
-            factory_ = ar_class_.rgeo_factory_for_column(column_, :srid => input_.srid)
-            ::RGeo::Feature.cast(input_, factory_)
+            factory_ = factory_settings_.get_column_factory(table_name_, column_, :srid => input_.srid)
+            ::RGeo::Feature.cast(input_, factory_) rescue nil
           when ::String
             marker_ = input_[4,1]
             if marker_ == "\x00" || marker_ == "\x01"
-              factory_ = ar_class_.rgeo_factory_for_column(column_, :srid => input_[0,4].unpack(marker_ == "\x01" ? 'V' : 'N').first)
-              ::RGeo::WKRep::WKBParser.new(factory_).parse(input_[4..-1])
+              factory_ = factory_settings_.get_column_factory(table_name_, column_,
+                :srid => input_[0,4].unpack(marker_ == "\x01" ? 'V' : 'N').first)
+              ::RGeo::WKRep::WKBParser.new(factory_).parse(input_[4..-1]) rescue nil
+            elsif input_[0,10] =~ /[0-9a-fA-F]{8}0[01]/
+              srid_ = input_[0,8].to_i(16)
+              if input[9,1] == '1'
+                srid_ = [srid_].pack('V').unpack('N').first
+              end
+              factory_ = factory_settings_.get_column_factory(table_name_, column_, :srid => srid_)
+              ::RGeo::WKRep::WKBParser.new(factory_).parse(input_[8..-1]) rescue nil
             else
-              factory_ = ar_class_.rgeo_factory_for_column(column_)
-              ::RGeo::WKRep::WKTParser.new(factory_, :support_ewkt => true).parse(input_)
+              factory_ = factory_settings_.get_column_factory(table_name_, column_)
+              ::RGeo::WKRep::WKTParser.new(factory_, :support_ewkt => true).parse(input_) rescue nil
             end
           else
             nil

data/test/tc_basic.rb

@@ -105,7 +105,7 @@ module RGeo
               assert_nil(obj_.latlon)
               obj_.latlon = @factory.point(1, 2)
               assert_equal(@factory.point(1, 2), obj_.latlon)
-              assert_equal(4326, obj_.latlon.srid)
+              assert_equal(3785, obj_.latlon.srid)
             end
             
             
@@ -127,7 +127,7 @@ module RGeo
               id_ = obj_.id
               obj2_ = klass_.find(id_)
               assert_equal(@factory.point(1, 2), obj2_.latlon)
-              assert_equal(4326, obj2_.latlon.srid)
+              assert_equal(3785, obj2_.latlon.srid)
             end
             
             

data/test/tc_spatial_queries.rb

@@ -72,14 +72,14 @@ module RGeo
               obj_.latlon = @factory.point(1, 2)
               obj_.save!
               id_ = obj_.id
-              obj2_ = klass_.where(:latlon => @factory.multi_point([@factory.point(1, 2)])).first
+              obj2_ = klass_.where(:latlon => @factory.point(1, 2)).first
               assert_equal(id_, obj2_.id)
               obj3_ = klass_.where(:latlon => @factory.point(2, 2)).first
               assert_nil(obj3_)
             end
             
             
-            def test_query_point_wkt
+            def _test_query_point_wkt
               klass_ = populate_ar_class(:latlon_point)
               obj_ = klass_.new
               obj_.latlon = @factory.point(1, 2)
@@ -107,7 +107,7 @@ module RGeo
                 assert_nil(obj3_)
               end
               
-                            
+              
             else
               
               puts "WARNING: The current Arel does not support named functions. Spatial expression tests skipped."

metadata

@@ -2,7 +2,7 @@
 name: activerecord-mysqlspatial-adapter
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.3.2
+  version: 0.4.0
 platform: ruby
 authors: 
 - Daniel Azuma
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-04-11 00:00:00 Z
+date: 2011-08-15 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rgeo-activerecord
@@ -20,7 +20,7 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        version: 0.3.3
+        version: 0.4.0
   type: :runtime
   version_requirements: *id001
 - !ruby/object:Gem::Dependency 
@@ -77,7 +77,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: virtuoso
-rubygems_version: 1.7.2
+rubygems_version: 1.8.7
 signing_key: 
 specification_version: 3
 summary: An ActiveRecord adapter for MySQL Spatial Extensions, based on RGeo and the mysql gem.