activerecord-mysql-unsigned 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 49fd5ea141df79c4b07954a2b4c1f41a2dc3dafa
-  data.tar.gz: 6479ea5eccbfb9599f6c652baf985f3ba49b5ed1
+  metadata.gz: 0701a7029950db4d1a05d8de74aaadf39b035368
+  data.tar.gz: 737d28712950d180796320e100cbd87b24c050cc
 SHA512:
-  metadata.gz: 7b5dcfbb334548aec6dad2153b2c51a283d665fa0eb93b5c979a90e52c8b2035204483fccf5572cec0a08b7261f4bb7b1c0e54ffc7243ed71590010c68e42ac6
-  data.tar.gz: 72ae3399cbfc9d907f38f3efaddb93d1f9cd96838b17bca8ca947c1178fde424a433ada20a244ac5ddeaf236591d7b2c15db24f9f9ef110dfd2f1048b55681a6
+  metadata.gz: 8d735efbeba0b96dad50e43c07e98fe9910b4f1d18127a2341b53abf1d7daa5ad75936def02ef086f60d12101c396251338fbf76c7f00a76109f22147a99ffe3
+  data.tar.gz: 1e2d852d8f0f616c6e0c71d36a6465ef543591ba404c50d0a1bc63e5fc2280e7988141e1f46c91622357abf893aeea2295a2ca3169cf096687edd44aaddc1c56

data/README.md

@@ -5,7 +5,7 @@ Add unsigned option to integer type for ActiveRecord's MySQL2 adapter.
 ## Support version
 
 ```
-ActiveRecord::VERSION >= 3.2 # include v4.0, and v4.1!
+4.2 > ActiveRecord::VERSION >= 3.2
 ```
 
 ## Installation

data/activerecord-mysql-unsigned.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec"
+  spec.add_development_dependency "rspec", "~> 3.0.0"
   spec.add_development_dependency "database_cleaner"
   spec.add_runtime_dependency "activesupport", ">= 3.2", "< 4.2"
   spec.add_runtime_dependency "activerecord", ">= 3.2", "< 4.2"

data/lib/activerecord-mysql-unsigned/active_record/v4_1/connection_adapters/abstract_mysql_adapter.rb

@@ -9,7 +9,10 @@ module ActiveRecord
         def visit_AddColumn(o)
           sql_type = type_to_sql(o.type.to_sym, o.limit, o.precision, o.scale, o.unsigned)
           sql = "ADD #{quote_column_name(o.name)} #{sql_type}"
-          add_column_options!(sql, column_options(o))
+          add_column_position!(
+            add_column_options!(sql, column_options(o)),
+            column_options(o)
+          )
         end
 
         def visit_ChangeColumnDefinition(o)

data/lib/activerecord-mysql-unsigned/version.rb

@@ -1,7 +1,7 @@
 module ActiveRecord
   module Mysql
     module Unsigned
-      VERSION = "0.1.1"
+      VERSION = "0.1.2"
     end
   end
 end

data/spec/after_option_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+describe "after option" do
+  before :all do
+    AddColumnAfterToGoodsTable.change
+  end
+
+  it "insert 'added_after_name' column after 'name' column" do
+    name_num = added_after_name_num = 0
+
+    Goods.columns.each_with_index do |column, i|
+      name_num = i if column.name == "name"
+      added_after_name_num = i if column.name == "added_after_name"
+    end
+
+    expect(name_num + 1).to eq(added_after_name_num)
+  end
+end

data/spec/spec_helper.rb

@@ -8,8 +8,7 @@ Dir["#{File.dirname(__FILE__)}/support/*.rb"].each {|file| require file}
 
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
-  config.color_enabled = true
+  config.color = true
 end

data/spec/support/migrations.rb

@@ -10,18 +10,22 @@ ActiveRecord::Base.establish_connection(config.merge(database: 'mysql'))
 ActiveRecord::Base.connection.drop_database(config[:database]) rescue nil
 ActiveRecord::Base.connection.create_database(config[:database])
 ActiveRecord::Base.establish_connection(config)
+#ActiveRecord::Base.logger = Logger.new(STDOUT)
 
 ActiveRecord::Migration.verbose = true
 
+# create goods table
 class CreateGoodsTable < ActiveRecord::Migration
   def self.change
     create_table :goods, force: true do |t|
       t.string  :name, null: false
+      t.boolean :deleted, default: false
     end
   end
 end
 CreateGoodsTable.change
 
+# create users table
 class CreateUsersTable < ActiveRecord::Migration
   def self.change
     create_table :users, force: true, id: false do |t|
@@ -42,7 +46,6 @@ class ChangePrimaryKeyToGoodsTable < ActiveRecord::Migration
     change_column :goods, :id, :integer, limit: 8, unsigned: true, null: false, auto_increment: true
   end
 end
-ChangePrimaryKeyToGoodsTable.change
 
 class ChangeColumnToUsersTable < ActiveRecord::Migration
   def self.change
@@ -52,11 +55,15 @@ class ChangeColumnToUsersTable < ActiveRecord::Migration
     change_column :users, :will_bigint,       :integer, limit: 8
   end
 end
-ChangeColumnToUsersTable.change
 
 class AddColumnToUsersTable < ActiveRecord::Migration
   def self.change
     add_column    :users, :added_unsigned_int, :integer, unsigned: true
   end
 end
-AddColumnToUsersTable.change
+
+class AddColumnAfterToGoodsTable < ActiveRecord::Migration
+  def self.change
+    add_column    :goods, :added_after_name, :integer, unsigned: true, after: :name
+  end
+end

data/spec/support/models.rb

@@ -1,4 +1,7 @@
 require 'active_record'
 
+class Goods < ActiveRecord::Base
+end
+
 class User < ActiveRecord::Base
 end

data/spec/unsigned_spec.rb

@@ -1,23 +1,30 @@
 require 'spec_helper'
 
 describe "INT column" do
+
+  before :all do
+    ChangePrimaryKeyToGoodsTable.change
+    ChangeColumnToUsersTable.change
+    AddColumnToUsersTable.change
+  end
+
   before(:each) do
     @user = User.new(name: "bob")
   end
 
   it "max value of signed int" do
     @user.signed_int = 2147483647
-    expect(@user.save).to be_true
+    expect(@user.save).to be_truthy
   end
 
   it "max value of unsigned int" do
     @user.unsigned_int = 4294967295
-    expect(@user.save).to be_true
+    expect(@user.save).to be_truthy
   end
 
   it "allowed minus value of signed int" do
     @user.signed_int = -2147483648
-    expect(@user.save).to be_true
+    expect(@user.save).to be_truthy
   end
 
   it "not allowed minus value of unsigned int" do
@@ -26,7 +33,7 @@ describe "INT column" do
     if ActiveRecord::VERSION::MAJOR == 4
       begin
         @user.save
-        expect(true).to be_false # should not be reached here
+        expect(true).to be_falsey # should not be reached here
       rescue => e
         expect(e).to be_an_instance_of ActiveRecord::StatementInvalid
       end
@@ -37,10 +44,11 @@ describe "INT column" do
     end
   end
 
-  it "unsigned column has 'unsigned' field" do
+  it "unsigned column has 'unsigned' attribute" do
     signed_int_col = User.columns[2]
-    expect(signed_int_col.unsigned).to be_false
+    expect(signed_int_col.unsigned).to be_falsey
+
     unsigned_int_col = User.columns[3]
-    expect(unsigned_int_col.unsigned).to be_true
+    expect(unsigned_int_col.unsigned).to be_truthy
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-mysql-unsigned
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - yo_waka
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-07 00:00:00.000000000 Z
+date: 2014-06-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -42,16 +42,16 @@ dependencies:
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
@@ -153,6 +153,7 @@ files:
 - lib/activerecord-mysql-unsigned/base.rb
 - lib/activerecord-mysql-unsigned/railtie.rb
 - lib/activerecord-mysql-unsigned/version.rb
+- spec/after_option_spec.rb
 - spec/spec_helper.rb
 - spec/support/database_cleaner.rb
 - spec/support/migrations.rb
@@ -179,11 +180,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Add unsigned option to integer type for ActiveRecord's MySQL2 adapter
 test_files:
+- spec/after_option_spec.rb
 - spec/spec_helper.rb
 - spec/support/database_cleaner.rb
 - spec/support/migrations.rb