activerecord-import 0.16.0 → 0.16.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 64717eaa9cb0c49761ad29e6aa358c87e96b7166
-  data.tar.gz: 879ac9c11ee4a9a62988c97608ad195a1052893d
+  metadata.gz: 90f09939f85ac5eea9961edb723ad60f0f44d4a8
+  data.tar.gz: d50f35bc63818c96ffa772d157189d96a738784b
 SHA512:
-  metadata.gz: 7e06cfe24bc207291c4a4c8737f8c3d6309218ccde2ca3246089f45d7f36c85f6fa7a63abe5758934dd6c9e939422c40395880b7ba950e10db7b96fa38b071af
-  data.tar.gz: 6ce0fc279753ab340269eefa2d64be18c40d2bed279f3cda27ba4057cb428582a207c5637da5a7c5222cffa77d2a43a0030578c87ebe05f76c81ad098da3fa21
+  metadata.gz: 4f4cf1a65474d658e5091b60b12756f70c6fe1af84d0b2477777f27cc76d137eb1bc7064ab8d33d548c0c8de01df494ec0fdddf73d7e55416fc772750bb9899a
+  data.tar.gz: 0b3a592bdbe01be8dd244f52643875825b2c52d8a8ec283f9825cf17012feddb394f131aa9a0722cdf89d9a8a6835ddff0a219b86e4d4049b70f8aca1f808b50

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+## Changes in 0.16.1
+
+### Fixes
+
+* Fixes issue with missing error messages on failed instances when
+  importing using arrays of columns and values. Thanks to @Fivell via \#332
+* Update so SQLite only return ids if table has a primary key field via \#333
+
+
 ## Changes in 0.16.0
 
 ### New Features

data/lib/activerecord-import/adapters/sqlite3_adapter.rb

@@ -35,8 +35,10 @@ module ActiveRecord::Import::SQLite3Adapter
         number_of_inserts += 1
         sql2insert = base_sql + value_set.join( ',' ) + post_sql
         last_insert_id = insert( sql2insert, *args )
-        first_insert_id = last_insert_id - affected_rows + 1
-        ids.concat((first_insert_id..last_insert_id).to_a)
+        if last_insert_id > 0
+          first_insert_id = last_insert_id - affected_rows + 1
+          ids.concat((first_insert_id..last_insert_id).to_a)
+        end
       end
     end
 

data/lib/activerecord-import/import.rb

@@ -476,7 +476,9 @@ class ActiveRecord::Base
           next if model.valid?(options[:validate_with_context])
           raise(ActiveRecord::RecordInvalid, model) if options[:raise_error]
           array_of_attributes[i] = nil
-          failed_instances << model.dup
+          failure = model.dup
+          failure.errors.send(:initialize_dup, model.errors)
+          failed_instances << failure
         end
       end
 

data/lib/activerecord-import/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module Import
-    VERSION = "0.16.0".freeze
+    VERSION = "0.16.1".freeze
   end
 end

data/test/import_test.rb

@@ -121,7 +121,11 @@ describe "#import" do
       it "should report the failed instances" do
         results = Topic.import columns, invalid_values, validate: true
         assert_equal invalid_values.size, results.failed_instances.size
-        results.failed_instances.each { |e| assert_kind_of Topic, e }
+        assert_not_equal results.failed_instances.first, results.failed_instances.last
+        results.failed_instances.each do |e|
+          assert_kind_of Topic, e
+          assert_equal e.errors.count, 1
+        end
       end
 
       it "should set ids in valid models if adapter supports setting primary key of imported objects" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-import
 version: !ruby/object:Gem::Version
-  version: 0.16.0
+  version: 0.16.1
 platform: ruby
 authors:
 - Zach Dennis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-10 00:00:00.000000000 Z
+date: 2016-10-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord