activerecord-exclusive-arc 0.1.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5dbceaa69bcb956d89d1c636209771640242741ae2e06f57a038f474f64825d8
-  data.tar.gz: a8319a8c41ea99543fc8d52387adb35aa6a56b264adfdfa39a25b8b6d603f774
+  metadata.gz: 27e01ec54aa223f1e36904771298125b451731632cca44ae6d0d15627cbcf879
+  data.tar.gz: 97990f81b596836909e67609a2d9745d6be13f0852373829656d2218454f6029
 SHA512:
-  metadata.gz: c0c2ab91655256c9226c3775d2e6ee1c05d733089110728ade4aa39416e23f15a7a048f6e2189fc23aa9aac93783180ac8eabca57f404808957a044375c9ee8d
-  data.tar.gz: ca725edf128c121af9e4a5e8880b8a8895ce8eefabf0ae9175d7c0054a1c7f38475f8b8e47ede79cd31db64fc63a697e97c28525c63062a21b148e042eaefadf
+  metadata.gz: 448c3910176f2f9163d0cfac054482fa2c6dc96b3e67d1093668626e2dbc94cfdeb59adcc371f3890af35541f9e4db7b8f4db0cd0108db09cd6bfe68de4954be
+  data.tar.gz: ec36d41ce0896b6505f76eb5112dd999db1cb334d9d0b956d82d7f043efba1e4999ef32ddbf0a384c140b5dcba01dfbaf7606b4638ac94381fbc8408751a7d3a

data/README.md

@@ -10,7 +10,7 @@ fact that the Ruby class name is stored in the database as a string. If you want
 Ruby class used for such reasons, you must also update the database strings that represent it. The bleeding
 of application-layer definitions into the database may become a liability.
 
-Another common argument concerns referential integrity. *Foreign Key Constraints* are a common mechanism to
+Another common argument concerns referential integrity. _Foreign Key Constraints_ are a common mechanism to
 ensure primary keys of tables can be reliably used as foreign keys on others. This becomes harder to enforce
 when a column that represents a Ruby class is one of the components required for unique identification.
 
@@ -19,8 +19,8 @@ polymorphic: true` relationship and the fact that polymorphic indexes require mu
 
 ### So how does this work?
 
-It reduces the boilerplate of managing a *Polymorphic Assication* modeled as a pattern called an *Exclusive
-Arc*. This maps nicely to a database constraint, a set of optional `belongs_to` relationships, some
+It reduces the boilerplate of managing a _Polymorphic Assication_ modeled as a pattern called an _Exclusive
+Arc_. This maps nicely to a database constraint, a set of optional `belongs_to` relationships, some
 polymorphic methods, and an `ActiveRecord` validation for good measure.
 
 ## How to use
@@ -49,7 +49,7 @@ This will inject code into your `Comment` Model:
 ```ruby
 class Comment < ApplicationRecord
   include ExclusiveArc::Model
-  exclusive_arc :commentable, [:post, :comment]
+  has_exclusive_arc :commentable, [:post, :comment]
 end
 ```
 
@@ -73,6 +73,17 @@ end
 
 It's a bit more involved than that, but it demonstrates the essense of the API as an `ActiveRecord` user.
 
+If you need to customize a specific `belongs_to` relationship, you can do so by declaring it before
+`has_exclusive_arc`:
+
+```ruby
+class Comment < ApplicationRecord
+  include ExclusiveArc::Model
+  belongs_to :post, -> { where(comments_enabled: true) }, optional: true
+  has_exclusive_arc :commentable, [:post, :comment]
+end
+```
+
 Continuing with our example, the generator command would also produce a migration that looks like this:
 
 ```ruby
@@ -135,4 +146,3 @@ Bug reports and pull requests are welcome on GitHub at https://github.com/waymon
 ### License
 
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).
-

data/lib/exclusive_arc/model.rb

@@ -8,27 +8,39 @@ module ExclusiveArc
     end
 
     class_methods do
-      def exclusive_arc(*args)
-        arcs = args[0].is_a?(Hash) ? args[0] : {args[0] => args[1]}
-        options = args[2] || {}
-        arcs.each do |(name, belong_tos)|
-          belong_tos.map { |option| belongs_to(option, optional: true) }
-          exclusive_arcs[name] = Definition.new(
-            reflections: reflections.slice(*belong_tos.map(&:to_s)),
-            options: options
-          )
+      def has_exclusive_arc(*args)
+        arc = args[0]
+        belong_tos = args[1]
+        belong_tos.map do |option|
+          next if reflections[option.to_s]
 
-          class_eval <<-RUBY, __FILE__, __LINE__ + 1
-            def #{name}
-              #{belong_tos.join(" || ")}
-            end
+          belongs_to(option, optional: true)
+        end
+        exclusive_arcs[arc] = Definition.new(
+          reflections: reflections.slice(*belong_tos.map(&:to_s)),
+          options: args[2] || {}
+        )
 
-            def #{name}=(polymorphic)
-              assign_exclusive_arc(:#{name}, polymorphic)
+        belong_tos.each do |option|
+          class_eval <<-RUBY, __FILE__, __LINE__ + 1
+            def #{option}=(polymorphic)
+              @#{arc} = nil unless @#{arc} == polymorphic
+              super
             end
           RUBY
         end
 
+        class_eval <<-RUBY, __FILE__, __LINE__ + 1
+          def #{arc}
+            @#{arc} ||= (#{belong_tos.join(" || ")})
+          end
+
+          def #{arc}=(polymorphic)
+            assign_exclusive_arc(:#{arc}, polymorphic)
+            @#{arc} = polymorphic
+          end
+        RUBY
+
         validate :validate_exclusive_arcs
       end
     end
@@ -36,9 +48,10 @@ module ExclusiveArc
     private
 
     def assign_exclusive_arc(arc, polymorphic)
-      exclusive_arcs.fetch(arc).reflections.each do |name, reflection|
-        public_send("#{name}=", polymorphic.is_a?(reflection.klass) ? polymorphic : nil)
+      attributes = exclusive_arcs.fetch(arc).reflections.to_h do |name, reflection|
+        [name, polymorphic.is_a?(reflection.klass) ? polymorphic : nil]
       end
+      assign_attributes attributes
     end
 
     def validate_exclusive_arcs

data/lib/exclusive_arc/version.rb

@@ -1,3 +1,3 @@
 module ExclusiveArc
-  VERSION = "0.1.0"
+  VERSION = "0.2.1"
 end

data/lib/generators/exclusive_arc_generator.rb

@@ -32,7 +32,7 @@ class ExclusiveArcGenerator < ActiveRecord::Generators::Base
       class_name.demodulize,
       <<~RB
         #{indents}include ExclusiveArc::Model
-        #{indents}exclusive_arc #{model_exclusive_arcs}
+        #{indents}has_exclusive_arc #{model_exclusive_arcs}
       RB
     )
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-exclusive-arc
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.1
 platform: ruby
 authors:
 - justin talbott
@@ -50,26 +50,6 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '8'
-- !ruby/object:Gem::Dependency
-  name: railties
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '6.1'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '8'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '6.1'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '8'
 description:
 email:
 - gmail@justintalbott.com