activerecord-delay_touching 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bf2e396443031e052664ae33fa9abca71b1a1b45
-  data.tar.gz: 0009099d96abdb6f58a1590c5f5c7df699d0382e
+  metadata.gz: 731f1b62489c8675bb3df76d2d12ffb90ae5cc58
+  data.tar.gz: ff36c494301d616c19dd8300d05245eae989e553
 SHA512:
-  metadata.gz: bba9504122174575808beec7d1107e603e434535afe421361dd83ad6341867fbdae957e509653349be3a7ebd16c97050d4c12ca900aa22360a547c61a017d2cd
-  data.tar.gz: 2e822052fb026400b9abd0b9bb25a36220d9eac30acb02267495535b9da99fc3be49e1cd296e6c035ccdd0c97c12c00fe51636d38f3f64664048a4fcb5f6863b
+  metadata.gz: 5777ddf6f855fafac79a3866fdd7940986aeb2882f5622ca31930bca8beb86d20213fef6db7957f223828e69aa17f558d4e906218d54087007f2c9408fa8307b
+  data.tar.gz: d0733fe1dd22034db87c60a3d46acf5a4034be3c7803c6ee3765a345735ba9c73afa563329158e8b6323837a760a434629900b4b9b50248fa5db9b9eb5509368

data/README.md

@@ -1,5 +1,7 @@
 # Activerecord::DelayTouching
 
+> **Note:** this version requires ActiveRecord 4.2 or higher. To use ActiveRecord 3.2 through 4.1, use the branch https://github.com/godaddy/activerecord-delay_touching/tree/pre-activerecord-4.2.
+
 Batch up your ActiveRecord "touch" operations for better performance.
 
 When you want to invalidate a cache in Rails, you use `touch: true`. But when

data/lib/activerecord/delay_touching.rb

@@ -86,6 +86,7 @@ module ActiveRecord
           column = column.to_s
           changes[column] = current_time
           records.each do |record|
+            next if record.destroyed?
             record.instance_eval do
               write_attribute column, current_time
               @changed_attributes.except!(*changes.keys)

data/lib/activerecord/delay_touching/version.rb

@@ -1,5 +1,5 @@
 module Activerecord
   module DelayTouching
-    VERSION = "1.0.0"
+    VERSION = "1.0.1"
   end
 end

data/spec/activerecord/delay_touching_spec.rb

@@ -151,6 +151,28 @@ describe Activerecord::DelayTouching do
     end
   end
 
+  context 'dependent deletes' do
+
+    let(:post) { Post.create! }
+    let(:user) { User.create! }
+    let(:comment) { Comment.create! }
+
+    before do
+      post.comments << comment
+      user.comments << comment
+    end
+
+    it 'does not attempt to touch deleted records' do
+      expect do
+        ActiveRecord::Base.delay_touching do
+          post.destroy
+        end
+      end.not_to raise_error
+      expect(post.destroyed?).to eq true
+    end
+
+  end
+
   def expect_updates(tables)
     expected_sql = tables.map do |entry|
       if entry.kind_of?(Hash)

data/spec/support/models.rb

@@ -5,3 +5,16 @@ end
 class Pet < ActiveRecord::Base
   belongs_to :person, touch: true, inverse_of: :pets
 end
+
+class Post < ActiveRecord::Base
+  has_many :comments, dependent: :destroy
+end
+
+class User < ActiveRecord::Base
+  has_many :comments, dependent: :destroy
+end
+
+class Comment < ActiveRecord::Base
+  belongs_to :post, touch: true
+  belongs_to :user, touch: true
+end

data/spec/support/schema.rb

@@ -16,4 +16,18 @@ ActiveRecord::Schema.define do
     t.timestamps
   end
 
+  create_table :posts, force: true do |t|
+    t.timestamps null: false
+  end
+
+  create_table :users, force: true do |t|
+    t.timestamps null: false
+  end
+
+  create_table :comments, force: true do |t|
+    t.integer :post_id
+    t.integer :user_id
+    t.timestamps null: false
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-delay_touching
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Brian Morearty
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-07 00:00:00.000000000 Z
+date: 2015-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -180,7 +180,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Batch up your ActiveRecord "touch" operations for better performance.