activerecord-databasevalidations 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 16b7e2657966158be5c02fd634d034b0ff7a63adbd82341f0abcab9e41d87fed
-  data.tar.gz: cf06bf1331a19a0bc11736212277ad595ecc2469900eae210d754fbc76cc2a83
+  metadata.gz: 86138fed43c841609f1a4b0f1952d956e84040d14bc966731ce8ffd56a533309
+  data.tar.gz: e133a86b1cb4c996c609c00e5b683fadab0d28bcfd696502cfc330c6a40d23d6
 SHA512:
-  metadata.gz: '078c2e682da2fa04f716c950ff7ab2608335ee0142b3b507d4e3c7249688187d914c1d1d12c5101ad4f46125c9628c3aafb0aa39606abea34d3354a59c4b974c'
-  data.tar.gz: aaf055985a320538354863a635bb879e40e733cc75d0abccc586134e8d78b019a7b27aef9f74cc1bbc247aee113dfa1fbb490d089e5929befde7d06dcb3f4125
+  metadata.gz: df4cb11a72a91ff8073a94c0bc1d5641cc9d674efd237b643c223ce49a3a8a660e185d3044fa78b416cdf0bd87494ea2b0d9338b9950675e182a9e7ce49b7054
+  data.tar.gz: f87e0c673004f5b1a16763c297da0744993388ca0d48ac6857f9a2b4b68f34409c2bb2c3e893706f7f5a96ec1e3688a7a6df2077a1947ba8beb4884c8044ace7

data/.travis.yml

@@ -1,25 +1,16 @@
 sudo: false
 language: ruby
 cache: bundler
+services:
+  - mysql
 
 rvm:
-- 2.2.2
-- 2.3.0
-- 2.4.1
-- 2.5.0
+- '2.5'
+- '2.6'
 
 gemfile:
-  - gemfiles/Gemfile.activerecord50
-  - gemfiles/Gemfile.activerecord51
   - gemfiles/Gemfile.activerecord52
-  - gemfiles/Gemfile.activerecord-edge
-
-matrix:
-  exclude:
-    - rvm: 2.2.2
-      gemfile: gemfiles/Gemfile.activerecord-edge
-    - rvm: 2.3.0
-      gemfile: gemfiles/Gemfile.activerecord-edge
+  - gemfiles/Gemfile.activerecord60
 
 before_script:
 - mysql -e 'create database database_validations;'

data/activerecord-databasevalidations.gemspec

@@ -18,9 +18,9 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.required_ruby_version = '>= 2.2.2'
+  spec.required_ruby_version = '>= 2.5'
 
-  spec.add_runtime_dependency "activerecord", ">= 5.0"
+  spec.add_runtime_dependency "activerecord", ">= 5.2"
   spec.add_runtime_dependency "rejectu"
 
   spec.add_development_dependency "bundler", "~> 1.5"

data/gemfiles/Gemfile.activerecord52

@@ -1,4 +1,4 @@
 source 'https://rubygems.org'
 gemspec path: '..'
 
-gem 'activerecord', github: 'rails/rails', branch: '5-2-stable'
+gem 'activerecord', '~> 5.2.0'

data/gemfiles/{Gemfile.activerecord50 → Gemfile.activerecord60}

@@ -1,4 +1,4 @@
 source 'https://rubygems.org'
 gemspec path: '..'
 
-gem 'activerecord', '~> 5.0.0'
+gem 'activerecord', '~> 6.0.0'

data/lib/active_record/database_validations/mysql.rb

@@ -64,8 +64,12 @@ module ActiveRecord
 
       def self.value_for_column(value, column_encoding = nil)
         value = value.to_s unless value.is_a?(String)
-        value.encode!('utf-8') if requires_transcoding?(value, column_encoding)
-        return value
+
+        if requires_transcoding?(value, column_encoding)
+          return value.encode(Encoding::UTF_8)
+        end
+
+        value
       end
     end
   end

data/lib/active_record/database_validations/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module DatabaseValidations
-    VERSION = "0.4.0"
+    VERSION = "0.5.0"
   end
 end

data/test/data_loss_test.rb

@@ -33,8 +33,8 @@ class DataLossTest < Minitest::Test
   end
 
   def test_decimal_silently_changes_out_of_bound_values
-    maximum = BigDecimal.new(10 **  (Unicorn.columns_hash['decimal'].precision - Unicorn.columns_hash['decimal'].scale))
-    delta   = BigDecimal.new(10 ** -(Unicorn.columns_hash['decimal'].scale), Unicorn.columns_hash['decimal'].precision)
+    maximum = BigDecimal(10 **  (Unicorn.columns_hash['decimal'].precision - Unicorn.columns_hash['decimal'].scale))
+    delta   = BigDecimal(10 ** -(Unicorn.columns_hash['decimal'].scale), Unicorn.columns_hash['decimal'].precision)
 
     refute_data_loss Unicorn.new(decimal: maximum - delta)
     assert_data_loss Unicorn.new(decimal: maximum)
@@ -42,8 +42,8 @@ class DataLossTest < Minitest::Test
     assert_data_loss Unicorn.new(decimal: 0 - maximum)
 
 
-    maximum = BigDecimal.new(10 **  (Unicorn.columns_hash['unsigned_decimal'].precision - Unicorn.columns_hash['unsigned_decimal'].scale))
-    delta   = BigDecimal.new(10 ** -(Unicorn.columns_hash['unsigned_decimal'].scale), Unicorn.columns_hash['unsigned_decimal'].precision)
+    maximum = BigDecimal(10 **  (Unicorn.columns_hash['unsigned_decimal'].precision - Unicorn.columns_hash['unsigned_decimal'].scale))
+    delta   = BigDecimal(10 ** -(Unicorn.columns_hash['unsigned_decimal'].scale), Unicorn.columns_hash['unsigned_decimal'].precision)
 
     refute_data_loss Unicorn.new(unsigned_decimal: maximum - delta)
     assert_data_loss Unicorn.new(unsigned_decimal: maximum)
@@ -99,7 +99,7 @@ class DataLossTest < Minitest::Test
   end
 
   def test_utf8mb3_field_sliently_truncates_strings_after_first_4byte_character
-    emoji = '💩'
+    emoji = "\u{1F4A9}"
     assert_equal 1, emoji.length
     assert_equal 4, emoji.bytesize
     assert_data_loss Unicorn.new(string: emoji)

data/test/database_constraints_validator_test.rb

@@ -98,7 +98,7 @@ class DatabaseConstraintsValidatorTest < Minitest::Test
     assert_equal 1, subvalidators.length
     assert_kind_of ActiveModel::Validations::BytesizeValidator, subvalidators.first
     assert_equal 65535, subvalidators.first.options[:maximum]
-    assert_equal nil, subvalidators.first.encoding
+    assert_nil subvalidators.first.encoding
   end
 
   def test_not_null_text_field_defines_requested_bytesize_validator_and_unicode_validator
@@ -120,7 +120,7 @@ class DatabaseConstraintsValidatorTest < Minitest::Test
 
   def test_should_not_create_a_validator_for_a_utf8mb4_field
     assert Bar._validators[:mb4_string].first.attribute_validators(Bar, :mb4_string).empty?
-    emoji = Bar.new(mb4_string: '💩')
+    emoji = Bar.new(mb4_string: '')
     assert emoji.valid?
     refute_data_loss emoji
   end
@@ -214,7 +214,7 @@ class DatabaseConstraintsValidatorTest < Minitest::Test
   end
 
   def test_error_messages
-    foo = Foo.new(string: 'ü' * 41, checked: nil, not_null_text: '💩')
+    foo = Foo.new(string: 'ü' * 41, checked: nil, not_null_text: "\u{1F4A9}")
     refute foo.save
 
     assert_equal ["is too long (maximum is 40 characters)"], foo.errors[:string]

data/test/varchar_default_size_test.rb

@@ -14,7 +14,7 @@ class VarcharDefaultSizeTest < Minitest::Test
       ActiveRecord::Migration.add_index(:varchars, :string, unique: true)
     end
 
-    assert_match /\Autf8mb4_/, Varchar.columns_hash['string'].collation
-    assert_equal 191, Varchar.columns_hash['string'].limit
+    assert_match(/\Autf8mb4_/, Varchar.columns_hash['string'].collation)
+    assert_equal(191, Varchar.columns_hash['string'].limit)
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-databasevalidations
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Willem van Bergen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-20 00:00:00.000000000 Z
+date: 2019-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.2'
 - !ruby/object:Gem::Dependency
   name: rejectu
   requirement: !ruby/object:Gem::Requirement
@@ -110,10 +110,8 @@ files:
 - README.md
 - Rakefile
 - activerecord-databasevalidations.gemspec
-- gemfiles/Gemfile.activerecord-edge
-- gemfiles/Gemfile.activerecord50
-- gemfiles/Gemfile.activerecord51
 - gemfiles/Gemfile.activerecord52
+- gemfiles/Gemfile.activerecord60
 - lib/active_model/validations/basic_multilingual_plane.rb
 - lib/active_model/validations/bytesize.rb
 - lib/active_model/validations/not_null.rb
@@ -149,15 +147,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.2.2
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.4
 signing_key: 
 specification_version: 4
 summary: Add validations to your ActiveRecord models based on MySQL database constraints.

data/gemfiles/Gemfile.activerecord-edge

@@ -1,4 +0,0 @@
-source 'https://rubygems.org'
-gemspec path: '..'
-
-gem 'activerecord', github: 'rails/rails', branch: 'master'

data/gemfiles/Gemfile.activerecord51

@@ -1,4 +0,0 @@
-source 'https://rubygems.org'
-gemspec path: '..'
-
-gem 'activerecord', '~> 5.1.0'