activerecord-databasevalidations 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aeb9fa64fe237e89b17e1f7e7cc9019ed6e16c92
-  data.tar.gz: b7efe30384468425e438904a4670ad852412df3b
+  metadata.gz: 8999070427c2a970512966469469db85bf257c57
+  data.tar.gz: a046eb206c0cf82a467ed08c725644007b9ce57b
 SHA512:
-  metadata.gz: 420b1b6dd7603ba7a604f6e93f0ca68f05b88fb64d43427079c3cd05dcb1ad0cfb55aedec7a859c710f809028c36cb32b4942b5c646a78af8258cf343791d55e
-  data.tar.gz: 69f7e812f395c42f69b0fc1dda70744ad92c7649977aa7a8ee758bbfdfa62c9e6d0ee5fd8cad2ac80c5daca58e930333673b5472690c2a24715edf95f155a491
+  metadata.gz: 427c779f06110f0a377bd40377e09bdcbdbb1681d58b1ebfba957e5586eaf9f33473e8ca5306ec481d3e4677fbd8a79865af3204779de65af84a91618548e449
+  data.tar.gz: '05518682e31a3fb8c7e37023c854284fef7e69b3d2f348dc00a5c1d5b1de23bfe58c02b3ddc6fca0453d461699fa5d25491c7e5ebd6b2a87a2a2912ed578db36'

data/Gemfile.activerecord50

@@ -1,4 +1,4 @@
 source 'https://rubygems.org'
 gemspec
 
-gem 'activerecord', github: 'rails/rails'
+gem 'activerecord', '~> 5.0.0'

data/lib/active_record/database_validations/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module DatabaseValidations
-    VERSION = "0.3.0"
+    VERSION = "0.3.1"
   end
 end

data/lib/active_record/validations/database_constraints.rb

@@ -63,8 +63,13 @@ module ActiveRecord
 
       def attribute_validators(klass, attribute)
         @constraint_validators[attribute] ||= begin
-          column = klass.columns_hash[attribute.to_s] or raise ArgumentError.new("Model #{self.class.name} does not have column #{column_name}!")
-          column = ActiveRecord::Validations::TypedColumn.new(column)
+          column_definition = klass.columns_hash[attribute.to_s]
+
+          unless column_definition
+            raise ArgumentError.new("Model #{klass.name} does not have column #{attribute.to_s}!")
+          end
+
+          column = ActiveRecord::Validations::TypedColumn.new(column_definition)
 
           [
             not_null_validator(klass, column),

data/test/basic_multilingual_plane_validator_test.rb

@@ -40,4 +40,15 @@ class BasicMultilingualPlaneValidatorTest < Minitest::Test
     @model.unicode = 'ü'.encode('ISO-8859-15')
     assert @model.valid?
   end
+
+  def test_utf8mb3_japanese
+    @model.unicode = 'これは普通なストリングです'
+    assert @model.valid?
+  end
+
+  def test_utf8mb4_kanji
+    @model.unicode = '𠜎𠜱𠝹𠱓𠱸𠲖𠳏𠳕𠴕𠵼𠵿𠸎𠸏𠹷'
+    assert @model.invalid?
+    assert_equal ["contains characters outside Unicode's basic multilingual plane"], @model.errors[:unicode]
+  end
 end

data/test/database_constraints_validator_test.rb

@@ -17,6 +17,8 @@ ActiveRecord::Migration.suppress_messages do
     t.string   :mb4_string
   end
 
+  ActiveRecord::Migration.create_table("empties", force: true)
+
   ActiveRecord::Migration.create_table("nums", force: true) do |t|
     t.column :decimal,          "DECIMAL(5,2)"
     t.column :unsigned_decimal, "DECIMAL(5,2) UNSIGNED"
@@ -39,6 +41,12 @@ class Bar < ActiveRecord::Base
   validates :mb4_string, database_constraints: :basic_multilingual_plane
 end
 
+class Empty < ActiveRecord::Base
+  attr_accessor :not_a_column
+
+  validates(:not_a_column, database_constraints: [:size])
+end
+
 class Num < ActiveRecord::Base
   validates :decimal, :unsigned_decimal, :tinyint, :smallint, :mediumint, :int, :bigint, :unsigned_int, database_constraints: :range
 end
@@ -53,6 +61,11 @@ class DatabaseConstraintsValidatorTest < Minitest::Test
     assert_raises(ArgumentError) { Bar.validates(:mb4_string, database_constraints: [:size, :bogus]) }
   end
 
+  def test_column_validation
+    exception = assert_raises(ArgumentError) { Empty.new.valid? }
+    assert_equal "Model Empty does not have column not_a_column!", exception.message
+  end
+
   def test_validators_are_defined
     assert_kind_of ActiveRecord::Validations::DatabaseConstraintsValidator, Foo._validators[:string].first
     assert_kind_of ActiveRecord::Validations::DatabaseConstraintsValidator, Foo._validators[:tinytext].first

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-databasevalidations
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Willem van Bergen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-16 00:00:00.000000000 Z
+date: 2017-10-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -164,7 +164,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.6.12
 signing_key: 
 specification_version: 4
 summary: Add validations to your ActiveRecord models based on MySQL database constraints.