activerecord-collection_cache_key 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 185f1aa953f1bb441199195b36f2c22e1471122a
-  data.tar.gz: 36b7816b234d9dddc9e2f605be97ace092ac1262
+  metadata.gz: ccd76e94d73ec763de6290eaae3ec459221513c1
+  data.tar.gz: 525b88d710b5a74411060ed912651a71ff79fb0a
 SHA512:
-  metadata.gz: 23ca1e42e9cd13102c39baddab18983276c8e92a1049de7eb808c0978ebe4b7e1d007e602feb73f206c2dd1900671f916ceab344fa7900c58ddde61b5681e14f
-  data.tar.gz: df4d5880037892e005c253150bf25b6cdbe5a1d69cb298636870bde27e2b21dd690d86300eb2405f54cc426c70a74d016a761fdfef08d9799923234c4d024dc7
+  metadata.gz: 788fcb1ebfcd065bd3786b8a7ef7d52b2b74e1e04660ebd5756689ea37f10bc607f5f4251ea2317750477674c1d66a4fbcaf7edea9341f658b9dc1109a9a4553
+  data.tar.gz: 1ef020a747534e3a6949f54d098a0ebedaa8855e9f8d37d086f31db6a25679e6321c40086306b8902635e3016c1ace119ab9f6844ab58704aee16ccb6ebbc81e

data/CHANGELOG.md

@@ -9,3 +9,10 @@ Initial Release
     taken into account in the cache key; this will err toward expiring too much
     rather than too little, and will *always* do a count query regardless of
     whether the relation is loaded or not.
+
+## v0.1.1 - 2016-04-01
+
+Bugfix
+
+* Corrects a bug where models with a `#size` or `#timestamp` method could
+  fail to generate a proper cache key.

data/lib/collection_cache_key/cache_key.rb

@@ -25,8 +25,9 @@ module CollectionCacheKey
       column = "#{connection.quote_table_name(collection.table_name)}.#{connection.quote_column_name(timestamp_column)}"
       query = collection.dup
       result = query.select("COUNT(*) AS size, MAX(#{column}) AS timestamp").first
+      attrs = result.attributes
 
-      [query_key(collection), result.size, parsed_timestamp(result.timestamp)]
+      [query_key(collection), attrs['size'], parsed_timestamp(attrs['timestamp'])]
     end
 
     def query_key(collection)

data/lib/collection_cache_key/version.rb

@@ -2,7 +2,7 @@ module CollectionCacheKey
   module VERSION
     MAJOR = 0
     MINOR = 1
-    PATCH = 0
+    PATCH = 1
     PRE = nil
     STRING = [MAJOR, MINOR, PATCH, PRE].compact.join('.')
   end

data/test/lib/collection_cache_key_test.rb

@@ -35,6 +35,18 @@ class CollectionCacheKeyTest < CollectionCacheKey::TestCase
              .must_equal("#{cache_namespace}/query-#{digest}-10-#{original_time_str}")
     end
 
+    it 'avoids method name collisions with the key generation internals' do
+      subject.class_eval do
+        def size
+          999_999
+        end
+      end
+
+      digest = Digest::MD5.hexdigest(default_sql)
+      subject.collection_cache_key
+             .must_equal("#{cache_namespace}/query-#{digest}-10-#{original_time_str}")
+    end
+
     it 'updates the cache_key when a record changes' do
       subject.first.update_attributes(updated_at: update_time)
       digest = Digest::MD5.hexdigest(default_sql)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-collection_cache_key
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Dan Drinkard
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-21 00:00:00.000000000 Z
+date: 2016-04-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord