activerecord-cockroachdb-adapter 0.3.0.beta1 → 5.2.0.beta2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 48ca5207eae1d4bf1c26da960ad80e78f54099b1eb62466e89ff5186c9d41632
-  data.tar.gz: d3d8a5c38a3adda552b283663d4aaf88e05587b3ac9e0da28418fa05d72cfcdd
+  metadata.gz: ce049d6cebd6b2024fe869221ab66233f8b529c00acd33020733c8e6a4d2721f
+  data.tar.gz: 4f2f4442b80029ad6954fc3231350ce0a22a4d984c31d1db8ddc454b1f558d71
 SHA512:
-  metadata.gz: 955dca7f67f68b93fd2ebd19cd6027de446598c823abbc108ce5630fbf6d566c14c09e283f37e3d04fb306ff72a68e55f6856daea91a61f9488636f9da957920
-  data.tar.gz: 9cb056da8d37cd199427f2ae25d354bcb3fb606fde92e1c01fb2cef7eedd2122a9eccbf0b3693d7d0c7197f8ff8d7d4b1321d16d9212db4331673ddf5669b934
+  metadata.gz: d9ce3b5f71d8a342350781ebfad293cd4d152e7cffe432591f09383f32eb52322a2e7c0011ce665ce6c6331b5c1012d61729b7d377b3468bd626a7023b7c04fe
+  data.tar.gz: d9013df894826c090485affc94d66df70d2ac79ac48d85ffe305598c2decaf217ab317d5c86a0a794d096bd309cfaf14c9a671f96d26dece5b37b031913fe4e9

data/.gitignore

@@ -7,3 +7,4 @@
 /pkg/
 /spec/reports/
 /tmp/
+*.gem

data/CONTRIBUTING.md

@@ -46,19 +46,31 @@ Using [bundler](http://bundler.io/), install the dependancies of Rails.
 bundle install
 ```
 
-Then, to run the full ActiveRecord test suite with an active CockroachDB instance:
+Then, to run the full test suite with an active CockroachDB instance:
 
 ```bash
 bundle exec rake test
 ```
 
-To run specific tests, set environemnt variable `TEST_FILES_AR`. For example, to run ActiveRecord tests `test/cases/associations_test.rb` and `test/cases/ar_schema_test.rb.rb`
+To run specific ActiveRecord tests, set environemnt variable `TEST_FILES_AR`. For example, to run ActiveRecord tests `test/cases/associations_test.rb` and `test/cases/ar_schema_test.rb.rb`
 
 ```bash
 TEST_FILES_AR="test/cases/associations_test.rb,test/cases/ar_schema_test.rb" bundle exec rake test
 ```
 
-By default, tests will be run from the bundled version of Rails. To run against a local copy, set environemnt variable `RAILS_SOURCE`.
+To run specific CockroachDB Adapter tests, set environemnt variable `TEST_FILES`. For example, to run CockroachDB Adpater tests `test/cases/adapter_test.rb` and `test/cases/associations/left_outer_join_association_test.rb`
+
+```bash
+TEST_FILES="test/cases/adapter_test.rb,test/cases/associations/left_outer_join_association_test.rb" bundle exec rake test
+```
+
+To run a specific test case, use minitest's `-n` option to run tests that match a given pattern. All minitest options are set via the `TESTOPTS` environemnt variable. For example, to run `test_indexes` from CockroachDB's `test/cases/adapter_test.rb` file
+
+```bash
+TEST_FILES="test/cases/adapter_test.rb" TESTOPTS=`-n=/test_indexes/` bundle exec rake test
+```
+
+By default, tests will be run from the bundled version of Rails. To run against a local copy, set environemnt variable `RAILS_SOURCE`. Running against a local copy of Rails can be helpful when try to debug issues.
 
 ```bash
 RAILS_SOURCE="path/to/local_copy" bundle exec rake test

data/activerecord-cockroachdb-adapter.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = "activerecord-cockroachdb-adapter"
-  spec.version       = "0.3.0.beta1"
+  spec.version       = "5.2.0.beta2"
   spec.licenses      = ["Apache-2.0"]
   spec.authors       = ["Cockroach Labs"]
   spec.email         = ["cockroach-db@googlegroups.com"]

data/build/teamcity-test.sh

@@ -1,9 +1,9 @@
 #!/usr/bin/env bash
 
-set -euo pipefail
+set -euox pipefail
 
 # Download CockroachDB
-VERSION=v20.1.0-rc.1
+VERSION=v20.1.0-rc.2
 wget -qO- https://binaries.cockroachdb.com/cockroach-$VERSION.linux-amd64.tgz | tar  xvz
 readonly COCKROACH=./cockroach-$VERSION.linux-amd64/cockroach
 
@@ -21,7 +21,7 @@ run_cockroach() {
   cockroach quit --insecure || true
   rm -rf cockroach-data
   # Start CockroachDB.
-  cockroach start --insecure --host=localhost --listening-url-file="$urlfile" >/dev/null 2>&1 &
+  cockroach start-single-node --max-sql-memory=25% --cache=25% --insecure --host=localhost --listening-url-file="$urlfile" >/dev/null 2>&1 &
   # Ensure CockroachDB is stopped on script exit.
   trap "echo 'Exit routine: Killing CockroachDB.' && kill -9 $! &> /dev/null" EXIT
   # Wait until CockroachDB has started.
@@ -33,6 +33,9 @@ run_cockroach() {
   done
   cockroach sql --insecure -e 'CREATE DATABASE activerecord_unittest;'
   cockroach sql --insecure -e 'CREATE DATABASE activerecord_unittest2;'
+  cockroach sql --insecure -e 'SET CLUSTER SETTING sql.stats.automatic_collection.enabled = false;'
+  cockroach sql --insecure -e 'SET CLUSTER SETTING sql.stats.histogram_collection.enabled = false;'
+  cockroach sql --insecure -e "SET CLUSTER SETTING jobs.retention_time = '180s';"
 }
 
 # Install ruby dependencies.
@@ -41,7 +44,7 @@ bundle install
 
 run_cockroach
 
-if ! (bundle exec rake test); then
+if ! (RUBYOPT="-W0" TESTOPTS="-v" bundle exec rake test); then
     echo "Tests failed"
     HAS_FAILED=1
 else

data/docker.sh

@@ -2,7 +2,7 @@
 #
 # This file is largely cargo-culted from cockroachdb/cockroach/build/builder.sh.
 
-set -euo pipefail
+set -euox pipefail
 
 DOCKER_IMAGE_TAG=activerecord_test_container
 

data/lib/active_record/connection_adapters/cockroachdb_adapter.rb

@@ -56,6 +56,10 @@ module ActiveRecord
         100000
       end
 
+      def supports_bulk_alter?
+        false
+      end
+
       def supports_json?
         # FIXME(joey): Add a version check.
         true
@@ -103,8 +107,7 @@ module ActiveRecord
       end
 
       def supports_advisory_locks?
-        # FIXME(joey): We may want to make this false.
-        true
+        false
       end
 
       def supports_virtual_columns?

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-cockroachdb-adapter
 version: !ruby/object:Gem::Version
-  version: 0.3.0.beta1
+  version: 5.2.0.beta2
 platform: ruby
 authors:
 - Cockroach Labs
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-04-17 00:00:00.000000000 Z
+date: 2020-05-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord