activerecord-bitemporal 5.0.0 → 5.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 25ef613d84eda786e3d04e90aeb9cc95b68887a84863200aa0622be9e89c73ea
-  data.tar.gz: 63920865d4f8f27703b6ffeaf4e0c38d297ea4bff22bf01a3884136875b2ccde
+  metadata.gz: f0e6cafe3d918cd4bdf47c2610eaf3760cfcedbec0365a7675ef99790a05baaf
+  data.tar.gz: 79b7823949b22cbcacdfb75b561c70808135ebd3dc1c6a5ff0ef8152c75b8d79
 SHA512:
-  metadata.gz: 6fbe2830897e6c3f70f29431f591e8fa9cd332ae260e23ef3c23b7afff7259819bc54b8bb9de38d26c07a96c1cd3e93af5f5b7b559d2814b61b3cabfb3dcb2a6
-  data.tar.gz: 3e45d6a45de435475388a77a534521049b603bddc5910046fc5b8f4c2577ad25e75387f397014374d94b4d3c515c4e4456ff76c4673952f06b497446166a7927
+  metadata.gz: 4331c2b17a26dfea76b5c1c85a6a0feac925a1c0b7d634fa734e35e5f7732e0d49d04172ae4bf6af5ae62b213481bd09da7807312f241578e72f2a9ee952f640
+  data.tar.gz: 98ffa072e196a6af9b61ef01ee5e7d8e3ef83a94abd8f666738831783b35bb16551fd0bd1d561f76a6a55aa522d4609274ec3e6a6a78d311b7c76e53c860b1c4

data/.github/auto_assign.yml

@@ -6,15 +6,10 @@ addAssignees: false
 
 # A list of reviewers to be added to pull requests (GitHub user name)
 reviewers:
-  - Dooor
-  - QWYNG
-  - bonobono555
   - krororo
   - lighty
   - mkmn
-  - motsat
   - osyo-manga
-  - wakasa51
   - wata727
   - yono
 

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## 5.0.1
+
+- [Fix a typo #157](https://github.com/kufu/activerecord-bitemporal/pull/157)
+- [Remove unneeded unscope values #159](https://github.com/kufu/activerecord-bitemporal/pull/159)
+- [Remove unused `without_ignore` option #160](https://github.com/kufu/activerecord-bitemporal/pull/160)
+- [update auto assign #161](https://github.com/kufu/activerecord-bitemporal/pull/161)
+
 ## 5.0.0
 
 ### Breaking Changed

data/lib/activerecord-bitemporal/bitemporal.rb

@@ -577,7 +577,7 @@ module ActiveRecord
             target_datetime
           # NOTE: 新規作成時以外では target_datetime の値を基準としてバリデーションする
           # 更新時にバリデーションする場合、valid_from の時間ではなくて target_datetime の時間を基準としているため
-          # valdi_from を基準としてしまうと整合性が取れなくなってしまう
+          # valid_from を基準としてしまうと整合性が取れなくなってしまう
           elsif !record.new_record?
             target_datetime
           else

data/lib/activerecord-bitemporal/scope.rb

@@ -259,7 +259,7 @@ module ActiveRecord::Bitemporal
               :gteq   # column >= datetime
             ].each { |op|
               module_eval <<-STR, __FILE__, __LINE__ + 1
-                def _#{column}_#{op}(datetime,**)
+                def _#{column}_#{op}(datetime)
                   target_datetime = datetime&.in_time_zone || Time.current
                   bitemporal_rewhere_bind("#{column}", :#{op}, target_datetime)
                     .tap { |relation| break relation.bitemporal_rewhere_bind("#{column}", :#{op}, target_datetime, bitemporal_value[:through].arel_table) if bitemporal_value[:through] }
@@ -355,14 +355,9 @@ module ActiveRecord::Bitemporal
             relation.bitemporal_value[:with_transaction_datetime] = :default_scope
           end
 
-          # Calling scope was slow, so don't call scope
-          relation.unscope_values += [
-            { where: "#{table.name}.transaction_from" },
-            { where: "#{table.name}.transaction_to" }
-          ]
           relation = relation
-            ._transaction_from_lteq(transaction_datetime || datetime, without_ignore: true)
-            ._transaction_to_gt(transaction_datetime || datetime, without_ignore: true)
+            ._transaction_from_lteq(transaction_datetime || datetime)
+            ._transaction_to_gt(transaction_datetime || datetime)
         else
           relation.tap { |relation| relation.without_transaction_datetime unless ActiveRecord::Bitemporal.transaction_datetime }
         end
@@ -375,13 +370,9 @@ module ActiveRecord::Bitemporal
             relation.bitemporal_value[:with_valid_datetime] = :default_scope
           end
 
-          relation.unscope_values += [
-            { where: "#{table.name}.valid_from" },
-            { where: "#{table.name}.valid_to" }
-          ]
           relation = relation
-            ._valid_from_lteq(valid_datetime || datetime, without_ignore: true)
-            ._valid_to_gt(valid_datetime || datetime, without_ignore: true)
+            ._valid_from_lteq(valid_datetime || datetime)
+            ._valid_to_gt(valid_datetime || datetime)
         else
           relation.tap { |relation| relation.without_valid_datetime unless ActiveRecord::Bitemporal.valid_datetime }
         end

data/lib/activerecord-bitemporal/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveRecord
   module Bitemporal
-    VERSION = "5.0.0"
+    VERSION = "5.0.1"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-bitemporal
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 5.0.1
 platform: ruby
 authors:
 - SmartHR
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-02-02 00:00:00.000000000 Z
+date: 2024-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -190,7 +190,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.26
+rubygems_version: 3.3.27
 signing_key: 
 specification_version: 4
 summary: BiTemporal Data Model for ActiveRecord