activerecord-attribute_converter 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f5ac88613a83588985a6f7b7729ba74958bd5a53
-  data.tar.gz: c9d1fb6f43d5c45aeec99088a0c6d6f6252fc057
+  metadata.gz: 3aed40acbba4ac1426e88a436c565d9cc742a389
+  data.tar.gz: fa25229c80a6e19ba9e1415dbba58c08bf547740
 SHA512:
-  metadata.gz: 0302cc8783014305e5de3597c455ce5d72b44fe81cc760eff5ab649c18cd135ae8594f1780bfaef8bf46ac3a5c37bc2063c3f6ba1d174578e815d6e228d37e2c
-  data.tar.gz: 7aec1c0d8d9b5067dc709180360d9d9ef5dfbe5fc043f73c13c3a6743da3e7a23e52ea8b186f70c9d24e268e75f9707a17ecf70a52d7262dae82e57a011733d9
+  metadata.gz: 6b7ff3b653bb30f2875dd5b72d9eda469403d73988ea56cffef1e19cb86da00ebabe7d198aafc947d865a1d3eb9242eb4506ed988773af15f4b96b0dcd24c52f
+  data.tar.gz: 025f70ac0557b428b0ac6e477a7df940e67e6e35e8046ff69413bf4038c2ee18d324687d1473e494267b39d2318ccdc63414e02d1ad046da9b52106a3e62fb08

data/CHANGELOG.md

@@ -1,2 +1,8 @@
-## 2014-03-17
+## 0.1.2 (2014-03-18)
+- Use ActiveRecord serializer instead of callbacks
+
+## 0.1.1 (2014-03-18)
+- Require modules eagerly
+
+## 0.1.0 (2014-03-17)
 - Initial release

data/lib/activerecord/attribute_converter.rb

@@ -5,7 +5,7 @@ require 'activerecord/attribute_converter/relation'
 require 'activerecord/attribute_converter/version'
 
 ActiveSupport.on_load(:active_record) do
-  ActiveRecord::Base.send(:include, ActiveRecord::AttributeConverter::Base)
+  ActiveRecord::Base.send(:extend, ActiveRecord::AttributeConverter::Base)
 
   ActiveRecord::PredicateBuilder.singleton_class.class_eval do
     include ActiveRecord::AttributeConverter::PredicateBuilder

data/lib/activerecord/attribute_converter/base.rb

@@ -1,47 +1,31 @@
-require 'active_support/concern'
-
 module ActiveRecord
   module AttributeConverter
     module Base
-      extend ActiveSupport::Concern
-
-      def internalize_attributes
-        self.class.attribute_converters.each do |attr, converter|
-          if attributes.has_key?(attr)
-            send("#{attr}=", converter.internalize(send(attr)))
-          end
+      class Serializer
+        def initialize(converter)
+          @converter = converter
         end
-      end
 
-      def externalize_attributes
-        self.class.attribute_converters.each do |attr, converter|
-          if attributes.has_key?(attr)
-            send("#{attr}=", converter.externalize(send(attr)))
-          end
+        def dump(obj)
+          @converter.internalize(obj)
         end
-      end
-
-      module ClassMethods
-        def apply_converter(attr, converter)
-          unless @attribute_converters
-            install_attribute_converter
-          end
 
-          self.attribute_converters[attr.to_s] = converter
+        def load(obj)
+          @converter.externalize(obj)
         end
+      end
 
-        def install_attribute_converter
+      def apply_converter(attr, converter)
+        unless @attribute_converters
           @attribute_converters = {}
-
-          before_save :internalize_attributes
-
-          after_save :externalize_attributes
-          after_find :externalize_attributes
         end
 
-        def attribute_converters
-          @attribute_converters || {}
-        end
+        serialize attr, Serializer.new(converter)
+        self.attribute_converters[attr.to_s] = converter
+      end
+
+      def attribute_converters
+        @attribute_converters || {}
       end
     end
   end

data/lib/activerecord/attribute_converter/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module AttributeConverter
-    VERSION = "0.1.1"
+    VERSION = "0.1.2"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-attribute_converter
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Kohei Suzuki