activerabbit-ai 0.4.5 → 0.4.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e2afb9bf892d3e3a7e83a65e224c791855aa7d6e86feb476ee0f66c108f617cd
-  data.tar.gz: 20e74e7fa56e865bd707ccd852e62894fa73fc1d5ac2145d7d6a606dff351722
+  metadata.gz: 06e58258544f159566a756467253a1a2a6a0a696479b37cd1f265902928a3f8c
+  data.tar.gz: e12b3dcd16a43ca524027e2b0ecd608d8bbe0441f2f89586d7bb5d1f57dbda1a
 SHA512:
-  metadata.gz: 40e742a6578a155441efe51fd97de272e8bfc7fe2e024cc2abe17e29ac2ee664079c6eb3093ae0aa311dea8f5438c96b60d88ba0a50e2477fdc2cc01b7b32006
-  data.tar.gz: 55fe08ec494af877576561418a7d3c9b63fd0b0bd34d3c04c3e59d5cb39d3d032992369ac056dc6e2417e75bad363fb5ac1dce115d3150765be7870b7859c34b
+  metadata.gz: eb2e853ad6f3791c567a9498af2a6684756042d0b7fa626e94ae057910422a594f0d705f5fbc923334af52c110062701db37c86766d14be17ef41d495e758fae
+  data.tar.gz: d498e0a7c16cb8abeb8c96724caf88ad32ac598e0d84994c90712de3e8f182a763aaeda73f39c8a3f94b00c31ff1b5b3629535946313a8adec952ccb0bf0466b

data/CHANGELOG.md

@@ -2,6 +2,35 @@
 
 All notable changes to this project will be documented in this file.
 
+## [0.4.7] - 2025-11-06
+
+### Fixed
+- **Multiple duplicate events**: Disabled Rails Error Reporter and rack.exception fallback subscriptions
+- These mechanisms were creating 3-4 duplicate events for each error
+- Middleware is now the single source of truth for error capture, providing the best context
+- Each error now creates exactly ONE event instead of 3-4
+
+### Changed
+- Rails Error Reporter subscription: DISABLED (middleware captures all controller errors)
+- rack.exception subscription: DISABLED (middleware captures all rack-level errors)
+- Middleware remains as the primary and only error capture mechanism
+
+## [0.4.6] - 2025-11-05
+
+### Fixed
+- **Duplicate issues bug**: Fixed error reporting creating duplicate issues with "unknown" controller_action
+- Error Reporter now properly extracts controller/action from Rails routing context
+- `rack.exception` fallback now also extracts controller_action correctly
+- All error capture mechanisms now produce consistent controller_action values, preventing duplicate issue grouping
+
+### Details
+Previously, the same error could create multiple issues in the dashboard:
+- Middleware capture: `TestController#action` ✓
+- Rails Error Reporter: `unknown` ✗ (created duplicate)
+- Rack.exception fallback: `unknown` ✗ (created duplicate)
+
+Now all mechanisms extract and use the same controller_action format, ensuring errors are properly grouped into a single issue.
+
 ## [0.4.4] - 2025-10-22
 
 ### Improved

data/lib/active_rabbit/client/error_reporter.rb

@@ -56,6 +56,20 @@ module ActiveRabbit
             # Top-level convenience for UI
             ctx[:request_path] = ctx[:request][:path]
             ctx[:request_method] = ctx[:request][:method]
+            
+            # Extract controller_action from routing info to prevent duplicate issues
+            routing = req_info[:routing]
+            if routing && routing[:controller] && routing[:action]
+              controller_name = routing[:controller].to_s
+              action_name = routing[:action].to_s
+              ctx[:controller_action] = "#{controller_name}##{action_name}"
+            end
+          else
+            # Fallback: Try to extract from controller instance in context
+            controller = context && (context[:controller] || context['controller'])
+            if controller && controller.respond_to?(:controller_name) && controller.respond_to?(:action_name)
+              ctx[:controller_action] = "#{controller.controller_name.camelize}Controller##{controller.action_name}"
+            end
           end
 
           if defined?(ActionController::RoutingError) && exception.is_a?(ActionController::RoutingError)

data/lib/active_rabbit/client/performance_monitor.rb

@@ -77,10 +77,22 @@ module ActiveRabbit
       private
 
       def build_performance_data(name:, duration_ms:, metadata:)
+        metadata = metadata || {}
+
+        # Extract important fields from metadata for top-level inclusion
+        controller = metadata[:controller] || metadata["controller"]
+        action = metadata[:action] || metadata["action"]
+        controller_action = "#{controller}##{action}" if controller && action
+
         data = {
           name: name.to_s,
           duration_ms: duration_ms.to_f,
-          metadata: scrub_pii(metadata || {}),
+          db_duration_ms: metadata[:db_runtime] || metadata["db_runtime"],
+          view_duration_ms: metadata[:view_runtime] || metadata["view_runtime"],
+          controller_action: controller_action,
+          request_path: metadata[:path] || metadata["path"],
+          request_method: metadata[:method] || metadata["method"],
+          metadata: scrub_pii(metadata),
           timestamp: Time.now.iso8601(3),
           environment: configuration.environment,
           release: configuration.release,

data/lib/active_rabbit/client/railtie.rb

@@ -59,25 +59,26 @@ module ActiveRabbit
         # Defer complex subscriptions until after initialization
         app.config.after_initialize do
 
-          # Fallback: low-level rack.exception subscription (older Rails and deep middleware errors)
-          ActiveSupport::Notifications.subscribe("rack.exception") do |*args|
-            begin
-              payload = args.last
-              exception = payload[:exception_object]
-              env = payload[:env]
-              next unless exception
-
-              ActiveRabbit::Reporting.report_exception(
-                exception,
-                env: env,
-                handled: false,
-                source: "rack.exception",
-                force: true
-              )
-            rescue => e
-              Rails.logger.error "[ActiveRabbit] Error handling rack.exception: #{e.class}: #{e.message}" if defined?(Rails)
-            end
-          end
+          # DISABLED: rack.exception creates duplicate events because middleware already catches all errors
+          # The middleware is the primary error capture mechanism and catches errors at the optimal level
+          # ActiveSupport::Notifications.subscribe("rack.exception") do |*args|
+          #   begin
+          #     payload = args.last
+          #     exception = payload[:exception_object]
+          #     env = payload[:env]
+          #     next unless exception
+          #
+          #     ActiveRabbit::Reporting.report_exception(
+          #       exception,
+          #       env: env,
+          #       handled: false,
+          #       source: "rack.exception",
+          #       force: true
+          #     )
+          #   rescue => e
+          #     Rails.logger.error "[ActiveRabbit] Error handling rack.exception: #{e.class}: #{e.message}" if defined?(Rails)
+          #   end
+          # end
         end
       end
 
@@ -287,10 +288,11 @@ module ActiveRabbit
       end
 
       initializer "active_rabbit.error_reporter" do |app|
-        # Defer attaching so application config has been applied
-        app.config.after_initialize do
-          ActiveRabbit::Client::ErrorReporter.attach!
-        end
+        # DISABLED: Rails error reporter creates duplicate events because middleware already catches all errors
+        # The middleware provides better context and catches errors at the right level
+        # app.config.after_initialize do
+        #   ActiveRabbit::Client::ErrorReporter.attach!
+        # end
       end
 
       initializer "active_rabbit.sidekiq" do
@@ -402,6 +404,7 @@ module ActiveRabbit
             duration_ms = ((finished - started) * 1000).round(2)
 
             Rails.logger.info "[ActiveRabbit] 📊 Controller action: #{payload[:controller]}##{payload[:action]} - #{duration_ms}ms"
+            Rails.logger.info "[ActiveRabbit] 📊 DB runtime: #{payload[:db_runtime]}, View runtime: #{payload[:view_runtime]}"
 
             ActiveRabbit::Client.track_performance(
               "controller.action",

data/lib/active_rabbit/client/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveRabbit
   module Client
-    VERSION = "0.4.5"
+    VERSION = "0.4.7"
   end
 end

data/lib/active_rabbit/reporting.rb

@@ -16,6 +16,14 @@ module ActiveRabbit
       enriched_context[:source] ||= source
       enriched_context[:handled] = handled if !enriched_context.key?(:handled)
 
+      # Extract controller_action from routing info to prevent duplicate issues
+      routing = req_info[:routing]
+      if routing && routing[:controller] && routing[:action] && !enriched_context[:controller_action]
+        controller_name = routing[:controller].to_s
+        action_name = routing[:action].to_s
+        enriched_context[:controller_action] = "#{controller_name}##{action_name}"
+      end
+
       # Enrich for routing errors so UI shows controller action and 404 specifics
       if defined?(ActionController::RoutingError) && exception.is_a?(ActionController::RoutingError)
         enriched_context[:controller_action] ||= 'Routing#not_found'

data/lib/active_rabbit.rb

@@ -4,11 +4,4 @@ require_relative "active_rabbit/client"
 require_relative "active_rabbit/routing/not_found_app"
 
 # Load Rails integration
-if defined?(Rails)
-  begin
-    require_relative "active_rabbit/client/railtie"
-  rescue => e
-    warn "[ActiveRabbit] Rails integration failed: #{e.message}" if Rails.env&.development?
-    warn "[ActiveRabbit] Backtrace: #{e.backtrace.first(5).join(', ')}" if Rails.env&.development?
-  end
-end
+require_relative "active_rabbit/client/railtie" if defined?(Rails)

data/lib/activerabbit-ai.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+# Compatibility loader for Bundler and Rails autoloading
+# because gem names cannot map "-" to "_" automatically.
+# This ensures `require "activerabbit-ai"` loads the real code.
+
+require_relative "active_rabbit"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerabbit-ai
 version: !ruby/object:Gem::Version
-  version: 0.4.5
+  version: 0.4.7
 platform: ruby
 authors:
 - Alex Shapalov
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-10-25 00:00:00.000000000 Z
+date: 2025-11-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -81,6 +81,7 @@ files:
 - README.md
 - Rakefile
 - TESTING_GUIDE.md
+- activerabbit-ai-0.4.5.gem
 - check_api_data.rb
 - examples/rails_app_testing.rb
 - examples/rails_integration.rb
@@ -105,6 +106,7 @@ files:
 - lib/active_rabbit/middleware/error_capture_middleware.rb
 - lib/active_rabbit/reporting.rb
 - lib/active_rabbit/routing/not_found_app.rb
+- lib/activerabbit-ai.rb
 - script/test_production_readiness.rb
 - script/test_rails_integration.rb
 - setup_local_gem_testing.sh