activemodel 7.2.1.2 → 7.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5f15df1a8704856788191a6dd2ff7a4dcbfc97bc39f1010fc10291f00b4f8541
-  data.tar.gz: 7bb664e8f4b317d7524a3fce9ecfa9050e26e52abb5f145be7da30a447250ffe
+  metadata.gz: '083ab781edd077dd1864bceb8ad069bde3954eaa020c84dddf2cd6c74490ab6a'
+  data.tar.gz: dd7682a299773c0d0e07b43d662ec98cefca8922eeca8ba6fe80856296c32f03
 SHA512:
-  metadata.gz: 14ed78c9526acc0f729488c0005926c11d30a4a25144d234d3c15e63b9021e68618646cdd4fc7e1729dfe2ec669bd6da65c602946e582d6b88799368d53eb920
-  data.tar.gz: fcfcdf7ad2cdb6ba0dd9c72774023fddbcfa863da95d2bb77e4b98977d2943b487814e2f91253da840238addcc216f1a4f5bbcdb728a8fdc2b61d0169e656d58
+  metadata.gz: cb3a9de619551c4a7685880566cbd1a8c3f230d8669980037d54611912e41772679f894625e6947ab5abeed2e974bc07cc03addbb99907ebed1927ee08d8cee2
+  data.tar.gz: 8c723612cdf1701f67977db5f8b2634c3e5e836a1c9bb6542bfba8b459b3ccb4762db96e9854be993a947f4b946a89a4f4f2e82d493f20672ed9494db0d980c6

data/CHANGELOG.md

@@ -1,3 +1,25 @@
+## Rails 7.2.2 (October 30, 2024) ##
+
+*   Fix regression in `alias_attribute` to work with user defined methods.
+
+    `alias_attribute` would wrongly assume the attribute accessor was generated by Active Model.
+
+    ```ruby
+    class Person
+      include ActiveModel::AttributeMethods
+
+      define_attribute_methods :name
+      attr_accessor :name
+
+      alias_attribute :full_name, :name
+    end
+
+    person.full_name # => NoMethodError: undefined method `attribute' for an instance of Person
+    ```
+
+    *Jean Boussier*
+
+
 ## Rails 7.2.1.2 (October 23, 2024) ##
 
 *   No changes.

data/lib/active_model/attribute_methods.rb

@@ -215,7 +215,12 @@ module ActiveModel
       end
 
       def generate_alias_attribute_methods(code_generator, new_name, old_name)
-        define_attribute_method(old_name, _owner: code_generator, as: new_name)
+        ActiveSupport::CodeGenerator.batch(code_generator, __FILE__, __LINE__) do |owner|
+          attribute_method_patterns.each do |pattern|
+            alias_attribute_method_definition(code_generator, pattern, new_name, old_name)
+          end
+          attribute_method_patterns_cache.clear
+        end
       end
 
       def alias_attribute_method_definition(code_generator, pattern, new_name, old_name) # :nodoc:
@@ -228,7 +233,7 @@ module ActiveModel
         call_args = []
         call_args << parameters if parameters
 
-        define_call(code_generator, method_name, target_name, mangled_name, parameters, call_args, namespace: :alias_attribute)
+        define_call(code_generator, method_name, target_name, mangled_name, parameters, call_args, namespace: :alias_attribute, as: method_name)
       end
 
       # Is +new_name+ an alias?
@@ -441,7 +446,7 @@ module ActiveModel
           mangled_name = name
 
           unless NAME_COMPILABLE_REGEXP.match?(name)
-            mangled_name = "__temp__#{name.unpack1("h*")}"
+            mangled_name = :"__temp__#{name.unpack1("h*")}"
           end
 
           mangled_name

data/lib/active_model/gem_version.rb

@@ -9,8 +9,8 @@ module ActiveModel
   module VERSION
     MAJOR = 7
     MINOR = 2
-    TINY  = 1
-    PRE   = "2"
+    TINY  = 2
+    PRE   = nil
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activemodel
 version: !ruby/object:Gem::Version
-  version: 7.2.1.2
+  version: 7.2.2
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-10-23 00:00:00.000000000 Z
+date: 2024-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.2.1.2
+        version: 7.2.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.2.1.2
+        version: 7.2.2
 description: A toolkit for building modeling frameworks like Active Record. Rich support
   for attributes, callbacks, validations, serialization, internationalization, and
   testing.
@@ -112,10 +112,10 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/rails/rails/issues
-  changelog_uri: https://github.com/rails/rails/blob/v7.2.1.2/activemodel/CHANGELOG.md
-  documentation_uri: https://api.rubyonrails.org/v7.2.1.2/
+  changelog_uri: https://github.com/rails/rails/blob/v7.2.2/activemodel/CHANGELOG.md
+  documentation_uri: https://api.rubyonrails.org/v7.2.2/
   mailing_list_uri: https://discuss.rubyonrails.org/c/rubyonrails-talk
-  source_code_uri: https://github.com/rails/rails/tree/v7.2.1.2/activemodel
+  source_code_uri: https://github.com/rails/rails/tree/v7.2.2/activemodel
   rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []