activemerchant 1.71.0 → 1.72.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fff082133e880818be78a31b9df09e0c8e03e3a2
-  data.tar.gz: 47044f1c90dc309d2bc1f63fd7de727313c5b6de
+  metadata.gz: 91813c36ae054c9add904f9965d29cfac9a24c35
+  data.tar.gz: d2cb404a124499f46cf62905fe0233ec3a34d39e
 SHA512:
-  metadata.gz: 3e2990e84e388fd93ab8030964ec8b01835c9a133a871b458c49a20ccfaa98280d1a6849f46f5633cf5a4405e8031a32cbd84ad75615c9bb44c93cd0b9c6555a
-  data.tar.gz: 6f255b508c3ff0de4151bd38344c144f0c138166f716f9a262938709f463a24f2711d6f801402dd3600ad61c15c76b5ccc31932a8ef16b0abaa4d7adf3f5b6d6
+  metadata.gz: ff2929501d9e434b2ffa8b47be745ae8fcb58ddafb2a74dcdfb7ce7699714f4605c7f75cb9bfccb9b917c9e24c2e01061ca49461573e6f1e0031c194f80869a7
+  data.tar.gz: 9fef03d8d88743d0396c359f0c29ce0a1d617d93c9c9c696ad48d9f0b3e2830dfe3ce524a5ee84f4432dd581bd48b18d0cae6e70c48db5e0d08978c68f6ca853

data/CHANGELOG

@@ -2,6 +2,27 @@
 
 == HEAD
 
+== Version 1.72.0 (September 20, 2017)
+* Adyen: Fix failing remote tests [dtykocki] #2584
+* Authorize.net: Remove numeric restriction on customer ID [dtykocki] #2579
+* Authorize.net: Restore default state value for non-US addresses [jasonwebster] #2563
+* Beanstream: Do not default state and zip with empty country [dtykocki] #2582
+* Braintree Blue: Add eci_indicator field for Apple Pay [davidsantoso] #2565
+* Conekta: Add guard clause for details fallbacks [curiousepic] #2573
+* Conekta: Pull required details from billing address [nfarve] #2568
+* DataCash: Enable refunding recurring transactions [davidsantoso] #2560
+* Ebanx: Adds Brazil Specific Parameters [nfarve] #2559
+* Kushki: Add support for refunds [dtykocki] #2575
+* MercadoPago: Additional tweaks for transaction requests [davidsantoso]
+* MercadoPago: Default to alphanumeric order_id [davidsantoso]
+* MercadoPago: Send diners_club cards as diners [davidsantoso] #2585
+* PayU Latam: Correctly condition buyer element fields [curiousepic] #2578
+* PayU Latam: Pass unique buyer fields and country requirements [curiousepic] #2570
+* Qvalent: Support general credit [curiousepic] #2558
+* SafeCharge: Update to Version 4.1.0 [nfarve] #2556
+* WePay: Don't default API version header [curiousepic] #2567
+* WePay: Don't require email for Store [curiousepic] #2588
+
 == Version 1.71.0 (August 22, 2017)
 * Bambora formerly Beanstream: Change casing on customerIp variable [aengusbates] #2551
 * Checkout V2: Add localized_amount support to add_invoice function [nicolas-maalouf-cko] #2452
@@ -19,6 +40,7 @@
 * TransFirst Express: Fix Optional Fields Being Passed Blank [nfarve] #2550
 * TransFirst: Fix partial refund [nfarve] #2541
 * Vantiv (Litle): Pass 3DS fields [curiousepic] #2536
+* Braintree Blue: Add phone to options [deedeelavinder] #2564
 
 == Version 1.70.0 (August 4, 2017)
 * Barclaycard Smartpay: Provider a default billing address house number [nfarve] #2520

data/lib/active_merchant/billing/gateways/authorize_net.rb

@@ -535,7 +535,7 @@ module ActiveMerchant
 
       def add_customer_data(xml, payment_source, options)
         xml.customer do
-          xml.id(options[:customer]) unless empty?(options[:customer]) || options[:customer] !~ /^\d+$/
+          xml.id(options[:customer]) unless empty?(options[:customer]) || options[:customer] !~ /^\w+$/
           xml.email(options[:email]) unless empty?(options[:email])
         end
 
@@ -719,7 +719,7 @@ module ActiveMerchant
         if ["US", "CA"].include?(address[:country])
           address[:state] || 'NC'
         else
-          address[:state]
+          address[:state] || 'n/a'
         end
       end
 

data/lib/active_merchant/billing/gateways/beanstream/beanstream_core.rb

@@ -1,6 +1,8 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     module BeanstreamCore
+      include Empty
+
       RECURRING_URL = 'https://www.beanstream.com/scripts/recurring_billing.asp'
       SECURE_PROFILE_URL = 'https://www.beanstream.com/scripts/payment_profile.asp'
 
@@ -177,6 +179,7 @@ module ActiveMerchant #:nodoc:
       end
 
       private
+
       def purchase_action(source)
         if source.is_a?(Check)
           :check_purchase
@@ -227,7 +230,7 @@ module ActiveMerchant #:nodoc:
           post[:ordAddress1]      = billing_address[:address1]
           post[:ordAddress2]      = billing_address[:address2]
           post[:ordCity]          = billing_address[:city]
-          post[:ordProvince]      = STATES[billing_address[:state].upcase] || billing_address[:state] if billing_address[:state]
+          post[:ordProvince]      = state_for(billing_address)
           post[:ordPostalCode]    = billing_address[:zip]
           post[:ordCountry]       = billing_address[:country]
         end
@@ -238,7 +241,7 @@ module ActiveMerchant #:nodoc:
           post[:shipAddress1]     = shipping_address[:address1]
           post[:shipAddress2]     = shipping_address[:address2]
           post[:shipCity]         = shipping_address[:city]
-          post[:shipProvince]     = STATES[shipping_address[:state].upcase] || shipping_address[:state] if shipping_address[:state]
+          post[:shipProvince]     = state_for(shipping_address)
           post[:shipPostalCode]   = shipping_address[:zip]
           post[:shipCountry]      = shipping_address[:country]
           post[:shippingMethod]   = shipping_address[:shipping_method]
@@ -246,8 +249,13 @@ module ActiveMerchant #:nodoc:
         end
       end
 
+      def state_for(address)
+        STATES[address[:state].upcase] || address[:state] if address[:state]
+      end
+
       def prepare_address_for_non_american_countries(options)
         [ options[:billing_address], options[:shipping_address] ].compact.each do |address|
+          next if empty?(address[:country])
           unless ['US', 'CA'].include?(address[:country])
             address[:state] = '--'
             address[:zip]   = '000000' unless address[:zip]

data/lib/active_merchant/billing/gateways/braintree_blue.rb

@@ -158,6 +158,8 @@ module ActiveMerchant #:nodoc:
             :first_name => creditcard.first_name,
             :last_name => creditcard.last_name,
             :email => scrub_email(options[:email]),
+            :phone => options[:phone] || (options[:billing_address][:phone] if options[:billing_address] &&
+				      options[:billing_address][:phone]),
             :credit_card => credit_card_params
           )
           Response.new(result.success?, message_from_result(result),
@@ -228,6 +230,8 @@ module ActiveMerchant #:nodoc:
             :first_name => creditcard.first_name,
             :last_name => creditcard.last_name,
             :email => scrub_email(options[:email]),
+            :phone => options[:phone] || (options[:billing_address][:phone] if options[:billing_address] &&
+	            options[:billing_address][:phone]),
             :id => options[:customer],
           }.merge credit_card_params
           result = @braintree_gateway.customer.create(merge_credit_card_options(parameters, options))
@@ -312,7 +316,7 @@ module ActiveMerchant #:nodoc:
           :region => address[:state],
           :postal_code => scrub_zip(address[:zip]),
         }
-        if(address[:country] || address[:country_code_alpha2])
+        if (address[:country] || address[:country_code_alpha2])
           mapped[:country_code_alpha2] = (address[:country] || address[:country_code_alpha2])
         elsif address[:country_name]
           mapped[:country_name] = address[:country_name]
@@ -451,6 +455,7 @@ module ActiveMerchant #:nodoc:
       def customer_hash(customer, include_credit_cards=false)
         hash = {
           "email" => customer.email,
+          "phone" => customer.phone,
           "first_name" => customer.first_name,
           "last_name" => customer.last_name,
           "id" => customer.id
@@ -492,7 +497,8 @@ module ActiveMerchant #:nodoc:
 
         customer_details = {
           "id" => transaction.customer_details.id,
-          "email" => transaction.customer_details.email
+          "email" => transaction.customer_details.email,
+          "phone" => transaction.customer_details.phone,
         }
 
         billing_details = {
@@ -541,7 +547,9 @@ module ActiveMerchant #:nodoc:
           :order_id => options[:order_id],
           :customer => {
             :id => options[:store] == true ? "" : options[:store],
-            :email => scrub_email(options[:email])
+            :email => scrub_email(options[:email]),
+            :phone => options[:phone] || (options[:billing_address][:phone] if options[:billing_address] &&
+	            options[:billing_address][:phone])
           },
           :options => {
             :store_in_vault => options[:store] ? true : false,
@@ -582,7 +590,8 @@ module ActiveMerchant #:nodoc:
                 :expiration_month => credit_card_or_vault_id.month.to_s.rjust(2, "0"),
                 :expiration_year => credit_card_or_vault_id.year.to_s,
                 :cardholder_name => credit_card_or_vault_id.name,
-                :cryptogram => credit_card_or_vault_id.payment_cryptogram
+                :cryptogram => credit_card_or_vault_id.payment_cryptogram,
+                :eci_indicator => credit_card_or_vault_id.eci
               }
           elsif credit_card_or_vault_id.source == :android_pay
               parameters[:android_pay_card] = {

data/lib/active_merchant/billing/gateways/conekta.rb

@@ -82,16 +82,15 @@ module ActiveMerchant #:nodoc:
 
       def add_details_data(post, options)
         details = {}
-        details[:name] = options[:customer] if options[:customer]
+        details[:name] = options[:customer] || (options[:billing_address][:name] if options[:billing_address])
+        details[:phone] = options[:phone] || (options[:billing_address][:phone] if options[:billing_address])
         details[:email] = options[:email] if options[:email]
-        details[:phone] = options[:phone] if options[:phone]
-        post[:device_fingerprint] = options[:device_fingerprint] if options[:device_fingerprint]
         details[:ip] = options[:ip] if options[:ip]
         add_billing_address(details, options)
         add_line_items(details, options)
         add_shipment(details, options)
-
         post[:details] = details
+        post[:device_fingerprint] = options[:device_fingerprint] if options[:device_fingerprint]
       end
 
       def add_shipment(post, options)

data/lib/active_merchant/billing/gateways/data_cash.rb

@@ -168,6 +168,7 @@ module ActiveMerchant
             unless money.nil?
               xml.tag! :TxnDetails do
                 xml.tag! :amount, amount(money)
+                xml.tag! :capturemethod, 'ecomm'
               end
             end
           end
@@ -188,6 +189,7 @@ module ActiveMerchant
             xml.tag! :TxnDetails do
               xml.tag! :merchantreference, format_reference_number(options[:order_id])
               xml.tag! :amount, amount(money)
+              xml.tag! :capturemethod, 'ecomm'
             end
           end
         end

data/lib/active_merchant/billing/gateways/ebanx.rb

@@ -48,7 +48,7 @@ module ActiveMerchant #:nodoc:
         add_customer_data(post, payment, options)
         add_payment(post, payment)
         add_address(post, options)
-
+        add_customer_responsible_person(post, payment, options) if post[:payment][:country] == 'BR'
         commit(:purchase, post)
       end
 
@@ -60,6 +60,7 @@ module ActiveMerchant #:nodoc:
         add_customer_data(post, payment, options)
         add_payment(post, payment)
         add_address(post, options)
+        add_customer_responsible_person(post, payment, options) if post[:payment][:country] == 'BR'
         post[:payment][:creditcard][:auto_capture] = false
 
         commit(:authorize, post)
@@ -129,6 +130,14 @@ module ActiveMerchant #:nodoc:
         post[:payment][:name] = payment.name
         post[:payment][:email] = options[:email] || "unspecified@example.com"
         post[:payment][:document] = options[:document]
+        post[:payment][:birth_date] = options[:birth_date] if options[:birth_date]
+      end
+
+      def add_customer_responsible_person(post, payment,  options)
+        post[:payment][:responsible] = {}
+        post[:payment][:responsible][:name] = payment.name
+        post[:payment][:responsible][:document] = options[:document]
+        post[:payment][:responsible][:birth_date] = options[:birth_date] if options[:birth_date]
       end
 
       def add_address(post, options)
@@ -147,6 +156,7 @@ module ActiveMerchant #:nodoc:
         post[:payment][:amount_total] = amount(money)
         post[:payment][:currency_code] = (options[:currency] || currency(money))
         post[:payment][:merchant_payment_code] = options[:order_id]
+        post[:payment][:instalments] = options[:instalments] || 1
       end
 
       def add_payment(post, payment)

data/lib/active_merchant/billing/gateways/kushki.rb

@@ -24,6 +24,15 @@ module ActiveMerchant #:nodoc:
         end
       end
 
+      def refund(amount, authorization, options={})
+        action = "refund"
+
+        post = {}
+        post[:ticketNumber] = authorization
+
+        commit(action, post)
+      end
+
       def void(authorization, options={})
         action = "void"
 
@@ -129,7 +138,8 @@ module ActiveMerchant #:nodoc:
       ENDPOINT = {
         "tokenize" => "tokens",
         "charge" => "charges",
-        "void" => "charges"
+        "void" => "charges",
+        "refund" => "refund"
       }
 
       def commit(action, params)
@@ -152,7 +162,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def ssl_invoke(action, params)
-        if action == "void"
+        if ["void", "refund"].include?(action)
           ssl_request(:delete, url(action, params), nil, headers(action))
         else
           ssl_post(url(action, params), post_data(params), headers(action))
@@ -174,8 +184,8 @@ module ActiveMerchant #:nodoc:
       def url(action, params)
         base_url = test? ? test_url : live_url
 
-        if action == "void"
-          base_url + ENDPOINT[action] + "/" + params[:ticketNumber]
+        if ["void", "refund"].include?(action)
+          base_url + ENDPOINT[action] + "/" + params[:ticketNumber].to_s
         else
           base_url + ENDPOINT[action]
         end
@@ -194,7 +204,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def success_from(response)
-        return true if response["token"] || response["ticketNumber"]
+        return true if response["token"] || response["ticketNumber"] || response["code"] == "K000"
       end
 
       def message_from(succeeded, response)

data/lib/active_merchant/billing/gateways/mercado_pago.rb

@@ -10,6 +10,11 @@ module ActiveMerchant #:nodoc:
       self.display_name = 'Mercado Pago'
       self.money_format = :dollars
 
+      CARD_BRAND = {
+        "american_express" => "amex",
+        "diners_club" => "diners"
+      }
+
       def initialize(options={})
         requires!(options, :access_token)
         super
@@ -18,7 +23,7 @@ module ActiveMerchant #:nodoc:
       def purchase(money, payment, options={})
         MultiResponse.run do |r|
           r.process { commit("tokenize", "card_tokens", card_token_request(money, payment, options)) }
-          options.merge!(card_brand: payment.brand)
+          options.merge!(card_brand: (CARD_BRAND[payment.brand] || payment.brand))
           options.merge!(card_token: r.authorization.split("|").first)
           r.process { commit("purchase", "payments", purchase_request(money, payment, options) ) }
         end
@@ -27,7 +32,7 @@ module ActiveMerchant #:nodoc:
       def authorize(money, payment, options={})
         MultiResponse.run do |r|
           r.process { commit("tokenize", "card_tokens", card_token_request(money, payment, options)) }
-          options.merge!(card_brand: payment.brand)
+          options.merge!(card_brand: (CARD_BRAND[payment.brand] || payment.brand))
           options.merge!(card_token: r.authorization.split("|").first)
           r.process { commit("authorize", "payments", authorize_request(money, payment, options) ) }
         end
@@ -80,7 +85,13 @@ module ActiveMerchant #:nodoc:
         post[:security_code] = payment.verification_value
         post[:expiration_month] = payment.month
         post[:expiration_year] = payment.year
-        post[:cardholder] = { name: payment.name }
+        post[:cardholder] = {
+          name: payment.name,
+          identification: {
+            type: options[:cardholder_identification_type],
+            number: options[:cardholder_identification_number]
+          }
+        }
         post
       end
 
@@ -126,8 +137,7 @@ module ActiveMerchant #:nodoc:
             payer: {
               address: {
                 zip_code: address[:zip],
-                street_number: split_street_address(address[:address1]).first,
-                street_name: split_street_address(address[:address1]).last
+                street_name: "#{address[:address1]} #{address[:address2]}"
               }
             }
           })
@@ -141,9 +151,7 @@ module ActiveMerchant #:nodoc:
             shipments: {
               receiver_address: {
                 zip_code: address[:zip],
-                street_number: split_street_address(address[:address1]).first,
-                street_name: split_street_address(address[:address1]).last,
-                apartment: address[:address2]
+                street_name: "#{address[:address1]} #{address[:address2]}"
               }
             }
           })
@@ -167,15 +175,12 @@ module ActiveMerchant #:nodoc:
         post[:description] = options[:description]
         post[:installments] = options[:installments] ? options[:installments].to_i : 1
         post[:statement_descriptor] = options[:statement_descriptor] if options[:statement_descriptor]
-        post[:order] = {
-          type: options[:order_type] || "mercadopago",
-          id: options[:order_id] || generate_integer_only_order_id
-        }
+        post[:external_reference] = options[:order_id] || SecureRandom.hex(16)
       end
 
       def add_payment(post, options)
         post[:token] = options[:card_token]
-        post[:payment_method_id] = options[:card_brand] == "american_express" ? "amex" : options[:card_brand]
+        post[:payment_method_id] = options[:card_brand]
       end
 
       def parse(body)
@@ -248,10 +253,6 @@ module ActiveMerchant #:nodoc:
           raise ResponseError.new(response)
         end
       end
-
-      def generate_integer_only_order_id
-        Time.now.to_i + rand(0..1000)
-      end
     end
   end
 end

data/lib/active_merchant/billing/gateways/payu_latam.rb

@@ -118,11 +118,11 @@ module ActiveMerchant #:nodoc:
         add_credentials(post, 'SUBMIT_TRANSACTION')
         add_transaction_elements(post, transaction_type, options)
         add_order(post, options)
-        add_buyer(post, options)
+        add_buyer(post, payment_method, options)
         add_invoice(post, amount, options)
         add_signature(post)
         add_payment_method(post, payment_method, options)
-        add_payer(post, options)
+        add_payer(post, payment_method, options)
         add_extra_parameters(post, options)
       end
 
@@ -138,6 +138,7 @@ module ActiveMerchant #:nodoc:
 
       def add_transaction_elements(post, type, options)
         transaction = {}
+        transaction[:paymentCountry] = options[:payment_country] || (options[:billing_address][:country] if options[:billing_address])
         transaction[:type] = type
         transaction[:ipAddress] = options[:ip] if options[:ip]
         transaction[:userAgent] = options[:user_agent] if options[:user_agent]
@@ -152,28 +153,69 @@ module ActiveMerchant #:nodoc:
         order[:referenceCode] = options[:order_id] || generate_unique_id
         order[:description] = options[:description] || 'unspecified'
         order[:language] = 'en'
+        order[:shippingAddress] = shipping_address_fields(options) if options[:shipping_address]
         post[:transaction][:order] = order
       end
 
-      def add_buyer(post, options)
-        if address = options[:shipping_address]
-          buyer = {}
-          buyer[:fullName] = address[:name]
-          buyer[:dniNumber] = options[:dni_number] if options[:dni_number]
-          buyer[:dniType] = options[:dni_type] if options[:dni_type]
-          buyer[:emailAddress] = options[:email] if options[:email]
-          buyer[:contactPhone] = address[:phone]
-          shipping_address = {}
-          shipping_address[:street1] = address[:address1]
-          shipping_address[:street2] = address[:address2]
-          shipping_address[:city] = address[:city]
-          shipping_address[:state] = address[:state]
-          shipping_address[:country] = address[:country]
-          shipping_address[:postalCode] = address[:zip]
-          shipping_address[:phone] = address[:phone]
-          buyer[:shippingAddress] = shipping_address
-          post[:transaction][:order][:buyer] = buyer
+      def add_payer(post, payment_method, options)
+        address = options[:billing_address]
+        payer = {}
+        payer[:fullName] = payment_method.name.strip
+        payer[:contactPhone] = address[:phone] if (address && address[:phone])
+        payer[:dniNumber] = options[:dni_number] if options[:dni_number]
+        payer[:dniType] = options[:dni_type] if options[:dni_type]
+        payer[:emailAddress] = options[:email] if options[:email]
+        payer[:birthdate] = options[:birth_date] if options[:birth_date] && options[:payment_country] == 'MX'
+        payer[:billingAddress] = billing_address_fields(options)
+        post[:transaction][:payer] = payer
+      end
+
+      def billing_address_fields(options)
+        return unless address = options[:billing_address]
+        billing_address = {}
+        billing_address[:street1] = address[:address1]
+        billing_address[:street2] = address[:address2]
+        billing_address[:city] = address[:city]
+        billing_address[:state] = address[:state]
+        billing_address[:country] = address[:country]
+        billing_address[:postalCode] = address[:zip] if options[:payment_country] == 'MX'
+        billing_address[:phone] = address[:phone]
+        billing_address
+      end
+
+      def add_buyer(post, payment_method, options)
+        buyer = {}
+        if buyer_hash = options[:buyer]
+          buyer[:fullName] = buyer_hash[:name]
+          buyer[:dniNumber] = buyer_hash[:dni_number]
+          buyer[:dniType] = buyer_hash[:dni_type]
+          buyer[:cnpj] = buyer_hash[:cnpj] if options[:payment_country] == 'BR'
+          buyer[:emailAddress] = buyer_hash[:email]
+          buyer[:contactPhone] = options[:shipping_address][:phone] if options[:shipping_address]
+          buyer[:shippingAddress] = shipping_address_fields(options) if options[:shipping_address]
+        else
+          buyer[:fullName] = payment_method.name.strip
+          buyer[:dniNumber] = options[:dni_number]
+          buyer[:dniType] = options[:dni_type]
+          buyer[:cnpj] = options[:cnpj] if options[:payment_country] == 'BR'
+          buyer[:emailAddress] = options[:email]
+          buyer[:contactPhone] = (options[:shipping_address][:phone] if options[:shipping_address]) || (options[:billing_address][:phone] if options[:billing_address])
+          buyer[:shippingAddress] = shipping_address_fields(options) if options[:shipping_address]
         end
+        post[:transaction][:order][:buyer] = buyer
+      end
+
+      def shipping_address_fields(options)
+        return unless address = options[:shipping_address]
+        shipping_address = {}
+        shipping_address[:street1] = address[:address1]
+        shipping_address[:street2] = address[:address2]
+        shipping_address[:city] = address[:city]
+        shipping_address[:state] = address[:state]
+        shipping_address[:country] = address[:country]
+        shipping_address[:postalCode] = address[:zip]
+        shipping_address[:phone] = address[:phone]
+        shipping_address
       end
 
       def add_invoice(post, money, options)
@@ -191,8 +233,8 @@ module ActiveMerchant #:nodoc:
 
         additional_values = {}
         additional_values[:TX_VALUE] = tx_value
-        additional_values[:TX_TAX] = tx_tax
-        additional_values[:TX_TAX_RETURN_BASE] = tx_tax_return_base
+        additional_values[:TX_TAX] = tx_tax if options[:payment_country] == 'CO'
+        additional_values[:TX_TAX_RETURN_BASE] = tx_tax_return_base if options[:payment_country] == 'CO'
 
         post[:transaction][:order][:additionalValues] = additional_values
       end
@@ -246,29 +288,6 @@ module ActiveMerchant #:nodoc:
         false
       end
 
-      def add_payer(post, options)
-        if address = options[:billing_address]
-          payer = {}
-          post[:transaction][:paymentCountry] = address[:country]
-          payer[:fullName] = address[:name]
-          payer[:contactPhone] = address[:phone]
-          payer[:dniNumber] = options[:dni_number] if options[:dni_number]
-          payer[:dniType] = options[:dni_type] if options[:dni_type]
-          payer[:emailAddress] = options[:email] if options[:email]
-          payer[:contactPhone] = address[:phone]
-          billing_address = {}
-          billing_address[:street1] = address[:address1]
-          billing_address[:street2] = address[:address2]
-          billing_address[:city] = address[:city]
-          billing_address[:state] = address[:state]
-          billing_address[:country] = address[:country]
-          billing_address[:postalCode] = address[:zip]
-          billing_address[:phone] = address[:phone]
-          payer[:billingAddress] = billing_address
-          post[:transaction][:payer] = payer
-        end
-      end
-
       def add_extra_parameters(post, options)
         extra_parameters = {}
         extra_parameters[:INSTALLMENTS_NUMBER] = options[:installments_number] || 1
@@ -326,6 +345,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def post_data(params)
+        params.merge(test: test?)
         params.to_json
       end
 

data/lib/active_merchant/billing/gateways/qvalent.rb

@@ -61,6 +61,18 @@ module ActiveMerchant #:nodoc:
         commit("refund", post)
       end
 
+      # Credit requires the merchant account to be enabled for "Adhoc Refunds"
+      def credit(amount, payment_method, options={})
+        post = {}
+        add_invoice(post, amount, options)
+        add_order_number(post, options)
+        add_payment_method(post, payment_method)
+        add_customer_data(post, options)
+        add_soft_descriptors(post, options)
+
+        commit("refund", post)
+      end
+
       def void(authorization, options={})
         post = {}
         add_reference(post, authorization, options)
@@ -136,7 +148,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_customer_data(post, options)
-        post["order.ipAddress"] = options[:ip]
+        post["order.ipAddress"] = options[:ip] || "127.0.0.1"
         post["order.xid"] = options[:xid] if options[:xid]
         post["order.cavv"] = options[:cavv] if options[:cavv]
       end

data/lib/active_merchant/billing/gateways/safe_charge.rb

@@ -13,7 +13,7 @@ module ActiveMerchant #:nodoc:
       self.homepage_url = 'https://www.safecharge.com'
       self.display_name = 'SafeCharge'
 
-      VERSION = '4.0.4'
+      VERSION = '4.1.0'
 
       def initialize(options={})
         requires!(options, :client_login_id, :client_password)
@@ -118,6 +118,8 @@ module ActiveMerchant #:nodoc:
         post[:sg_Version] = VERSION
         post[:sg_ClientUniqueID] = options[:order_id] if options[:order_id]
         post[:sg_UserID] = options[:user_id] if options[:user_id]
+        post[:sg_AuthType] = options[:auth_type] if options[:auth_type]
+        post[:sg_ExpectedFulfillmentCount] = options[:expected_fulfillment_count] if options[:expected_fulfillment_count]
       end
 
       def add_payment(post, payment)

data/lib/active_merchant/billing/gateways/wepay.rb

@@ -10,8 +10,6 @@ module ActiveMerchant #:nodoc:
       self.default_currency = 'USD'
       self.display_name = 'WePay'
 
-      API_VERSION = "2017-02-01"
-
       def initialize(options = {})
         requires!(options, :client_id, :account_id, :access_token)
         super(options)
@@ -78,8 +76,6 @@ module ActiveMerchant #:nodoc:
       end
 
       def store(creditcard, options = {})
-        requires!(options, :email)
-
         post = {}
         post[:client_id] = @options[:client_id]
         post[:user_name] = "#{creditcard.first_name} #{creditcard.last_name}"
@@ -229,19 +225,14 @@ module ActiveMerchant #:nodoc:
         headers = {
           "Content-Type"      => "application/json",
           "User-Agent"        => "ActiveMerchantBindings/#{ActiveMerchant::VERSION}",
-          "Authorization"     => "Bearer #{@options[:access_token]}",
-          "Api-Version"       => api_version(options)
+          "Authorization"     => "Bearer #{@options[:access_token]}"
         }
-
+        headers["Api-Version"] = options[:version] if options[:version]
         headers["Client-IP"] = options[:ip] if options[:ip]
         headers["WePay-Risk-Token"] = options[:risk_token] if options[:risk_token]
 
         headers
       end
-
-      def api_version(options)
-        options[:version] || API_VERSION
-      end
     end
   end
 end

data/lib/active_merchant/version.rb

@@ -1,3 +1,3 @@
 module ActiveMerchant
-  VERSION = "1.71.0"
+  VERSION = "1.72.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activemerchant
 version: !ruby/object:Gem::Version
-  version: 1.71.0
+  version: 1.72.0
 platform: ruby
 authors:
 - Tobias Luetke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-22 00:00:00.000000000 Z
+date: 2017-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport