activemerchant 1.70.0 → 1.71.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9e4551f67805adf4841b97037e5340d2a628864e
-  data.tar.gz: 289a668109a083ee0ee467972dddfd8adc65c5d6
+  metadata.gz: fff082133e880818be78a31b9df09e0c8e03e3a2
+  data.tar.gz: 47044f1c90dc309d2bc1f63fd7de727313c5b6de
 SHA512:
-  metadata.gz: 79a3b02993aecc1c0b0fabc8a0d96901cb40388ee52f2fec05be7d6b6377b956ed60e46f72ab113103d430201ef3402ef94dc33c7022ae0d732e088b2be145a3
-  data.tar.gz: a887ee071f9df0d1e49a5e92fd59576c142ae59a1a16df872c9c380b77ecb5eb6d7933090697564e1eaedd80685e859fd93b74be0344a451bdce297abc54292c
+  metadata.gz: 3e2990e84e388fd93ab8030964ec8b01835c9a133a871b458c49a20ccfaa98280d1a6849f46f5633cf5a4405e8031a32cbd84ad75615c9bb44c93cd0b9c6555a
+  data.tar.gz: 6f255b508c3ff0de4151bd38344c144f0c138166f716f9a262938709f463a24f2711d6f801402dd3600ad61c15c76b5ccc31932a8ef16b0abaa4d7adf3f5b6d6

data/CHANGELOG

@@ -2,6 +2,24 @@
 
 == HEAD
 
+== Version 1.71.0 (August 22, 2017)
+* Bambora formerly Beanstream: Change casing on customerIp variable [aengusbates] #2551
+* Checkout V2: Add localized_amount support to add_invoice function [nicolas-maalouf-cko] #2452
+* Checkout V2: Add UAE to country list [shasum] #2548
+* Checkout V2: Fix success response code validation [nicolas-maalouf-cko] #2452
+* CreditCall: Only allow AVS when specified [curiousepic] #2549
+* CreditCall: Parse additional params from responses [nfarve] #2552
+* CreditCall: Parse more response params [nfavre] #2543
+* MercadoPago: Small tweaks to building requests [davidsantoso] #2555
+* Orbital: Support Network Tokenization Credit Cards [curiousepic] #2553
+* Orbital: Updgrade schema version to 7.1 [curiousepic] #2546
+* Remove HUF from default non-fractional currencies [curiousepic] #2538
+* Stripe: Add support for statement_address parameters for EMV transactions [malcolm-mergulhao] #2524
+* TransFirst Express: Don't send address2 without value [nfarve] #2545
+* TransFirst Express: Fix Optional Fields Being Passed Blank [nfarve] #2550
+* TransFirst: Fix partial refund [nfarve] #2541
+* Vantiv (Litle): Pass 3DS fields [curiousepic] #2536
+
 == Version 1.70.0 (August 4, 2017)
 * Barclaycard Smartpay: Provider a default billing address house number [nfarve] #2520
 * FirstData E4: Fix duplicate XID and CAVV values in tokenized transactions [jasonwebster] #2529
@@ -15,6 +33,9 @@
 * Qvalent: Pass 3dSecure fields [curiousepic] #2508
 * SafeCharge: Correct UserID field name [curiousepic]
 * SafeCharge: Pass UserID field [curiousepic] #2507
+* AuthorizeNet: Allow Response Code 4 to be returned as successful [nfarve] #2530
+* Forte: Remove order number from captures in Forte Gateway [nfarve] #2532
+* PayU Latam: Add additional mandatory fields [deedeelavinder] #2528
 
 == Version 1.69.0 (July 12, 2017)
 * WePay: Add payer_rbits and transaction_rbits optional fields [davidsantoso]

data/lib/active_merchant/billing/gateway.rb

@@ -126,7 +126,7 @@ module ActiveMerchant #:nodoc:
       self.supported_cardtypes = []
 
       class_attribute :currencies_without_fractions, :currencies_with_three_decimal_places
-      self.currencies_without_fractions = %w(BIF BYR CLP CVE DJF GNF HUF ISK JPY KMF KRW PYG RWF UGX VND VUV XAF XOF XPF)
+      self.currencies_without_fractions = %w(BIF BYR CLP CVE DJF GNF ISK JPY KMF KRW PYG RWF UGX VND VUV XAF XOF XPF)
       self.currencies_with_three_decimal_places = %w()
 
       class_attribute :homepage_url

data/lib/active_merchant/billing/gateways/authorize_net.rb

@@ -898,7 +898,7 @@ module ActiveMerchant
         if cim?(action) || (action == :verify_credentials)
           response[:result_code] == "Ok"
         else
-          response[:response_code] == APPROVED && TRANSACTION_ALREADY_ACTIONED.exclude?(response[:response_reason_code])
+          [APPROVED, FRAUD_REVIEW].include?(response[:response_code]) && TRANSACTION_ALREADY_ACTIONED.exclude?(response[:response_reason_code])
         end
       end
 

data/lib/active_merchant/billing/gateways/beanstream/beanstream_core.rb

@@ -186,7 +186,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_customer_ip(post, options)
-        post[:customerIP] = options[:ip] if options[:ip]
+        post[:customerIp] = options[:ip] if options[:ip]
       end
 
       def void_action(original_transaction_type)

data/lib/active_merchant/billing/gateways/checkout_v2.rb

@@ -6,7 +6,7 @@ module ActiveMerchant #:nodoc:
       self.live_url = "https://api2.checkout.com/v2"
       self.test_url = "https://sandbox.checkout.com/api2/v2"
 
-      self.supported_countries = ['AD', 'AT', 'BE', 'BG', 'CH', 'CY', 'CZ', 'DE', 'DK', 'EE', 'ES', 'FO', 'FI', 'FR', 'GB', 'GI', 'GL', 'GR', 'HR', 'HU', 'IE', 'IS', 'IL', 'IT', 'LI', 'LT', 'LU', 'LV', 'MC', 'MT', 'NL', 'NO', 'PL', 'PT', 'RO', 'SE', 'SI', 'SM', 'SK', 'SJ', 'TR', 'VA']
+      self.supported_countries = ['AD', 'AE', 'AT', 'BE', 'BG', 'CH', 'CY', 'CZ', 'DE', 'DK', 'EE', 'ES', 'FO', 'FI', 'FR', 'GB', 'GI', 'GL', 'GR', 'HR', 'HU', 'IE', 'IS', 'IL', 'IT', 'LI', 'LT', 'LU', 'LV', 'MC', 'MT', 'NL', 'NO', 'PL', 'PT', 'RO', 'SE', 'SI', 'SM', 'SK', 'SJ', 'TR', 'VA']
       self.default_currency = "USD"
       self.money_format = :cents
       self.supported_cardtypes = [:visa, :master, :american_express, :diners_club]
@@ -75,7 +75,7 @@ module ActiveMerchant #:nodoc:
       private
 
       def add_invoice(post, money, options)
-        post[:value] = amount(money)
+        post[:value] = localized_amount(money, options[:currency])
         post[:trackId] = options[:order_id]
         post[:currency] = options[:currency] || currency(money)
         post[:descriptor] = {}
@@ -166,7 +166,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def success_from(response)
-        response["responseCode"] == "10000" || response["responseCode"] == "10100"
+        (response["responseCode"] == "10000" && !response["responseMessage"].start_with?("40")) || response["responseCode"] == "10100"
       end
 
       def message_from(succeeded, response)

data/lib/active_merchant/billing/gateways/creditcall.rb

@@ -14,6 +14,32 @@ module ActiveMerchant #:nodoc:
 
       self.homepage_url = 'https://www.creditcall.com'
       self.display_name = 'Creditcall'
+      
+      CVV_CODE = {
+        "matched" => "M",
+        "notmatched" => "N",
+        "notchecked" => "P",
+        "partialmatch" => "N"
+      }
+      
+      AVS_CODE = {
+        "matched;matched" => "D",
+        "matched;notchecked" =>"B",
+        "matched;notmatched" => "A",
+        "matched;partialmatch" => "A",
+        "notchecked;matched" => "P",
+        "notchecked;notchecked" =>"I",
+        "notchecked;notmatched" => "I",
+        "notchecked;partialmatch" => "I",
+        "notmatched;matched" => "W",
+        "notmatched;notchecked" =>"C",
+        "notmatched;notmatched" => "C",
+        "notmatched;partialmatch" => "C",
+        "partialmatched;matched" => "W",
+        "partialmatched;notchecked" =>"C",
+        "partialmatched;notmatched" => "C",
+        "partialmatched;partialmatch" => "C"
+      }
 
       def initialize(options={})
         requires!(options, :terminal_id, :transaction_key)
@@ -26,11 +52,16 @@ module ActiveMerchant #:nodoc:
           r.process { capture(money, r.authorization, options) }
         end
 
+        merged_params = multi_response.responses.map { |r| r.params }.reduce({}, :merge)
+        
         Response.new(
           multi_response.primary_response.success?,
           multi_response.primary_response.message,
-          multi_response.primary_response.params,
+          merged_params,
           authorization: multi_response.responses.first.authorization,
+          avs_result: AVSResult.new(code: avs_result_code_from(merged_params)),
+          cvv_result: CVVResult.new(cvv_result_code_from(merged_params)),
+          error_code: error_result_code_from(merged_params),
           test: test?
         )
       end
@@ -92,6 +123,18 @@ module ActiveMerchant #:nodoc:
 
       private
 
+      def avs_result_code_from(params)
+        AVS_CODE["#{params['Address']};#{params['Zip']}"]
+      end
+
+      def cvv_result_code_from(params)
+        CVV_CODE[params["CSC"]]
+      end
+
+      def error_result_code_from(params)
+        params["ErrorCode"]
+      end
+
       def build_xml_request
         builder = Nokogiri::XML::Builder.new do |xml|
           xml.Request(type: "CardEaseXML", version: "1.0.0") do
@@ -120,17 +163,22 @@ module ActiveMerchant #:nodoc:
 
       def add_card_details(xml, payment_method, options={})
         xml.CardDetails do
-          xml.Manual(type: "ecommerce") do
+          xml.Manual(type: manual_type(options)) do
             xml.PAN payment_method.number
             xml.ExpiryDate exp_date(payment_method)
             xml.CSC payment_method.verification_value unless empty?(payment_method.verification_value)
           end
 
-          if address = options[:billing_address]
-            xml.AdditionalVerification do
-              xml.Address address[:address1]
-              xml.Zip address[:zip]
-            end
+          add_additional_verification(xml, options)
+        end
+      end
+
+      def add_additional_verification(xml, options)
+        return unless (options[:verify_zip].to_s == 'true') || (options[:verify_address].to_s == 'true')
+        if address = options[:billing_address]
+          xml.AdditionalVerification do
+            xml.Zip address[:zip] if options[:verify_zip].to_s  == 'true'
+            xml.Address address[:address1] if options[:verify_address].to_s  == 'true'
           end
         end
       end
@@ -157,6 +205,16 @@ module ActiveMerchant #:nodoc:
           end
         end
 
+        node = xml.xpath("//Response/CardDetails")
+        node.children.each do |childnode|
+          if childnode.elements.empty?
+            response[childnode.name] = childnode.text
+          else
+            childnode_to_response(response, childnode)
+          end
+        end
+
+
         response
       end
 
@@ -179,8 +237,9 @@ module ActiveMerchant #:nodoc:
           message_from(response),
           response,
           authorization: authorization_from(response),
-          avs_result: AVSResult.new(code: response["some_avs_response_key"]),
-          cvv_result: CVVResult.new(response["some_cvv_response_key"]),
+          avs_result: AVSResult.new(code: avs_result_code_from(response)),
+          cvv_result: CVVResult.new(cvv_result_code_from(response)),
+          error_code: error_result_code_from(response),
           test: test?
         )
       end
@@ -205,6 +264,9 @@ module ActiveMerchant #:nodoc:
         response["CardEaseReference"]
       end
 
+      def manual_type(options)
+        options[:manual_type] ? options[:manual_type] : "ecommerce"
+      end
     end
   end
 end

data/lib/active_merchant/billing/gateways/forte.rb

@@ -46,7 +46,6 @@ module ActiveMerchant #:nodoc:
 
       def capture(money, authorization, options={})
         post = {}
-        add_invoice(post, options)
         post[:transaction_id] = transaction_id_from(authorization)
         post[:authorization_code] = authorization_code_from(authorization) || ""
         post[:action] = "capture"

data/lib/active_merchant/billing/gateways/litle.rb

@@ -175,7 +175,7 @@ module ActiveMerchant #:nodoc:
         add_order_source(doc, payment_method, options)
         add_billing_address(doc, payment_method, options)
         add_shipping_address(doc, payment_method, options)
-        add_payment_method(doc, payment_method)
+        add_payment_method(doc, payment_method, options)
         add_pos(doc, payment_method)
         add_descriptor(doc, options)
         add_debt_repayment(doc, options)
@@ -194,7 +194,7 @@ module ActiveMerchant #:nodoc:
         doc.debtRepayment(true) if options[:debt_repayment] == true
       end
 
-      def add_payment_method(doc, payment_method)
+      def add_payment_method(doc, payment_method, options)
         if payment_method.is_a?(String)
           doc.token do
             doc.litleToken(payment_method)
@@ -214,6 +214,11 @@ module ActiveMerchant #:nodoc:
             doc.cardholderAuthentication do
               doc.authenticationValue(payment_method.payment_cryptogram)
             end
+          elsif options[:order_source] && options[:order_source].start_with?('3ds')
+            doc.cardholderAuthentication do
+              doc.authenticationValue(options[:cavv]) if options[:cavv]
+              doc.authenticationTransactionId(options[:xid]) if options[:xid]
+            end
           end
         end
       end

data/lib/active_merchant/billing/gateways/mercado_pago.rb

@@ -91,6 +91,7 @@ module ActiveMerchant #:nodoc:
         add_additional_data(post, options)
         add_customer_data(post, payment, options)
         add_address(post, options)
+        post[:binary_mode] = true
         post
       end
 
@@ -101,12 +102,13 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_additional_data(post, options)
-        post[:sponsor_id] = options["sponsor_id"]
+        post[:sponsor_id] = options[:sponsor_id]
         post[:additional_info] = {
           ip_address: options[:ip_address]
         }
 
         add_address(post, options)
+        add_shipping_address(post, options)
       end
 
       def add_customer_data(post, payment, options)
@@ -119,21 +121,47 @@ module ActiveMerchant #:nodoc:
 
       def add_address(post, options)
         if address = (options[:billing_address] || options[:address])
-          street_number = address[:address1].split(" ").first
-          street_name = address[:address1].split(" ")[1..-1].join(" ")
 
-          post[:additional_info] = {
+          post[:additional_info].merge!({
             payer: {
               address: {
                 zip_code: address[:zip],
-                street_number: street_number,
-                street_name: street_name,
+                street_number: split_street_address(address[:address1]).first,
+                street_name: split_street_address(address[:address1]).last
               }
             }
-          }
+          })
         end
       end
 
+      def add_shipping_address(post, options)
+        if address = options[:shipping_address]
+
+          post[:additional_info].merge!({
+            shipments: {
+              receiver_address: {
+                zip_code: address[:zip],
+                street_number: split_street_address(address[:address1]).first,
+                street_name: split_street_address(address[:address1]).last,
+                apartment: address[:address2]
+              }
+            }
+          })
+        end
+      end
+
+      def split_street_address(address1)
+        street_number = address1.split(" ").first
+
+        if street_name = address1.split(" ")[1..-1]
+          street_name = street_name.join(" ")
+        else
+          nil
+        end
+
+        [street_number, street_name]
+      end
+
       def add_invoice(post, money, options)
         post[:transaction_amount] = amount(money).to_f
         post[:description] = options[:description]
@@ -147,7 +175,7 @@ module ActiveMerchant #:nodoc:
 
       def add_payment(post, options)
         post[:token] = options[:card_token]
-        post[:payment_method_id] = options[:card_brand]
+        post[:payment_method_id] = options[:card_brand] == "american_express" ? "amex" : options[:card_brand]
       end
 
       def parse(body)

data/lib/active_merchant/billing/gateways/orbital.rb

@@ -30,11 +30,11 @@ module ActiveMerchant #:nodoc:
     class OrbitalGateway < Gateway
       include Empty
 
-      API_VERSION = "5.6"
+      API_VERSION = "7.1"
 
       POST_HEADERS = {
         "MIME-Version" => "1.1",
-        "Content-Type" => "application/PTI56",
+        "Content-Type" => "application/PTI#{API_VERSION.gsub(/\./, '')}",
         "Content-transfer-encoding" => "text",
         "Request-number" => '1',
         "Document-type" => "Request",
@@ -191,7 +191,7 @@ module ActiveMerchant #:nodoc:
 
       # A – Authorization request
       def authorize(money, creditcard, options = {})
-        order = build_new_order_xml(AUTH_ONLY, money, options) do |xml|
+        order = build_new_order_xml(AUTH_ONLY, money, creditcard, options) do |xml|
           add_creditcard(xml, creditcard, options[:currency])
           add_address(xml, creditcard, options)
           if @options[:customer_profiles]
@@ -211,7 +211,7 @@ module ActiveMerchant #:nodoc:
 
       # AC – Authorization and Capture
       def purchase(money, creditcard, options = {})
-        order = build_new_order_xml(AUTH_AND_CAPTURE, money, options) do |xml|
+        order = build_new_order_xml(AUTH_AND_CAPTURE, money, creditcard, options) do |xml|
           add_creditcard(xml, creditcard, options[:currency])
           add_address(xml, creditcard, options)
           if @options[:customer_profiles]
@@ -229,7 +229,7 @@ module ActiveMerchant #:nodoc:
 
       # R – Refund request
       def refund(money, authorization, options = {})
-        order = build_new_order_xml(REFUND, money, options.merge(:authorization => authorization)) do |xml|
+        order = build_new_order_xml(REFUND, money, nil, options.merge(:authorization => authorization)) do |xml|
           add_refund(xml, options[:currency])
           xml.tag! :CustomerRefNum, options[:customer_ref_num] if @options[:customer_profiles] && options[:profile_txn]
         end
@@ -463,6 +463,16 @@ module ActiveMerchant #:nodoc:
         end
       end
 
+      def add_cdpt_eci_and_xid(xml, creditcard)
+        xml.tag! :AuthenticationECIInd, creditcard.eci
+        xml.tag! :XID, creditcard.transaction_id if creditcard.transaction_id
+      end
+
+      def add_cdpt_payment_cryptogram(xml, creditcard)
+        xml.tag! :DPANInd, 'Y'
+        xml.tag! :DigitalTokenCryptogram, creditcard.payment_cryptogram
+      end
+
       def add_refund(xml, currency=nil)
         xml.tag! :AccountNum, nil
 
@@ -566,7 +576,7 @@ module ActiveMerchant #:nodoc:
         @options[:ip_authentication] == true
       end
 
-      def build_new_order_xml(action, money, parameters = {})
+      def build_new_order_xml(action, money, creditcard, parameters = {})
         requires!(parameters, :order_id)
         xml = xml_envelope
         xml.tag! :Request do
@@ -589,6 +599,10 @@ module ActiveMerchant #:nodoc:
 
             yield xml if block_given?
 
+            if creditcard.is_a?(NetworkTokenizationCreditCard)
+              add_cdpt_eci_and_xid(xml, creditcard)
+            end
+
             xml.tag! :OrderID, format_order_id(parameters[:order_id])
             xml.tag! :Amount, amount(money)
             xml.tag! :Comments, parameters[:comments] if parameters[:comments]
@@ -598,6 +612,10 @@ module ActiveMerchant #:nodoc:
 
             # CustomerAni, AVSPhoneType and AVSDestPhoneType could be added here.
 
+            if creditcard.is_a?(NetworkTokenizationCreditCard)
+              add_cdpt_payment_cryptogram(xml, creditcard)
+            end
+
             if parameters[:soft_descriptors].is_a?(OrbitalSoftDescriptors)
               add_soft_descriptors(xml, parameters[:soft_descriptors])
             elsif parameters[:soft_descriptors].is_a?(Hash)

data/lib/active_merchant/billing/gateways/payu_latam.rb

@@ -49,7 +49,7 @@ module ActiveMerchant #:nodoc:
         post = {}
 
         add_credentials(post, 'SUBMIT_TRANSACTION')
-        add_transaction_type(post, 'CAPTURE')
+        add_transaction_elements(post, 'CAPTURE', options)
         add_reference(post, authorization)
 
         commit('capture', post)
@@ -59,7 +59,7 @@ module ActiveMerchant #:nodoc:
         post = {}
 
         add_credentials(post, 'SUBMIT_TRANSACTION')
-        add_transaction_type(post, 'VOID')
+        add_transaction_elements(post, 'VOID', options)
         add_reference(post, authorization)
 
         commit('void', post)
@@ -69,7 +69,7 @@ module ActiveMerchant #:nodoc:
         post = {}
 
         add_credentials(post, 'SUBMIT_TRANSACTION')
-        add_transaction_type(post, 'REFUND')
+        add_transaction_elements(post, 'REFUND', options)
         add_reference(post, authorization)
 
         commit('refund', post)
@@ -116,7 +116,7 @@ module ActiveMerchant #:nodoc:
 
       def auth_or_sale(post, transaction_type, amount, payment_method, options)
         add_credentials(post, 'SUBMIT_TRANSACTION')
-        add_transaction_type(post, transaction_type)
+        add_transaction_elements(post, transaction_type, options)
         add_order(post, options)
         add_buyer(post, options)
         add_invoice(post, amount, options)
@@ -136,9 +136,13 @@ module ActiveMerchant #:nodoc:
         post[:merchant] = merchant
       end
 
-      def add_transaction_type(post, type)
+      def add_transaction_elements(post, type, options)
         transaction = {}
         transaction[:type] = type
+        transaction[:ipAddress] = options[:ip] if options[:ip]
+        transaction[:userAgent] = options[:user_agent] if options[:user_agent]
+        transaction[:cookie] = options[:cookie] if options[:cookie]
+        transaction[:deviceSessionId] = options[:device_session_id] if options[:device_session_id]
         post[:transaction] = transaction
       end
 
@@ -155,7 +159,10 @@ module ActiveMerchant #:nodoc:
         if address = options[:shipping_address]
           buyer = {}
           buyer[:fullName] = address[:name]
-          buyer[:dniNumber] = options[:dni_number]
+          buyer[:dniNumber] = options[:dni_number] if options[:dni_number]
+          buyer[:dniType] = options[:dni_type] if options[:dni_type]
+          buyer[:emailAddress] = options[:email] if options[:email]
+          buyer[:contactPhone] = address[:phone]
           shipping_address = {}
           shipping_address[:street1] = address[:address1]
           shipping_address[:street2] = address[:address2]
@@ -174,8 +181,18 @@ module ActiveMerchant #:nodoc:
         tx_value[:value] = amount(money)
         tx_value[:currency] = options[:currency] || currency(money)
 
+        tx_tax = {}
+        tx_tax[:value] = options[:tax] || '0'
+        tx_tax[:currency] = options[:currency] || currency(money)
+
+        tx_tax_return_base = {}
+        tx_tax_return_base[:value] = options[:tax_return_base] || '0'
+        tx_tax_return_base[:currency] = options[:currency] || currency(money)
+
         additional_values = {}
         additional_values[:TX_VALUE] = tx_value
+        additional_values[:TX_TAX] = tx_tax
+        additional_values[:TX_TAX_RETURN_BASE] = tx_tax_return_base
 
         post[:transaction][:order][:additionalValues] = additional_values
       end
@@ -235,7 +252,10 @@ module ActiveMerchant #:nodoc:
           post[:transaction][:paymentCountry] = address[:country]
           payer[:fullName] = address[:name]
           payer[:contactPhone] = address[:phone]
-          payer[:dniNumber] = options[:dni_number]
+          payer[:dniNumber] = options[:dni_number] if options[:dni_number]
+          payer[:dniType] = options[:dni_type] if options[:dni_type]
+          payer[:emailAddress] = options[:email] if options[:email]
+          payer[:contactPhone] = address[:phone]
           billing_address = {}
           billing_address[:street1] = address[:address1]
           billing_address[:street2] = address[:address2]

data/lib/active_merchant/billing/gateways/stripe.rb

@@ -303,7 +303,9 @@ module ActiveMerchant #:nodoc:
           add_creditcard(post, payment, options)
         end
 
-        unless emv_payment?(payment)
+        if emv_payment?(payment)
+          add_statement_address(post, options)
+        else
           add_amount(post, money, options, true)
           add_customer_data(post, options)
           post[:description] = options[:description]
@@ -365,6 +367,18 @@ module ActiveMerchant #:nodoc:
         end
       end
 
+      def add_statement_address(post, options)
+        return unless statement_address = options[:statement_address]
+        return unless [:address1, :city, :zip, :state].all? { |key| statement_address[key].present? } 
+
+        post[:statement_address] = {}
+        post[:statement_address][:line1] = statement_address[:address1]
+        post[:statement_address][:line2] = statement_address[:address2] if statement_address[:address2].present?
+        post[:statement_address][:city] = statement_address[:city]
+        post[:statement_address][:postal_code] = statement_address[:zip]
+        post[:statement_address][:state] = statement_address[:state]
+      end
+
       def add_creditcard(post, creditcard, options)
         card = {}
         if emv_payment?(creditcard)

data/lib/active_merchant/billing/gateways/trans_first.rb

@@ -1,4 +1,5 @@
 module ActiveMerchant #:nodoc:
+
   module Billing #:nodoc:
     class TransFirstGateway < Gateway
       self.test_url = 'https://ws.cert.transfirst.com'
@@ -16,7 +17,7 @@ module ActiveMerchant #:nodoc:
       ACTIONS = {
         purchase: "CCSale",
         purchase_echeck: "ACHDebit",
-        refund: "CreditCardAutoRefundorVoid",
+        refund: "CreditCardCredit",
         refund_echeck: "ACHVoidTransaction",
         void: "CreditCardAutoRefundorVoid",
       }
@@ -52,6 +53,7 @@ module ActiveMerchant #:nodoc:
         transaction_id, payment_type = split_authorization(authorization)
         add_amount(post, money)
         add_pair(post, :TransID, transaction_id)
+        add_pair(post, :RefID, options[:order_id], required: true)
 
         commit((payment_type == "check" ? :refund_echeck : :refund), post)
       end
@@ -169,7 +171,6 @@ module ActiveMerchant #:nodoc:
 
       def commit(action, params)
         response = parse(ssl_post(url(action), post_data(action, params)))
-
         Response.new(
           success_from(response),
           message_from(response),

data/lib/active_merchant/billing/gateways/trans_first_transaction_express.rb

@@ -537,15 +537,17 @@ module ActiveMerchant #:nodoc:
           doc["v1"].title options[:title] if options[:title]
 
           if (billing_address = options[:billing_address])
-            doc["v1"].phone do
-              doc["v1"].type (options[:phone_number_type] || "4")
-              doc["v1"].nr billing_address[:phone].gsub(/\D/, '') if billing_address[:phone]
+            if billing_address[:phone]
+              doc["v1"].phone do
+                doc["v1"].type (options[:phone_number_type] || "4")
+                doc["v1"].nr billing_address[:phone].gsub(/\D/, '')
+              end
             end
-            doc["v1"].addrLn1 billing_address[:address1]
-            doc["v1"].addrLn2 billing_address[:address2]
-            doc["v1"].city billing_address[:city]
-            doc["v1"].state billing_address[:state]
-            doc["v1"].zipCode billing_address[:zip]
+            doc["v1"].addrLn1 billing_address[:address1] if billing_address[:address1]
+            doc["v1"].addrLn2 billing_address[:address2] if billing_address[:address2]
+            doc["v1"].city billing_address[:city] if billing_address[:city]
+            doc["v1"].state billing_address[:state] if billing_address[:state]
+            doc["v1"].zipCode billing_address[:zip] if billing_address[:zip]
             doc["v1"].ctry "US"
           end
 
@@ -556,11 +558,11 @@ module ActiveMerchant #:nodoc:
           if (shipping_address = options[:shipping_address])
             doc["v1"].ship do
               doc["v1"].fullName fullname
-              doc["v1"].addrLn1 shipping_address[:address1]
+              doc["v1"].addrLn1 shipping_address[:address1] if shipping_address[:address1]
               doc["v1"].addrLn2 shipping_address[:address2] if shipping_address[:address2]
-              doc["v1"].city shipping_address[:city]
-              doc["v1"].state shipping_address[:state]
-              doc["v1"].zipCode shipping_address[:zip]
+              doc["v1"].city shipping_address[:city] if shipping_address[:city]
+              doc["v1"].state shipping_address[:state] if shipping_address[:state]
+              doc["v1"].zipCode shipping_address[:zip] if shipping_address[:zip]
               doc["v1"].phone shipping_address[:phone].gsub(/\D/, '') if shipping_address[:phone]
               doc["v1"].email shipping_address[:email] if shipping_address[:email]
             end

data/lib/active_merchant/version.rb

@@ -1,3 +1,3 @@
 module ActiveMerchant
-  VERSION = "1.70.0"
+  VERSION = "1.71.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activemerchant
 version: !ruby/object:Gem::Version
-  version: 1.70.0
+  version: 1.71.0
 platform: ruby
 authors:
 - Tobias Luetke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-07 00:00:00.000000000 Z
+date: 2017-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport