activemerchant 1.38.0 → 1.38.1

data/CHANGELOG

@@ -1,5 +1,9 @@
 = ActiveMerchant CHANGELOG
 
+== Version 1.38.1 (September 16, 2013)
+
+* Moneris: Remove verification_value support [melari]
+
 == Version 1.38.0 (September 6, 2013)
 
 * FirstData E4: Include missing address information for AVS and CVV [melari]
@@ -20,6 +24,7 @@
 * MerchantWarrior: Send the CVV to the gateway [duff]
 * PayU: Fix a major bug with status types [melari]
 * SecureNet: Allow production transactions [duff]
+* Stripe: Allow a card_not_present_fee to be specified [melari]
 
 == Version 1.36.0 (August 2, 2013)
 

data/lib/active_merchant/billing/gateways/moneris.rb

@@ -128,7 +128,6 @@ module ActiveMerchant #:nodoc:
         else
           post[:pan]        = source.number
           post[:expdate]    = expdate(source)
-          post[:cvd_value]  = source.verification_value if source.verification_value?
         end
       end
 
@@ -156,7 +155,6 @@ module ActiveMerchant #:nodoc:
 
         Response.new(successful?(response), message_from(response[:message]), response,
           :test          => test?,
-          :cvv_result    => response[:cvd_result_code].try(:last),
           :authorization => authorization_from(response)
         )
       end
@@ -194,35 +192,14 @@ module ActiveMerchant #:nodoc:
         root  = xml.add_element("request")
         root.add_element("store_id").text  = options[:login]
         root.add_element("api_token").text = options[:password]
-        root.add_element(transaction_element(action, parameters))
-
-        xml.to_s
-      end
-
-      def transaction_element(action, parameters)
-        transaction = REXML::Element.new(action)
+        transaction = root.add_element(action)
 
         # Must add the elements in the correct order
         actions[action].each do |key|
-          if key == :cvd_info
-            transaction.add_element(cvd_element(parameters[:cvd_value]))
-          else
-            transaction.add_element(key.to_s).text = parameters[key] unless parameters[key].blank?
-          end
+          transaction.add_element(key.to_s).text = parameters[key] unless parameters[key].blank?
         end
 
-        transaction
-      end
-
-      def cvd_element(cvd_value)
-        element = REXML::Element.new('cvd_info')
-        if cvd_value
-          element.add_element('cvd_indicator').text = "1"
-          element.add_element('cvd_value').text = cvd_value
-        else
-          element.add_element('cvd_indicator').text = "0"
-        end
-        element
+        xml.to_s
       end
 
       def message_from(message)
@@ -242,8 +219,8 @@ module ActiveMerchant #:nodoc:
 
       def actions
         {
-          "purchase"           => [:order_id, :cust_id, :amount, :pan, :expdate, :crypt_type, :cvd_info],
-          "preauth"            => [:order_id, :cust_id, :amount, :pan, :expdate, :crypt_type, :cvd_info],
+          "purchase"           => [:order_id, :cust_id, :amount, :pan, :expdate, :crypt_type],
+          "preauth"            => [:order_id, :cust_id, :amount, :pan, :expdate, :crypt_type],
           "command"            => [:order_id],
           "refund"             => [:order_id, :amount, :txn_number, :crypt_type],
           "indrefund"          => [:order_id, :cust_id, :amount, :pan, :expdate, :crypt_type],

data/lib/active_merchant/billing/integrations/ipay88/helper.rb

@@ -47,11 +47,11 @@ module ActiveMerchant #:nodoc:
           end
 
           def amount=(money)
-            cents = money.respond_to?(:cents) ? money.cents : money
-            if money.is_a?(String) or cents.to_i < 0
+            @amount_in_cents = money.respond_to?(:cents) ? money.cents : money
+            if money.is_a?(String) or @amount_in_cents.to_i < 0
               raise ArgumentError, "money amount must be either a Money object or a positive integer in cents."
             end
-            add_field mappings[:amount], sprintf("%.2f", cents.to_f/100)
+            add_field mappings[:amount], sprintf("%.2f", @amount_in_cents.to_f/100)
           end
 
           def currency(symbol)
@@ -103,7 +103,7 @@ module ActiveMerchant #:nodoc:
             components  = [merchant_key]
             components << fields[mappings[:account]]
             components << fields[mappings[:order]]
-            components << amount_in_cents
+            components << amount_in_cents.to_s.gsub(/[.,]/, '')
             components << fields[mappings[:currency]]
             components.join
           end

data/lib/active_merchant/version.rb

@@ -1,3 +1,3 @@
 module ActiveMerchant
-  VERSION = "1.38.0"
+  VERSION = "1.38.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activemerchant
 version: !ruby/object:Gem::Version
-  version: 1.38.0
+  version: 1.38.1
   prerelease: 
 platform: ruby
 authors:
@@ -37,7 +37,7 @@ cert_chain:
   Z1BvU1BxN25rK3MyRlFVQko5VVpGSzFsZ016aG8vNGZaZ3pKd2J1K2NPOFNO
   dWFMUy9iagpoUGFTVHlWVTB5Q1Nudz09Ci0tLS0tRU5EIENFUlRJRklDQVRF
   LS0tLS0K
-date: 2013-09-06 00:00:00.000000000 Z
+date: 2013-09-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport