activemerchant 1.104.0 → 1.105.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e9ceb4b2da9006abdfcab980341c407f7b718ae35a424fc1e597c3cf2b189271
-  data.tar.gz: 19fe8973c00605d460cd56bcc8d0148cfa8ad7af9a33d07c9f2759da56dc5684
+  metadata.gz: ecb10bc188ad1b7d0286f0122d7c3643ba8c8b83aa2b3903ba2f582b1f43cad4
+  data.tar.gz: 5e28f570774addd9001a555b861757b0bf41aecdaa8c918d3f2926e32d41a7a8
 SHA512:
-  metadata.gz: 94d123473e989145c5d9a34294718cc8913d231c72b415bd0398e88cfefdc81b1cd9070eaf14648be6c723de201785920de8479b8ef997454df194cfaa4f7734
-  data.tar.gz: 9567e118dd21f0779d5a8bd228ab385f2378c338f838fe027ed6ad6a245a86362fd786d91aa53cbaa65b31d3817efdc8ca299ff84f44f182140ff43018cd6f7c
+  metadata.gz: da6fcbbd82d25fc8563ee47ec292d2fe276b445fdfe0b1194fdff5c9dddd8c091774f9abb95427721891bac3646e60d6018c2cbf50895c41c1a7aff772792d9b
+  data.tar.gz: d312d2bbdf0dc874a72519e8d4784c52bf0e663328ac4404ff6a1f92bdea1a9e9a50a0ae9732909275c4a177afce05370474cdef3fc0b02c5aa91ca0096164ff

data/CHANGELOG

@@ -1,6 +1,25 @@
 = ActiveMerchant CHANGELOG
 
-== HEAD
+== Version 1.105.0 (Feb 20, 2020)
+* Credorax: Fix `3ds_transtype` setting in post [chinhle23] #3531
+* Bambora Apac: Send void amount in options [leila-alderman] #3532
+* RuboCop: Fix Layout/IndentHash [leila-alderman] #3529
+* Stripe: Add connected account support [Carrigan] #3535
+* Redsys: Update scrub method to account for 3DS error responses [britth] #3534
+* Authorize.Net: Pass `account_type` to `check` payment types [chinhle23] #3530
+* Merchant Warrior: Send void amount in options [leila-alderman] #3525
+* Stripe: Add support for `statement_descriptor_suffix` field [Carrigan] #3528
+* Decidir: Add support for fraud_detection, site_id, and establishment_name [fatcatt316] #3527
+* HPS: support eCheck [therufs] #3500
+* EBANX: Add metadata information in post [miguelxpn] #3522
+* Paypal: Fix OrderTotal elements in `add_payment_details` [chinhle23] #3517
+* Worldpay: Add `riskData` GSF [fatcatt316] #3514
+* EBANX: Fix `scrub` [chinhle23] #3521
+* Worldpay: Remove unnecessary .tag! methods [leila-alderman] #3519
+* BPoint: Remove amount from void requests [leila-alderman] #3518
+* Authorize.net: Trim supported countries to AU, CA, US [fatcatt316] #3516
+* Credorax: Allow optional 3DS 2 fields [jeremywrowe] #3515
+* Stripe: Remove outdated 'customer options' deprecation [alexdunae] #3401
 
 == Version 1.104.0 (Jan 29, 2020)
 * Adyen: add `recurring_contract_type` GSF [therufs] #3460
@@ -41,6 +60,8 @@
 * Mercado Pago: Add taxes and net_amount gateway specific fields [carrigan] #3512
 * Moneris: use dedicated card_verification methods [alexdunae] #3428
 * Authorize.net: Trim down supported countries [fatcatt316] #3511
+* Stripe: Add support for `statement_descriptor_suffix` field [carrigan] #3528
+* Stripe: Add connected account support [carrigan] #3535
 
 == Version 1.103.0 (Dec 2, 2019)
 * Quickbooks: Mark transactions that returned `AuthorizationFailed` as failures [britth] #3447

data/README.md

@@ -92,7 +92,7 @@ guide and [Standardized 3DS Fields](https://github.com/activemerchant/active_mer
 The [ActiveMerchant Wiki](https://github.com/activemerchant/active_merchant/wikis) contains a [table of features supported by each gateway](https://github.com/activemerchant/active_merchant/wiki/Gateway-Feature-Matrix).
 
 * [Authorize.Net CIM](http://www.authorize.net/) - US
-* [Authorize.Net](http://www.authorize.net/) - AD, AT, AU, BE, BG, CA, CH, CY, CZ, DE, DK, ES, FI, FR, GB, GB, GI, GR, HU, IE, IT, LI, LU, MC, MT, NL, NO, PL, PT, RO, SE, SI, SK, SM, TR, US, VA
+* [Authorize.Net](http://www.authorize.net/) - AU, CA, US
 * [Axcess MS](http://www.axcessms.com/) - AD, AT, BE, BG, BR, CA, CH, CY, CZ, DE, DK, EE, ES, FI, FO, FR, GB, GI, GR, HR, HU, IE, IL, IM, IS, IT, LI, LT, LU, LV, MC, MT, MX, NL, NO, PL, PT, RO, RU, SE, SI, SK, TR, US, VA
 * [Balanced](https://www.balancedpayments.com/) - US
 * [Bambora Asia-Pacific](http://www.bambora.com/) - AU, NZ

data/lib/active_merchant/billing/gateways/authorize_net.rb

@@ -85,8 +85,8 @@ module ActiveMerchant
       AVS_REASON_CODES = %w(27 45)
 
       TRACKS = {
-          1 => /^%(?<format_code>.)(?<pan>[\d]{1,19}+)\^(?<name>.{2,26})\^(?<expiration>[\d]{0,4}|\^)(?<service_code>[\d]{0,3}|\^)(?<discretionary_data>.*)\?\Z/,
-          2 => /\A;(?<pan>[\d]{1,19}+)=(?<expiration>[\d]{0,4}|=)(?<service_code>[\d]{0,3}|=)(?<discretionary_data>.*)\?\Z/
+        1 => /^%(?<format_code>.)(?<pan>[\d]{1,19}+)\^(?<name>.{2,26})\^(?<expiration>[\d]{0,4}|\^)(?<service_code>[\d]{0,3}|\^)(?<discretionary_data>.*)\?\Z/,
+        2 => /\A;(?<pan>[\d]{1,19}+)=(?<expiration>[\d]{0,4}|=)(?<service_code>[\d]{0,3}|=)(?<discretionary_data>.*)\?\Z/
       }.freeze
 
       APPLE_PAY_DATA_DESCRIPTOR = 'COMMON.APPLE.INAPP.PAYMENT'
@@ -544,6 +544,7 @@ module ActiveMerchant
       def add_check(xml, check)
         xml.payment do
           xml.bankAccount do
+            xml.accountType(check.account_type)
             xml.routingNumber(check.routing_number)
             xml.accountNumber(check.account_number)
             xml.nameOnAccount(truncate(check.name, 22))

data/lib/active_merchant/billing/gateways/balanced.rb

@@ -251,10 +251,10 @@ module ActiveMerchant #:nodoc:
         )
 
         {
-            'Authorization' => 'Basic ' + Base64.encode64(@options[:login].to_s + ':').strip,
-            'User-Agent' => "Balanced/v1.1 ActiveMerchantBindings/#{ActiveMerchant::VERSION}",
-            'Accept' => 'application/vnd.api+json;revision=1.1',
-            'X-Balanced-User-Agent' => @@ua,
+          'Authorization' => 'Basic ' + Base64.encode64(@options[:login].to_s + ':').strip,
+          'User-Agent' => "Balanced/v1.1 ActiveMerchantBindings/#{ActiveMerchant::VERSION}",
+          'Accept' => 'application/vnd.api+json;revision=1.1',
+          'X-Balanced-User-Agent' => @@ua,
         }
       end
     end

data/lib/active_merchant/billing/gateways/bambora_apac.rb

@@ -30,7 +30,7 @@ module ActiveMerchant #:nodoc:
         commit('SubmitSinglePayment') do |xml|
           xml.Transaction do
             xml.CustRef options[:order_id]
-            add_amount(xml, money)
+            xml.Amount amount(money)
             xml.TrnType '1'
             add_payment(xml, payment)
             add_credentials(xml, options)
@@ -43,7 +43,7 @@ module ActiveMerchant #:nodoc:
         commit('SubmitSinglePayment') do |xml|
           xml.Transaction do
             xml.CustRef options[:order_id]
-            add_amount(xml, money)
+            xml.Amount amount(money)
             xml.TrnType '2'
             add_payment(xml, payment)
             add_credentials(xml, options)
@@ -56,7 +56,7 @@ module ActiveMerchant #:nodoc:
         commit('SubmitSingleCapture') do |xml|
           xml.Capture do
             xml.Receipt authorization
-            add_amount(xml, money)
+            xml.Amount amount(money)
             add_credentials(xml, options)
           end
         end
@@ -66,17 +66,17 @@ module ActiveMerchant #:nodoc:
         commit('SubmitSingleRefund') do |xml|
           xml.Refund do
             xml.Receipt authorization
-            add_amount(xml, money)
+            xml.Amount amount(money)
             add_credentials(xml, options)
           end
         end
       end
 
-      def void(money, authorization, options={})
+      def void(authorization, options={})
         commit('SubmitSingleVoid') do |xml|
           xml.Void do
             xml.Receipt authorization
-            add_amount(xml, money)
+            xml.Amount amount(options[:amount])
             add_credentials(xml, options)
           end
         end
@@ -116,10 +116,6 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def add_amount(xml, money)
-        xml.Amount amount(money)
-      end
-
       def add_payment(xml, payment)
         if payment.is_a?(String)
           add_token(xml, payment)

data/lib/active_merchant/billing/gateways/bpoint.rb

@@ -61,10 +61,10 @@ module ActiveMerchant #:nodoc:
         commit(request_body)
       end
 
-      def void(amount, authorization, options={})
+      def void(authorization, options={})
         request_body = soap_request do |xml|
           process_payment(xml) do |payment_xml|
-            add_void(payment_xml, amount, authorization, options)
+            add_void(payment_xml, authorization, options)
           end
         end
         commit(request_body)
@@ -73,7 +73,7 @@ module ActiveMerchant #:nodoc:
       def verify(credit_card, options={})
         MultiResponse.run(:use_first_response) do |r|
           r.process { authorize(100, credit_card, options) }
-          r.process(:ignore_result) { void(100, r.authorization, options) }
+          r.process(:ignore_result) { void(r.authorization, options.merge(amount: 100)) }
         end
       end
 
@@ -154,7 +154,9 @@ module ActiveMerchant #:nodoc:
         transaction_number_xml(xml, transaction_number)
       end
 
-      def add_void(xml, amount, transaction_number, options)
+      def add_void(xml, transaction_number, options)
+        # The amount parameter is required for void requests on BPoint.
+        amount = options[:amount]
         payment_xml(xml, 'REVERSAL', amount, options)
         transaction_number_xml(xml, transaction_number)
       end

data/lib/active_merchant/billing/gateways/credorax.rb

@@ -132,6 +132,7 @@ module ActiveMerchant #:nodoc:
         add_customer_data(post, options)
         add_email(post, options)
         add_3d_secure(post, options)
+        add_3ds_2_optional_fields(post, options)
         add_echo(post, options)
         add_submerchant_id(post, options)
         add_stored_credential(post, options)
@@ -147,6 +148,7 @@ module ActiveMerchant #:nodoc:
         add_customer_data(post, options)
         add_email(post, options)
         add_3d_secure(post, options)
+        add_3ds_2_optional_fields(post, options)
         add_echo(post, options)
         add_submerchant_id(post, options)
         add_stored_credential(post, options)
@@ -228,6 +230,21 @@ module ActiveMerchant #:nodoc:
           gsub(%r((b5=)\d+), '\1[FILTERED]')
       end
 
+      def add_3ds_2_optional_fields(post, options)
+        three_ds = options[:three_ds_2] || {}
+
+        if three_ds.has_key?(:optional)
+          three_ds[:optional].each do |key, value|
+            normalized_value = normalize(value)
+            next if normalized_value.nil?
+
+            post[key] = normalized_value unless post[key]
+          end
+        end
+
+        post
+      end
+
       private
 
       def add_invoice(post, money, options)
@@ -308,7 +325,7 @@ module ActiveMerchant #:nodoc:
           post[:'3ds_redirect_url'] = three_ds_2_options[:notification_url]
           post[:'3ds_challengewindowsize'] = options[:three_ds_challenge_window_size] || '03'
           post[:d5] = browser_info[:user_agent]
-          post[:'3ds_transtype'] = options[:transaction_type] || '01'
+          post[:'3ds_transtype'] = options[:three_ds_transtype] || '01'
           post[:'3ds_browsertz'] = browser_info[:timezone]
           post[:'3ds_browserscreenwidth'] = browser_info[:width]
           post[:'3ds_browserscreenheight'] = browser_info[:height]
@@ -405,8 +422,10 @@ module ActiveMerchant #:nodoc:
 
       def sign_request(params)
         params = params.sort
-        params.each { |param| param[1].gsub!(/[<>()\\]/, ' ') }
-        values = params.map { |param| param[1].strip }
+        values = params.map do |param|
+          value = param[1].gsub(/[<>()\\]/, ' ')
+          value.strip
+        end
         Digest::MD5.hexdigest(values.join + @options[:cipher_key])
       end
 

data/lib/active_merchant/billing/gateways/decidir.rb

@@ -7,7 +7,7 @@ module ActiveMerchant #:nodoc:
       self.supported_countries = ['AR']
       self.money_format = :cents
       self.default_currency = 'ARS'
-      self.supported_cardtypes = [:visa, :master, :american_express, :diners_club, :naranja, :cabal]
+      self.supported_cardtypes = %i[visa master american_express diners_club naranja cabal]
 
       self.homepage_url = 'http://www.decidir.com'
       self.display_name = 'Decidir'
@@ -113,6 +113,9 @@ module ActiveMerchant #:nodoc:
         post[:installments] = options[:installments] ? options[:installments].to_i : 1
         post[:description] = options[:description] if options[:description]
         post[:email] = options[:email] if options[:email]
+        post[:establishment_name] = options[:establishment_name] if options[:establishment_name]
+        post[:fraud_detection] = add_fraud_detection(options[:fraud_detection]) if options[:fraud_detection].present?
+        post[:site_id] = options[:site_id] if options[:site_id]
         post[:sub_payments] = []
 
         add_invoice(post, money, options)
@@ -176,6 +179,19 @@ module ActiveMerchant #:nodoc:
         post[:card_data] = card_data
       end
 
+      def add_fraud_detection(options = {})
+        {}.tap do |hsh|
+          hsh[:send_to_cs] = options[:send_to_cs] if valid_fraud_detection_option?(options[:send_to_cs]) # true/false
+          hsh[:channel] = options[:channel] if valid_fraud_detection_option?(options[:channel])
+          hsh[:dispatch_method] = options[:dispatch_method] if valid_fraud_detection_option?(options[:dispatch_method])
+        end
+      end
+
+      # Avoid sending fields with empty or null when not populated.
+      def valid_fraud_detection_option?(val)
+        !val.nil? && val != ''
+      end
+
       def headers(options = {})
         {
           'apikey' => @options[:api_key],

data/lib/active_merchant/billing/gateways/ebanx.rb

@@ -120,7 +120,7 @@ module ActiveMerchant #:nodoc:
 
       def scrub(transcript)
         transcript.
-          gsub(/(integration_key\\?":\\?")(\d*)/, '\1[FILTERED]').
+          gsub(/(integration_key\\?":\\?")(\w*)/, '\1[FILTERED]').
           gsub(/(card_number\\?":\\?")(\d*)/, '\1[FILTERED]').
           gsub(/(card_cvv\\?":\\?")(\d*)/, '\1[FILTERED]')
       end
@@ -201,6 +201,7 @@ module ActiveMerchant #:nodoc:
 
       def add_additional_data(post, options)
         post[:device_id] = options[:device_id] if options[:device_id]
+        post[:metadata] = options[:metadata] if options[:metadata]
       end
 
       def parse(body)
@@ -209,7 +210,7 @@ module ActiveMerchant #:nodoc:
 
       def commit(action, parameters)
         url = url_for((test? ? test_url : live_url), action, parameters)
-        response = parse(ssl_request(HTTP_METHOD[action], url, post_data(action, parameters), {}))
+        response = parse(ssl_request(HTTP_METHOD[action], url, post_data(action, parameters), {'x-ebanx-client-user-agent': "ActiveMerchant/#{ActiveMerchant::VERSION}"}))
 
         success = success_from(action, response)
 

data/lib/active_merchant/billing/gateways/efsnet.rb

@@ -201,15 +201,15 @@ module ActiveMerchant #:nodoc:
       CREDIT_CARD_FIELDS = %w(AuthorizationNumber ClientIpAddress BillingAddress BillingCity BillingState BillingPostalCode BillingCountry BillingName CardVerificationValue ExpirationMonth ExpirationYear ReferenceNumber TransactionAmount AccountNumber)
 
       ACTIONS = {
-           :credit_card_authorize       => CREDIT_CARD_FIELDS,
-           :credit_card_charge          => CREDIT_CARD_FIELDS,
-           :credit_card_voice_authorize => CREDIT_CARD_FIELDS,
-           :credit_card_capture         => CREDIT_CARD_FIELDS,
-           :credit_card_credit          => CREDIT_CARD_FIELDS + ['OriginalTransactionAmount'],
-           :credit_card_refund          => %w(ReferenceNumber TransactionAmount OriginalTransactionAmount OriginalTransactionID ClientIpAddress),
-           :void_transaction            => %w(ReferenceNumber TransactionID),
-           :credit_card_settle          => %w(ReferenceNumber TransactionAmount OriginalTransactionAmount OriginalTransactionID ClientIpAddress),
-           :system_check                => %w(SystemCheck),
+        :credit_card_authorize       => CREDIT_CARD_FIELDS,
+        :credit_card_charge          => CREDIT_CARD_FIELDS,
+        :credit_card_voice_authorize => CREDIT_CARD_FIELDS,
+        :credit_card_capture         => CREDIT_CARD_FIELDS,
+        :credit_card_credit          => CREDIT_CARD_FIELDS + ['OriginalTransactionAmount'],
+        :credit_card_refund          => %w(ReferenceNumber TransactionAmount OriginalTransactionAmount OriginalTransactionID ClientIpAddress),
+        :void_transaction            => %w(ReferenceNumber TransactionID),
+        :credit_card_settle          => %w(ReferenceNumber TransactionAmount OriginalTransactionAmount OriginalTransactionID ClientIpAddress),
+        :system_check                => %w(SystemCheck),
       }
     end
   end

data/lib/active_merchant/billing/gateways/global_collect.rb

@@ -156,16 +156,16 @@ module ActiveMerchant #:nodoc:
         pre_authorization = options[:pre_authorization] ? 'PRE_AUTHORIZATION' : 'FINAL_AUTHORIZATION'
 
         post['cardPaymentMethodSpecificInput'] = {
-            'paymentProductId' => BRAND_MAP[payment.brand],
-            'skipAuthentication' => 'true', # refers to 3DSecure
-            'skipFraudService' => 'true',
-            'authorizationMode' => pre_authorization
+          'paymentProductId' => BRAND_MAP[payment.brand],
+          'skipAuthentication' => 'true', # refers to 3DSecure
+          'skipFraudService' => 'true',
+          'authorizationMode' => pre_authorization
         }
         post['cardPaymentMethodSpecificInput']['card'] = {
-            'cvv' => payment.verification_value,
-            'cardNumber' => payment.number,
-            'expiryDate' => expirydate,
-            'cardholderName' => payment.name
+          'cvv' => payment.verification_value,
+          'cardNumber' => payment.number,
+          'expiryDate' => expirydate,
+          'cardholderName' => payment.name
         }
       end
 

data/lib/active_merchant/billing/gateways/hps.rb

@@ -32,10 +32,10 @@ module ActiveMerchant #:nodoc:
         commit('CreditAuth') do |xml|
           add_amount(xml, money)
           add_allow_dup(xml)
-          add_customer_data(xml, card_or_token, options)
+          add_card_or_token_customer_data(xml, card_or_token, options)
           add_details(xml, options)
           add_descriptor_name(xml, options)
-          add_payment(xml, card_or_token, options)
+          add_card_or_token_payment(xml, card_or_token, options)
           add_three_d_secure(xml, card_or_token, options)
         end
       end
@@ -47,15 +47,11 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def purchase(money, card_or_token, options={})
-        commit('CreditSale') do |xml|
-          add_amount(xml, money)
-          add_allow_dup(xml)
-          add_customer_data(xml, card_or_token, options)
-          add_details(xml, options)
-          add_descriptor_name(xml, options)
-          add_payment(xml, card_or_token, options)
-          add_three_d_secure(xml, card_or_token, options)
+      def purchase(money, payment_method, options={})
+        if payment_method.is_a?(Check)
+          commit_check_sale(money, payment_method, options)
+        else
+          commit_credit_sale(money, payment_method, options)
         end
       end
 
@@ -64,22 +60,28 @@ module ActiveMerchant #:nodoc:
           add_amount(xml, money)
           add_allow_dup(xml)
           add_reference(xml, transaction_id)
-          add_customer_data(xml, transaction_id, options)
+          add_card_or_token_customer_data(xml, transaction_id, options)
           add_details(xml, options)
         end
       end
 
       def verify(card_or_token, options={})
         commit('CreditAccountVerify') do |xml|
-          add_customer_data(xml, card_or_token, options)
+          add_card_or_token_customer_data(xml, card_or_token, options)
           add_descriptor_name(xml, options)
-          add_payment(xml, card_or_token, options)
+          add_card_or_token_payment(xml, card_or_token, options)
         end
       end
 
       def void(transaction_id, options={})
-        commit('CreditVoid') do |xml|
-          add_reference(xml, transaction_id)
+        if options[:check_void]
+          commit('CheckVoid') do |xml|
+            add_reference(xml, transaction_id)
+          end
+        else
+          commit('CreditVoid') do |xml|
+            add_reference(xml, transaction_id)
+          end
         end
       end
 
@@ -92,11 +94,35 @@ module ActiveMerchant #:nodoc:
           gsub(%r((<hps:CardNbr>)[^<]*(<\/hps:CardNbr>))i, '\1[FILTERED]\2').
           gsub(%r((<hps:CVV2>)[^<]*(<\/hps:CVV2>))i, '\1[FILTERED]\2').
           gsub(%r((<hps:SecretAPIKey>)[^<]*(<\/hps:SecretAPIKey>))i, '\1[FILTERED]\2').
-          gsub(%r((<hps:PaymentData>)[^<]*(<\/hps:PaymentData>))i, '\1[FILTERED]\2')
+          gsub(%r((<hps:PaymentData>)[^<]*(<\/hps:PaymentData>))i, '\1[FILTERED]\2').
+          gsub(%r((<hps:RoutingNumber>)[^<]*(<\/hps:RoutingNumber>))i, '\1[FILTERED]\2').
+          gsub(%r((<hps:AccountNumber>)[^<]*(<\/hps:AccountNumber>))i, '\1[FILTERED]\2')
       end
 
       private
 
+      def commit_check_sale(money, check, options)
+        commit('CheckSale') do |xml|
+          add_check_payment(xml, check, options)
+          add_amount(xml, money)
+          add_sec_code(xml, options)
+          add_check_customer_data(xml, check, options)
+          add_details(xml, options)
+        end
+      end
+
+      def commit_credit_sale(money, card_or_token, options)
+        commit('CreditSale') do |xml|
+          add_amount(xml, money)
+          add_allow_dup(xml)
+          add_card_or_token_customer_data(xml, card_or_token, options)
+          add_details(xml, options)
+          add_descriptor_name(xml, options)
+          add_card_or_token_payment(xml, card_or_token, options)
+          add_three_d_secure(xml, card_or_token, options)
+        end
+      end
+
       def add_reference(xml, transaction_id)
         xml.hps :GatewayTxnId, transaction_id
       end
@@ -105,7 +131,7 @@ module ActiveMerchant #:nodoc:
         xml.hps :Amt, amount(money) if money
       end
 
-      def add_customer_data(xml, credit_card, options)
+      def add_card_or_token_customer_data(xml, credit_card, options)
         xml.hps :CardHolderData do
           if credit_card.respond_to?(:number)
             xml.hps :CardHolderFirstName, credit_card.first_name if credit_card.first_name
@@ -124,7 +150,15 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def add_payment(xml, card_or_token, options)
+      def add_check_customer_data(xml, check, options)
+        xml.hps :ConsumerInfo do
+          xml.hps :FirstName, check.first_name
+          xml.hps :LastName, check.last_name
+          xml.hps :CheckName, options[:company_name] if options[:company_name]
+        end
+      end
+
+      def add_card_or_token_payment(xml, card_or_token, options)
         xml.hps :CardData do
           if card_or_token.respond_to?(:number)
             if card_or_token.track_data
@@ -159,6 +193,17 @@ module ActiveMerchant #:nodoc:
         end
       end
 
+      def add_check_payment(xml, check, options)
+        xml.hps :CheckAction, 'SALE'
+        xml.hps :AccountInfo do
+          xml.hps :RoutingNumber, check.routing_number
+          xml.hps :AccountNumber, check.account_number
+          xml.hps :CheckNumber, check.number
+          xml.hps :AccountType, check.account_type.upcase
+        end
+        xml.hps :CheckType, check.account_holder_type.upcase
+      end
+
       def add_details(xml, options)
         xml.hps :AdditionalTxnFields do
           xml.hps :Description, options[:description] if options[:description]
@@ -167,6 +212,10 @@ module ActiveMerchant #:nodoc:
         end
       end
 
+      def add_sec_code(xml, options)
+        xml.hps :SECCode, options[:sec_code] || 'WEB'
+      end
+
       def add_allow_dup(xml)
         xml.hps :AllowDup, 'Y'
       end
@@ -214,8 +263,8 @@ module ActiveMerchant #:nodoc:
         xml = Builder::XmlMarkup.new(encoding: 'UTF-8')
         xml.instruct!(:xml, encoding: 'UTF-8')
         xml.SOAP :Envelope, {
-            'xmlns:SOAP' => 'http://schemas.xmlsoap.org/soap/envelope/',
-            'xmlns:hps' => 'http://Hps.Exchange.PosGateway'
+          'xmlns:SOAP' => 'http://schemas.xmlsoap.org/soap/envelope/',
+          'xmlns:hps' => 'http://Hps.Exchange.PosGateway'
         } do
           xml.SOAP :Body do
             xml.hps :PosRequest do
@@ -296,10 +345,11 @@ module ActiveMerchant #:nodoc:
         )
       end
 
+      SUCCESSFUL_RESPONSE_CODES = %w(0 00 85)
       def successful?(response)
         (
           (response['GatewayRspCode'] == '0') &&
-          ((response['RspCode'] || '00') == '00' || response['RspCode'] == '85')
+          ((SUCCESSFUL_RESPONSE_CODES.include? response['RspCode']) || !response['RspCode'])
         )
       end
 
@@ -307,10 +357,10 @@ module ActiveMerchant #:nodoc:
         if response['Fault']
           response['Fault']
         elsif response['GatewayRspCode'] == '0'
-          if response['RspCode'] != '00' && response['RspCode'] != '85'
-            issuer_message(response['RspCode'])
-          else
+          if SUCCESSFUL_RESPONSE_CODES.include? response['RspCode']
             response['GatewayRspMsg']
+          else
+            issuer_message(response['RspCode'])
           end
         else
           (GATEWAY_MESSAGES[response['GatewayRspCode']] || response['GatewayRspMsg'])