activemail 1.1.1 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d7cc246dce0922db6f211036614c9c09e61f07ec31be8a8f080ec5367b639162
-  data.tar.gz: f73779825c12264751b039b6fdac9bce76db075d26f058f432d9b85f79529f6a
+  metadata.gz: 45cf8d77d0e4e10e7669e5cfeaa843b174a495b900d6bc5ffc83b2af18bfb11d
+  data.tar.gz: 4b750b051e3354ffc5eeac01e71df54f9bc724b6d3c00ab2d160845a70396db7
 SHA512:
-  metadata.gz: 6edee3036ed2af1fa135508c8b936a61a9045a48f8b44ada6e762dead35510f6a8fd0b8c623f82132d72b6726c4cb3a7adfa96c58f93eebb0eb239340cd69118
-  data.tar.gz: 1d49cbdcafea296842256ec928e626513d3fefe6f0d81d6ce1a2ea9229b9173735269c80123e94c832ba2bd691d8ce08468fba33cb65839cceb162de50af6c99
+  metadata.gz: aebffed9184e53716057ec140ea66c71ebca81cac9d15ca3cd60b20da4f7fdfc0da8f5fa599e3aa18a08b7d75400295be8b56c1a776cc36465ac412646d515f0
+  data.tar.gz: a9975ff0585326d018de39b7d651515d788f792465ac49f8d147034df5e7abc6e9fbcd1a5e4fb717612e59969efac36a5799bc8d1e35e698146cee7afb59f287

data/CHANGELOG.md

@@ -5,6 +5,13 @@ All notable changes to this project are documented here.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.2.0] - 2026-07-01
+
+### Added
+
+- `config.blank_link_rel` (default `"noopener"`): a `rel` is now emitted automatically on
+  `target="_blank"` anchors. Set `nil` to disable; an explicit `rel="…"` still wins.
+
 ## [1.1.1] - 2026-06-16
 
 ### Added

data/lib/activemail/components/base.rb

@@ -29,7 +29,7 @@ module ActiveMail
       abstract!
 
       IGNORED_ON_PASSTHROUGH = T.let(
-        %w[class id href size large no-expander small target up size-sm size-lg style].freeze,
+        %w[class id href size large no-expander small target rel up size-sm size-lg style].freeze,
         T::Array[String]
       )
 
@@ -103,8 +103,20 @@ module ActiveMail
       end
 
       sig { params(node: Nokogiri::XML::Node).returns(String) }
-      def target_attribute(node)
-        node.attributes['target'] ? %( target="#{escape_attr(node.attributes['target'])}") : ''
+      def link_attributes(node)
+        target = node.attributes['target']&.value
+        rel = resolve_rel(node, target)
+        [
+          target ? %( target="#{escape_attr(target)}") : '',
+          rel ? %( rel="#{escape_attr(rel)}") : ''
+        ].join
+      end
+
+      sig { params(node: Nokogiri::XML::Node, target: T.nilable(String)).returns(T.nilable(String)) }
+      def resolve_rel(node, target)
+        rel = node.attributes['rel']&.value
+        rel = nil if rel&.strip&.empty?
+        rel || (ActiveMail.configuration.blank_link_rel if target == '_blank')
       end
 
       # Outlook-safe nested-table structure kept in one place for <button> and <cta>.

data/lib/activemail/components/button.rb

@@ -28,11 +28,11 @@ module ActiveMail
 
       sig { params(node: Nokogiri::XML::Node, inner: String, expand: T::Boolean).returns(String) }
       def anchor(node, inner, expand)
-        target = target_attribute(node)
+        links = link_attributes(node)
         extra = expand ? ' align="center" class="float-center"' : ''
         # Padding on the <a> makes the whole button a clickable target.
         link_style = "display:inline-block;text-decoration:none;#{BUTTON_PADDING}"
-        attrs = %(#{pass_through_attributes(node)}href="#{escape_attr(node.attr('href'))}"#{target}#{extra})
+        attrs = %(#{pass_through_attributes(node)}href="#{escape_attr(node.attr('href'))}"#{links}#{extra})
         %(<a #{attrs}#{style_attribute(node, link_style)}>#{inner}</a>)
       end
     end

data/lib/activemail/components/cta.rb

@@ -16,7 +16,7 @@ module ActiveMail
         raise ArgumentError, '<cta> requires an href attribute' if node.attr('href').to_s.strip.empty?
 
         style = ActiveMail.tokens.button_style(class?(node, 'secondary') ? :secondary : :primary)
-        anchor = %(<a href="#{escape_attr(node.attr('href'))}"#{target_attribute(node)} ) +
+        anchor = %(<a href="#{escape_attr(node.attr('href'))}"#{link_attributes(node)} ) +
                  %(style="#{link_style(style)}">#{inner}</a>)
         bulletproof_button_table(
           outer_classes: combine_classes(node, 'cta'),

data/lib/activemail/components/menu_item.rb

@@ -12,7 +12,7 @@ module ActiveMail
       def transform(node, inner)
         attributes = combine_attributes(node, 'menu-item')
         # No href → a non-link item, not a broken <a href="">; mirrors <button>.
-        content = node.attr('href') ? %(<a href="#{escape_attr(node.attr('href'))}"#{target_attribute(node)}>#{inner}</a>) : inner
+        content = node.attr('href') ? %(<a href="#{escape_attr(node.attr('href'))}"#{link_attributes(node)}>#{inner}</a>) : inner
         th = ::ActiveMail::Core::INTERIM_TH_TAG
         %(<#{th} #{attributes}#{style_attribute(node)}>#{content}</#{th}>)
       end

data/lib/activemail/configuration.rb

@@ -86,6 +86,13 @@ module ActiveMail
     value
   end
 
+  sig { params(name: Symbol, value: T.untyped).returns(Integer) }
+  def self.positive_integer!(name, value)
+    raise TypeError, "#{name} must be an Integer, got #{value.inspect} (#{value.class})" unless value.is_a?(Integer)
+
+    assert_positive_dimension!(name, value)
+  end
+
   class Configuration
     extend T::Sig
 
@@ -113,16 +120,13 @@ module ActiveMail
     end
 
     sig { returns(Symbol) }
-    attr_reader :template_engine
-
-    sig { returns(Symbol) }
-    attr_reader :on_parse_error
+    attr_reader :template_engine, :on_parse_error
 
     sig { returns(Integer) }
-    attr_reader :column_count
+    attr_reader :column_count, :container_width
 
-    sig { returns(Integer) }
-    attr_reader :container_width
+    sig { returns(T.nilable(String)) }
+    attr_reader :blank_link_rel
 
     # Mutating the returned hash would bypass validate_component!.
     sig { returns(ActiveMail::ComponentMap) }
@@ -146,6 +150,7 @@ module ActiveMail
       @inliner = T.let(:premailer, InlinerSetting)
       @resolved_inliner = T.let(nil, T.nilable(ActiveMail::Inliner::Base))
       @register_inline_interceptor = T.let(true, T::Boolean)
+      @blank_link_rel = T.let('noopener', T.nilable(String))
     end
 
     # Validates eagerly (like sibling setters): a typo fails at boot, not silently mid-delivery.
@@ -180,12 +185,20 @@ module ActiveMail
 
     sig { params(value: T.untyped).returns(Integer) }
     def column_count=(value)
-      @column_count = positive_integer!(:column_count, value)
+      @column_count = ActiveMail.positive_integer!(:column_count, value)
     end
 
     sig { params(value: T.untyped).returns(Integer) }
     def container_width=(value)
-      @container_width = positive_integer!(:container_width, value)
+      @container_width = ActiveMail.positive_integer!(:container_width, value)
+    end
+
+    sig { params(value: T.untyped).returns(T.nilable(String)) }
+    def blank_link_rel=(value)
+      raise TypeError, "blank_link_rel must be a String or nil, got #{value.inspect} (#{value.class})" unless value.nil? || value.is_a?(String)
+
+      normalized = value&.strip
+      @blank_link_rel = normalized&.empty? ? nil : normalized
     end
 
     sig { params(value: T.untyped).returns(ActiveMail::ComponentMap) }
@@ -216,14 +229,5 @@ module ActiveMail
 
       raise ArgumentError, "unknown inliner #{value.inspect}, expected one of #{INLINERS.keys.inspect}, an Inliner::Base subclass, or an instance"
     end
-
-    # Integer-only (no to_int): a Float would otherwise be silently truncated
-    # (12.9 -> 12), contradicting assert_positive_dimension!'s invariant.
-    sig { params(name: Symbol, value: T.untyped).returns(Integer) }
-    def positive_integer!(name, value)
-      raise TypeError, "#{name} must be an Integer, got #{value.inspect} (#{value.class})" unless value.is_a?(Integer)
-
-      ActiveMail.assert_positive_dimension!(name, value)
-    end
   end
 end

data/lib/activemail/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module ActiveMail
-  VERSION = '1.1.1'
+  VERSION = '1.2.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activemail
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.2.0
 platform: ruby
 authors:
 - Advitam