activejob-resque-disconnect 0.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: dc9af47d06d09561e4b9124c2d997eaa44d19d00
+  data.tar.gz: c29fe167d1ddb0ceba7641f4d3d8f1e9f6cc5b84
+SHA512:
+  metadata.gz: d2a9ea10fd546914a395b6591f1c9c902ba99d10cc62b99a895f386980bdc0d1aa890864605d6338767efc825ab0accddf5d623f349a5f403f3ddd56d547c3eb
+  data.tar.gz: 5e10aec03c72d6fa5a1d0932dc6b6486f090a48caa621254fad10d9edd2349a98406a2391e7348202cd499cb28fcf6fc75e2f310e536d0b731490968a7a441d2

data/Gemfile

@@ -0,0 +1,8 @@
+source 'https://rubygems.org'
+
+gemspec
+
+group :test, :integration do
+  gem 'resque', require: false
+  gem 'resque-scheduler', require: false
+end

data/Gemfile.lock

@@ -0,0 +1,109 @@
+PATH
+  remote: .
+  specs:
+    activejob-resque-disconnect (0.1.0)
+      activejob (>= 4.2)
+      activerecord (>= 4.2)
+      resque
+      resque-scheduler
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activejob (4.2.0)
+      activesupport (= 4.2.0)
+      globalid (>= 0.3.0)
+    activemodel (4.2.0)
+      activesupport (= 4.2.0)
+      builder (~> 3.1)
+    activerecord (4.2.0)
+      activemodel (= 4.2.0)
+      activesupport (= 4.2.0)
+      arel (~> 6.0)
+    activesupport (4.2.0)
+      i18n (~> 0.7)
+      json (~> 1.7, >= 1.7.7)
+      minitest (~> 5.1)
+      thread_safe (~> 0.3, >= 0.3.4)
+      tzinfo (~> 1.1)
+    arel (6.0.0)
+    ast (2.0.0)
+    astrolabe (1.3.0)
+      parser (>= 2.2.0.pre.3, < 3.0)
+    builder (3.2.2)
+    diff-lcs (1.2.5)
+    globalid (0.3.0)
+      activesupport (>= 4.1.0)
+    i18n (0.7.0)
+    json (1.8.2)
+    minitest (5.5.1)
+    mono_logger (1.1.0)
+    multi_json (1.10.1)
+    parser (2.2.0.2)
+      ast (>= 1.1, < 3.0)
+    powerpack (0.0.9)
+    rack (1.6.0)
+    rack-protection (1.5.3)
+      rack
+    rainbow (2.0.0)
+    rake (10.4.2)
+    redis (3.2.0)
+    redis-namespace (1.5.1)
+      redis (~> 3.0, >= 3.0.4)
+    resque (1.25.2)
+      mono_logger (~> 1.0)
+      multi_json (~> 1.0)
+      redis-namespace (~> 1.3)
+      sinatra (>= 0.9.2)
+      vegas (~> 0.1.2)
+    resque-scheduler (4.0.0)
+      mono_logger (~> 1.0)
+      redis (~> 3.0)
+      resque (~> 1.25)
+      rufus-scheduler (~> 3.0)
+    rspec (3.1.0)
+      rspec-core (~> 3.1.0)
+      rspec-expectations (~> 3.1.0)
+      rspec-mocks (~> 3.1.0)
+    rspec-core (3.1.7)
+      rspec-support (~> 3.1.0)
+    rspec-expectations (3.1.2)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.1.0)
+    rspec-its (1.1.0)
+      rspec-core (>= 3.0.0)
+      rspec-expectations (>= 3.0.0)
+    rspec-mocks (3.1.3)
+      rspec-support (~> 3.1.0)
+    rspec-support (3.1.2)
+    rubocop (0.28.0)
+      astrolabe (~> 1.3)
+      parser (>= 2.2.0.pre.7, < 3.0)
+      powerpack (~> 0.0.6)
+      rainbow (>= 1.99.1, < 3.0)
+      ruby-progressbar (~> 1.4)
+    ruby-progressbar (1.7.1)
+    rufus-scheduler (3.0.9)
+      tzinfo
+    sinatra (1.4.5)
+      rack (~> 1.4)
+      rack-protection (~> 1.4)
+      tilt (~> 1.3, >= 1.3.4)
+    thread_safe (0.3.4)
+    tilt (1.4.1)
+    tzinfo (1.2.2)
+      thread_safe (~> 0.1)
+    vegas (0.1.11)
+      rack (>= 1.0.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  activejob-resque-disconnect!
+  rake (>= 10.3)
+  resque
+  resque-scheduler
+  rspec
+  rspec-its
+  rubocop

data/README.md

@@ -0,0 +1,14 @@
+# ActiveJob::QueueAdapters::ResqueDisconnectAdapter
+
+ActiveJob adapter for Resque which disconnects when the worker has finished.
+
+By default the connection will be left open until the database times it out, which eats up
+database connections for no good reason.
+
+```ruby
+require 'active_job/queue_adapters/resque_disconnect_adapter'
+
+MyApp::Application.configure do
+  config.active_job.queue_adapter = ActiveJob::QueueAdapters::ResqueDisconnectAdapter
+end
+```

data/activejob-resque-disconnect.gemspec

@@ -0,0 +1,32 @@
+require File.expand_path('../lib/version', __FILE__)
+
+Gem::Specification.new do |s|
+  s.name = 'activejob-resque-disconnect'
+  s.version = ActiveJob::QueueAdapters::RESQUE_DISCONNECT_ADAPTER_VERSION
+  s.date = Date.today.strftime('%Y-%m-%d')
+  s.authors = ['Isaac Seymour']
+  s.email = ['isaac@isaacseymour.co.uk']
+  s.summary = 'ActiveJob Resque adapter which disconnects when the job is complete'
+  s.description = <<-EOL
+    If you're using ActiveRecord with Resque, a new database connection will get opened
+    for each worker process. When the worker completes, this connection is left open by
+    default, which is pretty bad. This adapter closes the connection when the job has_rdoc
+    finished executing.
+  EOL
+  s.homepage = 'http://github.com/gocardless/activejob-resque-disconnect'
+  s.license = 'MIT'
+
+  s.has_rdoc = false
+  s.files = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
+  s.require_paths = %w(lib)
+
+  s.add_dependency('activejob', '>= 4.2')
+  s.add_dependency('activerecord', '>= 4.2')
+  s.add_dependency('resque')
+  s.add_dependency('resque-scheduler')
+
+  s.add_development_dependency('rake', ' >= 10.3')
+  s.add_development_dependency('rspec')
+  s.add_development_dependency('rspec-its')
+  s.add_development_dependency('rubocop')
+end

data/lib/active_job/queue_adapters/resque_disconnect_adapter.rb

@@ -0,0 +1,51 @@
+require 'resque'
+require 'active_job'
+require 'active_record'
+require 'active_support/core_ext/enumerable'
+require 'active_support/core_ext/array/access'
+
+begin
+  require 'resque-scheduler'
+rescue LoadError
+  begin
+    require 'resque_scheduler'
+  rescue LoadError
+    false
+  end
+end
+
+module ActiveJob
+  module QueueAdapters
+    # == Resque adapter for Active Job which disconnects when the job is done
+    #
+    #   require 'active_job/queue_adapters/resque_disconnect_adapter'
+    #   Rails.application.config.active_job.queue_adapter = ActiveJob::QueueAdapters::ResqueDisconnectAdapter
+    class ResqueDisconnectAdapter
+      class << self
+        def enqueue(job)
+          Resque.enqueue_to(job.queue_name, JobWrapper, job.serialize)
+        end
+
+        def enqueue_at(job, timestamp)
+          unless Resque.respond_to?(:enqueue_at_with_queue)
+            raise NotImplementedError,
+                  "To be able to schedule jobs with Resque you need the " \
+                  "resque-scheduler gem. Please add it to your Gemfile and run bundle " \
+                  "install"
+          end
+          Resque.enqueue_at_with_queue(job.queue_name, timestamp, JobWrapper, job.serialize)
+        end
+      end
+
+      class JobWrapper
+        class << self
+          def perform(job_data)
+            ActiveJob::Base.execute(job_data)
+          ensure
+            ActiveRecord::Base.connection.disconnect!
+          end
+        end
+      end
+    end
+  end
+end

data/lib/version.rb

@@ -0,0 +1,5 @@
+module ActiveJob
+  module QueueAdapters
+    RESQUE_DISCONNECT_ADAPTER_VERSION = '0.1.0'.freeze
+  end
+end

data/spec/job_wrapper_spec.rb

@@ -0,0 +1,29 @@
+require 'spec_helper'
+
+RSpec.describe ActiveJob::QueueAdapters::ResqueDisconnectAdapter::JobWrapper do
+  subject(:perform) { described_class.perform(job_data) }
+  let(:job_data) { { 'job' => 'data' } }
+
+  let(:connection) { double(disconnect!: true) }
+  before { allow(ActiveJob::Base).to receive(:execute) }
+  before { allow(ActiveRecord::Base).to receive(:connection).and_return(connection) }
+
+  it "executes the job" do
+    expect(ActiveJob::Base).to receive(:execute).with('job' => 'data')
+    perform
+  end
+
+  it "disconnects from the database" do
+    expect(connection).to receive(:disconnect!)
+    perform
+  end
+
+  context "when the job raises" do
+    before { expect(ActiveJob::Base).to receive(:execute).and_raise('hell') }
+
+    it "still disconnects" do
+      expect(connection).to receive(:disconnect!)
+      expect { perform }.to raise_error(RuntimeError, 'hell')
+    end
+  end
+end

data/spec/resque_disconnect_adapter_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper'
+
+RSpec.describe ActiveJob::QueueAdapters::ResqueDisconnectAdapter do
+  let(:job) { double(queue_name: :queue, serialize: { 'job' => 'params' }) }
+
+  describe ".enqueue" do
+    subject(:enqueue) { described_class.enqueue(job) }
+
+    it "enqueues to Resque" do
+      expect(Resque).to receive(:enqueue_to).
+        with(:queue, described_class::JobWrapper, { 'job' => 'params' })
+
+      enqueue
+    end
+  end
+
+  describe ".enqueue_at" do
+    subject(:enqueue_at) { described_class.enqueue_at(job, timestamp) }
+    let(:timestamp) { 'time to work' }
+
+    it "enqueues to Resque" do
+      expect(Resque).to receive(:enqueue_at_with_queue).
+        with(:queue, timestamp, described_class::JobWrapper, { 'job' => 'params' })
+
+      enqueue_at
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,20 @@
+require 'active_job/queue_adapters/resque_disconnect_adapter'
+require 'rspec/its'
+
+RSpec.configure do |config|
+  config.expect_with :rspec do |expectations|
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  config.mock_with :rspec do |mocks|
+    mocks.verify_partial_doubles = true
+  end
+
+  config.disable_monkey_patching!
+
+  config.warnings = true
+
+  config.order = :random
+
+  Kernel.srand config.seed
+end

metadata

@@ -0,0 +1,170 @@
+--- !ruby/object:Gem::Specification
+name: activejob-resque-disconnect
+version: !ruby/object:Gem::Version
+  version: 0.1.0
+platform: ruby
+authors:
+- Isaac Seymour
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2015-01-16 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: activejob
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '4.2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '4.2'
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '4.2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '4.2'
+- !ruby/object:Gem::Dependency
+  name: resque
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: resque-scheduler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '10.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '10.3'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec-its
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+description: |2
+      If you're using ActiveRecord with Resque, a new database connection will get opened
+      for each worker process. When the worker completes, this connection is left open by
+      default, which is pretty bad. This adapter closes the connection when the job has_rdoc
+      finished executing.
+email:
+- isaac@isaacseymour.co.uk
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- Gemfile
+- Gemfile.lock
+- README.md
+- activejob-resque-disconnect.gemspec
+- lib/active_job/queue_adapters/resque_disconnect_adapter.rb
+- lib/version.rb
+- spec/job_wrapper_spec.rb
+- spec/resque_disconnect_adapter_spec.rb
+- spec/spec_helper.rb
+homepage: http://github.com/gocardless/activejob-resque-disconnect
+licenses:
+- MIT
+metadata: {}
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 2.4.1
+signing_key: 
+specification_version: 4
+summary: ActiveJob Resque adapter which disconnects when the job is complete
+test_files: []
+has_rdoc: false