activejob-perform_later 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0bf0068119703052a61e0ff042f4ff652ae380d5
-  data.tar.gz: ece4cf16091688d47ba1e33c524441b3a4c10538
+  metadata.gz: d508092f2ef6a4fc5bd5f60ec442ea4ee10f8975
+  data.tar.gz: 3486db8eba486b5f7a7102855742eda024d29d20
 SHA512:
-  metadata.gz: e03d6dcc0804be43bdca4cbce6822da6d52520a9378f23e36f14a33ca7a85ee182910fa705d8ba44e23d370c2eb18dbec1aafa6f499f6be9d0c6af3781207c64
-  data.tar.gz: e4c23d5af8909444f14de42ec9d83728261da6b9ce80fd53543edcbfe3bfaedc5f477d73efea29ff5add702859d651561d7b00848e93e254fac6a270e2f48115
+  metadata.gz: 2e60e0bca26484a94c12cbbe3f9971d96eed6d980435314db8f4224e62c35cf7be4cba799d6f091475f59408cb7a513ba3a73b4c26dd3e92007b62b49119af2b
+  data.tar.gz: 69dfc83edede4301f1ac69d0ba76fed5bf41c4cb43f9cd9a53b519a412bf03af325719353f3543183f20add6a80f263569bf3f0c5076fe2a19b8fcf58859d240

data/.rubocop.yml

@@ -0,0 +1,119 @@
+AllCops:
+  TargetRubyVersion: 2.2
+  # RuboCop has a bunch of cops enabled by default. This setting tells RuboCop
+  # to ignore them, so only the ones explicitly set in this file are enabled.
+  DisabledByDefault: true
+  Exclude:
+    - '**/templates/**/*'
+    - '**/vendor/**/*'
+
+# Prefer &&/|| over and/or.
+Style/AndOr:
+  Enabled: true
+
+# Do not use braces for hash literals when they are the last argument of a
+# method call.
+Style/BracesAroundHashParameters:
+  Enabled: true
+
+# Align `when` with `case`.
+Style/CaseIndentation:
+  Enabled: true
+
+# Align comments with method definitions.
+Style/CommentIndentation:
+  Enabled: true
+
+# No extra empty lines.
+Style/EmptyLines:
+  Enabled: true
+
+# In a regular class definition, no empty lines around the body.
+Style/EmptyLinesAroundClassBody:
+  Enabled: true
+
+# In a regular module definition, no empty lines around the body.
+Style/EmptyLinesAroundModuleBody:
+  Enabled: true
+
+# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
+Style/HashSyntax:
+  Enabled: true
+
+# Method definitions after `private` or `protected` isolated calls need one
+# extra level of indentation.
+Style/IndentationConsistency:
+  Enabled: true
+  EnforcedStyle: rails
+
+# Two spaces, no tabs (for indentation).
+Style/IndentationWidth:
+  Enabled: true
+
+Style/SpaceAfterColon:
+  Enabled: true
+
+Style/SpaceAfterComma:
+  Enabled: true
+
+Style/SpaceAroundEqualsInParameterDefault:
+  Enabled: true
+
+Style/SpaceAroundKeyword:
+  Enabled: true
+
+Style/SpaceAroundOperators:
+  Enabled: true
+
+Style/SpaceBeforeFirstArg:
+    Enabled: true
+
+# Defining a method with parameters needs parentheses.
+Style/MethodDefParentheses:
+  Enabled: true
+
+# Use `foo {}` not `foo{}`.
+Style/SpaceBeforeBlockBraces:
+  Enabled: true
+
+# Use `foo { bar }` not `foo {bar}`.
+Style/SpaceInsideBlockBraces:
+  Enabled: true
+
+# Use `{ a: 1 }` not `{a:1}`.
+Style/SpaceInsideHashLiteralBraces:
+  Enabled: true
+
+Style/SpaceInsideParens:
+  Enabled: true
+
+# Check quotes usage according to lint rule below.
+Style/StringLiterals:
+  Enabled: true
+  EnforcedStyle: double_quotes
+
+# Detect hard tabs, no hard tabs.
+Style/Tab:
+  Enabled: true
+
+# Blank lines should not have any spaces.
+Style/TrailingBlankLines:
+  Enabled: true
+
+# No trailing whitespace.
+Style/TrailingWhitespace:
+  Enabled: true
+
+# Use quotes for string literals when they are enough.
+Style/UnneededPercentQ:
+  Enabled: true
+
+# Align `end` with the matching keyword or starting expression except for
+# assignments, where it should be aligned with the LHS.
+Lint/EndAlignment:
+  Enabled: true
+  AlignWith: variable
+
+# Use my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
+Lint/RequireParentheses:
+  Enabled: true

data/README.md

@@ -1,3 +1,6 @@
+[![Build Status](https://travis-ci.org/cristianbica/activejob-perform_later.svg?branch=master)](https://travis-ci.org/cristianbica/activejob-perform_later)
+
+
 # Activejob::PerformLater
 
 Make any method perfomed later.

data/lib/activejob/perform_later.rb

@@ -1,6 +1,6 @@
 require "activejob/perform_later/version"
-require 'active_support'
-require 'active_job'
+require "active_support"
+require "active_job"
 
 module Activejob
   module PerformLater
@@ -9,7 +9,10 @@ module Activejob
     autoload :Job
     autoload :Proxy
     autoload :Mixin
+    autoload :Util
   end
 end
 
 Object.send(:include, Activejob::PerformLater::Mixin)
+Object.send(:extend, Activejob::PerformLater::Mixin)
+Module.send(:extend, Activejob::PerformLater::Mixin)

data/lib/activejob/perform_later/mixin.rb

@@ -1,34 +1,14 @@
 module Activejob
   module PerformLater
     module Mixin
-      extend ActiveSupport::Concern
-
-      module ClassMethods
-        def perform_later(*args)
-          if args[0].is_a?(Symbol)
-            raise ArgumentError, "#{self} does not have a `#{args[0]}` class method" unless respond_to?(args[0])
-            method  = args[0]
-            options = args[1]||{}
-
-            aliased_method, punctuation = method.to_s.sub(/([?!=])$/, ''), $1
-            now_method, later_method = "#{aliased_method}_now#{punctuation}", "#{aliased_method}_later#{punctuation}"
-
-            singleton_class.send(:define_method, later_method) do |*args|
-              Job.new(self.name, now_method, args).enqueue options
-            end
-
-            singleton_class.send(:alias_method, now_method, method)
-            singleton_class.send(:alias_method, method, later_method)
-          else
-            options = args[0]||{}
-            Proxy.new(self.name, options)
-          end
+      def perform_later(*method_names)
+        options = method_names.extract_options!
+        if method_names.empty?
+          Activejob::PerformLater::Util.proxy_calls(self, options)
+        else
+          Activejob::PerformLater::Util.perform_methods_later(self, method_names, options)
         end
       end
-
-      def perform_later(options={})
-        Proxy.new(self, options)
-      end
     end
   end
 end

data/lib/activejob/perform_later/proxy.rb

@@ -2,7 +2,7 @@ module Activejob
   module PerformLater
     class Proxy < BasicObject
       def initialize(target, options)
-        @target = target
+        @target = Util.proxiable_object(target)
         @options = options
       end
 

data/lib/activejob/perform_later/util.rb

@@ -0,0 +1,33 @@
+module Activejob
+  module PerformLater
+    module Util
+      extend self
+
+      def proxy_calls(obj, options)
+        Proxy.new(obj, options)
+      end
+
+      def perform_methods_later(obj, method_names, options)
+        raise ArgumentError, "You can only declare class methods as delayed" unless obj.class == Class || obj.class == Module
+        method_names.each do |method_name|
+          perform_method_later(obj, method_name, options)
+        end
+      end
+
+      def perform_method_later(obj, method_name, options)
+        raise ArgumentError, "#{self} must respond to `#{method_name}`" unless obj.respond_to?(method_name)
+        aliased_method, punctuation = method_name.to_s.sub(/([?!=])$/, ""), $1
+        now_method, later_method = "#{aliased_method}_now#{punctuation}", "#{aliased_method}_later#{punctuation}"
+        obj.singleton_class.send(:define_method, later_method) do |*args|
+          Job.new(::Activejob::PerformLater::Util.proxiable_object(obj), now_method, args).enqueue options
+        end
+        obj.singleton_class.send(:alias_method, now_method, method_name)
+        obj.singleton_class.send(:alias_method, method_name, later_method)
+      end
+
+      def proxiable_object(obj)
+        obj.class == ::Class || obj.class == ::Module ? obj.name : obj
+      end
+    end
+  end
+end

data/lib/activejob/perform_later/version.rb

@@ -1,5 +1,5 @@
 module Activejob
   module PerformLater
-    VERSION = "1.0.1"
+    VERSION = "1.0.2"
   end
 end

data/test/cases/{class_methods_always_test.rb → classes/class_methods_always_test.rb}

@@ -1,7 +1,7 @@
-require 'helper'
-require 'classes/test_class'
+require "helper"
+require "support/test_class"
 
-class ClassMethodsAlwaysTest < ActiveSupport::TestCase
+class ClassesClassMethodsAlwaysTest < ActiveSupport::TestCase
   include ActiveJob::TestHelper
 
   def test_creates_later_and_now_methods
@@ -29,7 +29,7 @@ class ClassMethodsAlwaysTest < ActiveSupport::TestCase
   end
 
   def test_enqueues_the_job_on_a_queue
-    assert_enqueued_with(job: Activejob::PerformLater::Job, args: ["TestClass", "three_now", [1, 2]], queue: 'non_default') do
+    assert_enqueued_with(job: Activejob::PerformLater::Job, args: ["TestClass", "three_now", [1, 2]], queue: "non_default") do
       TestClass.three(1, 2)
     end
   end
@@ -49,7 +49,7 @@ class ClassMethodsAlwaysTest < ActiveSupport::TestCase
   end
 
   def test_performs_the_job_on_a_queue
-    assert_performed_with(job: Activejob::PerformLater::Job, args: ["TestClass", "three_now", [1, 2]], queue: 'non_default') do
+    assert_performed_with(job: Activejob::PerformLater::Job, args: ["TestClass", "three_now", [1, 2]], queue: "non_default") do
       TestClass.three(1, 2)
     end
   end

data/test/cases/{class_methods_on_demand_test.rb → classes/class_methods_on_demand_test.rb}

@@ -1,7 +1,7 @@
-require 'helper'
-require 'classes/test_class'
+require "helper"
+require "support/test_class"
 
-class ClassMethodsAlwaysTest < ActiveSupport::TestCase
+class ClassesClassMethodsOnDemandTest < ActiveSupport::TestCase
   include ActiveJob::TestHelper
 
   def test_enqueues_the_job
@@ -25,12 +25,11 @@ class ClassMethodsAlwaysTest < ActiveSupport::TestCase
   end
 
   def test_enqueues_the_job_on_a_queue
-    assert_enqueued_with(job: Activejob::PerformLater::Job, args: ["TestClass", "five", [1, 2]], queue: 'non_default') do
-        TestClass.perform_later(queue: "non_default").five(1, 2)
+    assert_enqueued_with(job: Activejob::PerformLater::Job, args: ["TestClass", "five", [1, 2]], queue: "non_default") do
+      TestClass.perform_later(queue: "non_default").five(1, 2)
     end
   end
 
-
   def test_performs_the_job
     assert_performed_jobs 1 do
       TestClass.perform_later.five
@@ -52,8 +51,8 @@ class ClassMethodsAlwaysTest < ActiveSupport::TestCase
   end
 
   def test_performs_the_job_on_a_queue
-    assert_performed_with(job: Activejob::PerformLater::Job, args: ["TestClass", "five", [1, 2]], queue: 'non_default') do
-        TestClass.perform_later(queue: "non_default").five(1, 2)
+    assert_performed_with(job: Activejob::PerformLater::Job, args: ["TestClass", "five", [1, 2]], queue: "non_default") do
+      TestClass.perform_later(queue: "non_default").five(1, 2)
     end
   end
 end

data/test/cases/{instance_methods_on_demand_test.rb → classes/instance_methods_on_demand_test.rb}

@@ -1,7 +1,7 @@
-require 'helper'
-require 'classes/test_class'
+require "helper"
+require "support/test_class"
 
-class ClassMethodsAlwaysTest < ActiveSupport::TestCase
+class ClassesInstanceMethodsOnDemandTest < ActiveSupport::TestCase
   include ActiveJob::TestHelper
 
   def test_enqueues_the_job
@@ -11,7 +11,7 @@ class ClassMethodsAlwaysTest < ActiveSupport::TestCase
   end
 
   def test_enqueues_the_job_with_arguments
-    assert_enqueued_with(job: Activejob::PerformLater::Job, args: [{"_aj_globalid"=>"gid://ajpl/TestClass/0"}, 'six', [1, 2]]) do
+    assert_enqueued_with(job: Activejob::PerformLater::Job, args: [TestClass.new, "six", [1, 2]]) do
       TestClass.new.perform_later.six(1, 2)
     end
   end
@@ -25,12 +25,11 @@ class ClassMethodsAlwaysTest < ActiveSupport::TestCase
   end
 
   def test_enqueues_the_job_on_a_queue
-    assert_enqueued_with(job: Activejob::PerformLater::Job, queue: 'non_default') do
-        TestClass.new.perform_later(queue: "non_default").six
+    assert_enqueued_with(job: Activejob::PerformLater::Job, queue: "non_default") do
+      TestClass.new.perform_later(queue: "non_default").six
     end
   end
 
-
   def test_performs_the_job
     assert_performed_jobs 1 do
       TestClass.new.perform_later.six
@@ -38,7 +37,7 @@ class ClassMethodsAlwaysTest < ActiveSupport::TestCase
   end
 
   def test_performs_the_job_with_arguments
-    assert_performed_with(job: Activejob::PerformLater::Job, args: [{"_aj_globalid"=>"gid://ajpl/TestClass/0"}, 'six', [1, 2]]) do
+    assert_performed_with(job: Activejob::PerformLater::Job, args: [TestClass.new, "six", [1, 2]]) do
       TestClass.new.perform_later.six(1, 2)
     end
   end
@@ -52,9 +51,8 @@ class ClassMethodsAlwaysTest < ActiveSupport::TestCase
   end
 
   def test_performs_the_job_on_a_queue
-    assert_performed_with(job: Activejob::PerformLater::Job, queue: 'non_default') do
+    assert_performed_with(job: Activejob::PerformLater::Job, queue: "non_default") do
       TestClass.new.perform_later(queue: "non_default").six
     end
   end
-
 end

data/test/cases/modules/always_test.rb

@@ -0,0 +1,56 @@
+require "helper"
+require "support/test_module"
+
+class ModulesAlwaysTest < ActiveSupport::TestCase
+  include ActiveJob::TestHelper
+
+  def test_creates_later_and_now_methods
+    assert_respond_to TestModule, :one_later
+    assert_respond_to TestModule, :one_now
+  end
+
+  def test_creates_later_and_now_methods_with_punctuation
+    assert_respond_to TestModule, :four_later?
+    assert_respond_to TestModule, :four_now?
+  end
+
+  def test_enqueues_the_job
+    assert_enqueued_jobs 1 do
+      TestModule.one
+    end
+  end
+
+  def test_enqueues_the_job_with_delay
+    travel_to Time.now do
+      assert_enqueued_with(job: Activejob::PerformLater::Job, args: ["TestModule", "two_now", [1, 2]], at: 60.seconds.from_now.to_f) do
+        TestModule.two(1, 2)
+      end
+    end
+  end
+
+  def test_enqueues_the_job_on_a_queue
+    assert_enqueued_with(job: Activejob::PerformLater::Job, args: ["TestModule", "three_now", [1, 2]], queue: "non_default") do
+      TestModule.three(1, 2)
+    end
+  end
+
+  def test_performs_the_job
+    assert_performed_jobs 1 do
+      TestModule.one
+    end
+  end
+
+  def test_performs_the_job_with_delay
+    travel_to Time.now do
+      assert_performed_with(job: Activejob::PerformLater::Job, args: ["TestModule", "two_now", [1, 2]], at: 60.seconds.from_now.to_f) do
+        TestModule.two(1, 2)
+      end
+    end
+  end
+
+  def test_performs_the_job_on_a_queue
+    assert_performed_with(job: Activejob::PerformLater::Job, args: ["TestModule", "three_now", [1, 2]], queue: "non_default") do
+      TestModule.three(1, 2)
+    end
+  end
+end

data/test/cases/modules/on_demand_test.rb

@@ -0,0 +1,58 @@
+require "helper"
+require "support/test_module"
+
+class ModulesOnDemandTest < ActiveSupport::TestCase
+  include ActiveJob::TestHelper
+
+  def test_enqueues_the_job
+    assert_enqueued_jobs 1 do
+      TestModule.perform_later.five
+    end
+  end
+
+  def test_enqueues_the_job_with_arguments
+    assert_enqueued_with(job: Activejob::PerformLater::Job, args: ["TestModule", "five", [1, 2]]) do
+      TestModule.perform_later.five(1, 2)
+    end
+  end
+
+  def test_enqueues_the_job_with_delay
+    travel_to Time.now do
+      assert_enqueued_with(job: Activejob::PerformLater::Job, args: ["TestModule", "five", [1, 2]], at: 60.seconds.from_now.to_f) do
+        TestModule.perform_later(wait: 60.seconds).five(1, 2)
+      end
+    end
+  end
+
+  def test_enqueues_the_job_on_a_queue
+    assert_enqueued_with(job: Activejob::PerformLater::Job, args: ["TestModule", "five", [1, 2]], queue: "non_default") do
+      TestModule.perform_later(queue: "non_default").five(1, 2)
+    end
+  end
+
+  def test_performs_the_job
+    assert_performed_jobs 1 do
+      TestModule.perform_later.five
+    end
+  end
+
+  def test_performs_the_job_with_arguments
+    assert_performed_with(job: Activejob::PerformLater::Job, args: ["TestModule", "five", [1, 2]]) do
+      TestModule.perform_later.five(1, 2)
+    end
+  end
+
+  def test_performs_the_job_with_delay
+    travel_to Time.now do
+      assert_performed_with(job: Activejob::PerformLater::Job, args: ["TestModule", "five", [1, 2]], at: 60.seconds.from_now.to_f) do
+        TestModule.perform_later(wait: 60.seconds).five(1, 2)
+      end
+    end
+  end
+
+  def test_performs_the_job_on_a_queue
+    assert_performed_with(job: Activejob::PerformLater::Job, args: ["TestModule", "five", [1, 2]], queue: "non_default") do
+      TestModule.perform_later(queue: "non_default").five(1, 2)
+    end
+  end
+end

data/test/{classes → support}/test_class.rb

@@ -19,7 +19,7 @@ class TestClass
 
   def self.three(*)
   end
-  perform_later :three, queue: 'non_default'
+  perform_later :three, queue: "non_default"
 
   def self.four?(*)
   end

data/test/support/test_module.rb

@@ -0,0 +1,20 @@
+module TestModule
+  def self.one(*)
+  end
+  perform_later :one
+
+  def self.two(*)
+  end
+  perform_later :two, wait: 60
+
+  def self.three(*)
+  end
+  perform_later :three, queue: "non_default"
+
+  def self.four?(*)
+  end
+  perform_later :four?
+
+  def self.five(*)
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activejob-perform_later
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Cristian Bica
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-02 00:00:00.000000000 Z
+date: 2016-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob
@@ -60,6 +60,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
 - LICENSE.txt
@@ -70,12 +71,16 @@ files:
 - lib/activejob/perform_later/job.rb
 - lib/activejob/perform_later/mixin.rb
 - lib/activejob/perform_later/proxy.rb
+- lib/activejob/perform_later/util.rb
 - lib/activejob/perform_later/version.rb
-- test/cases/class_methods_always_test.rb
-- test/cases/class_methods_on_demand_test.rb
-- test/cases/instance_methods_on_demand_test.rb
-- test/classes/test_class.rb
+- test/cases/classes/class_methods_always_test.rb
+- test/cases/classes/class_methods_on_demand_test.rb
+- test/cases/classes/instance_methods_on_demand_test.rb
+- test/cases/modules/always_test.rb
+- test/cases/modules/on_demand_test.rb
 - test/helper.rb
+- test/support/test_class.rb
+- test/support/test_module.rb
 homepage: ''
 licenses:
 - MIT
@@ -96,14 +101,16 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Make any method perfomed later.
 test_files:
-- test/cases/class_methods_always_test.rb
-- test/cases/class_methods_on_demand_test.rb
-- test/cases/instance_methods_on_demand_test.rb
-- test/classes/test_class.rb
+- test/cases/classes/class_methods_always_test.rb
+- test/cases/classes/class_methods_on_demand_test.rb
+- test/cases/classes/instance_methods_on_demand_test.rb
+- test/cases/modules/always_test.rb
+- test/cases/modules/on_demand_test.rb
 - test/helper.rb
-has_rdoc: 
+- test/support/test_class.rb
+- test/support/test_module.rb