activeinteractor 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bbabe89a7d29d7b1faba5a48f6d7cc105db0bc783ce6b14ecef236534a69c2e2
-  data.tar.gz: 6716e1bba69f443f360632aa8af7f3c5c89f3b60d5bf3679427e63c12d65b454
+  metadata.gz: 18cf10a86ec48171ff40670464a016626fed857a9f429f39a66cecd5e5d89ce8
+  data.tar.gz: f53205376b409a3c4a589b73c3f45dd5f56264c077d96e8af64d28918da0ea91
 SHA512:
-  metadata.gz: 34bbeb89139ffdccb6a1fc38e73f125995a21a9ad2026bbde21ac6a251ff0bec533d35143ce13e569fe2f55c33feafb03e8eac142b2e1577d127f359b4b52d4c
-  data.tar.gz: dc8e8775074d0d451678597c459ed6bc4b55043c89755c6be0d34ca56ab4cf74624686bad25e4111e7457fed5f0bcd3ee8d3cab6316b4d5a13567b8ac004e6ad
+  metadata.gz: 52ae6e7c4a6a595ee8ef7bdecf5b496cd399f60ab79b0b7806b690661b1a8a82ce05438026a2a6a1e6177688077057209a2aad546f36bb57fb16ba87948fe3c8
+  data.tar.gz: d6510e42ddb2bb1b639fe36b7ec4a9df936519be1cce3d6c7000ecc05578f9609118b50131a82e19b725ff5dfa21597f00b23cabe16bbb5a153dc60bded0f716

data/CHANGELOG.md

@@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning].
 
 ## [Unreleased]
 
+## [v1.1.1] - 2020-10-21
+
+### Fixed
+
+- [\#267](https://github.com/aaronmallen/activeinteractor/pull/267) Allow default attributes to propagate to
+  sibling/child interactors
+
 ## [v1.1.0] - 2020-10-04
 
 ### Added
@@ -212,7 +219,8 @@ and this project adheres to [Semantic Versioning].
 
 <!-- versions -->
 
-[Unreleased]: https://github.com/aaronmallen/activeinteractor/compare/v1.1.0...HEAD
+[Unreleased]: https://github.com/aaronmallen/activeinteractor/compare/v1.1.1...HEAD
+[v1.1.1]: https://github.com/aaronmallen/activeinteractor/compare/v1.1.0...v1.1.1
 [v1.1.0]: https://github.com/aaronmallen/activeinteractor/compare/v1.0.5...v1.1.0
 [v1.0.5]: https://github.com/aaronmallen/activeinteractor/compare/v1.0.4...v1.0.5
 [v1.0.4]: https://github.com/aaronmallen/activeinteractor/compare/v1.0.3...v1.0.4

data/lib/active_interactor/context/attributes.rb

@@ -79,7 +79,7 @@ module ActiveInteractor
       def []=(name, value)
         public_send("#{name}=", value)
 
-        super
+        super unless @table.nil?
       end
 
       # Get values defined on the instance of {Base context} whose keys are defined on the {Base context} class'
@@ -132,7 +132,7 @@ module ActiveInteractor
         copy_flags!(context)
 
         merged_context_attributes(context).each_pair do |key, value|
-          public_send("#{key}=", value) unless value.nil?
+          self[key] = value unless value.nil?
         end
         self
       end
@@ -170,8 +170,8 @@ module ActiveInteractor
       def merge_attribute_values(context)
         return unless context
 
-        context.each_pair do |key, value|
-          public_send("#{key}=", value)
+        attributes.compact.merge(context).each_pair do |key, value|
+          self[key] = value
         end
       end
     end

data/lib/active_interactor/version.rb

@@ -3,5 +3,5 @@
 module ActiveInteractor
   # The ActiveInteractor version
   # @return [String] the ActiveInteractor version
-  VERSION = '1.1.0'
+  VERSION = '1.1.1'
 end

data/spec/integration/a_basic_organizer_spec.rb

@@ -224,5 +224,124 @@ RSpec.describe 'A basic organizer', type: :integration do
         end
       end
     end
+
+    context 'when passing default attributes on the organizer and its interactors' do
+      let!(:test_organizer_context_class) do
+        build_context('TestOrganizerContext') do
+          attribute :foo
+          attribute :baz
+          attribute :zoo, default: 'zoo'
+          attribute :taz, default: 'taz0'
+        end
+      end
+
+      let!(:test_interactor_3_context_class) do
+        build_context('TestInteractor3Context') do
+          attribute :foo
+          attribute :bar, default: 'bar'
+          attribute :baz, default: 'baz'
+          attribute :zoo
+          attribute :taz, default: 'taz3'
+        end
+      end
+
+      let!(:test_interactor_4_context_class) do
+        build_context('TestInteractor4Context') do
+          attribute :foo
+          attribute :bar, default: 'bar'
+          attribute :baz
+        end
+      end
+
+      let!(:test_interactor_3) do
+        build_interactor('TestInteractor3') do
+          def perform
+            context.bar = 'bar'
+            context.taz_is_set_at_3 = (context.taz == 'taz')
+            context.baz_is_set_at_3 = (context.baz == 'baz')
+            context.zoo_is_set_at_3 = (context.zoo == 'zoo')
+          end
+        end
+      end
+
+      let!(:test_interactor_4) do
+        build_interactor('TestInteractor4') do
+          def perform
+            context.taz_is_set_at_4 = (context.taz == 'taz')
+            context.baz_is_set_at_4 = (context.baz == 'baz')
+            context.zoo_is_set_at_4 = (context.zoo == 'zoo')
+          end
+        end
+      end
+
+      let!(:interactor_class) do
+        build_organizer('TestOrganizer') do
+          organize TestInteractor3, TestInteractor4
+        end
+      end
+
+      describe '.context_class' do
+        describe 'TestOrganizer' do
+          subject { interactor_class.context_class }
+
+          it { is_expected.to eq TestOrganizerContext }
+          it { is_expected.to be < ActiveInteractor::Context::Base }
+        end
+
+        describe 'TestInteractor3' do
+          subject { test_interactor_3.context_class }
+
+          it { is_expected.to eq TestInteractor3Context }
+          it { is_expected.to be < ActiveInteractor::Context::Base }
+        end
+
+        describe 'TestInteractor4' do
+          subject { test_interactor_4.context_class }
+
+          it { is_expected.to eq TestInteractor4Context }
+          it { is_expected.to be < ActiveInteractor::Context::Base }
+        end
+      end
+
+      describe '.perform' do
+        subject(:result) { interactor_class.perform(context_attributes) }
+
+        context 'when inputs are not defined' do
+          let(:context_attributes) { {} }
+
+          it { is_expected.to have_attributes(foo: nil, bar: 'bar', baz: 'baz') }
+        end
+
+        context 'when [:foo] is defined' do
+          let(:context_attributes) { { foo: 'foo' } }
+
+          it { is_expected.to have_attributes(foo: 'foo', bar: 'bar', baz: 'baz') }
+        end
+
+        context 'when [:taz] is defined' do
+          let(:context_attributes) { { taz: 'taz' } }
+
+          it { is_expected.to have_attributes(taz: 'taz', taz_is_set_at_3: true, taz_is_set_at_4: true) }
+        end
+
+        context 'when [:bar] is nil' do
+          let(:context_attributes) { { bar: nil } }
+
+          it { is_expected.to have_attributes(foo: nil, bar: 'bar', baz: 'baz') }
+        end
+
+        context 'when [:baz] is nil' do
+          let(:context_attributes) { {} }
+
+          it { is_expected.to have_attributes(baz: 'baz', baz_is_set_at_3: true, baz_is_set_at_4: true) }
+        end
+
+        context 'when [:zoo] is nil' do
+          let(:context_attributes) { {} }
+
+          it { is_expected.to have_attributes(zoo: 'zoo', zoo_is_set_at_3: true, zoo_is_set_at_4: true) }
+        end
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activeinteractor
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Aaron Allen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-10-04 00:00:00.000000000 Z
+date: 2020-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -203,10 +203,10 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/aaronmallen/activeinteractor/issues
-  changelog_uri: https://github.com/aaronmallen/activeinteractor/blob/v1.1.0/CHANGELOG.md
-  documentation_uri: https://www.rubydoc.info/gems/activeinteractor/1.1.0
+  changelog_uri: https://github.com/aaronmallen/activeinteractor/blob/v1.1.1/CHANGELOG.md
+  documentation_uri: https://www.rubydoc.info/gems/activeinteractor/1.1.1
   hompage_uri: https://github.com/aaronmallen/activeinteractor
-  source_code_uri: https://github.com/aaronmallen/activeinteractor/tree/v1.1.0
+  source_code_uri: https://github.com/aaronmallen/activeinteractor/tree/v1.1.1
   wiki_uri: https://github.com/aaronmallen/activeinteractor/wiki
 post_install_message: 
 rdoc_options: []
@@ -229,42 +229,42 @@ specification_version: 4
 summary: Ruby interactors with ActiveModel::Validations
 test_files:
 - spec/support/shared_examples/a_class_that_extends_active_interactor_models_example.rb
-- spec/support/shared_examples/a_class_with_interactor_methods_example.rb
 - spec/support/shared_examples/a_class_with_interactor_context_methods_example.rb
-- spec/support/shared_examples/a_class_with_organizer_callback_methods_example.rb
 - spec/support/shared_examples/a_class_with_interactor_callback_methods_example.rb
+- spec/support/shared_examples/a_class_with_interactor_methods_example.rb
+- spec/support/shared_examples/a_class_with_organizer_callback_methods_example.rb
 - spec/support/spec_helpers.rb
 - spec/support/helpers/factories.rb
-- spec/integration/an_organizer_with_options_callbacks_spec.rb
-- spec/integration/an_interactor_with_validations_on_calling_spec.rb
-- spec/integration/an_organizer_with_failing_nested_organizer_spec.rb
-- spec/integration/a_basic_interactor_spec.rb
-- spec/integration/a_basic_organizer_spec.rb
-- spec/integration/an_organizer_with_conditionally_organized_interactors_spec.rb
+- spec/active_interactor/organizer/interactor_interface_spec.rb
+- spec/active_interactor/organizer/interactor_interface_collection_spec.rb
+- spec/active_interactor/organizer/base_spec.rb
+- spec/active_interactor/config_spec.rb
+- spec/active_interactor/interactor/perform/options_spec.rb
+- spec/active_interactor/interactor/worker_spec.rb
+- spec/active_interactor/error_spec.rb
+- spec/active_interactor/base_spec.rb
+- spec/active_interactor/context/base_spec.rb
 - spec/integration/an_interactor_with_validations_spec.rb
+- spec/integration/a_basic_interactor_spec.rb
+- spec/integration/active_record_integration_spec.rb
+- spec/integration/an_organizer_performing_in_parallel_spec.rb
+- spec/integration/an_organizer_with_failing_nested_organizer_spec.rb
+- spec/integration/an_interactor_with_after_context_validation_callbacks_spec.rb
 - spec/integration/an_interactor_with_an_existing_context_class_spec.rb
-- spec/integration/an_organizer_with_around_each_callbacks_spec.rb
-- spec/integration/an_interactor_with_validations_on_called_spec.rb
-- spec/integration/an_interactor_with_around_perform_callbacks_spec.rb
 - spec/integration/an_interactor_with_before_rollback_callbacks_spec.rb
-- spec/integration/an_interactor_with_before_perform_callbacks_spec.rb
+- spec/integration/an_organizer_with_before_each_callbacks_spec.rb
+- spec/integration/an_interactor_with_validations_on_calling_spec.rb
+- spec/integration/an_organizer_with_options_callbacks_spec.rb
 - spec/integration/an_interactor_with_around_rollback_callbacks_spec.rb
+- spec/integration/an_interactor_with_validations_on_called_spec.rb
 - spec/integration/an_interactor_with_after_perform_callbacks_spec.rb
-- spec/integration/an_interactor_with_after_context_validation_callbacks_spec.rb
-- spec/integration/an_organizer_with_after_each_callbacks_spec.rb
-- spec/integration/active_record_integration_spec.rb
 - spec/integration/a_failing_interactor_spec.rb
-- spec/integration/an_organizer_with_before_each_callbacks_spec.rb
-- spec/integration/an_organizer_performing_in_parallel_spec.rb
+- spec/integration/an_organizer_with_conditionally_organized_interactors_spec.rb
+- spec/integration/an_interactor_with_around_perform_callbacks_spec.rb
+- spec/integration/an_organizer_with_around_each_callbacks_spec.rb
 - spec/integration/an_interactor_with_after_rollback_callbacks_spec.rb
-- spec/active_interactor/interactor/worker_spec.rb
-- spec/active_interactor/interactor/perform/options_spec.rb
-- spec/active_interactor/context/base_spec.rb
-- spec/active_interactor/config_spec.rb
-- spec/active_interactor/error_spec.rb
-- spec/active_interactor/base_spec.rb
-- spec/active_interactor/organizer/interactor_interface_collection_spec.rb
-- spec/active_interactor/organizer/base_spec.rb
-- spec/active_interactor/organizer/interactor_interface_spec.rb
+- spec/integration/an_organizer_with_after_each_callbacks_spec.rb
+- spec/integration/an_interactor_with_before_perform_callbacks_spec.rb
+- spec/integration/a_basic_organizer_spec.rb
 - spec/spec_helper.rb
 - spec/active_interactor_spec.rb