activeadmin_reorderable 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b0cdf7b48ce9d9b388c2140c1278d5626386139523b4d5505a1a2b4186c9b401
-  data.tar.gz: 43d51f9f8abcd5519224855536a737cfb2bc6b5e9f6b607babbd36ac264809bd
+  metadata.gz: 432b1bf79ccce9af126f1d991c7a00a926a80d2e6aa3544c93650a2860591628
+  data.tar.gz: 71d1daeb82bb9c9631c5e947a98437478b6c347d0e55846c84b5d653dbe02aaf
 SHA512:
-  metadata.gz: 6ad7ef181efc4d8cb1b3b636ec14a12adef97efd0c6ed1a33e8c52dea4cb4ce18438979a4f42cd67fe018fbd1afc9a33e20b69eaff8fd21cfe2d13d53a701601
-  data.tar.gz: 52bcb5b1dc53133d2e5cb39b6d7c4c4bbfe562f2061a3cc49f4a76df9aa662613650434dff80368a1c347999318c6a1bd9ef09f65ab906374e08398362df398a
+  metadata.gz: 9969c5d1b405bbc2f00530a08b97c182a35460295f3929befc05a6288756fc908df1a8e2ad9ce9d281667b65d3bd698452248cfe712cce94fb563a0f3ba1b348
+  data.tar.gz: 9778aaf69204141275c167df461034b75c40033c9ab91b92db45d1a00138f573251090d0b40f5a5934e43d6dbe45e5befca8a3c28d05e9b47f7313bdfbe5e89a

data/README.md

@@ -8,6 +8,14 @@ Drag and drop to reorder your ActiveAdmin tables.
 Your resource classes must respond to `insert_at` ala the [`acts_as_list`](https://github.com/swanandp/acts_as_list) API. You don't need to use `acts_as_list`, but if you don't, make sure to define `insert_at`.
 
 ## Installation
+### Importmap
+
+- Add `gem 'activeadmin_reorderable'` to `Gemfile` and run `bundle install`
+- Add `import "activeadmin_reorderable"` to JS entrypoint (a JS file that is included for activeadmin)
+- Add `@import "activeadmin_reorderable";` in your CSS style file
+
+NOTE: no need to pin the import in your application. That's handled internally by the gem.
+
 ### Sprockets
 - Add `gem 'activeadmin_reorderable'` to `Gemfile` and run `bundle install`
 - Add `#= require activeadmin_reorderable` to `app/assets/javascripts/active_admin.js.coffee`
@@ -61,31 +69,4 @@ end
 
 ## Contributing
 
-1. Fork it ( https://github.com/[my-github-username]/activeadmin_reorderable/fork )
-2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am "Add some feature"`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create a new Pull Request
-
-### Issue and PR reviews
-
-Another way you can help is by reviewing issues, trying to reproduce bugs, and providing feedback on PRs.
-
-## Pushing a new version
-
-First, you must be authorized on both rubygems.org and npmjs.com. Then:
-
-Update the ruby gem:
-- Update the version in `lib/activeadmin_reorderable/version.rb`
-- `gem build activeadmin_reorderable.gemspec`
-- `gem push activeadmin_reorderable-X.Y.Z.gem`
-
-Update the npm package:
-- Update the version in `package.json`
-- `npm publish`
-
-Tag the version in git:
-- `git tag X.Y.Z`
-- `git push origin X.Y.Z`
-
-Update the changelog
+See [CONTRIBUTING.md](./CONTRIBUTING.md)

data/app/assets/javascripts/activeadmin_reorderable.js

@@ -59,7 +59,10 @@ const updateEvenOddClasses = (row, index) => {
 }
 
 const updatePositionText = (row, index) => {
-  row.querySelector(".position").textContent = index
+  const position = row.querySelector(".position")
+  if (position) {
+    position.textContent = index
+  }
 }
 
 const updateBackend = (url, rowIndex) => {
@@ -79,7 +82,7 @@ const updateBackend = (url, rowIndex) => {
 }
 
 document.addEventListener("DOMContentLoaded", () => {
-  document.querySelectorAll(".aa-reorderable").forEach((table) => {
+  document.querySelectorAll("table.aa-reorderable").forEach((table) => {
     setupReorderable({
       table,
       onUpdate: (row) => {

data/lib/activeadmin_reorderable/engine.rb

@@ -2,5 +2,12 @@ require 'rails/engine'
 
 module ActiveadminReorderable
   class Engine < Rails::Engine
+    initializer "activeadmin_reorderable.importmap", before: "importmap" do |app|
+      # Skip if importmap-rails is not installed
+      next unless app.config.respond_to?(:importmap)
+
+      app.config.importmap.paths << Engine.root.join("config/importmap.rb")
+      app.config.importmap.cache_sweepers << Engine.root.join("app/assets/javascripts")
+    end
   end
 end

data/lib/activeadmin_reorderable/version.rb

@@ -1,3 +1,3 @@
 module ActiveadminReorderable
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "activeadmin_reorderable",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "description": "Drag and drop to reorder your ActiveAdmin tables.",
   "main": "app/assets/javascripts/activeadmin_reorderable.js",
   "files": [

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activeadmin_reorderable
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Derek Kniffin
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-07-11 00:00:00.000000000 Z
+date: 2024-07-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeadmin
@@ -158,20 +158,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '4.10'
-- !ruby/object:Gem::Dependency
-  name: site_prism
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement