activeadmin_favorites 0.1.8 → 0.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1c6a1ca67243ef7bcf12defce94d288b0afca716511a3a04f6326ecce641e784
-  data.tar.gz: 0150e3932226fe8890a22dac1889d57f8e74fb868928ec8027763a8e07acfc0c
+  metadata.gz: 3509bb00158d9a807b7ff01e637302b061ae0a30b6e3adf2ca985c4c23c2376c
+  data.tar.gz: '0876219df16bdf67f790adb9541b55677a2938eef7ad81e006951aad6e875905'
 SHA512:
-  metadata.gz: 520cd1dec8f6f362b90163d65f8a3d3231f603481a7f95354600cd455cde6fbe37eaaae3bd5b3f26e90cae6bd784075b4dfb4432b4f43747cde70f25ff2ba7fe
-  data.tar.gz: 510d6d7d6b0bc26017bca1d6ff576ba3e835f95215dba7a299ca810d40ea44d541f88e21526449a575f27b41535b1fb1e1e76a5902d9947223a132d3d5984d04
+  metadata.gz: ed84a8a3710e2b13a3509afec58f33ad49b8d050c290ba8375029bc6ef28bdc491d4887d66b93ac464f1604a25f41ee7bf880e5f7a62c043156a662afd1b9d82
+  data.tar.gz: d368aef63d1250df6627bafb17d6956082473873dcd3a2a3a2f27b525c7a69eccedd1cbc9ef2604b8af88725aa3b40803ac238b933b6aa887dd13188d370f1c0

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # CHANGELOG
 
+## 0.1.9 (2026-11-04)
+
+- Show Add to favorites / Edit favorite as a star icon button on index action rows (accessible name only; filled when an owned favorite matches).
+- Hide the Personalize page cog when the page lens catalog is empty; keep the favorites hub at `/admin/favorites`.
+- CI: refresh lockfiles for current advisories (`loofah` 2.25.3, `nokogiri` 1.19.7, `rack` 3.2.8, `rails-html-sanitizer` 1.7.2, `sqlite3` 2.10.2) and raise the sqlite3 development floor.
+
 ## 0.1.8 (2026-10-29)
 
 - Fix Active Admin view-path detection so sibling gems such as `activeadmin-command_palette` are not treated as Active Admin. Prefer `ActiveAdmin::Engine.root`, with a fallback that requires a digit version segment after `activeadmin-`.

data/README.md

@@ -108,11 +108,11 @@ Catalog entries are discovered at render time from ActiveAdmin columns, filters,
 
 The gem installs:
 
-- **Add to favorites** on index pages (saved filters)
-- **Personalize page** cogwheel on index and show pages
-- **Favorites** hub with type tabs (all, filters, lens, combined)
+- **Add to favorites** star icon on index pages (outline when unsaved, filled when an owned filter favorite matches the current query; label is the accessible name only)
+- **Personalize page** cogwheel on index and show pages (hidden when the page lens catalog is empty)
+- **Favorites** hub at `/admin/favorites` with type tabs (all, filters, lens, combined)
 
-Defaults are stored in `active_admin_view_lens_defaults`. Named lens favorites and combined favorites use `admin_favorites.layout`.
+Defaults are stored in `active_admin_view_lens_defaults`. Named lens favorites and combined favorites use `admin_favorites.layout`. The favorites hub stays reachable from `/admin/favorites` and from personalization menus on pages that still have catalog entries.
 
 ## Development
 

data/activeadmin_favorites.gemspec

@@ -55,7 +55,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake", "~> 13"
   spec.add_development_dependency "rspec", "~> 3"
   spec.add_development_dependency "rspec-rails", ">= 6"
-  spec.add_development_dependency "sqlite3", ">= 2.9.6"
+  spec.add_development_dependency "sqlite3", ">= 2.10.2"
   spec.add_development_dependency "rubocop-rails", "~> 2.34"
   spec.add_development_dependency "rubocop-rspec", "~> 3.8"
   spec.add_development_dependency "rubocop-thread_safety", "~> 0.7"

data/app/assets/controllers/activeadmin_favorites/personalization_controller.js

@@ -18,6 +18,19 @@ export default class extends Controller {
 
   connect() {
     this.catalogLoaded = false
+    this.boundApplyEmptyCatalogVisibility = () => this.applyEmptyCatalogVisibility()
+    // Catalog JSON is rendered at the end of the resource page; wait for full parse.
+    if (document.readyState === "loading") {
+      document.addEventListener("DOMContentLoaded", this.boundApplyEmptyCatalogVisibility, {once: true})
+    } else {
+      this.applyEmptyCatalogVisibility()
+    }
+    document.addEventListener("turbo:load", this.boundApplyEmptyCatalogVisibility)
+  }
+
+  disconnect() {
+    document.removeEventListener("DOMContentLoaded", this.boundApplyEmptyCatalogVisibility)
+    document.removeEventListener("turbo:load", this.boundApplyEmptyCatalogVisibility)
   }
 
   prepareMenu() {
@@ -40,6 +53,11 @@ export default class extends Controller {
     }
   }
 
+  applyEmptyCatalogVisibility() {
+    // Start hidden in markup; reveal only when the deferred catalog has entries.
+    this.element.classList.toggle("hidden", this.catalogEntries().length === 0)
+  }
+
   escapeHtml(value) {
     return String(value)
       .replaceAll("&", "&")
@@ -60,9 +78,11 @@ export default class extends Controller {
     if (groups.length === 0) {
       this.catalogGroupsTarget.innerHTML =
         `<p class="favorites-personalization-menu__empty">${this.escapeHtml(this.emptyCatalogLabelValue)}</p>`
+      this.applyEmptyCatalogVisibility()
       return
     }
 
+    this.applyEmptyCatalogVisibility()
     this.catalogGroupsTarget.innerHTML = groups.map((group) => {
       const label = this.escapeHtml(this.groupLabelsValue[group] || group.replace(/_/g, " "))
       const items = grouped[group].map((entry) => {

data/app/views/active_admin/favorites/_filter_favorite_button.html.erb

@@ -0,0 +1,18 @@
+<%= link_to(
+  destination,
+  class: "action-item-button inline-flex items-center justify-center",
+  aria: {label: label},
+  data: {testid: "filter-favorite", favorited: favorited},
+  title: label
+) do %>
+  <% if favorited %>
+    <svg class="w-5 h-5" aria-hidden="true" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" fill="currentColor">
+      <path fill-rule="evenodd" d="M10.788 3.21c.448-1.077 1.976-1.077 2.424 0l2.082 5.006 5.404.434c1.164.093 1.636 1.545.749 2.305l-4.117 3.527 1.257 5.273c.271 1.136-.964 2.033-1.96 1.425L12 18.354 7.373 21.18c-.996.608-2.231-.29-1.96-1.425l1.257-5.273-4.117-3.527c-.887-.76-.415-2.212.749-2.305l5.404-.434 2.082-5.005Z" clip-rule="evenodd" />
+    </svg>
+  <% else %>
+    <svg class="w-5 h-5" aria-hidden="true" xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24" stroke-width="1.5" stroke="currentColor">
+      <path stroke-linecap="round" stroke-linejoin="round" d="M11.48 3.499a.562.562 0 0 1 1.04 0l2.125 5.111a.563.563 0 0 0 .475.345l5.518.442c.499.04.701.663.321.988l-4.204 3.602a.563.563 0 0 0-.182.557l1.285 5.385a.562.562 0 0 1-.84.61l-4.725-2.885a.562.562 0 0 0-.586 0L6.982 20.54a.562.562 0 0 1-.84-.61l1.285-5.386a.562.562 0 0 0-.182-.557l-4.204-3.602a.562.562 0 0 1 .321-.988l5.518-.442a.563.563 0 0 0 .475-.345L11.48 3.5Z" />
+    </svg>
+  <% end %>
+  <span class="sr-only"><%= label %></span>
+<% end %>

data/app/views/active_admin/favorites/_personalization_trigger.html.erb

@@ -7,7 +7,7 @@
   menu_id = "personalization-menu-#{resource_key}-#{action_name}"
 %>
 <div
-  class="relative"
+  class="relative hidden"
   data-controller="<%= stimulus_controller %>"
   data-<%= stimulus_controller %>-resource-key-value="<%= resource_key %>"
   data-<%= stimulus_controller %>-action-name-value="<%= action_name %>"
@@ -26,6 +26,7 @@
     show_rows: t("active_admin.favorites.groups.show_rows", default: "Rows")
   }.to_json %>"
   data-<%= stimulus_controller %>-empty-catalog-label-value="<%= t("active_admin.favorites.no_personalization_items") %>"
+  data-testid="page-personalization"
 >
   <button
     type="button"

data/lib/activeadmin/favorites/install.rb

@@ -58,6 +58,7 @@ module ActiveAdmin
         config.add_action_item(FILTER_FAVOURITE_ACTION, only: :index, priority: 5) do
           sanitized_query = Favorite.sanitize_query_string(request.query_string)
           user = send(ActiveAdmin::Favorites.config.current_user_method)
+          favorited = false
 
           if sanitized_query.blank?
             label = I18n.t("active_admin.favorites.add_favorite")
@@ -74,6 +75,7 @@ module ActiveAdmin
             }
             lookup[ActiveAdmin::Favorites.config.user_foreign_key] = user.id
             owned_existing = Favorite.filters_kind.find_by(lookup)
+            favorited = owned_existing.present?
 
             label = if owned_existing
               I18n.t("active_admin.favorites.edit_favorite")
@@ -93,7 +95,8 @@ module ActiveAdmin
             end
           end
 
-          link_to label, destination, class: "action-item-button"
+          render partial: "active_admin/favorites/filter_favorite_button",
+            locals: {label: label, destination: destination, favorited: favorited}
         end
       end
 

data/lib/activeadmin/favorites/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveAdmin
   module Favorites
-    VERSION = "0.1.8"
+    VERSION = "0.1.9"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activeadmin_favorites
 version: !ruby/object:Gem::Version
-  version: 0.1.8
+  version: 0.1.9
 platform: ruby
 authors:
 - Andrei Makarov
@@ -189,14 +189,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.9.6
+        version: 2.10.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.9.6
+        version: 2.10.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
@@ -355,6 +355,7 @@ files:
 - app/models/active_admin/favorites/lens_favorite.rb
 - app/models/active_admin/favorites/view_lens/layout.rb
 - app/models/active_admin/favorites/view_lens_default.rb
+- app/views/active_admin/favorites/_filter_favorite_button.html.erb
 - app/views/active_admin/favorites/_lens_catalog_data.html.erb
 - app/views/active_admin/favorites/_macro_fields.html.erb
 - app/views/active_admin/favorites/_personalization_trigger.html.erb