activeadmin 3.5.1 → 3.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 11f17bd91f5f20e866dc189cbf0f191e5fbdf2ad192c00db190ca3538f852dd1
-  data.tar.gz: 816caf26faae1c3b204266d2b8ec6e4b80ee23efffe75657baa52ccadb60c383
+  metadata.gz: be95e31901e8d39cce8d91294688462aab2b0de748a1e42ab78225a80cf3691c
+  data.tar.gz: 627f265f8ff2cafbae08e8e620e6a838c724c60bb3ac1d25327485587cade73f
 SHA512:
-  metadata.gz: 45b21c4efe22df18b7a6a937973bc80280147311cd6ef8b4eed2e2ead031505bbe5418933952c8ca1d72c1d6f6cb99ad0012447cd08c8a86ff8f86680b136904
-  data.tar.gz: d516429f775372f7e55be58d9dcd6093b6be85a79f9c0de3819b3a5b41acb3adce80f788687655b05dd69f44d35ce695d06496a8a7b2a1f708e6dec3261649b3
+  metadata.gz: 7a4382f75f12aa918e5a027e9f56244b9b957fc1efcce1b20faae4005406c90f328857d96ba828a9b5b4f55e364d31a529fcb8c626eeece5a95b7458eab6a795
+  data.tar.gz: 8f52969b691a64f6ebe7a8401fe8a5f39fc3cb745bd73b5754f6071583fd450a9d2cd4568cc64f7ae51aa536eba10e57173dffbb9c1d554137cf7d423a3ac9db

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## Unreleased
 
+## 3.5.2 [☰](https://github.com/activeadmin/activeadmin/compare/v3.5.1..v3.5.2)
+
+### Bug Fixes
+
+* Backport run update_resource inside a transaction to avoid autosaving relationships through assign_attributes when the record is invalid [#9064] by [@mgrunberg] and [@deivid-rodriguez]
+
 ## 3.5.1 [☰](https://github.com/activeadmin/activeadmin/compare/v3.5.0..v3.5.1)
 
 ### Bug Fixes
@@ -1010,6 +1016,7 @@ Please check [0-6-stable] for previous changes.
 [#8964]: https://github.com/activeadmin/activeadmin/pull/8964
 [#8965]: https://github.com/activeadmin/activeadmin/pull/8965
 [#8978]: https://github.com/activeadmin/activeadmin/pull/8978
+[#9064]: https://github.com/activeadmin/activeadmin/pull/9064
 
 [@1000ship]: https://github.com/1000ship
 [@5t111111]: https://github.com/5t111111

data/lib/active_admin/resource_controller/data_access.rb

@@ -168,11 +168,16 @@ module ActiveAdmin
       #
       # @return [void]
       def update_resource(object, attributes)
-        object = assign_attributes(object, attributes)
+        status = nil
+        ActiveRecord::Base.transaction do
+          object = assign_attributes(object, attributes)
 
-        run_update_callbacks object do
-          save_resource(object)
+          run_update_callbacks object do
+            status = save_resource(object)
+            raise ActiveRecord::Rollback unless status
+          end
         end
+        status
       end
 
       # Destroys an object from the database and calls appropriate callbacks.

data/lib/active_admin/router.rb

@@ -68,7 +68,7 @@ module ActiveAdmin
       router.get "/#{page}", to: "#{page}#index"
       config.page_actions.each do |action|
         Array.wrap(action.http_verb).each do |verb|
-          build_route(verb, "/#{page}/#{action.name}" => "#{page}##{action.name}")
+          build_route(verb, "/#{page}/#{action.name}", to: "#{page}##{action.name}")
         end
       end
     end

data/lib/active_admin/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module ActiveAdmin
-  VERSION = "3.5.1"
+  VERSION = "3.5.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activeadmin
 version: !ruby/object:Gem::Version
-  version: 3.5.1
+  version: 3.5.2
 platform: ruby
 authors:
 - Charles Maresh
@@ -527,7 +527,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.6
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Active Admin is a Ruby on Rails plugin for generating administration style
   interfaces. It abstracts common business application patterns to make it simple