activeadmin 1.4.2 → 1.4.3
Sign up to get free protection for your applications and to get access to all the features.
Potentially problematic release.
This version of activeadmin might be problematic. Click here for more details.
- checksums.yaml +4 -4
- data/.circleci/config.yml +112 -7
- data/.gitignore +1 -31
- data/.rubocop.yml +5 -0
- data/.simplecov +1 -3
- data/CHANGELOG.md +146 -136
- data/CONTRIBUTING.md +7 -1
- data/Gemfile +21 -1
- data/Gemfile.common +8 -35
- data/Gemfile.lock +67 -65
- data/README.md +3 -3
- data/Rakefile +11 -10
- data/gemfiles/rails_42.gemfile +1 -1
- data/gemfiles/rails_42.gemfile.lock +36 -107
- data/gemfiles/rails_50.gemfile +1 -1
- data/gemfiles/rails_50.gemfile.lock +39 -110
- data/gemfiles/rails_51.gemfile +1 -1
- data/gemfiles/rails_51.gemfile.lock +39 -109
- data/lib/active_admin/batch_actions/controller.rb +1 -1
- data/lib/active_admin/resource_controller/scoping.rb +1 -1
- data/lib/active_admin/version.rb +1 -1
- data/lib/active_admin/view_helpers/method_or_proc_helper.rb +1 -0
- data/tasks/application_generator.rb +4 -2
- data/tasks/gemfiles.rake +1 -1
- data/tasks/lint.rake +2 -2
- data/tasks/release.rake +6 -0
- data/tasks/test.rake +4 -5
- metadata +3 -3
- data/codecov.yml +0 -25
checksums.yaml
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
---
|
2
2
|
SHA256:
|
3
|
-
metadata.gz:
|
4
|
-
data.tar.gz:
|
3
|
+
metadata.gz: 29d7c95a552afce6991952dc4d0e4006b2d354172ad46e897ccb4765e4d04f3f
|
4
|
+
data.tar.gz: 319f648ea6256a882a18f683f6dcc770f7b2ab54fdfd98e2b0a35fd511a34dc2
|
5
5
|
SHA512:
|
6
|
-
metadata.gz:
|
7
|
-
data.tar.gz:
|
6
|
+
metadata.gz: f73c6de3272fc66e167e93f99392ad2bd1d78629635c3d7f58adc1171e2d7df9bf2cee8de5f2e701d8d49eaa29f945f46285c5493de73a377982801014447378
|
7
|
+
data.tar.gz: 4dd517e49cd37d1469e6d530d7677d1a8a1b6ee8069dea3f1c27e1c764c39b2fe67790ecc3f1e37e974cfb51967dcaf61e8a8fe811bf8ac79a0002703f6cc0ed
|
data/.circleci/config.yml
CHANGED
@@ -20,7 +20,7 @@ version: 2.1
|
|
20
20
|
.install_dependencies: &install_dependencies
|
21
21
|
run:
|
22
22
|
name: Install dependencies
|
23
|
-
command: bundle install --
|
23
|
+
command: bundle install --path /home/circleci/project/vendor/bundle --retry 3 --jobs 3
|
24
24
|
|
25
25
|
.install_chromedriver: &install_chromedriver
|
26
26
|
run:
|
@@ -38,6 +38,28 @@ version: 2.1
|
|
38
38
|
name: Create test app
|
39
39
|
command: PARALLEL_TEST_PROCESSORS=4 bundle exec rake setup
|
40
40
|
|
41
|
+
.restore_coverage: &restore_coverage
|
42
|
+
attach_workspace:
|
43
|
+
at: tmp
|
44
|
+
|
45
|
+
.format_coverage: &format_coverage
|
46
|
+
run:
|
47
|
+
name: Format coverage
|
48
|
+
command: tmp/test-reporter format-coverage --input-type simplecov --output tmp/codeclimate.$CIRCLE_JOB.json
|
49
|
+
|
50
|
+
.save_coverage: &save_coverage
|
51
|
+
persist_to_workspace:
|
52
|
+
root: tmp
|
53
|
+
paths:
|
54
|
+
- codeclimate.*.json
|
55
|
+
|
56
|
+
.submit_coverage: &submit_coverage
|
57
|
+
run:
|
58
|
+
name: Upload coverage results to Code Climate
|
59
|
+
command: |
|
60
|
+
tmp/test-reporter sum-coverage tmp/codeclimate.*.json --parts 21 --output tmp/codeclimate.total.json
|
61
|
+
tmp/test-reporter upload-coverage --input tmp/codeclimate.total.json
|
62
|
+
|
41
63
|
.save_test_app_to_workspace: &save_test_app_to_workspace
|
42
64
|
persist_to_workspace:
|
43
65
|
root: spec/rails
|
@@ -76,6 +98,11 @@ version: 2.1
|
|
76
98
|
name: Run lints
|
77
99
|
command: bundle exec rake lint
|
78
100
|
|
101
|
+
.run_bug_report_template: &run_bug_report_template
|
102
|
+
run:
|
103
|
+
name: Run bug report template
|
104
|
+
command: ACTIVE_ADMIN_PATH=. ruby lib/bug_report_templates/active_admin_master.rb
|
105
|
+
|
79
106
|
.test_steps: &test_steps
|
80
107
|
- checkout
|
81
108
|
- *install_bundler
|
@@ -86,7 +113,10 @@ version: 2.1
|
|
86
113
|
- *save_cache
|
87
114
|
- *restore_test_app_from_workspace
|
88
115
|
- *restore_test_times
|
116
|
+
- *restore_coverage
|
89
117
|
- *run_tests
|
118
|
+
- *format_coverage
|
119
|
+
- *save_coverage
|
90
120
|
- *save_test_times
|
91
121
|
|
92
122
|
.test_app_steps: &test_app_steps
|
@@ -100,6 +130,33 @@ version: 2.1
|
|
100
130
|
- *save_test_app_to_workspace
|
101
131
|
|
102
132
|
jobs:
|
133
|
+
setup_coverage:
|
134
|
+
docker:
|
135
|
+
- image: circleci/ruby:2.5.3
|
136
|
+
|
137
|
+
steps:
|
138
|
+
- run:
|
139
|
+
name: Download Code Climate test-reporter
|
140
|
+
command: |
|
141
|
+
mkdir tmp
|
142
|
+
curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-0.6.3-linux-amd64 > tmp/test-reporter
|
143
|
+
chmod +x tmp/test-reporter
|
144
|
+
|
145
|
+
- persist_to_workspace:
|
146
|
+
root: tmp
|
147
|
+
paths:
|
148
|
+
- test-reporter
|
149
|
+
|
150
|
+
upload_coverage:
|
151
|
+
docker:
|
152
|
+
- image: circleci/ruby:2.5.3
|
153
|
+
environment:
|
154
|
+
CC_TEST_REPORTER_ID: 8d5fcf7abea6d56c625104a9d1a81140a588a7f546f4fa9de9bc6ffc8feaaf70
|
155
|
+
|
156
|
+
steps:
|
157
|
+
- *restore_coverage
|
158
|
+
- *submit_coverage
|
159
|
+
|
103
160
|
testapp42:
|
104
161
|
docker:
|
105
162
|
- image: circleci/ruby:2.5.3-node
|
@@ -142,7 +199,7 @@ jobs:
|
|
142
199
|
|
143
200
|
lint_and_docs:
|
144
201
|
docker:
|
145
|
-
- image: circleci/ruby:2.5.3
|
202
|
+
- image: circleci/ruby:2.5.3-node
|
146
203
|
|
147
204
|
environment:
|
148
205
|
BUNDLE_GEMFILE: Gemfile
|
@@ -155,7 +212,11 @@ jobs:
|
|
155
212
|
- *install_dependencies
|
156
213
|
- *save_cache
|
157
214
|
- *generate_docs
|
215
|
+
- *restore_coverage
|
158
216
|
- *run_lints
|
217
|
+
- *run_bug_report_template
|
218
|
+
- *format_coverage
|
219
|
+
- *save_coverage
|
159
220
|
|
160
221
|
ruby23rails42:
|
161
222
|
docker:
|
@@ -379,12 +440,27 @@ workflows:
|
|
379
440
|
#
|
380
441
|
build:
|
381
442
|
jobs:
|
382
|
-
-
|
443
|
+
- setup_coverage
|
444
|
+
|
445
|
+
- lint_and_docs:
|
446
|
+
requires:
|
447
|
+
- setup_coverage
|
448
|
+
|
449
|
+
- testapp42:
|
450
|
+
requires:
|
451
|
+
- setup_coverage
|
452
|
+
|
453
|
+
- testapp50:
|
454
|
+
requires:
|
455
|
+
- setup_coverage
|
456
|
+
|
457
|
+
- testapp51:
|
458
|
+
requires:
|
459
|
+
- setup_coverage
|
383
460
|
|
384
|
-
-
|
385
|
-
|
386
|
-
|
387
|
-
- testapp52
|
461
|
+
- testapp52:
|
462
|
+
requires:
|
463
|
+
- setup_coverage
|
388
464
|
|
389
465
|
- ruby23rails42:
|
390
466
|
requires:
|
@@ -465,3 +541,32 @@ workflows:
|
|
465
541
|
- jruby92rails52:
|
466
542
|
requires:
|
467
543
|
- testapp52
|
544
|
+
|
545
|
+
- upload_coverage:
|
546
|
+
requires:
|
547
|
+
- lint_and_docs
|
548
|
+
|
549
|
+
- ruby23rails42
|
550
|
+
- ruby23rails50
|
551
|
+
- ruby23rails51
|
552
|
+
- ruby23rails52
|
553
|
+
|
554
|
+
- ruby24rails42
|
555
|
+
- ruby24rails50
|
556
|
+
- ruby24rails51
|
557
|
+
- ruby24rails52
|
558
|
+
|
559
|
+
- ruby25rails42
|
560
|
+
- ruby25rails50
|
561
|
+
- ruby25rails51
|
562
|
+
- ruby25rails52
|
563
|
+
|
564
|
+
- jruby91rails42
|
565
|
+
- jruby91rails50
|
566
|
+
- jruby91rails51
|
567
|
+
- jruby91rails52
|
568
|
+
|
569
|
+
- jruby92rails42
|
570
|
+
- jruby92rails50
|
571
|
+
- jruby92rails51
|
572
|
+
- jruby92rails52
|
data/.gitignore
CHANGED
@@ -1,46 +1,16 @@
|
|
1
|
-
## Mac
|
2
|
-
.DS_Store
|
3
|
-
|
4
|
-
## Windows
|
5
|
-
.Thumbs.db
|
6
|
-
|
7
|
-
## TextMate
|
8
|
-
*.tm_project
|
9
|
-
*.tmproj
|
10
|
-
tmtags
|
11
|
-
|
12
|
-
## Emacs
|
13
|
-
*~
|
14
|
-
\#*
|
15
|
-
.\#*
|
16
|
-
|
17
|
-
## Vim
|
18
|
-
*.swp
|
19
|
-
# IDEA / RUBYMINE
|
20
|
-
.idea
|
21
|
-
|
22
|
-
## RVM
|
23
|
-
.rvmrc
|
24
|
-
.ruby-version
|
25
|
-
.ruby-gemset
|
26
|
-
|
27
1
|
## Project (general)
|
28
|
-
tags
|
29
2
|
tmp
|
30
3
|
coverage
|
31
|
-
rdoc
|
32
|
-
doc
|
33
4
|
.yardoc
|
5
|
+
.ruby-version
|
34
6
|
pkg
|
35
7
|
|
36
8
|
## Project (specific)
|
37
9
|
.bundle
|
38
10
|
spec/rails
|
39
|
-
*.sqlite3-journal
|
40
11
|
.test-rails-apps
|
41
12
|
public
|
42
13
|
.rspec_failures
|
43
14
|
.rails-version
|
44
15
|
.rbenv-version
|
45
|
-
.localeapp/*
|
46
16
|
lib/bug_report_templates/tmp
|
data/.rubocop.yml
CHANGED
@@ -4,6 +4,8 @@ inherit_mode:
|
|
4
4
|
merge:
|
5
5
|
- Include
|
6
6
|
|
7
|
+
require: rubocop-rspec
|
8
|
+
|
7
9
|
AllCops:
|
8
10
|
DisabledByDefault: true
|
9
11
|
TargetRubyVersion: 2.3
|
@@ -48,6 +50,9 @@ Layout/EndOfLine:
|
|
48
50
|
Layout/ExtraSpacing:
|
49
51
|
Enabled: true
|
50
52
|
|
53
|
+
RSpec/HookArgument:
|
54
|
+
Enabled: true
|
55
|
+
|
51
56
|
Style/Encoding:
|
52
57
|
Enabled: true
|
53
58
|
|
data/.simplecov
CHANGED
data/CHANGELOG.md
CHANGED
@@ -2,17 +2,24 @@
|
|
2
2
|
|
3
3
|
## Unreleased
|
4
4
|
|
5
|
+
## 1.4.3 [☰](https://github.com/activeadmin/activeadmin/compare/v1.4.2...v1.4.3)
|
6
|
+
|
7
|
+
### Bug Fixes
|
8
|
+
|
9
|
+
* Fix `form` parameter to `batch_action` no longer accepting procs. [#5611] by [@buren] and [@deivid-rodriguez]
|
10
|
+
* Fix passing a proc to `scope_to`. [#5611] by [@deivid-rodriguez]
|
11
|
+
|
5
12
|
## 1.4.2 [☰](https://github.com/activeadmin/activeadmin/compare/v1.4.1...v1.4.2)
|
6
13
|
|
7
14
|
### Bug Fixes
|
8
15
|
|
9
|
-
* Fix `input_html` filter option evaluated only once. [#5376]
|
16
|
+
* Fix `input_html` filter option evaluated only once. [#5376] by [@kjeldahl]
|
10
17
|
|
11
18
|
## 1.4.1 [☰](https://github.com/activeadmin/activeadmin/compare/v1.4.0...v1.4.1)
|
12
19
|
|
13
20
|
### Bug Fixes
|
14
21
|
|
15
|
-
* Fix menu item link with method delete. [#5583]
|
22
|
+
* Fix menu item link with method delete. [#5583] by [@tiagotex]
|
16
23
|
|
17
24
|
## 1.4.0 [☰](https://github.com/activeadmin/activeadmin/compare/v1.3.1...v1.4.0)
|
18
25
|
|
@@ -20,38 +27,38 @@
|
|
20
27
|
|
21
28
|
#### Minor
|
22
29
|
|
23
|
-
* Add missing I18n for comments. [#5458]
|
24
|
-
* Fix batch_actions.delete_confirmation translation in zh-CN.yml. [#5453]
|
25
|
-
* Add some missing italian translations. [#5433]
|
26
|
-
* Enhance some chinese translations. [#5413]
|
27
|
-
* Add missing filter predicate translations to nb. [#5357]
|
28
|
-
* Add missing norwegian comment translations. [#5375]
|
29
|
-
* Add missing dutch translations. [#5368]
|
30
|
-
* Add missing german translations. [#5341]
|
31
|
-
* Add missing spanish translation. [#5336]
|
32
|
-
* Add from and to predicates for russian language. [#5330]
|
33
|
-
* Fix typo in finnish translation. [#5320]
|
34
|
-
* Add missing turkish translations. [#5295]
|
35
|
-
* Add missing chinese translations. [#5266]
|
36
|
-
* Allow proc label in datepicker input. [#5408]
|
37
|
-
* Add `group` attribute to scopes in order to show them in grouped. [#5359]
|
38
|
-
* Add missing polish translations and improve existing ones. [#5537]
|
39
|
-
* Add `priority` option to `action_item`. [#5334]
|
30
|
+
* Add missing I18n for comments. [#5458], [#5461] by [@mauriciopasquier]
|
31
|
+
* Fix batch_actions.delete_confirmation translation in zh-CN.yml. [#5453] by [@ShallmentMo]
|
32
|
+
* Add some missing italian translations. [#5433] by [@stefsava]
|
33
|
+
* Enhance some chinese translations. [#5413] by [@shouya]
|
34
|
+
* Add missing filter predicate translations to nb. [#5357] by [@rogerkk]
|
35
|
+
* Add missing norwegian comment translations. [#5375] by [@rogerkk]
|
36
|
+
* Add missing dutch translations. [#5368] by [@dennisvdvliet]
|
37
|
+
* Add missing german translations. [#5341] by [@eikes]
|
38
|
+
* Add missing spanish translation. [#5336] by [@mconiglio]
|
39
|
+
* Add from and to predicates for russian language. [#5330] by [@glebtv]
|
40
|
+
* Fix typo in finnish translation. [#5320] by [@JiiHu]
|
41
|
+
* Add missing turkish translations. [#5295] by [@kobeumut]
|
42
|
+
* Add missing chinese translations. [#5266] by [@jasl]
|
43
|
+
* Allow proc label in datepicker input. [#5408] by [@tiagotex]
|
44
|
+
* Add `group` attribute to scopes in order to show them in grouped. [#5359] by [@leio10]
|
45
|
+
* Add missing polish translations and improve existing ones. [#5537] by [@Wowu]
|
46
|
+
* Add `priority` option to `action_item`. [#5334] by [@andreslemik]
|
40
47
|
|
41
48
|
### Bug Fixes
|
42
49
|
|
43
|
-
* Fixed the string representation of the resolved `sort_key` when no explicit `sortable` attribute is passed. [#5464]
|
44
|
-
* Fixed docs on the column `sortable` attribute (which actually doesn't have to be explicitly specified when a block is passed to column). [#5464]
|
45
|
-
* Fixed `if:` scope option when a lambda is passed. [#5501]
|
46
|
-
* Comment validation adding redundant errors when resource is missing. [#5517]
|
47
|
-
* Fixed resource filtering by association when the resource has custom primary key. [#5446]
|
48
|
-
* Fixed "create anoter" checkbox styling. [#5324]
|
50
|
+
* Fixed the string representation of the resolved `sort_key` when no explicit `sortable` attribute is passed. [#5464] by [@chumakoff]
|
51
|
+
* Fixed docs on the column `sortable` attribute (which actually doesn't have to be explicitly specified when a block is passed to column). [#5464] by [@chumakoff]
|
52
|
+
* Fixed `if:` scope option when a lambda is passed. [#5501] by [@deivid-rodriguez]
|
53
|
+
* Comment validation adding redundant errors when resource is missing. [#5517] by [@deivid-rodriguez]
|
54
|
+
* Fixed resource filtering by association when the resource has custom primary key. [#5446] by [@wasifhossain]
|
55
|
+
* Fixed "create anoter" checkbox styling. [#5324] by [@faucct]
|
49
56
|
|
50
57
|
## 1.3.1 [☰](https://github.com/activeadmin/activeadmin/compare/v1.3.0...v1.3.1)
|
51
58
|
|
52
59
|
### Bug Fixes
|
53
60
|
|
54
|
-
* gemspec should have more permissive ransack dependency. [#5448]
|
61
|
+
* gemspec should have more permissive ransack dependency. [#5448] by [@varyonic]
|
55
62
|
|
56
63
|
## 1.3.0 [☰](https://github.com/activeadmin/activeadmin/compare/v1.2.1...v1.3.0)
|
57
64
|
|
@@ -59,13 +66,13 @@
|
|
59
66
|
|
60
67
|
#### Major
|
61
68
|
|
62
|
-
* Rails 5.2 support [#5343]
|
69
|
+
* Rails 5.2 support [#5343] by [@varyonic], [#5399], [#5401] by [@zorab47]
|
63
70
|
|
64
71
|
## 1.2.1 [☰](https://github.com/activeadmin/activeadmin/compare/v1.2.0...v1.2.1)
|
65
72
|
|
66
73
|
### Bug Fixes
|
67
74
|
|
68
|
-
* Resolve issue with [#5275]
|
75
|
+
* Resolve issue with [#5275] preventing XSS in filters sidebar. [#5299] by [@faucct]
|
69
76
|
|
70
77
|
## 1.2.0 [☰](https://github.com/activeadmin/activeadmin/compare/v1.1.0...v1.2.0)
|
71
78
|
|
@@ -73,41 +80,41 @@
|
|
73
80
|
|
74
81
|
#### Minor
|
75
82
|
|
76
|
-
* Do not display pagination info when there are no comments. [#5119]
|
77
|
-
* Revert generated config files to pluralized. [#5120]
|
78
|
-
* Warn when action definition overwrites controller method. [#5167]
|
79
|
-
* Better performance of comments show view. [#5208]
|
80
|
-
* Mitigate memory bloat [#4118]
|
81
|
-
* Fix issue applying custom decorations. [#5253]
|
82
|
-
* Brazilian locale updated. [#5125]
|
83
|
-
* Japanese locale updated. [#5143]
|
84
|
-
* Italian locale updated. [#5180]
|
85
|
-
* Swedish locale updated. [#5187]
|
86
|
-
* Vietnamese locale updated. [#5194]
|
87
|
-
* Esperanto locale added. [#5210]
|
83
|
+
* Do not display pagination info when there are no comments. [#5119] by [@alex-bogomolov]
|
84
|
+
* Revert generated config files to pluralized. [#5120] by [@varyonic], [#5137] by [@deivid-rodriguez]
|
85
|
+
* Warn when action definition overwrites controller method. [#5167] by [@aarek]
|
86
|
+
* Better performance of comments show view. [#5208] by [@dhyegofernando]
|
87
|
+
* Mitigate memory bloat [#4118] with CSV exports. [#5251] by [@f1sherman]
|
88
|
+
* Fix issue applying custom decorations. [#5253] by [@faucct]
|
89
|
+
* Brazilian locale updated. [#5125] by [@renotocn]
|
90
|
+
* Japanese locale updated. [#5143] by [@5t111111], [#5157] by [@innparusu95]
|
91
|
+
* Italian locale updated. [#5180] by [@blocknotes]
|
92
|
+
* Swedish locale updated. [#5187] by [@jawa]
|
93
|
+
* Vietnamese locale updated. [#5194] by [@Nguyenanh]
|
94
|
+
* Esperanto locale added. [#5210] by [@RobinvanderVliet]
|
88
95
|
|
89
96
|
### Bug Fixes
|
90
97
|
|
91
|
-
* Fix a couple of issues rendering filter labels. [#5223]
|
92
|
-
* Prevent NameError when filtering on a namespaced association. [#5240]
|
93
|
-
* Fix undefined method error in Ransack when building filters. [#5238]
|
94
|
-
* Fixed [#5198]
|
95
|
-
* Sanitize display_name. [#5284]
|
98
|
+
* Fix a couple of issues rendering filter labels. [#5223] by [@wspurgin]
|
99
|
+
* Prevent NameError when filtering on a namespaced association. [#5240] by [@DanielHeath]
|
100
|
+
* Fix undefined method error in Ransack when building filters. [#5238] by [@wspurgin]
|
101
|
+
* Fixed [#5198] Prevent XSS on sidebar's current filter rendering. [#5275] by [@deivid-rodriguez]
|
102
|
+
* Sanitize display_name. [#5284] by [@markstory]
|
96
103
|
|
97
104
|
## 1.1.0 [☰](https://github.com/activeadmin/activeadmin/compare/v1.0.0...v1.1.0)
|
98
105
|
|
99
106
|
### Bug Fixes
|
100
107
|
|
101
|
-
* Fixed [#5093]
|
102
|
-
* Fixed [#4173]
|
103
|
-
* Fixed [#5043]
|
104
|
-
* Fixed [#3894]
|
108
|
+
* Fixed [#5093] Handle table prefix & table suffix for `ActiveAdminComment` model
|
109
|
+
* Fixed [#4173] by including the default Kaminari templates. [#5069] by [@javierjulio]
|
110
|
+
* Fixed [#5043]. Do not crash in sidebar rendering when a default scope is not specified. [#5044] by [@Fivell]
|
111
|
+
* Fixed [#3894]. Make tab's component work with non-ascii titles. [#5046] by [@Fivell]
|
105
112
|
|
106
113
|
### Removals
|
107
114
|
|
108
|
-
* Ruby 2.1 support has been dropped. [#5003]
|
109
|
-
* Replaced `sass-rails` with `sass` dependency. [#5037]
|
110
|
-
* Removed `jquery-ui-rails` as a dependency. [#5052]
|
115
|
+
* Ruby 2.1 support has been dropped. [#5003] by [@deivid-rodriguez]
|
116
|
+
* Replaced `sass-rails` with `sass` dependency. [#5037] by [@javierjulio]
|
117
|
+
* Removed `jquery-ui-rails` as a dependency. [#5052] by [@javierjulio]
|
111
118
|
The specific jQuery UI assets used are now within the vendor directory. This
|
112
119
|
will be replaced by alternatives and dropped entirely in a major release.
|
113
120
|
Please remove any direct inclusions of `//= require jquery-ui`. This allows us
|
@@ -115,134 +122,134 @@
|
|
115
122
|
|
116
123
|
### Deprecations
|
117
124
|
|
118
|
-
* Deprecated `config.register_stylesheet` and `config.register_javascript`. Import your CSS and JS files in `active_admin.scss` or `active_admin.js`. [#5060]
|
119
|
-
* Deprecated `type` param from `status_tag` and related CSS classes [#4989]
|
120
|
-
|
125
|
+
* Deprecated `config.register_stylesheet` and `config.register_javascript`. Import your CSS and JS files in `active_admin.scss` or `active_admin.js`. [#5060] by [@javierjulio]
|
126
|
+
* Deprecated `type` param from `status_tag` and related CSS classes [#4989] by [@javierjulio]
|
127
|
+
The method signature has changed from:
|
121
128
|
|
122
|
-
|
123
|
-
|
124
|
-
|
129
|
+
```ruby
|
130
|
+
status_tag(status, :ok, class: 'completed', label: 'on')
|
131
|
+
```
|
125
132
|
|
126
|
-
|
133
|
+
to:
|
127
134
|
|
128
|
-
|
129
|
-
|
130
|
-
|
135
|
+
```ruby
|
136
|
+
status_tag(status, class: 'completed ok', label: 'on')
|
137
|
+
```
|
131
138
|
|
132
|
-
|
139
|
+
The following CSS classes have been deprecated and will be removed in the future:
|
133
140
|
|
134
|
-
|
135
|
-
|
136
|
-
|
137
|
-
|
138
|
-
|
139
|
-
|
140
|
-
|
141
|
+
```css
|
142
|
+
.status_tag {
|
143
|
+
&.ok, &.published, &.complete, &.completed, &.green { background: #8daa92; }
|
144
|
+
&.warn, &.warning, &.orange { background: #e29b20; }
|
145
|
+
&.error, &.errored, &.red { background: #d45f53; }
|
146
|
+
}
|
147
|
+
```
|
141
148
|
|
142
149
|
### Enhancements
|
143
150
|
|
144
151
|
#### Minor
|
145
152
|
|
146
|
-
* Support proc as an input_html option value when declaring filters. [#5029]
|
147
|
-
* Base localization support, better associations handling for active filters sidebar. [#4951]
|
148
|
-
* Allow AA scopes to return paginated collections. [#4996]
|
149
|
-
* Added `scopes_show_count` configuration to setup show_count attribute for scopes globally. [#4950]
|
150
|
-
* Allow custom panel title given with `attributes_table`. [#4940]
|
151
|
-
* Allow passing a class to `action_item` block. [#4997]
|
152
|
-
* Add pagination to the comments section. [#5088]
|
153
|
+
* Support proc as an input_html option value when declaring filters. [#5029] by [@Fivell]
|
154
|
+
* Base localization support, better associations handling for active filters sidebar. [#4951] by [@Fivell]
|
155
|
+
* Allow AA scopes to return paginated collections. [#4996] by [@Fivell]
|
156
|
+
* Added `scopes_show_count` configuration to setup show_count attribute for scopes globally. [#4950] by [@Fivell]
|
157
|
+
* Allow custom panel title given with `attributes_table`. [#4940] by [@ajw725]
|
158
|
+
* Allow passing a class to `action_item` block. [#4997] by [@Fivell]
|
159
|
+
* Add pagination to the comments section. [#5088] by [@alex-bogomolov]
|
153
160
|
|
154
|
-
## 1.0.0 [☰](https://github.com/activeadmin/activeadmin/compare/v0.6.3...
|
161
|
+
## 1.0.0 [☰](https://github.com/activeadmin/activeadmin/compare/v0.6.3...v1.0.0)
|
155
162
|
|
156
163
|
### Breaking Changes
|
157
164
|
|
158
|
-
* Rename `allow_comments` to `comments` for more consistent naming. [#3695]
|
159
|
-
* JavaScript `window.AA` has been removed, use `window.ActiveAdmin`. [#3606]
|
160
|
-
* `f.form_buffers` has been removed. [#3486]
|
161
|
-
* Iconic has been removed. [#3553]
|
162
|
-
* `config.show_comments_in_menu` has been removed, see `config.comments_menu`. [#4187]
|
163
|
-
* Rails 3.2 & Ruby 1.9.3 support has been dropped. [#4848]
|
164
|
-
* Ruby 2.0.0 support has been dropped. [#4851]
|
165
|
-
* Rails 4.0 & 4.1 support has been dropped. [#4870]
|
165
|
+
* Rename `allow_comments` to `comments` for more consistent naming. [#3695] by [@pranas]
|
166
|
+
* JavaScript `window.AA` has been removed, use `window.ActiveAdmin`. [#3606] by [@timoschilling]
|
167
|
+
* `f.form_buffers` has been removed. [#3486] by [@varyonic]
|
168
|
+
* Iconic has been removed. [#3553] by [@timoschilling]
|
169
|
+
* `config.show_comments_in_menu` has been removed, see `config.comments_menu`. [#4187] by [@drn]
|
170
|
+
* Rails 3.2 & Ruby 1.9.3 support has been dropped. [#4848] by [@deivid-rodriguez]
|
171
|
+
* Ruby 2.0.0 support has been dropped. [#4851] by [@deivid-rodriguez]
|
172
|
+
* Rails 4.0 & 4.1 support has been dropped. [#4870] by [@deivid-rodriguez]
|
166
173
|
|
167
174
|
### Enhancements
|
168
175
|
|
169
176
|
#### Major
|
170
177
|
|
171
|
-
* Migration from Metasearch to Ransack. [#1979]
|
172
|
-
* Rails 4 support. [#2326]
|
173
|
-
* Rails 4.2 support. [#3731]
|
174
|
-
* Rails 5 support. [#4254]
|
175
|
-
* Rails 5.1 support. [#4882]
|
178
|
+
* Migration from Metasearch to Ransack. [#1979] by [@seanlinsley]
|
179
|
+
* Rails 4 support. [#2326] by many people :heart:
|
180
|
+
* Rails 4.2 support. [#3731] by [@gonzedge] and [@timoschilling]
|
181
|
+
* Rails 5 support. [#4254] by [@seanlinsley]
|
182
|
+
* Rails 5.1 support. [#4882] by [@varyonic]
|
176
183
|
|
177
184
|
#### Minor
|
178
185
|
|
179
|
-
* "Create another" checkbox for the new resource page. [#4477]
|
180
|
-
* Page supports belongs_to. [#4759]
|
181
|
-
* Support for custom sorting strategies. [#4768]
|
182
|
-
* Stream CSV downloads as they're generated. [#3038]
|
183
|
-
* Disable streaming in development for easier debugging. [#3535]
|
184
|
-
* Improved code reloading. [#3783]
|
185
|
-
* Do not auto link to inaccessible actions. [#3686]
|
186
|
-
* Allow to enable comments on per-resource basis. [#3695]
|
187
|
-
* Unify DSL for index `actions` and `actions dropdown: true`. [#3463]
|
188
|
-
* Add DSL method `includes` for `ActiveRecord::Relation#includes`. [#3464]
|
189
|
-
* BOM (byte order mark) configurable for CSV download. [#3519]
|
190
|
-
* Column block on table index is now sortable by default. [#3075]
|
191
|
-
* Allow Arbre to be used inside ActiveAdmin forms. [#3486]
|
192
|
-
* Make AA ORM-agnostic. [#2545]
|
193
|
-
* Add multi-record support to `attributes_table_for`. [#2544]
|
194
|
-
* Table CSS classes are now prefixed to prevent clashes. [#2532]
|
195
|
-
* Allow Inherited Resources shorthand for redirection. [#2001]
|
196
|
-
|
197
|
-
```ruby
|
198
|
-
|
199
|
-
|
200
|
-
|
201
|
-
|
202
|
-
end
|
186
|
+
* "Create another" checkbox for the new resource page. [#4477] by [@bolshakov]
|
187
|
+
* Page supports belongs_to. [#4759] by [@Fivell] and [@zorab47]
|
188
|
+
* Support for custom sorting strategies. [#4768] by [@Fivell]
|
189
|
+
* Stream CSV downloads as they're generated. [#3038] by [@craigmcnamara]
|
190
|
+
* Disable streaming in development for easier debugging. [#3535] by [@seanlinsley]
|
191
|
+
* Improved code reloading. [#3783] by [@chancancode]
|
192
|
+
* Do not auto link to inaccessible actions. [#3686] by [@pranas]
|
193
|
+
* Allow to enable comments on per-resource basis. [#3695] by [@pranas]
|
194
|
+
* Unify DSL for index `actions` and `actions dropdown: true`. [#3463] by [@timoschilling]
|
195
|
+
* Add DSL method `includes` for `ActiveRecord::Relation#includes`. [#3464] by [@timoschilling]
|
196
|
+
* BOM (byte order mark) configurable for CSV download. [#3519] by [@timoschilling]
|
197
|
+
* Column block on table index is now sortable by default. [#3075] by [@dmitry]
|
198
|
+
* Allow Arbre to be used inside ActiveAdmin forms. [#3486] by [@varyonic]
|
199
|
+
* Make AA ORM-agnostic. [#2545] by [@johnnyshields]
|
200
|
+
* Add multi-record support to `attributes_table_for`. [#2544] by [@zorab47]
|
201
|
+
* Table CSS classes are now prefixed to prevent clashes. [#2532] by [@TimPetricola]
|
202
|
+
* Allow Inherited Resources shorthand for redirection. [#2001] by [@seanlinsley]
|
203
|
+
|
204
|
+
```ruby
|
205
|
+
controller do
|
206
|
+
# Redirects to index page instead of rendering updated resource
|
207
|
+
def update
|
208
|
+
update!{ collection_path }
|
203
209
|
end
|
204
|
-
|
210
|
+
end
|
211
|
+
```
|
205
212
|
|
206
|
-
* Accept block for download links. [#2040]
|
213
|
+
* Accept block for download links. [#2040] by [@potatosalad]
|
207
214
|
|
208
|
-
```ruby
|
209
|
-
index download_links: ->{ can?(:view_all_download_links) || [:pdf] }
|
210
|
-
```
|
215
|
+
```ruby
|
216
|
+
index download_links: ->{ can?(:view_all_download_links) || [:pdf] }
|
217
|
+
```
|
211
218
|
|
212
|
-
* Comments menu can be customized via configuration passed to `config.comments_menu`. [#4187]
|
213
|
-
* Added `config.route_options` to namespace to customize routes. [#4731]
|
219
|
+
* Comments menu can be customized via configuration passed to `config.comments_menu`. [#4187] by [@drn]
|
220
|
+
* Added `config.route_options` to namespace to customize routes. [#4731] by [@stereoscott]
|
214
221
|
|
215
222
|
### Security Fixes
|
216
223
|
|
217
|
-
* Prevents access to formats that the user not permitted to see. [#4867]
|
218
|
-
* Prevents potential DOS attack via Ruby symbols. [#1926]
|
224
|
+
* Prevents access to formats that the user not permitted to see. [#4867] by [@Fivell] and [@timoschilling]
|
225
|
+
* Prevents potential DOS attack via Ruby symbols. [#1926] by [@seanlinsley]
|
219
226
|
* [this isn't an issue for those using Ruby >= 2.2](http://rubykaigi.org/2014/presentation/S-NarihiroNakamura)
|
220
227
|
|
221
228
|
### Bug Fixes
|
222
229
|
|
223
|
-
* Fixes filters for `has_many :through` relationships. [#2541]
|
224
|
-
* "New" action item now only shows up on the index page. bf659bc by [@seanlinsley]
|
225
|
-
* Fixes comment creation bug with aliased resources. 9a082486 by [@seanlinsley]
|
226
|
-
* Fixes the deletion of `:if` and `:unless` from filters. [#2523]
|
230
|
+
* Fixes filters for `has_many :through` relationships. [#2541] by [@shekibobo]
|
231
|
+
* "New" action item now only shows up on the index page. bf659bc by [@seanlinsley]
|
232
|
+
* Fixes comment creation bug with aliased resources. 9a082486 by [@seanlinsley]
|
233
|
+
* Fixes the deletion of `:if` and `:unless` from filters. [#2523] by [@PChambino]
|
227
234
|
|
228
235
|
### Deprecations
|
229
236
|
|
230
|
-
* `ActiveAdmin::Event` (`ActiveAdmin::EventDispatcher`). [#3435]
|
237
|
+
* `ActiveAdmin::Event` (`ActiveAdmin::EventDispatcher`). [#3435] by [@timoschilling]
|
231
238
|
`ActiveAdmin::Event` will be removed in a future version, ActiveAdmin switched
|
232
239
|
to use `ActiveSupport::Notifications`
|
233
240
|
NOTE: The blog parameters has changed:
|
234
241
|
|
235
|
-
```ruby
|
236
|
-
ActiveSupport::Notifications.subscribe ActiveAdmin::Application::BeforeLoadEvent do |event, *args|
|
237
|
-
|
238
|
-
end
|
242
|
+
```ruby
|
243
|
+
ActiveSupport::Notifications.subscribe ActiveAdmin::Application::BeforeLoadEvent do |event, *args|
|
244
|
+
# some code
|
245
|
+
end
|
239
246
|
|
240
|
-
ActiveSupport::Notifications.publish ActiveAdmin::Application::BeforeLoadEvent, "some data"
|
241
|
-
```
|
247
|
+
ActiveSupport::Notifications.publish ActiveAdmin::Application::BeforeLoadEvent, "some data"
|
248
|
+
```
|
242
249
|
|
243
250
|
## Previous Changes
|
244
251
|
|
245
|
-
Please check [0-6-stable]
|
252
|
+
Please check [0-6-stable] for previous changes.
|
246
253
|
|
247
254
|
[0-6-stable]: https://github.com/activeadmin/activeadmin/blob/0-6-stable/CHANGELOG.md
|
248
255
|
|
@@ -353,6 +360,7 @@ Please check [0-6-stable][] for previous changes.
|
|
353
360
|
[#5517]: https://github.com/activeadmin/activeadmin/pull/5517
|
354
361
|
[#5537]: https://github.com/activeadmin/activeadmin/pull/5537
|
355
362
|
[#5583]: https://github.com/activeadmin/activeadmin/pull/5583
|
363
|
+
[#5611]: https://github.com/activeadmin/activeadmin/pull/5611
|
356
364
|
|
357
365
|
[@5t111111]: https://github.com/5t111111
|
358
366
|
[@aarek]: https://github.com/aarek
|
@@ -361,6 +369,7 @@ Please check [0-6-stable][] for previous changes.
|
|
361
369
|
[@andreslemik]: https://github.com/andreslemik
|
362
370
|
[@blocknotes]: https://github.com/blocknotes
|
363
371
|
[@bolshakov]: https://github.com/bolshakov
|
372
|
+
[@buren]: https://github.com/buren
|
364
373
|
[@chancancode]: https://github.com/chancancode
|
365
374
|
[@chumakoff]: https://github.com/chumakoff
|
366
375
|
[@craigmcnamara]: https://github.com/craigmcnamara
|
@@ -400,6 +409,7 @@ Please check [0-6-stable][] for previous changes.
|
|
400
409
|
[@shekibobo]: https://github.com/shekibobo
|
401
410
|
[@shouya]: https://github.com/shouya
|
402
411
|
[@stefsava]: https://github.com/stefsava
|
412
|
+
[@stereoscott]: https://github.com/stereoscott
|
403
413
|
[@tiagotex]: https://github.com/tiagotex
|
404
414
|
[@timoschilling]: https://github.com/timoschilling
|
405
415
|
[@TimPetricola]: https://github.com/TimPetricola
|