activeadmin-rails 1.7.0 → 1.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a0fbadfbfdeab69087abd64f588056156b07290b03f628c964647eb2417cb271
-  data.tar.gz: 8cb8c6a961c9497bd41f88932248a2b631d78eebc160f3d96ee5350e5cc444d6
+  metadata.gz: 34770b5aac9a2079cd8c360765e1b0f1ca09b5fac462ca586b97a9f55ff66915
+  data.tar.gz: 79f6e989087820f88e3724c061344e7b70f233f56b76af378512a6d3ef697c05
 SHA512:
-  metadata.gz: 666e2d4ee9f3e8c429fb5b1860aa1928933d39afaad93712c82fbdff73b6476e3228da72f90bdbcda19ca8e80157cfed5d942c185e405cc3efec3f805a0c17bc
-  data.tar.gz: 59b7772b54d705c5560fe176278ddd5ce322af83e23951f1de92a4ee00b3d2d22c6c6ce09431c0cbd90864f89c962622207f1e44760f23b3cdd59de7de49113e
+  metadata.gz: 3909daf70b9cd60b09bc38891f74cd3d3102cb2946936c35f69ee73156cdb9827bd2a0d1af4baa36ecb9936c2634d117044676bb1f0ce7d8b5241f51c4ab2e31
+  data.tar.gz: 38982c2eaa887c737ea0ea09e4a9f609930601a561b181a02a70c5b6ad750dda2c9f33a7c882331185bc6566d3952608445e19d9785d008052eab14e018e98d0

data/.github/workflows/ci.yaml

@@ -14,6 +14,12 @@ jobs:
     strategy:
       matrix:
         include:
+          - ruby: { name: 3.3, value: 3.3.6 }
+            deps: rails_72
+            os: ubuntu-24.04
+          - ruby: { name: 3.3, value: 3.3.6 }
+            deps: rails_71
+            os: ubuntu-24.04
           - ruby: { name: 3.2, value: 3.2.2 }
             deps: rails_71
             os: ubuntu-22.04
@@ -23,10 +29,10 @@ jobs:
           - ruby: { name: 3.2, value: 3.2.2 }
             deps: rails_70_hotwire
             os: ubuntu-22.04
-          - ruby: { name: 3.0, value: 3.0.1 }
+          - ruby: { name: 3.1, value: 3.1.6 }
             deps: rails_70
             os: ubuntu-22.04
-          - ruby: { name: 3.0, value: 3.0.1 }
+          - ruby: { name: 3.1, value: 3.1.6 }
             deps: rails_70_hotwire
             os: ubuntu-22.04
           - ruby: { name: 3.1, value: 3.1.2 }
@@ -35,12 +41,6 @@ jobs:
           - ruby: { name: 3.1, value: 3.1.2 }
             deps: rails_61_turbolinks
             os: ubuntu-22.04
-          - ruby: { name: 3.0, value: 3.0.1 }
-            deps: rails_61
-            os: ubuntu-22.04
-          - ruby: { name: 3.0, value: 3.0.1 }
-            deps: rails_61_turbolinks
-            os: ubuntu-22.04
       fail-fast: false
 
     env:

data/.github/workflows/daily.yaml

@@ -14,6 +14,9 @@ jobs:
     strategy:
       matrix:
         include:
+          - ruby: { name: 3.3, value: 3.3.6 }
+            deps: rails_71
+            os: ubuntu-24.04
           - ruby: { name: 3.2, value: 3.2.2 }
             deps: rails_71
             os: ubuntu-22.04
@@ -23,10 +26,10 @@ jobs:
           - ruby: { name: 3.2, value: 3.2.2 }
             deps: rails_70_hotwire
             os: ubuntu-22.04
-          - ruby: { name: 3.0, value: 3.0.1 }
+          - ruby: { name: 3.1, value: 3.1.6 }
             deps: rails_70
             os: ubuntu-22.04
-          - ruby: { name: 3.0, value: 3.0.1 }
+          - ruby: { name: 3.1, value: 3.1.6 }
             deps: rails_70_hotwire
             os: ubuntu-22.04
           - ruby: { name: 3.1, value: 3.1.2 }
@@ -35,12 +38,6 @@ jobs:
           - ruby: { name: 3.1, value: 3.1.2 }
             deps: rails_61_turbolinks
             os: ubuntu-22.04
-          - ruby: { name: 3.0, value: 3.0.1 }
-            deps: rails_61
-            os: ubuntu-22.04
-          - ruby: { name: 3.0, value: 3.0.1 }
-            deps: rails_61_turbolinks
-            os: ubuntu-22.04
       fail-fast: false
 
     env:

data/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Changelog
 
+## 1.7.1 [☰](https://github.com/varyonic/activeadmin-rails/compare/v1.7.0...v1.7.1)
+
+#### Minor
+
+* Rails 7.2 support. [#53] by [@varyonic]
+* Verify Ruby 3.3 support. [#50] by [@varyonic]
+
+### Bug Fixes
+
+* Fix streaming CSV export. [#52] by [@varyonic]
+
+### Security Fixes
+
+* Don't restrict jquery-ui-rails upgrades. [#49] by [@varyonic]
+
 ## 1.7.0 [☰](https://github.com/varyonic/activeadmin-rails/compare/v1.6.0...v1.7.0)
 
 This release replaces Arbre::Pages with a conventional Rails layout and view partials.

data/CONTRIBUTING.md

@@ -36,7 +36,7 @@ Make sure you're using a recent ruby and have the `bundler` gem installed.
 Select the Gemfile for your preferred Rails version, preferably the latest:
 
 ```sh
-export BUNDLE_GEMFILE=gemfiles/rails_71.gemfile
+export BUNDLE_GEMFILE=gemfiles/rails_72.gemfile
 ```
 
 Now install the development dependencies:

data/Gemfile

@@ -5,6 +5,7 @@ gem 'arbo'
 # Optional dependencies
 gem 'cancan'
 gem 'pundit'
+gem 'sqlite3', '~> 1.x'
 gem 'jruby-openssl', '~> 0.10.1', platforms: :jruby
 
 # Utility gems used in both development & test environments
@@ -41,7 +42,7 @@ group :test do
   gem 'capybara'
   gem 'simplecov', require: false # Test coverage generator. Go to /coverage/ after running tests
   gem 'codecov', require: false # Test coverage website. Go to https://codecov.io
-  gem 'cucumber-rails', github: 'cucumber/cucumber-rails', require: false
+  gem 'cucumber-rails', require: false
   gem 'cucumber'
   gem 'database_cleaner'
   gem 'jasmine'

data/README.md

@@ -17,7 +17,6 @@ but Varyonic has no plans to provide commercial support - let us know if you do.
 [![Github Actions  ][actions_badge]][actions]
 [![Quality         ][codeclimate_badge]][codeclimate]
 [![Coverage        ][codecov_badge]][codecov]
-[![Inch CI         ][inch_badge]][inch]
 
 ## Goals
 
@@ -72,8 +71,6 @@ Tool                  | Description
 [codeclimate]: https://codeclimate.com/github/varyonic/activeadmin/maintainability
 [codecov_badge]: https://codecov.io/gh/varyonic/activeadmin/branch/main/graph/badge.svg
 [codecov]: https://codecov.io/gh/varyonic/activeadmin
-[inch_badge]: http://inch-ci.org/github/varyonic/activeadmin.svg?branch=main
-[inch]: http://inch-ci.org/github/varyonic/activeadmin
 
 [docs]: http://activeadmin.org/0-installation.html
 [demo]: http://demo.activeadmin.org/admin

data/activeadmin-rails.gemspec

@@ -29,7 +29,7 @@ Gem::Specification.new do |s|
   s.add_dependency 'formtastic_i18n'
   s.add_dependency 'inherited_resources', '>= 1.13.1'
   s.add_dependency 'jquery-rails', '>= 4.2.0'
-  s.add_dependency 'jquery-ui-rails', '~> 6.0'
+  s.add_dependency 'jquery-ui-rails', '>= 6.0'
   s.add_dependency 'kaminari', '>= 1.0.1'
   s.add_dependency 'railties', '>= 5.0'
   s.add_dependency 'ransack', '>= 1.8.7'

data/features/step_definitions/format_steps.rb

@@ -24,11 +24,13 @@ end
 # Check first rows of the displayed CSV.
 Then /^I should download a CSV file with "([^"]*)" separator for "([^"]*)" containing:$/ do |sep, resource_name, table|
   body   = page.driver.response.body
-  content_type_header, content_disposition_header = %w[Content-Type Content-Disposition].map do |header_name|
+  content_type_header, content_disposition_header, last_modified_header = %w[Content-Type Content-Disposition Last-Modified].map do |header_name|
     page.response_headers[header_name]
   end
   expect(content_type_header).to eq 'text/csv; charset=utf-8'
   expect(content_disposition_header).to match /\Aattachment; filename=".+?\.csv"\z/
+  expect(last_modified_header).to_not be_nil
+  expect(Date.strptime(last_modified_header, "%a, %d %b %Y %H:%M:%S GMT")).to be_a(Date)
 
   csv = CSV.parse(body, col_sep: sep)
   table.raw.each_with_index do |expected_row, row_index|

data/gemfiles/rails_61.gemfile

@@ -9,7 +9,6 @@ gem "sprockets", ">= 4.0.x"
 gem "bootsnap"
 gem "devise", "~> 4.4"
 gem "draper"
-gem 'sqlite3', platforms: :mri
 gem "activerecord-jdbcsqlite3-adapter", ">= 60.0.x", platform: :jruby
 
 gemspec path: "../"

data/gemfiles/rails_61_turbolinks.gemfile

@@ -9,7 +9,6 @@ gem "sprockets", ">= 4.0.x"
 gem "bootsnap"
 gem "devise", "~> 4.4"
 gem "draper"
-gem 'sqlite3', platforms: :mri
 gem "activerecord-jdbcsqlite3-adapter", ">= 60.0.x", platform: :jruby
 
 gemspec path: "../"

data/gemfiles/rails_70.gemfile

@@ -9,7 +9,6 @@ gem "sprockets", ">= 4.0.x"
 gem "bootsnap"
 gem "devise", "~> 4.4"
 gem "draper"
-gem 'sqlite3', platforms: :mri
 gem "activerecord-jdbcsqlite3-adapter", ">= 60.0.x", platform: :jruby
 
 gemspec path: "../"

data/gemfiles/rails_70_hotwire.gemfile

@@ -9,7 +9,6 @@ gem "sprockets", ">= 4.0.x"
 gem "bootsnap"
 gem "devise", "~> 4.9" # support for Hotwire + Turbo, default in Rails 7+
 gem "draper"
-gem 'sqlite3', platforms: :mri
 gem "activerecord-jdbcsqlite3-adapter", ">= 60.0.x", platform: :jruby
 
 gemspec path: "../"

data/gemfiles/rails_71.gemfile

@@ -11,7 +11,6 @@ gem 'devise', '>= 4.9.3'
 gem 'rack', '~> 2.2'
 gem 'bootsnap'
 gem 'draper'
-gem 'sqlite3', platforms: :mri
 gem 'activerecord-jdbcsqlite3-adapter', '>= 60.0.x', platform: :jruby
 
 gemspec path: '../'

data/gemfiles/rails_72.gemfile

@@ -0,0 +1,16 @@
+source 'https://rubygems.org'
+
+eval_gemfile(File.expand_path(File.join('..', 'Gemfile'), __dir__))
+
+gem 'rails', '~> 7.2.0'
+gem 'rails-i18n'
+gem 'inherited_resources', '>= 1.14.0'
+gem 'formtastic', '>= 5.0.0'
+gem 'ransack', '>= 4.1.0'
+gem 'devise', '>= 4.9.3'
+gem 'rack', '>= 2.2'
+gem 'bootsnap'
+gem 'draper'
+gem 'activerecord-jdbcsqlite3-adapter', '>= 70.0.x', platform: :jruby
+
+gemspec path: '../'

data/lib/active_admin/deprecation.rb

@@ -2,8 +2,12 @@ module ActiveAdmin
   module Deprecation
     module_function
 
+    def deprecator # :nodoc:
+      @deprecator ||= ActiveSupport::Deprecation.new
+    end
+
     def warn(message, callstack = caller)
-      ActiveSupport::Deprecation.warn "Active Admin: #{message}", callstack
+      deprecator.warn "Active Admin: #{message}", callstack
     end
 
   end

data/lib/active_admin/resource_controller/streaming.rb

@@ -20,6 +20,7 @@ module ActiveAdmin
       def stream_resource(&block)
         headers['X-Accel-Buffering'] = 'no'
         headers['Cache-Control'] = 'no-cache'
+        headers["Last-Modified"] = Time.current.httpdate
 
         if ActiveAdmin.application.disable_streaming_in.include? Rails.env
           self.response_body = block[String.new]

data/lib/active_admin/version.rb

@@ -1,3 +1,3 @@
 module ActiveAdmin
-  VERSION = '1.7.0'
+  VERSION = '1.7.1'
 end

data/spec/requests/pages/layout_spec.rb

@@ -46,6 +46,7 @@ RSpec.describe 'layout', type: :request do
     it "should display appropriate text" do
       get edit_user_path(user), headers: { 'HTTP_USER_AGENT' => user_agent }
 
+      pending if ActiveAdmin::Dependency.rails >= '7.2' # Rails 7.2+ provides its own browser warning
       expect(page).to have_css 'div.unsupported_browser h1', text: /no longer supports Internet Explorer versions 8/
       expect(page).to have_css 'div.unsupported_browser p', text: /upgrade your browser/
       expect(page).to have_css 'div.unsupported_browser p', text: /turn off "Compatibility View"/

data/spec/support/rails_template.rb

@@ -211,6 +211,8 @@ directory File.expand_path('../templates/admin', __FILE__), 'app/admin'
 # Add predefined policies
 directory File.expand_path('../templates/policies', __FILE__), 'app/policies'
 
+directory File.expand_path("templates/public", __dir__), "public", force: true
+
 if ENV['RAILS_ENV'] != 'test'
   inject_into_file 'config/routes.rb', "\n  root to: redirect('admin')", after: /.*routes.draw do/
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activeadmin-rails
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 1.7.1
 platform: ruby
 authors:
 - Piers Chambers, Greg Bell
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-11-30 00:00:00.000000000 Z
+date: 2024-11-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: arbo
@@ -84,14 +84,14 @@ dependencies:
   name: jquery-ui-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '6.0'
 - !ruby/object:Gem::Dependency
@@ -474,6 +474,7 @@ files:
 - gemfiles/rails_70.gemfile
 - gemfiles/rails_70_hotwire.gemfile
 - gemfiles/rails_71.gemfile
+- gemfiles/rails_72.gemfile
 - lib/active_admin.rb
 - lib/active_admin/abstract_view_factory.rb
 - lib/active_admin/application.rb
@@ -672,6 +673,7 @@ files:
 - spec/support/templates/policies/store_policy.rb
 - spec/support/templates/policies/user_policy.rb
 - spec/support/templates/post_decorator.rb
+- spec/support/templates/public/favicon.ico
 - spec/unit/abstract_view_factory_spec.rb
 - spec/unit/action_builder_spec.rb
 - spec/unit/active_admin_spec.rb
@@ -789,7 +791,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.3.26
 signing_key:
 specification_version: 4
 summary: A rapid development framework for Ruby on Rails.
@@ -921,6 +923,7 @@ test_files:
 - spec/support/templates/policies/store_policy.rb
 - spec/support/templates/policies/user_policy.rb
 - spec/support/templates/post_decorator.rb
+- spec/support/templates/public/favicon.ico
 - spec/unit/abstract_view_factory_spec.rb
 - spec/unit/action_builder_spec.rb
 - spec/unit/active_admin_spec.rb