active_zuora 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,15 @@
 ---
-SHA1:
-  metadata.gz: 5ff1cc26c4a195b5c6938e8c4f8d31c47e725729
-  data.tar.gz: 26d461961a52d3507aae19d1fce9370a35d7c9df
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    NTkwNDBiNjM1ODBhZjMyNzA3MjI2YzE4MDQ0MTA3YTQwMjhkYzcwNw==
+  data.tar.gz: !binary |-
+    ZDA0MDIwMjE0NTQwZmE1MTQzZDk5ZjA3YzQ3Mzk2NTBkYTc0ZDBkNg==
 SHA512:
-  metadata.gz: 19e0a15c649f728ef73e226a5328a2b96cff15f8cd1149cd47d2db40855e7bf2e7027d0d025b8340071719686f550db0df0079a5dff326639f778d5e244c4849
-  data.tar.gz: a52a64fed7da41be69ae64f508f8ac451f896be4691fcea8e4f1c02e7a7efd94a48341cd52639adcc38597e5e0d3f6f8883be0a1f3169f10f98036a18ae5bb70
+  metadata.gz: !binary |-
+    MTk0ODE2YzI3ZjI1MGRmOGM4MDVmYTQ0YjNkOWQzOWZmMWFkNmMxNTBlMzYx
+    YWJlNDk3Y2ZkNDU5MjNiZDU4ZmYyODlkNDhmOGNkZTQ4ZjdmNzExNTFmZjA4
+    YzViNTI1MWZmYjg3NjY2Njk4ZmJmNDMwYTljOTcwZWFlMTcyN2M=
+  data.tar.gz: !binary |-
+    NDkwODA5ZDc3NDA4MTA4YjU5MGU5NjRhZmMwZjFkODc0NjI2ZDE2YmRjNGFh
+    NzNlMjFmYjk4ZDgzYzZlZDY5NTRmYTI3ZDg2YzcyMjllMjBjYzQxNWE5MDAw
+    ZGY1MzM0OGFjNjU3NWIxOGY3MGM3ZTkxZGYyOTNiMTU3NmVhZGM=

data/CHANGELOG.markdown

@@ -1,3 +1,7 @@
+#### v2.1.1
 #### v2.1.0
+* Upgrade Savon to 1.2 https://github.com/sportngin/active_zuora/pull/22
+  - By @nvd
+  - Makes AZ 2 Thread Safe
 #### v2.0.6
 #### v2.0.5

data/README.md

@@ -9,6 +9,9 @@ This repostiory contains >= Version 2 of Active Zuora
 
 Version 1 can be found at https://github.com/sportngin/active_zuora_v1
 
+## Thread Safety
+2.0.X versions of Active Zuora are not thread safe. They depend on a version of [Savon](https://github.com/savonrb/savon) that is [does not work with threads](https://github.com/savonrb/savon/issues/259).
+
 ## Configuration
 
     ActiveZuora.configure(

data/lib/active_zuora/persistence.rb

@@ -117,6 +117,7 @@ module ActiveZuora
         end
 
         return 0 if zobjects.empty?
+
         results = connection.request(action) do |soap|
           soap.body do |xml|
             zobjects.map do |zobject|
@@ -128,21 +129,16 @@ module ActiveZuora
             end.last
           end
         end["#{action.to_s}_response".to_sym][:result]
+
         results = [results] unless results.is_a?(Array)
-        zobjects.each_with_index do |zobject, i|
-          # If it's an update, grab by id, otherwise by index
-          if action == :update
-            result = results.find { |r| r[:id] == zobject.id } || 
-              { :errors => { :message => "No result returned." } }
-          else
-            result = results[i] || { :errors => { :message => "No result returned." } }
-          end
+        zobjects.zip(results).each do |zobject, result|
           if result[:success]
             zobject.clear_changed_attributes
           else
             zobject.add_zuora_errors result[:errors]
           end
         end
+
         # Return the count of updates that succeeded.
         results.select{ |result| result[:success] }.size
       end

data/lib/active_zuora/version.rb

@@ -1,3 +1,3 @@
 module ActiveZuora
-  VERSION = "2.1.0"
+  VERSION = "2.1.1"
 end

data/spec/account_integration_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+describe 'Create Account' do
+
+  integration_test do
+
+    let(:account) do
+      Z::Account.new name: 'Joe Customer',
+                     currency: Tenant.currency,
+                     bill_cycle_day: '1'
+    end
+
+    after(:each) do
+      account.delete unless account.new_record?
+    end
+
+    it 'can create an account' do
+      expect(account).to be_a_new_record
+      expect(account).to_not be_valid
+      expect(account.id).to_not be_present
+      expect(account.errors.full_messages).to eq ["Status can't be blank"]
+
+      now 'update account to be valid' do
+        account.status = 'Draft'
+        expect(account).to be_valid
+        expect(account.errors.full_messages).to be_empty
+      end
+
+      now 'save the account' do
+        expect(account.save).to be true
+        expect(account.id).to be_present
+        expect(account.errors.full_messages).to eq []
+      end
+
+      now 'ensure error messages are accessible' do
+        expect(account.update_attributes status: 'Active').to be false
+        expect(account.errors.full_messages).to eq ['Active account must have both sold to and bill to.']
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -22,8 +22,12 @@ def integration_test
   end
 end
 
+def now(_message)
+  yield
+end
+
 module Tenant
   def self.currency
     ENV['ZUORA_CURRENCY'] || 'USD'
   end
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_zuora
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Ed Lebert
@@ -9,88 +9,88 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-06 00:00:00.000000000 Z
+date: 2015-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 1.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 1.2.0
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
-    - - "<"
+    - - <
       - !ruby/object:Gem::Version
         version: 5.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
-    - - "<"
+    - - <
       - !ruby/object:Gem::Version
         version: 5.0.0
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
-    - - "<"
+    - - <
       - !ruby/object:Gem::Version
         version: 5.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
-    - - "<"
+    - - <
       - !ruby/object:Gem::Version
         version: 5.0.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 0.8.7
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 0.8.7
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
 description: ActiveZuora - Zuora API based on ActiveModel and auto-generated from
@@ -103,10 +103,10 @@ extensions: []
 extra_rdoc_files:
 - README.md
 files:
-- ".gitignore"
-- ".octopolo.yml"
-- ".soyuz.yml"
-- ".travis.yml"
+- .gitignore
+- .octopolo.yml
+- .soyuz.yml
+- .travis.yml
 - CHANGELOG.markdown
 - Gemfile
 - MIT-LICENSE
@@ -138,6 +138,7 @@ files:
 - lib/active_zuora/subscribe.rb
 - lib/active_zuora/version.rb
 - lib/active_zuora/z_object.rb
+- spec/account_integration_spec.rb
 - spec/belongs_to_associations_spec.rb
 - spec/connection_spec.rb
 - spec/has_many_integration_spec.rb
@@ -155,12 +156,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
@@ -170,6 +171,7 @@ signing_key:
 specification_version: 4
 summary: ActiveZuora - Zuora API that looks and feels like ActiveRecord.
 test_files:
+- spec/account_integration_spec.rb
 - spec/belongs_to_associations_spec.rb
 - spec/connection_spec.rb
 - spec/has_many_integration_spec.rb