active_utils 2.0.1 → 2.0.2

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    M2U5MzA5NDk5Zjk3OTRiZTY0ZjgyZDgyOGIzNjg5MzY2ZGJjODM1Yw==
-  data.tar.gz: !binary |-
-    N2Q0YTc3Y2QxM2M5N2FiMzJhMzk5NWZmMjY3ZjMxYjIzMjIwMzljOQ==
+SHA1:
+  metadata.gz: c6b630a34ea73ba2891b97742823b62856bd532b
+  data.tar.gz: 27c652fccd8be0d20dfd462efb0c7f36afc5d6a3
 SHA512:
-  metadata.gz: !binary |-
-    YWYwMzdkNjc0MDUxMmEzZGQ2MzRiMmYzM2JjYTg3N2Q4ODVjNTQzNTE4NmM0
-    MzMzNzU3YTU3NzczNWY5NzhjYjczMWU3YmE5ZTQ5OGRlNzhmZjkxOTA0MzMy
-    N2NiNzNmNGNlNTRkNGVjYTVkNjM3ODg3ZjFjYzJkMjRkODIxOGQ=
-  data.tar.gz: !binary |-
-    OTg3OTZhODY2ZTFmNjE4NGQzYzE5ZTI0YmI2ZGIzZWZjYjJiOTNiNjJlN2Iw
-    N2NkY2ViMzliYTM1MDZiZjI4NzVlYWVmNWQ2ZDY5NjE2MjAwMDQ4YzQ4MWQw
-    MjhlNTYzN2ZmNDdiOThlMmE1Yjk0OGU1OTU3ZmYwNGFiZWYyNDU=
+  metadata.gz: f6a173be5591946ed8679e8010b2c008a49228d3789581a1f360f74dc29b5d77d1a8d0734ad7e4401aba9dc68efe5c2702b8d82242057548ee87523578915219
+  data.tar.gz: 4338b8518c3673270d7cd469c489e0b9af4a2d7d8c951cc2f441babb1691f27ccfe877be561bc3d4816e141a39e081f0efa37ce6ff3cf8ab02947376848daa6e

data/lib/active_utils/common/error.rb

@@ -23,4 +23,7 @@ module ActiveMerchant #:nodoc:
 
   class ClientCertificateError < ActiveMerchantError # :nodoc
   end
+
+  class InvalidResponseError < ActiveMerchantError # :nodoc
+  end
 end

data/lib/active_utils/common/network_connection_retries.rb

@@ -23,6 +23,8 @@ module ActiveMerchant
         rescue OpenSSL::X509::CertificateError => e
           NetworkConnectionRetries.log(options[:logger], :error, e.message, options[:tag])
           raise ActiveMerchant::ClientCertificateError, "The remote server did not accept the provided SSL certificate"
+        rescue Zlib::BufError => e
+          raise ActiveMerchant::InvalidResponseError, "The remote server replied with an invalid response" 
         rescue *connection_errors.keys => e
           raise ActiveMerchant::ConnectionError, connection_errors[e.class]
         end
@@ -47,7 +49,7 @@ module ActiveMerchant
         log_with_retry_details(options[:logger], initial_retries-retries, Time.now.to_f - request_start, e.message, options[:tag])
         retry unless retries.zero?
         raise ActiveMerchant::ConnectionError, e.message
-      rescue ActiveMerchant::ConnectionError => e
+      rescue ActiveMerchant::ConnectionError, ActiveMerchant::InvalidResponseError => e
         retries -= 1
         log_with_retry_details(options[:logger], initial_retries-retries, Time.now.to_f - request_start, e.message, options[:tag])
         retry if (options[:retry_safe] || retry_safe) && !retries.zero?

data/lib/active_utils/version.rb

@@ -1,3 +1,3 @@
 module ActiveUtils
-  VERSION = "2.0.1"
+  VERSION = "2.0.2"
 end

data/test/unit/network_connection_retries_test.rb

@@ -22,6 +22,14 @@ class NetworkConnectionRetriesTest < Test::Unit::TestCase
     end
   end
 
+  def test_invalid_response_error
+    assert_raises(ActiveMerchant::InvalidResponseError) do
+      retry_exceptions do
+        raise Zlib::BufError
+      end
+    end
+  end
+
   def test_unrecoverable_exception_logged_if_logger_provided
     @logger.expects(:info).once
     assert_raises(ActiveMerchant::ConnectionError) do

metadata

@@ -1,69 +1,69 @@
 --- !ruby/object:Gem::Specification
 name: active_utils
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.2
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-25 00:00:00.000000000 Z
+date: 2014-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 2.3.11
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 2.3.11
 - !ruby/object:Gem::Dependency
   name: i18n
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: 
@@ -109,17 +109,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: active_utils
-rubygems_version: 2.1.5
+rubygems_version: 2.0.3
 signing_key: 
 specification_version: 4
 summary: Common utils used by active_merchant, active_fulfillment, and active_shipping