active_type 1.4.1 → 1.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 70a593b09da1c5389129939864d40d6ee562d2bf4b7a3bee41bbf749ba81efff
-  data.tar.gz: e8aa031eb6aac62a71556a85c23c55ffa2ee5efa52067226306faca924c7d240
+  metadata.gz: dc8f689fdb28d28edb7fc550d21e0c9d4810f298da570e9e8dc223a028c09dc1
+  data.tar.gz: 7f41ea5cd75b455190740c263f836d42cd268e0ab15e3143c9c8dfedb21e0b04
 SHA512:
-  metadata.gz: 3d287c42812f6afa854f608f52202c1ed6c38cd63aa6cbd7813abbad13c881e8ac333c3f5ce99503bb6c38221c19d0f858307174d37fdc84b2f74fc1b8a61fd1
-  data.tar.gz: a966aa55504b560c99782561854487465dc7f46715b5e6deb1eb2a13fa4f016a83147b9306679936147759c2592b83aaae273f809d6f5f3ff3bca6450b49a5dd
+  metadata.gz: da0b114cb9f97509bc8becad66a553538cbb362d07f9c8a6f1f17d7298282c302a83f477669110fd564f269b9dda5c2a009df41d40990a030044b90be869b03e
+  data.tar.gz: a9c59ed853ad1972ffd1d13d73eb452945f7c882bff1bc0dec49dec26a4b59c726b14381dd7a75f3905f0a5052906d027e8f500910e9b0395e6bc6a076639193

data/CHANGELOG.md

@@ -4,6 +4,14 @@ All notable changes to this project will be documented in this file.
 
 ## Unreleased changes
 
+## 1.4.2 (2020-09-17)
+
+* Fixed: Assigning values to virtual attributes through internal setter methods (e.g. `_write_attribute`) no longer results in "can't write unknown attribute" errors.
+
+## 1.4.1 (2020-08-05)
+
+* Fixed: Avoid `Module#parents` deprecation warning on Rails 6. Thanks to @cilim.
+
 ## 1.4.0 (2020-07-27)
 
 * Extended records now use their own I18n namespace when looking up translations for models or attributes.

data/Gemfile.3.2.mysql2.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.3.2)
+    active_type (1.4.2)
       activerecord (>= 3.2)
 
 GEM
@@ -54,4 +54,4 @@ DEPENDENCIES
   rspec (~> 3.4)
 
 BUNDLED WITH
-   2.0.2
+   2.1.4

data/Gemfile.3.2.sqlite3.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.3.2)
+    active_type (1.4.2)
       activerecord (>= 3.2)
 
 GEM
@@ -54,4 +54,4 @@ DEPENDENCIES
   sqlite3
 
 BUNDLED WITH
-   2.0.2
+   2.1.4

data/Gemfile.4.2.mysql2.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.3.2)
+    active_type (1.4.2)
       activerecord (>= 3.2)
 
 GEM
@@ -58,4 +58,4 @@ DEPENDENCIES
   rspec (~> 3.4)
 
 BUNDLED WITH
-   2.0.2
+   2.1.4

data/Gemfile.4.2.pg.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.3.2)
+    active_type (1.4.2)
       activerecord (>= 3.2)
 
 GEM
@@ -58,4 +58,4 @@ DEPENDENCIES
   rspec (~> 3.4)
 
 BUNDLED WITH
-   2.0.2
+   2.1.4

data/Gemfile.4.2.sqlite3.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.3.2)
+    active_type (1.4.2)
       activerecord (>= 3.2)
 
 GEM
@@ -58,4 +58,4 @@ DEPENDENCIES
   sqlite3
 
 BUNDLED WITH
-   2.0.2
+   2.1.4

data/Gemfile.5.2.mysql2.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.3.2)
+    active_type (1.4.2)
       activerecord (>= 3.2)
 
 GEM
@@ -56,4 +56,4 @@ DEPENDENCIES
   rspec (~> 3.4)
 
 BUNDLED WITH
-   2.0.2
+   2.1.4

data/Gemfile.5.2.pg.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.4.1)
+    active_type (1.4.2)
       activerecord (>= 3.2)
 
 GEM

data/Gemfile.5.2.sqlite3.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.3.2)
+    active_type (1.4.2)
       activerecord (>= 3.2)
 
 GEM
@@ -56,4 +56,4 @@ DEPENDENCIES
   sqlite3
 
 BUNDLED WITH
-   2.0.2
+   2.1.4

data/Gemfile.6.0.pg.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_type (1.3.2)
+    active_type (1.4.2)
       activerecord (>= 3.2)
 
 GEM
@@ -56,4 +56,4 @@ DEPENDENCIES
   rspec (~> 3.4)
 
 BUNDLED WITH
-   2.0.2
+   2.1.4

data/lib/active_type/version.rb

@@ -1,3 +1,3 @@
 module ActiveType
-  VERSION = '1.4.1'
+  VERSION = '1.4.2'
 end

data/lib/active_type/virtual_attributes.rb

@@ -144,28 +144,47 @@ module ActiveType
       @virtual_attributes_cache ||= {}
     end
 
-    def [](name)
+    def read_existing_virtual_attribute(name, &block_when_not_virtual)
       if self.singleton_class._has_virtual_column?(name)
         read_virtual_attribute(name)
       else
-        super
+        yield
       end
     end
 
-    # ActiveRecord 4.2.1
-    def _read_attribute(name)
+    def write_existing_virtual_attribute(name, value, &block_when_not_virtual)
       if self.singleton_class._has_virtual_column?(name)
-        read_virtual_attribute(name)
+        write_virtual_attribute(name, value)
       else
-        super
+        yield
+      end
+    end
+
+    def [](name)
+      read_existing_virtual_attribute(name) { super }
+    end
+
+    if ActiveRecord::VERSION::STRING >= '4.2.0'
+      def _read_attribute(name)
+        read_existing_virtual_attribute(name) { super }
+      end
+    else
+      def read_attribute(name)
+        read_existing_virtual_attribute(name) { super }
       end
     end
 
     def []=(name, value)
-      if self.singleton_class._has_virtual_column?(name)
-        write_virtual_attribute(name, value)
-      else
-        super
+      write_existing_virtual_attribute(name, value) { super }
+    end
+
+    if ActiveRecord::VERSION::STRING >= '5.2.0'
+      def _write_attribute(name, value)
+        write_existing_virtual_attribute(name, value) { super }
+      end
+    else
+      def write_attribute(name, value)
+        write_existing_virtual_attribute(name, value) { super }
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_type
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.4.2
 platform: ruby
 authors:
 - Tobias Kraze
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-08-05 00:00:00.000000000 Z
+date: 2020-09-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -123,7 +123,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.8
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Make any Ruby object quack like ActiveRecord