active_type 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: af57ff59af07cfdb0a8576c733da8aa2d0e254ce
-  data.tar.gz: e1e04618118baf2b5260e20ed3685d695930e756
+  metadata.gz: 873fb9515c20f974ad20b3cd2b8f4fd787aa9649
+  data.tar.gz: 9fd4f0f639d4189fcd82778d94a63315733376a8
 SHA512:
-  metadata.gz: 91477402f2df135aa9a2bef4a3b63f51c113be820940f83c350230af27b76dcc3c16d587c11874bd64320e1115f68b8fb25c7904e9d6579e3313853fddb8ad08
-  data.tar.gz: 7f9fa15fc5ed489c5bee1350f07b97852e32732017c4bb0535d53f4e3fb36c928f20bb9b44dcb5ab6f1ebce5cb892a60e3c382e5e92044e38ef51c823409fb7b
+  metadata.gz: f6f51d7a8632c8701c5a1dc100aeadd769c0e646774533b3b4c459139eaa81a6144fca448d242c9da75dbb5968f1e2ef8a8eda034836a8b942ff6eb567bd0d2e
+  data.tar.gz: 1a581ee2b4c8dbab6f9d3be522f7a256b877dff9c1a98e7bef1ef294e4a154d48cbd09acc790425d73aa4844865b8902e90d82c520da6638094da1a58d7ba81e

data/.travis.yml

@@ -9,8 +9,8 @@ gemfile:
   - gemfiles/Gemfile.3.2
   - gemfiles/Gemfile.4.0
   - gemfiles/Gemfile.4.1
-  - gemfiles/Gemfile.4.2
-  - gemfiles/Gemfile.4.2.pg
+  - gemfiles/Gemfile.4.2.1
+  - gemfiles/Gemfile.4.2.1.pg
 before_script:
   - psql -c 'create database active_type_test;' -U postgres
 script: bundle exec rspec spec
@@ -27,17 +27,19 @@ matrix:
     - rvm: "1.8.7"
       gemfile: gemfiles/Gemfile.4.1
     - rvm: "1.8.7"
-      gemfile: gemfiles/Gemfile.4.2
+      gemfile: gemfiles/Gemfile.4.2.1
     - rvm: "1.8.7"
-      gemfile: gemfiles/Gemfile.4.2.pg
+      gemfile: gemfiles/Gemfile.4.2.1.pg
     - rvm: "1.9.3"
-      gemfile: gemfiles/Gemfile.4.2.pg
+      gemfile: gemfiles/Gemfile.4.2.1.pg
     - rvm: "2.0.0"
-      gemfile: gemfiles/Gemfile.4.2.pg
+      gemfile: gemfiles/Gemfile.4.2.1.pg
+
     - rvm: "2.1.2"
       gemfile: gemfiles/Gemfile.3.2
     - rvm: "2.1.2"
       gemfile: gemfiles/Gemfile.4.0
+
     - rvm: "2.2.0"
       gemfile: gemfiles/Gemfile.3.2
     - rvm: "2.2.0"

data/CHANGELOG.md

@@ -0,0 +1,49 @@
+# ActiveType Change Log
+
+All notable changes to this project will be documented in this file.
+
+ActiveType is in a pre-1.0 state. This means that its APIs and behavior are subject to breaking changes without deprecation notices. Until 1.0, version numbers will follow a [Semver][]-ish `0.y.z` format, where `y` is incremented when new features or breaking changes are introduced, and `z` is incremented for lesser changes or bug fixes.
+
+## [Unreleased]
+
+* Your contribution here!
+
+## [0.4.0][] (2015-06-12)
+
+* Add ActiveType.cast to cast ActiveRecord instances and relations to extended models
+
+## [0.3.5][] (2015-06-11)
+
+* Make gem crash during loading with ActiveRecord 4.2.0 because [#31](https://github.com/makandra/active_type/issues/31)
+
+## [0.3.4][] (2015-03-14)
+
+* Support belongs_to associations for ActiveRecord 4.2.1
+* Ensure that ActiveType::Object correctly validates boolean attributes (issue [#34](https://github.com/makandra/active_type/issues/34))
+
+## [0.3.3][] (2015-01-23)
+
+* Don't crash for database types without casting rules (fixes [#25](https://github.com/makandra/active_type/issues/25))
+
+## [0.3.2][] (2015-01-22)
+
+* Making the gem to work with Rails version 4.0.0
+* Use native database type for type casting in pg
+
+## [0.3.1][] (2014-11-19)
+
+* Support nested attributes in extended records (fixes [#17](https://github.com/makandra/active_type/issues/17))
+
+## [0.3.0][] (2014-09-23)
+
+* Add support for Rails 4.2beta
+
+[Semver]: http://semver.org
+[Unreleased]: https://github.com/makandra/active_type/compare/v0.4.0...HEAD
+[0.4.0]: https://github.com/makandra/active_type/compare/v0.3.5...v0.4.0
+[0.3.5]: https://github.com/makandra/active_type/compare/v0.3.4...v0.3.5
+[0.3.4]: https://github.com/makandra/active_type/compare/v0.3.3...v0.3.4
+[0.3.3]: https://github.com/makandra/active_type/compare/v0.3.2...v0.3.3
+[0.3.2]: https://github.com/makandra/active_type/compare/v0.3.1...v0.3.2
+[0.3.1]: https://github.com/makandra/active_type/compare/v0.3.0...v0.3.1
+[0.3.0]: https://github.com/makandra/active_type/compare/v0.2.1...v0.3.0

data/README.md

@@ -271,8 +271,8 @@ Supported options for `nests_many` / `nests_one` are:
   ```
 
 
-Casting
--------
+Casting records or relations
+----------------------------
 
 When working with ActiveType you will often find it useful to cast an ActiveRecord instance to its extended `ActiveType::Record` variant.
 
@@ -288,7 +288,7 @@ class SignUp < ActiveType::Record[User]
 end
 
 user = User.find(1)
-sign_up = ActiveType.cast(SignUp)
+sign_up = ActiveType.cast(user, SignUp)
 sign_up.is_a?(SignUp) # => true
 ```
 

data/Rakefile

@@ -4,7 +4,6 @@ require 'bundler/gem_tasks'
 desc 'Default: Run all specs.'
 task :default => 'all:spec'
 
-
 namespace :all do
 
   desc "Run specs on all versions"

data/gemfiles/Gemfile.3.2

@@ -5,3 +5,4 @@ gem 'rspec', '<2.99'
 gem 'sqlite3'
 
 gem 'active_type', :path => '..'
+gem 'i18n', '=0.6.11' # 0.7 no longer builds for Ruby 1.8.7

data/gemfiles/Gemfile.3.2.lock

@@ -21,7 +21,7 @@ GEM
     arel (3.0.3)
     builder (3.0.4)
     diff-lcs (1.2.5)
-    i18n (0.7.0)
+    i18n (0.6.11)
     multi_json (1.11.1)
     rspec (2.14.1)
       rspec-core (~> 2.14.0)
@@ -40,5 +40,6 @@ PLATFORMS
 DEPENDENCIES
   active_type!
   activerecord (~> 3.2.0)
+  i18n (= 0.6.11)
   rspec (< 2.99)
   sqlite3

data/lib/active_type/version.rb

@@ -1,3 +1,3 @@
 module ActiveType
-  VERSION = '0.4.0'
+  VERSION = '0.4.1'
 end

data/lib/active_type/virtual_attributes.rb

@@ -40,6 +40,8 @@ module ActiveType
         add_virtual_column(name, type, options)
         build_reader(name)
         build_writer(name)
+        build_value_was_method(name)
+        build_value_changed_method(name)
       end
 
       private
@@ -70,6 +72,22 @@ module ActiveType
         BODY
       end
 
+      def build_value_was_method(name)
+        @module.module_eval <<-BODY, __FILE__, __LINE__ + 1
+          def #{name}_was
+            nil
+          end
+        BODY
+      end
+
+      def build_value_changed_method(name)
+        @module.module_eval <<-BODY, __FILE__, __LINE__ + 1
+          def #{name}_changed?
+            not #{name}.nil?
+          end
+        BODY
+      end
+
       def validate_attribute_name!(name)
         unless name.to_s =~ /\A[A-z0-9_]*\z/
           raise InvalidAttributeNameError.new("'#{name}' is not a valid name for a virtual attribute")

data/spec/active_type/object_spec.rb

@@ -315,6 +315,10 @@ describe ActiveType::Object do
     it_should_behave_like "a class supporting dup for attributes", ActiveType::Object
   end
 
+  describe 'dirty tracking' do
+    it_should_behave_like 'a class supporting dirty tracking for virtual attributes', ActiveType::Object
+  end
+
   describe '#belongs_to' do
     subject { ObjectSpec::ObjectWithBelongsTo.new }
 

data/spec/active_type/record_spec.rb

@@ -199,6 +199,10 @@ describe ActiveType::Record do
     it_should_behave_like "a class supporting dup for attributes", RecordSpec::Record
   end
 
+  describe 'dirty tracking' do
+    it_should_behave_like 'a class supporting dirty tracking for virtual attributes', RecordSpec::Record
+  end
+
   describe 'persistence' do
 
     it 'persists to the database' do

data/spec/active_type/util_spec.rb

@@ -39,8 +39,8 @@ describe ActiveType::Util do
     describe 'for a relation' do
     
       it 'casts a scope to a scope of another class' do
-        record = UtilSpec::BaseRecord.create!(persisted_string: 'foo')
-        base_scope = UtilSpec::BaseRecord.where(persisted_string: 'foo')
+        record = UtilSpec::BaseRecord.create!(:persisted_string => 'foo')
+        base_scope = UtilSpec::BaseRecord.where(:persisted_string => 'foo')
         casted_scope = ActiveType::Util.cast(base_scope, UtilSpec::ExtendedRecord)
         casted_scope.build.should be_a(UtilSpec::ExtendedRecord)
         found_record = casted_scope.find(record.id)
@@ -49,9 +49,9 @@ describe ActiveType::Util do
       end
 
       it 'preserves existing scope conditions' do
-        match = UtilSpec::BaseRecord.create!(persisted_string: 'foo')
-        no_match = UtilSpec::BaseRecord.create!(persisted_string: 'bar')
-        base_scope = UtilSpec::BaseRecord.where(persisted_string: 'foo')
+        match = UtilSpec::BaseRecord.create!(:persisted_string => 'foo')
+        no_match = UtilSpec::BaseRecord.create!(:persisted_string => 'bar')
+        base_scope = UtilSpec::BaseRecord.where(:persisted_string => 'foo')
         casted_scope = ActiveType::Util.cast(base_scope, UtilSpec::ExtendedRecord)
         casted_match = UtilSpec::ExtendedRecord.find(match.id)
         casted_scope.to_a.should == [casted_match]
@@ -62,7 +62,7 @@ describe ActiveType::Util do
     describe 'for a record type' do
 
       it 'casts a base record to an extended record' do
-        base_record = UtilSpec::BaseRecord.create!(persisted_string: 'foo')
+        base_record = UtilSpec::BaseRecord.create!(:persisted_string => 'foo')
         extended_record = ActiveType::Util.cast(base_record, UtilSpec::ExtendedRecord)
         extended_record.should be_a(UtilSpec::ExtendedRecord)
         extended_record.should be_persisted
@@ -72,7 +72,7 @@ describe ActiveType::Util do
       end
 
       it 'casts an extended record to a base record' do
-        extended_record = UtilSpec::ExtendedRecord.create!(persisted_string: 'foo')
+        extended_record = UtilSpec::ExtendedRecord.create!(:persisted_string => 'foo')
         base_record = ActiveType::Util.cast(extended_record, UtilSpec::BaseRecord)
         base_record.should be_a(UtilSpec::BaseRecord)
         base_record.should be_persisted
@@ -82,33 +82,33 @@ describe ActiveType::Util do
       end
 
       it 'calls after_initialize callbacks of the cast target' do
-        base_record = UtilSpec::BaseRecord.create!(persisted_string: 'foo')
+        base_record = UtilSpec::BaseRecord.create!(:persisted_string => 'foo')
         extended_record = ActiveType::Util.cast(base_record, UtilSpec::ExtendedRecord)
         extended_record.virtual_string.should be_present
       end
 
       it 'lets after_initialize callbacks access attributes (bug in ActiveRecord#becomes)' do
-        base_record = UtilSpec::BaseRecord.create!(persisted_string: 'foo')
+        base_record = UtilSpec::BaseRecord.create!(:persisted_string => 'foo')
         extended_record = ActiveType::Util.cast(base_record, UtilSpec::ExtendedRecord)
         extended_record.virtual_string.should == 'persisted_string is foo'
       end
 
       it 'preserves the #type of an STI record that is casted to an ExtendedRecord' do
-        child_record = UtilSpec::Child.create!(persisted_string: 'foo')
+        child_record = UtilSpec::Child.create!(:persisted_string => 'foo')
         extended_child_record = ActiveType::Util.cast(child_record, UtilSpec::ExtendedChild)
         extended_child_record.should be_a(UtilSpec::ExtendedChild)
         extended_child_record.type.should == 'UtilSpec::Child'
       end
 
       it 'changes the #type of an STI record when casted to another type in the hierarchy' do
-        child_record = UtilSpec::Child.create!(persisted_string: 'foo')
+        child_record = UtilSpec::Child.create!(:persisted_string => 'foo')
         child_sibling_record = ActiveType::Util.cast(child_record, UtilSpec::ChildSibling)
         child_sibling_record.should be_a(UtilSpec::ChildSibling)
         child_sibling_record.type.should == 'UtilSpec::Child'
       end
 
       it 'preserves dirty tracking flags' do
-        base_record = UtilSpec::BaseRecord.create!(persisted_string: 'foo')
+        base_record = UtilSpec::BaseRecord.create!(:persisted_string => 'foo')
         base_record.changes.should == {}
         base_record.persisted_string = 'bar'
         base_record.changes.should == { 'persisted_string' => ['foo', 'bar'] }

data/spec/shared_examples/dirty_tracking.rb

@@ -0,0 +1,31 @@
+shared_examples_for "a class supporting dirty tracking for virtual attributes" do |klass|
+
+  subject do
+    Class.new(klass) do
+      attribute :virtual_attribute
+    end.new
+  end
+
+  describe '#virtual_attribute_was' do
+
+    it 'always returns nil, since there can be no previously saved value' do
+      subject.virtual_attribute_was.should be_nil
+    end
+
+  end
+
+  describe '#virtual_attribute_changed?' do
+
+    it 'returns true if the attribute is not nil' do
+      subject.virtual_attribute = 'foo'
+      subject.virtual_attribute_changed?.should be_true
+    end
+
+    it 'returns false if the attribute is nil' do
+      subject.virtual_attribute = nil
+      subject.virtual_attribute_changed?.should be_false
+    end
+
+  end
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_type
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Tobias Kraze
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-12 00:00:00.000000000 Z
+date: 2015-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -62,6 +62,7 @@ files:
 - ".gitignore"
 - ".ruby-version"
 - ".travis.yml"
+- CHANGELOG.md
 - LICENSE
 - README.md
 - Rakefile
@@ -106,6 +107,7 @@ files:
 - spec/shared_examples/coercible_columns.rb
 - spec/shared_examples/constructor.rb
 - spec/shared_examples/defaults.rb
+- spec/shared_examples/dirty_tracking.rb
 - spec/shared_examples/dupable.rb
 - spec/shared_examples/mass_assignment.rb
 - spec/spec_helper.rb
@@ -134,7 +136,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Make any Ruby object quack like ActiveRecord
@@ -154,6 +156,7 @@ test_files:
 - spec/shared_examples/coercible_columns.rb
 - spec/shared_examples/constructor.rb
 - spec/shared_examples/defaults.rb
+- spec/shared_examples/dirty_tracking.rb
 - spec/shared_examples/dupable.rb
 - spec/shared_examples/mass_assignment.rb
 - spec/spec_helper.rb