active_storage_silent_logs 0.1 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 772fc4a80106efe09e4a9e49ebb23d7b66c4a299
-  data.tar.gz: 3fbc28328723a813c6c0092dde3f334b8848c6cb
+SHA256:
+  metadata.gz: 385f684a5006952f768e6a13c4c4ae16bf5d91d7746cb314c81933c64e42c3ff
+  data.tar.gz: 73bf38fd7e80c3456316221496e8c0e5fa11bae9beeefdfb50865df1876d09bb
 SHA512:
-  metadata.gz: bea68343b0e85073188138cb6d2567b7ac29c69dd82bc8c2c88bf4e936ae5665258a886470a1885b0f7440e570a4fe52ab32bc483b6490c3e297179937f13f1d
-  data.tar.gz: 96a0c5f1332326d020c6e6bc8dc1dd0489431e3a7f5c51b5015cc332b91dd09004dafcc1579c44d5176f3e7bcc9027c234bdad6add0deae4b542570bb51b28a3
+  metadata.gz: cd9f975794edc04c7f3ac615e925f0ef49ac8181952bcf8c62b88e5821c58b47b7359cfd4630b64e317620613588541d952751da6ff6b3292abfdd660479c1ae
+  data.tar.gz: 971064ac28ed630b25bf71840538e92b41357dd98867c5a3cdf82dd8907c587c881a7d07e43353026df7ab5f8ced75b8dab2559606080bb587335b6e5ef0fad8

data/README.md

@@ -8,12 +8,18 @@ Processing by ActiveStorage::DiskController#show as PNG
   Parameters: {"content_type"=>"image/png", "disposition"=>"inline; filename=\"image.png\"; filename*=UTF-8''image.png", "encoded_key"=>"eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaEpJaDExUkhSelFuaHpNbVJyV1dsNFVsaGpaMXBTYVV0YWNGUUdPZ1pGVkE9PSIsImV4cCI6IjIwMTgtMDgtMjlUMTQ6MzA6MjAuMjE3WiIsInB1ciI6ImJsb2Jfa2V5In19--96a1e9bc562decfc1b9c22ebde2e57029ed5ea20", "filename"=>"image"}
 ```
 
+In console it looks like:
+
+[![Sample](https://raw.githubusercontent.com/igorkasyanchuk/active_storage_silent_logs/master/docs/log.png)](https://raw.githubusercontent.com/igorkasyanchuk/active_storage_silent_logs/master/docs/log.png)
+
 I think no. It looks like a garbage. 
 
 Imagine you have 1000 images to show! How long you need to scroll to see log of main request? 
 
 So if you want this gem can hide such logs for you. Very useful for development.
 
+** Since Rails logger is not thread-safe this gem doesn't fix all messages, since one thread could impact another. If you want to hide - run puma with only one thread (open `puma.rb` and put `threads_count = ENV.fetch("RAILS_MAX_THREADS") { 1 }`).**
+
 ## Usage
 
 Just add gem into `Gemfile` in Rails app.
@@ -22,7 +28,7 @@ Just add gem into `Gemfile` in Rails app.
 
 
 ```ruby
-gem 'active_storage_silent_logs', group: [:development, :test]
+gem 'active_storage_silent_logs', group: :development
 ```
 
 And then execute:
@@ -33,9 +39,13 @@ $ bundle
 ## TODO
 * verify with other storages (s3 and other cloud services)
 * can we disable puma logger?
+* is it possible to fix issue with thread-safe with logger?
 
 ## Contributing
+
 You are welcome to contribute and help with testing.
 
+To play with gem open `test/dummy` and run `rake db:migrate` + `rails s -b 0.0.0.0 puma`.
+
 ## License
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/lib/active_storage_silent_logs.rb

@@ -1,40 +1,3 @@
-require "active_storage_silent_logs/railtie"
-
-module ActiveStorageSilentLogs
-  class SilentLogger
-    KEY    = 'active_storage_silent_logs.old_level'.freeze
-    FORMAT = /rails\/active_storage/.freeze
-
-    def initialize(app)
-      @app = app
-    end
-
-    def call(env)
-      if skip?(env)
-        tssss(env) do
-          @app.call(env)
-        end
-      else
-        @app.call(env)
-      end
-    end
-
-    def tssss(env)
-      env[KEY] = Rails.logger.level
-      begin
-        Rails.logger.level = Logger::ERROR
-        yield
-      ensure
-        Rails.logger.level = env[KEY] if env[KEY]
-      end
-    end
-
-
-    private
-
-    def skip?(env)
-      env['PATH_INFO'] =~ FORMAT
-    end
-    
-  end
-end
+require "active_storage_silent_logs/silent_logger"
+require "active_storage_silent_logs/controller"
+require "active_storage_silent_logs/railtie"

data/lib/active_storage_silent_logs/controller.rb

@@ -0,0 +1,20 @@
+module ActiveStorageSilentLogs
+  module Controller
+    extend ActiveSupport::Concern
+
+    included do
+      around_action :__with_no_logger
+    end
+
+    def __with_no_logger
+      old_level = Rails.logger.level
+      begin
+        Rails.logger.level = Logger::ERROR
+        yield
+      ensure
+        Rails.logger.level = old_level
+      end
+    end
+    
+  end
+end

data/lib/active_storage_silent_logs/railtie.rb

@@ -1,9 +1,11 @@
 module ActiveStorageSilentLogs
   class Railtie < ::Rails::Railtie
     initializer "active_storage_silent_logs" do
-      #Rails.application.middleware.use ActiveStorageSilentLogs::SilentLogger
-
       Rails.application.config.middleware.insert_before Rack::Sendfile, ActiveStorageSilentLogs::SilentLogger
+
+      ActiveStorage::BaseController.send :include, ActiveStorageSilentLogs::Controller
+
+      Rails.application.config.filter_parameters += [:content_type, :disposition, :encoded_key, :signed_blob_id, :variation_key]
     end
   end
 end

data/lib/active_storage_silent_logs/silent_logger.rb

@@ -0,0 +1,41 @@
+module ActiveStorageSilentLogs
+  class SilentLogger
+    KEY    = 'active_storage_silent_logs.old_level'.freeze
+    FORMAT = /rails\/active_storage/.freeze
+
+    attr_reader :level
+
+    def initialize(app)
+      @app   = app
+      @level = Rails.logger.level
+    end
+
+    def call(env)
+      if skip?(env)
+        tssss(env) { @app.call(env) }
+      else
+        @app.call(env)
+      end
+    end
+
+    def tssss(env)
+      begin
+        Rails.logger.level = Logger::ERROR
+        yield
+      ensure
+        Rails.logger.level = level
+      end
+    end
+
+    private
+
+    def skip?(env)
+      env['PATH_INFO'] =~ FORMAT
+    end
+
+    def whats_is_going_on
+      puts "===================== #{Rails.logger.level}"
+    end
+
+  end
+end

data/lib/active_storage_silent_logs/version.rb

@@ -1,3 +1,3 @@
 module ActiveStorageSilentLogs
-  VERSION = '0.1'
+  VERSION = '0.1.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_storage_silent_logs
 version: !ruby/object:Gem::Version
-  version: '0.1'
+  version: 0.1.1
 platform: ruby
 authors:
 - Igor Kasyanchuk
@@ -77,7 +77,9 @@ files:
 - README.md
 - Rakefile
 - lib/active_storage_silent_logs.rb
+- lib/active_storage_silent_logs/controller.rb
 - lib/active_storage_silent_logs/railtie.rb
+- lib/active_storage_silent_logs/silent_logger.rb
 - lib/active_storage_silent_logs/version.rb
 - lib/tasks/active_storage_silent_logs_tasks.rake
 homepage: https://github.com/igorkasyanchuk/active_storage_silent_logs
@@ -100,7 +102,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Silent your Active Storage logs to avoid "noise" in logs.