active_snapshot 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7f9f530f0b44c50f31da3e79937c51551bc03ef8fe3d730c500068d642f10df5
-  data.tar.gz: '029ad3e165ef4bba92031c1db765335a0cee40b419ab5d4c4c1ed7b402dca595'
+  metadata.gz: 204744938dec9e53545cc73a6497d47b9463b76b0622491d442b5ed4169b7c83
+  data.tar.gz: dee647e71ff99f91e79764f6094e9253fa74b9641e6f2e611ea10485e3d1d570
 SHA512:
-  metadata.gz: 9a502d15dda8b60c30e20a3fe6feea694e92569f6ce44eca50fd0544b14947df44499d727502345527c6456b681995673d78ebd80ac4bf6117d9868535c06275
-  data.tar.gz: cf6014aa8d08761a4e38be0769917732610b7b1fe41925c9f5d02c36a53ad0551b7781ed85e333792b936e2c823884f38face8310bc8a6f25845e4995ac7c6e8
+  metadata.gz: fe9542a0beecba0f52d3d25f0dfbd1197f31eb4ab9758f7ccfaf0e5455dfd150ef6ee1ba81fc138383ff8004a9e26a037a6ad72c004766bac1f0a3bf68edb4e6
+  data.tar.gz: eeab5ae90f2dc09f34ece44aa51992df834cf552693849d4595554e08448d4d8fceac954cb5ccbbe47089b1a868eeb089b5391ed3cf8a410aad6d436e6a3ef6a

data/CHANGELOG.md

@@ -2,12 +2,17 @@ CHANGELOG
 ---------
 
 - **UNRELEASED**
-  * [View Diff](https://github.com/westonganger/active_snapshot/compare/v0.2.3...master)
+  * [View Diff](https://github.com/westonganger/active_snapshot/compare/v0.2.4...master)
   * Nothing yet
 
-- **UNRELEASED**
+- **v0.2.4** - Feb 25, 2022
+  * [View Diff](https://github.com/westonganger/active_snapshot/compare/v0.2.3...v0.2.4)
+  * [PR #20](https://github.com/westonganger/active_snapshot/pull/20) - Resolve error when `has_snapshot_children` has not been defined as it should be optional
+  * [PR #18](https://github.com/westonganger/active_snapshot/pull/18) - Fix bug where sub-classes of a model would not be assigned correctly as parent when restoring
+
+- **v0.2.3** - Jan 7, 2022
   * [View Diff](https://github.com/westonganger/active_snapshot/compare/v0.2.2...v0.2.3)
-  * Support Ruby 3.1
+  * Support Ruby 3.1 using `YAML.unsafe_load`
   * Fix unique constraint on snapshots.identifier column
 
 - **v0.2.2** - August 27, 2021

data/README.md

@@ -77,7 +77,7 @@ snapshot.restore!
 snapshot.destroy!
 ```
 
-# Restoring Associated / Child Records
+# Tracking Associated / Child Records
 
 ```ruby
 class Post < ActiveRecord::Base

data/lib/active_snapshot/models/concerns/snapshots_concern.rb

@@ -38,9 +38,7 @@ module ActiveSnapshot
     class_methods do
 
       def has_snapshot_children(&block)
-        if !block_given? && !defined?(@snapshot_children_proc)
-          raise ArgumentError.new("Invalid `has_snapshot_children` requires block to be defined")
-        elsif block_given?
+        if block_given?
           @snapshot_children_proc = block
         else
           @snapshot_children_proc

data/lib/active_snapshot/models/snapshot.rb

@@ -98,7 +98,7 @@ module ActiveSnapshot
 
           reified_children_hash[key] << reified_item
 
-        elsif [self.item_id, self.item_type] == [si.item_id, si.item_type]
+        elsif self.item_id == si.item_id && (self.item_type == si.item_type || si.item_type.constantize.new.is_a?(self.item_type.constantize))
           reified_parent = reified_item
         end
       end

data/lib/active_snapshot/version.rb

@@ -1,3 +1,3 @@
 module ActiveSnapshot
-  VERSION = "0.2.3".freeze
+  VERSION = "0.2.4".freeze
 end

data/test/dummy_app/app/models/parent_without_children.rb

@@ -0,0 +1,5 @@
+class ParentWithoutChildren < ApplicationRecord
+  include ActiveSnapshot
+
+  self.table_name = "posts"
+end

data/test/dummy_app/app/models/sub_post.rb

@@ -0,0 +1,11 @@
+class SubPost < Post
+  has_snapshot_children do
+    instance = self.class.includes(:comments, :notes).find(id)
+
+    {
+      comments: instance.comments,
+      notes: instance.notes,
+      nil_assoc: nil,
+    }
+  end
+end