active_shipping 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8daef7547a1eadf200bb06247f518cc9e5813a31
-  data.tar.gz: ea7675b5b350fdf8ea1372e87f22b3efcb99f74f
+  metadata.gz: '049d76632467f43502625eb1059dcc9db84009ff'
+  data.tar.gz: 2067401f05fcdad7fd6fd1b6bb14eb06dd08d90b
 SHA512:
-  metadata.gz: a2b9295a91d1a7af45debd3c659588b9e3f86fb212d266c58d4274a60db07f760ff0833dd01795ad69449bceafb3de154dcef1999c80c8bd26df753292f45c45
-  data.tar.gz: c1390c553d52b92720f7219ce72ee8f68589361b342346a8b88b2b616c1b668931472c17d816aeb4c74c91e35394e5c355b2428679d492d32d2969da1e08db5d
+  metadata.gz: 7240de267d12ccfeef56c846b4869f244ef2d9fc4094fb28ed560431f1815c9e0ad4840a03ea56fd25df8d1af28a82425dbfed332ebe4f2d1544572b00e1e209
+  data.tar.gz: 5520de3c6a87772b29241fe241a7a142d188f36e27de5ae6228ea83d83a61b6278cb468a371513ce7d05087795f59b1bdfe385a32478c2c4f904b3ef947105a5

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # ActiveShipping CHANGELOG
 
+### v2.0.1
+- Raise ActiveShipping::ResponseError error in favour of ActiveUtils::ResponseError for CanadaPostPWS#find_shipment_receipt
+
 ### v2.0.0
 - Drop support for < ruby 2.2, support ruby 2.4
 - Drop support for < Rails 4.2.

data/lib/active_shipping/carriers/canada_post_pws.rb

@@ -115,6 +115,8 @@ module ActiveShipping
     def find_shipment_receipt(shipping_id, options = {})
       response = ssl_get(shipment_receipt_url(shipping_id, options), headers(options, SHIPMENT_MIMETYPE, SHIPMENT_MIMETYPE))
       parse_shipment_receipt_response(response)
+    rescue ActiveUtils::ResponseError => e
+      raise ActiveShipping::ResponseError.new(e.message)
     end
 
     def retrieve_shipping_label(shipping_response, options = {})

data/lib/active_shipping/version.rb

@@ -1,3 +1,3 @@
 module ActiveShipping
-  VERSION = "2.0.0"
+  VERSION = "2.0.1"
 end

data/test/unit/carriers/canada_post_pws_shipping_test.rb

@@ -229,6 +229,16 @@ class CanadaPostPwsShippingTest < ActiveSupport::TestCase
     assert_equal @cp.parse_shipment_receipt_response(xml_response), response
   end
 
+  def test_find_shipment_receipt_returns_active_shipping_response_error_if_active_utils_response_error
+    options = @default_options.dup
+    bad_response = Net::HTTPResponse.new({}, 404, "404 Not Found")
+    response_error = ActiveUtils::ResponseError.new(bad_response)
+    @cp.expects(:ssl_get).once.raises(response_error)
+    assert_raises ActiveShipping::ResponseError do
+      response = @cp.find_shipment_receipt('1234567', options)
+    end
+  end
+
   def test_character_limit_on_customs_description
     @line_item1.first.stubs(:name).returns("Some super long description that exceeds the 44 character limit")
     options = @default_options.dup

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_shipping
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-30 00:00:00.000000000 Z
+date: 2017-05-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: measured