active_shipping 1.8.3 → 1.8.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 572372570feb79b6fd7481886401fa9b2fb89adb
-  data.tar.gz: f7b5f0dc4eda2870f548a9c9bf533cc8221e4e26
+  metadata.gz: 5712c0da451436687a6aa8d40beac5052f2a70ef
+  data.tar.gz: 428dfca820554e30e1878f4392f5382a19acf930
 SHA512:
-  metadata.gz: bacd3051567a465b2d3a1b8f1f1c430cc9b300ea5b0877bc0947d5ed43e83b9170fd772a21d417ee74de6329eeaf6b088ecfeb7c0957d3bf855eaa85506093f7
-  data.tar.gz: 546dd1e2a5855b9f86744da0dc14b3afa86aa67705af72156e3412d43844f0f8f204403e43e618ce30b4e8fdc1716eabd163713be44b8842e10f6f57fc7ac036
+  metadata.gz: a080e2b7592da6cf5650314ce14a91765a3ef3069a068fcbb48f809fcaa1a3be0d2b622544e3740e97153ff380ae944a9c590405ea66cfaab5238e0629b44889
+  data.tar.gz: 9ededa9fd2d52ddd0cd8d73185c79ddbf857eafd8ae8f728992d778c9f4b20b3cad4dd5d3586798b84d095df22ffa36b134f0391020106adf346791bd0b32a3e

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # ActiveShipping CHANGELOG
 
+### v1.8.4
+- Add price details to rate estimates
+- Fix encoding for UPS responses
+
 ### v1.8.3
 - Add description field to rate estimates
 

data/README.md

@@ -1,6 +1,6 @@
 # ActiveShipping [![Build status](https://travis-ci.org/Shopify/active_shipping.svg?branch=master)](https://travis-ci.org/Shopify/active_shipping)
 
-This library interfaces with the web services of various shipping carriers. The goal is to abstract the features that are most frequently used into a pleasant and consistent Ruby API.
+This library interfaces with the web services of various shipping carriers. The goal is to abstract the features that are most frequently used into a pleasant and consistent Ruby API:
 
 - Finding shipping rates
 - Registering shipments
@@ -116,15 +116,15 @@ After installing dependencies with `bundle install`, you can run the unit tests
 
 ## Development
 
-Yes, please! Take a look at the tests and the implementation of the Carrier class to see how the basics work. At some point soon there will be a carrier template generator along the lines of the gateway generator included in Active Merchant, but carrier.rb outlines most of what's necessary. The other main classes that would be good to familiarize yourself with are Location, Package, and Response.
+Yes, please! Take a look at the tests and the implementation of the Carrier class to see how the basics work. At some point soon there will be a carrier template generator along the lines of the gateway generator included in Active Merchant, but the [Carrier class](https://github.com/Shopify/active_shipping/blob/master/lib/active_shipping/carrier.rb) outlines most of what's necessary. The other main classes that would be good to familiarize yourself with are [Location](https://github.com/Shopify/active_shipping/blob/master/lib/active_shipping/location.rb), [Package](https://github.com/Shopify/active_shipping/blob/master/lib/active_shipping/package.rb), and [Response](https://github.com/Shopify/active_shipping/blob/master/lib/active_shipping/response.rb).
 
-For the features you add, you should have both unit tests and remote tests. It's probably best to start with the remote tests, and then log those requests and responses and use them as the mocks for the unit tests. You can see how this works with the USPS tests right now:
+For the features that you add, you should have both unit tests and remote tests. It's probably best to start with the remote tests, and then log those requests and responses and use them as the mocks for the unit tests. You can see how this works with the USPS tests right now:
 
-https://github.com/Shopify/active_shipping/blob/master/test/remote/usps_test.rb
-https://github.com/Shopify/active_shipping/blob/master/test/unit/carriers/usps_test.rb
-https://github.com/Shopify/active_shipping/tree/master/test/fixtures/xml/usps
+[https://github.com/Shopify/active_shipping/blob/master/test/remote/usps_test.rb](https://github.com/Shopify/active_shipping/blob/master/test/remote/usps_test.rb)
+[https://github.com/Shopify/active_shipping/blob/master/test/unit/carriers/usps_test.rb](https://github.com/Shopify/active_shipping/blob/master/test/unit/carriers/usps_test.rb)
+[https://github.com/Shopify/active_shipping/tree/master/test/fixtures/xml/usps](https://github.com/Shopify/active_shipping/tree/master/test/fixtures/xml/usps)
 
-To log requests and responses, just set the `logger` on your carrier class to some kind of `Logger` object:
+To log requests and responses, just set the `logger` on your Carrier class to some kind of `Logger` object:
 
 ```ruby
 ActiveShipping::USPS.logger = Logger.new($stdout)
@@ -132,11 +132,11 @@ ActiveShipping::USPS.logger = Logger.new($stdout)
 
 (This logging functionality is provided by the [`PostsData` module](https://github.com/Shopify/active_utils/blob/master/lib/active_utils/posts_data.rb) in the `active_utils` dependency.)
 
-To debug API requests and your code you can run `rake console` to start a Pry session with `ActiveShipping` included
+To debug API requests and your code, you can run `rake console` to start a Pry session with `ActiveShipping` included
 and instances of the various carriers set up with your test credentials.
-Look at the file `test/console.rb` to see the other goodies it provides.
+Look at the file [`test/console.rb`](https://github.com/Shopify/active_shipping/blob/master/test/console.rb) to see the other goodies it provides.
 
-After you've pushed your well-tested changes to your github fork, make a pull request and we'll take it from there! For more information, see CONTRIBUTING.md.
+After you've pushed your well-tested changes to your github fork, make a pull request, and we'll take it from there! For more information, see [CONTRIBUTING.md](https://github.com/Shopify/active_shipping/blob/master/CONTRIBUTING.md).
 
 ## Legal Mumbo Jumbo
 

data/dev.yml

@@ -15,3 +15,7 @@ commands:
       else
         bundle exec ruby -Itest "$@"
       fi
+
+packages:
+  - git@github.com:Shopify/dev-shopify.git
+

data/lib/active_shipping/carrier.rb

@@ -155,7 +155,7 @@ module ActiveShipping
       @last_request = r
     end
 
-    # Calculates a timestamp that corresponds a given number if business days in the future
+    # Calculates a timestamp that corresponds a given number of business days in the future
     #
     # @param days [Integer] The number of business days from now.
     # @return [DateTime] A timestamp, the provided number of business days in the future.

data/lib/active_shipping/carriers/ups.rb

@@ -1001,7 +1001,8 @@ module ActiveShipping
     end
 
     def commit(action, request, test = false)
-      ssl_post("#{test ? TEST_URL : LIVE_URL}/#{RESOURCES[action]}", request)
+      response = ssl_post("#{test ? TEST_URL : LIVE_URL}/#{RESOURCES[action]}", request)
+      response.encode('utf-8', 'iso-8859-1')
     end
 
     def within_same_area?(origin, location)

data/lib/active_shipping/carriers/usps.rb

@@ -118,8 +118,6 @@ module ActiveShipping
     # Array of U.S. possessions according to USPS: https://www.usps.com/ship/official-abbreviations.htm
     US_POSSESSIONS = %w(AS FM GU MH MP PW PR VI)
 
-    # TODO: figure out how USPS likes to say "Ivory Coast"
-    #
     # Country names:
     # http://pe.usps.gov/text/Imm/immctry.htm
     COUNTRY_NAME_CONVERSIONS = {

data/lib/active_shipping/rate_estimate.rb

@@ -75,6 +75,10 @@ module ActiveShipping
   #   Additional priced options bundled with the given rate estimate with price in cents
   #   @return [Array<{ code: String, price: Integer }>]
   #
+  # @!attribute charge_items
+  #   Breakdown of a shipping rate's price with amounts in cents.
+  #   @return [Array<{ group: String, code: String, name: String, description: String, amount: Integer }>]
+  #
   class RateEstimate
     attr_accessor :origin, :destination, :package_rates,
                 :carrier, :service_name, :service_code, :description,
@@ -82,7 +86,7 @@ module ActiveShipping
                 :currency, :negotiated_rate, :insurance_price,
                 :estimate_reference, :expires_at, :pickup_time,
                 :compare_price, :phone_required, :delivery_category,
-                :shipment_options
+                :shipment_options, :charge_items
 
     def initialize(origin, destination, carrier, service_name, options = {})
       self.origin, self.destination, self.carrier, self.service_name = origin, destination, carrier, service_name
@@ -107,6 +111,7 @@ module ActiveShipping
       self.insurance_price = options[:insurance_price]
       self.delivery_category = options[:delivery_category]
       self.shipment_options = options[:shipment_options] || []
+      self.charge_items = options[:charge_items] || []
     end
 
     # The total price of the shipments in cents.

data/lib/active_shipping/shipping_response.rb

@@ -11,7 +11,7 @@ module ActiveShipping
   #   @return [String]
   #
   # @!attribute tracking_number
-  #   The tracking number of the shipments, witch can be shared with the customer and
+  #   The tracking number of the shipments, which can be shared with the customer and
   #   be used for {ActiveShipping::Carrier#find_tracking_info}.
   #   @return [String]
   class ShippingResponse < Response

data/lib/active_shipping/tracking_response.rb

@@ -2,7 +2,7 @@ module ActiveShipping
 
   # Represents the response to a {ActiveShipping::Carrier#find_tracking_info} call.
   #
-  # @note Some carriers provide more information that others, so not all attributes
+  # @note Some carriers provide more information than others, so not all attributes
   #   will be set, depending on what carrier you are using.
   #
   # @!attribute carrier
@@ -82,7 +82,7 @@ module ActiveShipping
       @shipment_events.last
     end
 
-    # Returns `true` if something the shipment has arrived at the destination.
+    # Returns `true` if the shipment has arrived at the destination.
     # @return [Boolean]
     def is_delivered?
       @status == :delivered

data/lib/active_shipping/version.rb

@@ -1,3 +1,3 @@
 module ActiveShipping
-  VERSION = "1.8.3"
+  VERSION = "1.8.4"
 end

data/test/unit/carrier_test.rb

@@ -58,8 +58,8 @@ class CarrierTest < Minitest::Test
   end
 
   def test_timestamp_from_business_day_returns_two_days_in_the_future
-    current = DateTime.new(2016, 7, 19) # Tuesday
-    expected = DateTime.new(2016, 7, 21)
+    current = DateTime.parse("Tue 19 Jul 2016")
+    expected = DateTime.parse("Thu 21 Jul 2016")
 
     Timecop.freeze(current) do
       assert_equal expected, @carrier.send(:timestamp_from_business_day, 2)
@@ -67,8 +67,8 @@ class CarrierTest < Minitest::Test
   end
 
   def test_timestamp_from_business_day_returns_two_days_in_the_future_over_a_weekend
-    current = DateTime.new(2016, 7, 22) # Friday
-    expected = DateTime.new(2016, 7, 26)
+    current = DateTime.parse("Fri 22 Jul 2016")
+    expected = DateTime.parse("Tue 26 Jul 2016")
 
     Timecop.freeze(current) do
       assert_equal expected, @carrier.send(:timestamp_from_business_day, 2)
@@ -76,8 +76,8 @@ class CarrierTest < Minitest::Test
   end
 
   def test_timestamp_from_business_day_returns_fifteen_days_in_the_future
-    current = DateTime.new(2016, 7, 6) # Wednesday
-    expected = DateTime.new(2016, 7, 27) # includes 3 weekends
+    current = DateTime.parse("Wed 06 Jul 2016")
+    expected = DateTime.parse("Wed 27 Jul 2016") # includes 3 weekends
 
     Timecop.freeze(current) do
       assert_equal expected, @carrier.send(:timestamp_from_business_day, 15)
@@ -85,8 +85,8 @@ class CarrierTest < Minitest::Test
   end
 
   def test_timestamp_from_business_day_handles_saturday
-    current = DateTime.new(2016, 7, 9) # Saturday
-    expected = DateTime.new(2016, 7, 11)
+    current = DateTime.parse("Sat 09 Jul 2016")
+    expected = DateTime.parse("Mon 11 Jul 2016")
 
     Timecop.freeze(current) do
       assert_equal expected, @carrier.send(:timestamp_from_business_day, 1)
@@ -94,8 +94,8 @@ class CarrierTest < Minitest::Test
   end
 
   def test_timestamp_from_business_day_handles_sunday
-    current = DateTime.new(2016, 7, 10) # Sunday
-    expected = DateTime.new(2016, 7, 11)
+    current = DateTime.parse("Sun 10 Jul 2016")
+    expected = DateTime.parse("Mon 11 Jul 2016")
 
     Timecop.freeze(current) do
       assert_equal expected, @carrier.send(:timestamp_from_business_day, 1)
@@ -103,7 +103,7 @@ class CarrierTest < Minitest::Test
   end
 
   def test_timestamp_from_business_day_returns_datetime
-    Timecop.freeze(DateTime.civil(2016, 7, 19)) do
+    Timecop.freeze(DateTime.parse("Tue 19 Jul 2016")) do
       assert_equal DateTime, @carrier.send(:timestamp_from_business_day, 1).class
     end
   end

data/test/unit/carriers/canada_post_pws_register_test.rb

@@ -37,9 +37,11 @@ class CanadaPostPwsRegisterTest < Minitest::Test
     endpoint = @cp.endpoint + "ot/token"
     response = xml_fixture('canadapost_pws/register_token_response')
     @cp.expects(:ssl_post).with(endpoint, anything, anything).returns(response)
+    url = 'http://localhost:3000/cp-register/'
+    customer_id = "12345"
 
     response = @cp.register_merchant
-    assert "http://www.canadapost.ca/cpotools/apps/drc/merchant?return-url=#{CGI.escape('http://localhost:3000/cp-register/')}&token-id=#{response.token_id}&platform-id=111111111", response.redirect_url('http://localhost:3000/cp-register/', '111111111')
+    assert_equal "http://www.canadapost.ca/cpotools/apps/drc/merchant?return-url=#{customer_id}&token-id=#{response.token_id}&platform-id=#{url}", response.redirect_url(url, customer_id)
   end
 
   def test_retrieve_merchant_details

data/test/unit/carriers/fedex_test.rb

@@ -15,31 +15,31 @@ class FedExTest < Minitest::Test
   end
 
   def test_business_days
-    today = DateTime.civil(2013, 3, 12, 0, 0, 0, "-4") #Tuesday
+    today = DateTime.parse("Tue 12 Mar 2013 00:00:00-0400")
 
     Timecop.freeze(today) do
-      assert_equal DateTime.civil(2013, 3, 13, 0, 0, 0, "-4"), @carrier.send(:business_days_from, today, 1)
-      assert_equal DateTime.civil(2013, 3, 15, 0, 0, 0, "-4"), @carrier.send(:business_days_from, today, 3)
-      assert_equal DateTime.civil(2013, 3, 18, 0, 0, 0, "-4"), @carrier.send(:business_days_from, today, 4)
-      assert_equal DateTime.civil(2013, 3, 19, 0, 0, 0, "-4"), @carrier.send(:business_days_from, today, 5)
+      assert_equal DateTime.parse("Wed 13 Mar 2013 00:00:00-0400"), @carrier.send(:business_days_from, today, 1)
+      assert_equal DateTime.parse("Fri 15 Mar 2013 00:00:00-0400"), @carrier.send(:business_days_from, today, 3)
+      assert_equal DateTime.parse("Mon 18 Mar 2013 00:00:00-0400"), @carrier.send(:business_days_from, today, 4)
+      assert_equal DateTime.parse("Tue 19 Mar 2013 00:00:00-0400"), @carrier.send(:business_days_from, today, 5)
     end
   end
 
   def test_home_delivery_business_days
-    today = DateTime.civil(2013, 3, 12, 0, 0, 0, "-4") #Tuesday
+    today = DateTime.parse("Tue 12 Mar 2013 00:00:00-0400")
 
     Timecop.freeze(today) do
-      assert_equal DateTime.civil(2013, 3, 13, 0, 0, 0, "-4"), @carrier.send(:business_days_from, today, 1, true)
-      assert_equal DateTime.civil(2013, 3, 15, 0, 0, 0, "-4"), @carrier.send(:business_days_from, today, 3, true)
-      assert_equal DateTime.civil(2013, 3, 16, 0, 0, 0, "-4"), @carrier.send(:business_days_from, today, 4, true)
-      assert_equal DateTime.civil(2013, 3, 19, 0, 0, 0, "-4"), @carrier.send(:business_days_from, today, 5, true)
+      assert_equal DateTime.parse("Wed 13 Mar 2013 00:00:00-0400"), @carrier.send(:business_days_from, today, 1, true)
+      assert_equal DateTime.parse("Fri 15 Mar 2013 00:00:00-0400"), @carrier.send(:business_days_from, today, 3, true)
+      assert_equal DateTime.parse("Sat 16 Mar 2013 00:00:00-0400"), @carrier.send(:business_days_from, today, 4, true)
+      assert_equal DateTime.parse("Tue 19 Mar 2013 00:00:00-0400"), @carrier.send(:business_days_from, today, 5, true)
     end
   end
 
   def test_turn_around_time_default
     mock_response = xml_fixture('fedex/ottawa_to_beverly_hills_rate_response').gsub('<v6:DeliveryTimestamp>2011-07-29</v6:DeliveryTimestamp>', '')
 
-    today = DateTime.civil(2013, 3, 11, 0, 0, 0, "-4") #Monday
+    today = Date.parse("Mon 11 Mar 2013")
 
     Timecop.freeze(today) do
       delivery_date = Date.today + 7.days # FIVE_DAYS in fixture response, plus weekend
@@ -260,7 +260,7 @@ class FedExTest < Minitest::Test
 
     @carrier.expects(:commit).returns(mock_response)
 
-    today = DateTime.civil(2013, 3, 15, 0, 0, 0, "-4")
+    today = Date.parse("Fri 15 Mar 2013")
 
     Timecop.freeze(today) do
       rate_estimates = @carrier.find_rates( location_fixtures[:ottawa],
@@ -268,7 +268,7 @@ class FedExTest < Minitest::Test
                                             package_fixtures.values_at(:book, :wii), :test => true)
 
       # the above fixture will specify a transit time of 5 days, with 2 weekend days accounted for
-      delivery_date = Date.today + 7
+      delivery_date = Date.today + 5 + 2
       assert_equal delivery_date, rate_estimates.rates[0].delivery_date
     end
   end
@@ -278,7 +278,7 @@ class FedExTest < Minitest::Test
 
     @carrier.expects(:commit).returns(mock_response)
 
-    today = DateTime.civil(2015, 06, 04, 0, 0, 0, "-4") #Thursday
+    today = Date.parse("Thursday 04 Jun 2015")
 
     Timecop.freeze(today) do
       rate_estimates = @carrier.find_rates( location_fixtures[:ottawa],
@@ -298,7 +298,7 @@ class FedExTest < Minitest::Test
 
     @carrier.expects(:commit).returns(mock_response)
 
-    today = DateTime.civil(2015, 06, 03, 0, 0, 0, "-4") #Wednesday
+    today = Date.parse("Wed 03 Jun 2015") #Wednesday
 
     Timecop.freeze(today) do
       rate_estimates = @carrier.find_rates( location_fixtures[:ottawa],

data/test/unit/carriers/shipwire_test.rb

@@ -23,7 +23,7 @@ class ShipwireTest < Minitest::Test
   end
 
   def test_successfully_get_international_rates
-    date = DateTime.new(2011, 8, 1)
+    date = DateTime.parse("Mon 01 Aug 2011")
     @carrier.expects(:ssl_post).returns(xml_fixture('shipwire/international_rates_response'))
 
     Timecop.freeze(date) do
@@ -49,7 +49,7 @@ class ShipwireTest < Minitest::Test
   end
 
   def test_successfully_get_domestic_rates
-    date = DateTime.new(2011, 8, 1)
+    date = DateTime.parse("Mon 01 Aug 2011")
     @carrier.expects(:ssl_post).returns(xml_fixture('shipwire/rates_response'))
 
     Timecop.freeze(date) do

data/test/unit/carriers/ups_test.rb

@@ -179,6 +179,13 @@ class UPSTest < Minitest::Test
     assert_equal "Failure: Package exceeds the maximum length constraint of 108 inches. Length is the longest side of a package.", e.message
   end
 
+  def test_response_parsing_an_undecoded_character
+    unencoded_response = @tracking_response.gsub('NAPERVILLE', "N\xc4PERVILLE")
+    @carrier.stubs(:ssl_post).returns(unencoded_response)
+    response = @carrier.find_tracking_info('1Z5FX0076803466397')
+    assert_equal 'NÄPERVILLE', response.shipment_events.first.location.city
+  end
+
   def test_response_parsing_an_unknown_error
     mock_response = '<RatingServiceSelectionResponse><Response><ResponseStatusCode>0</ResponseStatusCode></Response></RatingServiceSelectionResponse>'
     @carrier.expects(:commit).returns(mock_response)
@@ -527,7 +534,7 @@ class UPSTest < Minitest::Test
     )
 
     response.delivery_estimates.each do |delivery_estimate|
-      assert delivery_estimate.service_name, UPS::DEFAULT_SERVICES[delivery_estimate.service_code]
+      assert_equal delivery_estimate.service_code, UPS::DEFAULT_SERVICE_NAME_TO_CODE[delivery_estimate.service_name]
     end
   end
 

data/test/unit/rate_estimate_test.rb

@@ -6,7 +6,7 @@ class RateEstimateTest < Minitest::Test
     @destination = {city: "Beverly Hills", state: "CA", country: "United States", postal_code: "90210"}
     @line_items  = [Package.new(500, [2, 3, 4], description: "a box full of stuff", value: 2500)]
     @carrier     = CanadaPost.new(login: 'test')
-    @options     = {currency: 'USD', delivery_range: [DateTime.new(2016, 7, 1), DateTime.new(2016, 7, 3)]}
+    @options     = {currency: 'USD', delivery_range: [DateTime.parse("Fri 01 Jul 2016"), DateTime.parse("Sun 03 Jul 2016")]}
 
     @rate_estimate = RateEstimate.new(@origin, @destination, @carrier, @service_name, @options)
   end
@@ -63,8 +63,30 @@ class RateEstimateTest < Minitest::Test
     assert_equal "local_delivery", est.delivery_category
   end
 
+  def test_charge_items_is_set
+    charge_items = [
+      {
+        group: "base_charge",
+        code: 'label',
+        name: "USPS Priority Mail label",
+        description: "USPS Priority Mail label to New York, NY, US",
+        amount: 14.64
+      },
+      {
+        group: "included_option",
+        code: 'tracking',
+        name: "Tracking",
+        description: "Free tracking",
+        amount: 0
+      }
+    ]
+    est = RateEstimate.new(@origin, @destination, @carrier, @service_name, @options.merge(charge_items: charge_items))
+
+    assert_equal charge_items, est.charge_items
+  end
+
   def test_delivery_date_pulls_from_delivery_range
-    assert_equal [DateTime.new(2016, 7, 1), DateTime.new(2016, 7, 3)], @rate_estimate.delivery_range
-    assert_equal DateTime.new(2016, 7, 3), @rate_estimate.delivery_date
+    assert_equal [DateTime.parse("Fri 01 Jul 2016"), DateTime.parse("Sun 03 Jul 2016")], @rate_estimate.delivery_range
+    assert_equal DateTime.parse("Sun 03 Jul 2016"), @rate_estimate.delivery_date
   end
 end

data/test/unit/shipment_event_test.rb

@@ -4,7 +4,7 @@ class ShipmentEventTest < Minitest::Test
   def test_equality
     options1 = [
       'ARRIVED AT UNIT',
-      DateTime.new(2016, 5, 12, 5, 45),
+      DateTime.parse('Thu 12 May 2016 05:45:00'),
       Location.new(city: 'SAN JOSE', state: 'CA', postal_code: '90001', country: 'US'),
       'ARRIVED AT UNIT',
       '07'

data/test/unit/tracking_response_test.rb

@@ -7,19 +7,19 @@ class TrackingResponseTest < Minitest::Test
       status: 'DELIVERED',
       status_code: 'I0',
       status_description: 'DELIVERED',
-      actual_delivery_date: DateTime.new(2016, 5, 14, 13, 20),
+      actual_delivery_date: DateTime.parse("Sat 14 May 2016 13:20:00"),
       tracking_number: 'TRACKINGNUMBER1234ABC',
       shipment_events: [
         ShipmentEvent.new(
           'DELIVERED',
-          DateTime.new(2016, 5, 14, 13, 20),
+          DateTime.parse("Sat 14 May 2016 13:20:00"),
           Location.new(city: 'LOS ANGELES', state: 'CA', postal_code: '90210', country: 'US'),
           'DELIVERED',
           'I0'
         ),
         ShipmentEvent.new(
           'ARRIVED AT UNIT',
-          DateTime.new(2016, 5, 12, 5, 45),
+          DateTime.parse("Thu 12 May 2016 05:45:00"),
           Location.new(city: 'SAN JOSE', state: 'CA', postal_code: '90001', country: 'US'),
           'ARRIVED AT UNIT',
           '07'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_shipping
 version: !ruby/object:Gem::Version
-  version: 1.8.3
+  version: 1.8.4
 platform: ruby
 authors:
 - James MacAulay
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-08 00:00:00.000000000 Z
+date: 2016-11-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: quantified