active_scheduler 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 26ba70054e1bb771404a32c12fb267d203af40ff
-  data.tar.gz: 8ae34c71ac6b98180726bac6c709d302d6fec381
+  metadata.gz: c723aa094616a7530ea528c8910f5abfe695d91b
+  data.tar.gz: a8286d5ebc009739893d72912fc3534158161dbe
 SHA512:
-  metadata.gz: 4ce49add1fbfd7c9f7855a9743c427f52c425bcb90ecf8937aefb1c92231d474f7acbfa5fc4e53f60fa9eb2a2c696033d1267f964ca4a0605ce2a4ab7053a6d3
-  data.tar.gz: 5c8b69658933b8c32f07d784ce01c95534c4b680c30c6a319015f257cc50e94d25d5f110970f3a40e52a7addb51b6c0989ef31844eaafa02c461bea5c0bcf1b9
+  metadata.gz: 42cc510cc65ff67895469f65ee436024faeaf4b064bf2e18e2264219ba89b55603c6f0f489008838db3e8c6bf107dcbc771d986d0e1599ab4e19b41e751ba4d3
+  data.tar.gz: 71cba03ce129f5a22a5b948f71a3cc3428d0a09939c0df418c77ce364e43d3251a6f2aae43c3639c1c9a0c38425e6d44ce0e0e7d89c58cbc9d0e46a93b73ba2f

data/CHANGELOG.markdown

@@ -1,3 +1,7 @@
+# 0.2.0
+
+- Deprecate `arguments` in favor of `args` [#5](https://github.com/JustinAiken/active_scheduler/pull/5)
+
 # 0.1.0
 
 - Only wrap jobs that are descendants of `ActiveJob::Base` [#3](https://github.com/JustinAiken/active_scheduler/pull/3)

data/lib/active_scheduler/resque_wrapper.rb

@@ -20,6 +20,14 @@ module ActiveScheduler
         next unless class_name.constantize <= ActiveJob::Base
 
         queue = opts[:queue] || 'default'
+        args = opts[:args]
+
+        if !args && opts.has_key?(:arguments)
+          warn 'active_scheduler: [DEPRECATION] using the `arguments` key in ' \
+            'your resque schedule will soon be deprecated. Please revert to ' \
+            'the resque standard `args` key.'
+          args = opts[:arguments]
+        end
 
         schedule[job] = {
           class:        'ActiveScheduler::ResqueWrapper',
@@ -27,7 +35,7 @@ module ActiveScheduler
           args: [{
             job_class:  class_name,
             queue_name: queue,
-            arguments:  opts[:arguments]
+            arguments:  args
           }]
         }
 

data/lib/active_scheduler/version.rb

@@ -1,3 +1,3 @@
 module ActiveScheduler
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/spec/active_scheduler/resque_wrapper_spec.rb

@@ -18,7 +18,7 @@ describe ActiveScheduler::ResqueWrapper do
           "args"        => [{
             "job_class"  => "SimpleJob",
             "queue_name" => "simple",
-            "arguments"  => nil
+            "arguments"  => ['foo-arg-1', 'foo-arg-2'],
           }]
         )
       end
@@ -31,7 +31,7 @@ describe ActiveScheduler::ResqueWrapper do
             "queue"       => "simple",
             "description" => "It's a simple job.",
             "every"       => "30s",
-            "args"        => [nil],
+            "args"        => ['foo-arg-1', 'foo-arg-2'],
           )
         end
       end
@@ -50,7 +50,7 @@ describe ActiveScheduler::ResqueWrapper do
           "args"        => [{
             "job_class"  => "SimpleJob",
             "queue_name" => "simple",
-            "arguments"  => nil
+            "arguments"  => "foo-argument",
           }]
         )
       end
@@ -98,7 +98,7 @@ describe ActiveScheduler::ResqueWrapper do
           "args"        => [{
             "job_class"  => "MyScheduleNameIsClassNameJob",
             "queue_name" => "myscheduledjobqueue",
-            "arguments"  => nil
+            "arguments"  => [nil]
           }]
         )
       end

data/spec/fixtures/simple_job.json

@@ -3,6 +3,7 @@
     "every": "30s",
     "queue": "simple",
     "class": "SimpleJob",
-    "description": "It's a simple job."
+    "description": "It's a simple job.",
+    "arguments": "foo-argument"
   }
 }

data/spec/fixtures/simple_job.yaml

@@ -3,5 +3,6 @@ simple_job:
   queue: "simple"
   class: "SimpleJob"
   args:
-    -
+    - foo-arg-1
+    - foo-arg-2
   description: "It's a simple job."

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_scheduler
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Justin Aiken
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-29 00:00:00.000000000 Z
+date: 2016-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob