active_sanity 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 5cf8143fcceaa8ee3dd6fe9ceff8f66844b62f47
-  data.tar.gz: e07b90a22a9591f456786e02a816d683b876f70c
+SHA256:
+  metadata.gz: '0558af4db68be1d5ad7994453fee0a5abdfd3a79fd0e01417fa25afa7dc6ad98'
+  data.tar.gz: 7422349844512998be28691efc24d2211554a819f395cc39b0540d4edeedf398
 SHA512:
-  metadata.gz: 1072acfdf533b9ae67c1d6d146978e2c472a356c3d2f4acb6f23d3bc72dadb21196c0675a4f63cae9871f78c05c5c763d3f59d1b9d908e0e7960012817f882cd
-  data.tar.gz: 57c275494f381403304da75d3a3193d5e544481c4e2141d56ff959d5fc23ad0adc2b623f51e36300b062dcbfdbf8566a6a306fed49c0bd40836610560eb804f7
+  metadata.gz: 4f825526ec0ee8c0a52ad40beef09c86cb5f64f7a8e61f2ed4beb01e1f22e56a97a77dfc4b7cf3368e147181f33b3829ad631bf9631d6b16fab12805ae11e493
+  data.tar.gz: bee1b677fd834b29b3b8edc1c573372b6de0a3db0b8edf2cf86a88c0ecdc7b89fbb0d576c17525c04fea54de13f8671e009c9f16472b846b1b6b6aa3e403fa1d

data/.circleci/config.yml

@@ -0,0 +1,18 @@
+version: 2.1
+orbs:
+  ruby: circleci/ruby@0.1.2
+
+jobs:
+  build:
+    docker:
+      - image: circleci/ruby:2.6.3-stretch-node
+    executor: ruby/default
+    steps:
+      - checkout
+      - run:
+          name: Which bundler?
+          command: bundle -v
+      - ruby/bundle-install
+      - run:
+          name: cucumber
+          command: RAILS_ENV=test bundle exec cucumber

data/Gemfile

@@ -4,3 +4,4 @@ source 'http://rubygems.org'
 gemspec
 
 gem 'sqlite3'
+gem 'bootsnap', require: false

data/README.md

@@ -1,12 +1,13 @@
 # Active Sanity
 
-[![Build Status](https://secure.travis-ci.org/pcreux/active_sanity.png)](http://travis-ci.org/pcreux/active_sanity)
+[![Build Status](https://circleci.com/gh/pcreux/active_sanity.svg?style=svg)](https://circleci.com/gh/pcreux/active_sanity)
 
 Perform a sanity check on your database through active record
 validation.
 
 ## Requirements
 
+* ActiveSanity ~0.5 Rails ~5.0 or ~6.0
 * ActiveSanity ~0.3 and ~0.4 requires Rails ~4.0
 * ActiveSanity ~0.2 requires Rails ~3.1
 * ActiveSanity ~0.1 requires Rails ~3.0
@@ -19,14 +20,14 @@ Add the following line to your Gemfile
 
 If you wish to store invalid records in your database run:
 
-    $ rails generate active_sanity
-    $ rake db:migrate
+    $ bin/rails generate active_sanity
+    $ bin/rails db:migrate
 
 ## Usage
 
 Just run:
 
-    rake db:check_sanity
+    bin/rails db:check_sanity
 
 ActiveSanity will iterate over every records of all your models to check
 whether they're valid or not. It will save invalid records in the table
@@ -62,7 +63,7 @@ This gem is quite simple so I experiment using features only. To run the
 acceptance test suite, just run:
 
     bundle install
-    RAILS_ENV=test cucumber features
+    RAILS_ENV=test bundle exec cucumber features
 
 Using features only was kinda handsome until I had to deal with two
 different database schema (with / without the table invalid_records) in

data/active_sanity.gemspec

@@ -12,10 +12,9 @@ Gem::Specification.new do |s|
   s.description = 'Performs a Sanity Check of your database by logging all invalid Active Records'
   s.homepage    = 'https://github.com/pcreux/active_sanity'
 
-  s.add_dependency 'rails', '< 5.0'
-
-  s.required_ruby_version = '>= 1.9.3'
+  s.add_dependency 'rails', '>=5.0'
 
+  s.add_development_dependency 'rails', '~>6.0'
   s.add_development_dependency 'rspec', '~>3.1'
   s.add_development_dependency 'cucumber', '~>1.3'
   s.add_development_dependency 'sqlite3', '~>1.3'

data/features/check_sanity.feature

@@ -23,7 +23,7 @@ Feature: Check sanity
     When I run "rake db:check_sanity"
     Then I should see the following invalid records:
       | User     | 1 | {:username=>["can't be blank", "is too short (minimum is 3 characters)"]} |
-      | Post     | 1 | {:category=>["can't be blank"]} |
+      | Post     | 1 | {:category=>["must exist", "can't be blank"]} |
 
   Scenario: Check sanity on database with invalid records with ignored classes
     Given the database contains a few valid records

data/features/check_sanity_with_db_storage.feature

@@ -23,7 +23,7 @@ Feature: Check sanity with db storage
     When I run "rake db:check_sanity"
     Then the table "invalid_records" should contain:
       | User     | 1 | {:username=>["can't be blank", "is too short (minimum is 3 characters)"]} |
-      | Post     | 1 | {:category=>["can't be blank"]} |
+      | Post     | 1 | {:category=>["must exist", "can't be blank"]} |
 
   Scenario: Check sanity on database with invalid records now valid
     Given the database contains a few valid records
@@ -31,12 +31,12 @@ Feature: Check sanity with db storage
     When I run "rake db:check_sanity"
     Then the table "invalid_records" should contain:
       | User     | 1 | {:username=>["can't be blank", "is too short (minimum is 3 characters)"]} |
-      | Post     | 1 | {:category=>["can't be blank"]} |
+      | Post     | 1 | {:category=>["must exist", "can't be blank"]} |
 
     Given the first author's username is "Greg"
     When I run "rake db:check_sanity"
     Then the table "invalid_records" should contain:
-      | Post     | 1 | {:category=>["can't be blank"]} |
+      | Post     | 1 | {:category=>["must exist", "can't be blank"]} |
     Then the table "invalid_records" should not contain errors for "User" "1"
 
   Scenario: Check sanity on database with invalid records that were invalid for different reasons earlier
@@ -45,7 +45,7 @@ Feature: Check sanity with db storage
     When I run "rake db:check_sanity"
     Then the table "invalid_records" should contain:
       | User     | 1 | {:username=>["can't be blank", "is too short (minimum is 3 characters)"]} |
-      | Post     | 1 | {:category=>["can't be blank"]} |
+      | Post     | 1 | {:category=>["must exist", "can't be blank"]} |
 
     Given the first post category is set
     And the first post title is empty

data/features/step_definitions/rails_app.rb

@@ -1,10 +1,19 @@
+SystemCommandFailed = Class.new(StandardError)
+
+def system!(cmd)
+  system(cmd) || raise(SystemCommandFailed, cmd)
+end
+
 def setup_rails_app
   return if File.directory?('test/rails_app')
 
-  unless system 'bundle exec rails new test/rails_app -m test/rails_template.rb && cd ./test/rails_app && RAILS_ENV=test bundle exec rake db:migrate'
-    system('rm -fr test/rails_app')
-    fail 'Failed to generate test/rails_app'
-  end
+  system! 'bundle exec rails new test/rails_app --skip-sprockets --skip-spring --skip-javascript --skip-turbolinks'
+  system! 'cd ./test/rails_app && bundle'
+  system! 'cd ./test/rails_app && bin/rails app:template LOCATION=../rails_template.rb'
+  system!' cd ./test/rails_app && RAILS_ENV=test bin/rails db:migrate'
+rescue SystemCommandFailed => e
+  system!('rm -fr test/rails_app')
+  raise e
 end
 
 Given /^I have a rails app using 'active_sanity'$/ do
@@ -29,14 +38,14 @@ Given /^I have a rails app using 'active_sanity' with db storage$/ do
 
   # Reset connection
   ActiveRecord::Base.connection.reconnect!
-  InvalidRecord.table_exists? # Looks up if table exists.
+  InvalidRecord.table_exists?.should be true # Looks up if table exists.
 end
 
 Given /^the database contains a few valid records$/ do
   Author.create!(first_name: 'Greg', last_name: 'Bell', username: 'gregbell')
   Publisher.create!(first_name: 'Sam',  last_name: 'Vincent', username: 'samvincent')
   Category.create!(name: 'Uncategorized')
-  Post.create!(author: Author.first, category: Category.first,
+  Post.create!(author: Author.first!, category: Category.first!,
     title: 'How ActiveAdmin changed the world', body: 'Lot of love.',
     published_at: 4.years.from_now)
 end

data/features/support/env.rb

@@ -6,7 +6,7 @@ Bundler.setup
 
 if File.directory?('test/rails_app')
   Dir.chdir('test/rails_app') do
-    fail unless system('rm -f db/migrate/*create_invalid_records.rb && RAILS_ENV=test rake db:drop db:create db:migrate')
+    fail unless system('rm -f db/migrate/*create_invalid_records.rb && RAILS_ENV=test bin/rails db:drop db:create db:migrate')
   end
 end
 

data/lib/active_sanity/checker.rb

@@ -112,7 +112,7 @@ module ActiveSanity
     def store_invalid_record(record)
       return unless InvalidRecord.table_exists?
 
-      invalid_record = InvalidRecord.where(record_type: type_of(record), record_id: record.id).first
+      invalid_record = InvalidRecord.where(record: record).first
       invalid_record ||= InvalidRecord.new
       invalid_record.record = record
       invalid_record.validation_errors = record.errors.messages

data/lib/active_sanity/version.rb

@@ -1,3 +1,3 @@
 module ActiveSanity
-  VERSION = '0.4.0'
+  VERSION = '0.5.0'
 end

data/lib/generators/active_sanity/templates/create_invalid_records.rb.erb

@@ -1,5 +1,5 @@
-class CreateInvalidRecords < ActiveRecord::Migration<%= rails_version %>
-  def self.up
+class CreateInvalidRecords < ActiveRecord::Migration[<%= ActiveRecord::Migration.current_version %>]
+  def up
     create_table :invalid_records do |t|
       t.references :record, polymorphic: true, null: false
       t.text :validation_errors
@@ -7,7 +7,7 @@ class CreateInvalidRecords < ActiveRecord::Migration<%= rails_version %>
     end
   end
 
-  def self.down
+  def down
     drop_table :invalid_records
   end
 end

metadata

@@ -1,29 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: active_sanity
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Philippe Creux
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-20 00:00:00.000000000 Z
+date: 2020-06-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '6.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -74,6 +88,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".circleci/config.yml"
 - ".gitignore"
 - ".rubocop.yml"
 - CHANGELOG.md
@@ -106,15 +121,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Checks Sanity of Active Record records