active_sample 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6dd6c0bf33766ec1d797c6f4feb61388e0e7c65d
-  data.tar.gz: 5e3717c5e1739c29eaaf1fdd79a4cf2817ceb5bc
+  metadata.gz: f1513c164798f757b3fc73c5e68c2f35d05af054
+  data.tar.gz: a6a0d345d62422af604a2e343c1976e56cd2e5c3
 SHA512:
-  metadata.gz: 214b99ef168631ff5636ea41ff42959304ecf9b20628f7d93d30fa87490c39179fa71256629c91ac53faf5273e021478ed940d1a567ff68f22372ab7133f9f24
-  data.tar.gz: d8f3b7ec8c4ae6e24a97832feec7715388e558db6acf64f2e3501ba24974259ad687a98ec0371149e4fee1913ba7941854bef2cad3bc85313bf6a4d921a2eb9b
+  metadata.gz: beea2ea92ce72d877f58e0ce30f0a4219970d216fc4e8c539756e99d0f16e01aebe2380d7bc6478097e4bc10d0fe52ec8161bc5a2ed53376152b283a8027ddd9
+  data.tar.gz: 6e11efeb2582aa9b16771b39822f95b0f9e767d36055effd9a6acc74d1551c7b08931a67795b50e9f581c93697ce70c05d51feed37841bccc70dc0d4843675da

data/.travis.yml

@@ -2,3 +2,5 @@ sudo: false
 language: ruby
 rvm:
   - 2.3.0
+before_script:
+  - psql -c "create database test_active_sample;" -U postgres

data/CHANGELOG.md

@@ -0,0 +1,9 @@
+# Changelog
+
+## 1.0.1 - 2016.05.07
+
+- Improves `Model.sample(1)` case.
+
+## 1.0.0 - 2016.05.05
+
+- Initial release :tada:.

data/README.md

@@ -1,9 +1,14 @@
-# ActiveSample
+# Active Sample
+
+[![Gem Version](https://badge.fury.io/rb/active_sample.svg)](https://badge.fury.io/rb/active_sample)
+[![Build Status](https://travis-ci.org/JuanitoFatas/active_sample.svg?branch=master)](https://travis-ci.org/JuanitoFatas/active_sample)
 
 Sample functionality for Active Record.
 
 ## Usage
 
+**Don't use this for large set of data for now (See [#1](https://github.com/JuanitoFatas/active_sample/issues/1)).**
+
 ```ruby
 User.count # => 0
 User.sample => nil

data/lib/active_sample/version.rb

@@ -1,3 +1,3 @@
 module ActiveSample
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/lib/active_sample.rb

@@ -10,16 +10,18 @@ module ActiveSample
       raise NegativeSampleError.new("negative sample number".freeze)
     end
 
-    return nil if count == 0
+    max_id = maximum(:id)
 
-    if n > count
-      where(id: ids.shuffle)
-    elsif n > 1
-      where(id: ids.sample(n))
+    return nil if max_id == nil
+
+    if n == 1
+      while !(found = find_by(id: 1 + rand(max_id))); end
+
+      found
     elsif n == 0
-      where(id: [])
+      none
     else
-      find ids.sample
+      where(id: ids.sample(n))
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_sample
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - JuanitoFatas
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-05-04 00:00:00.000000000 Z
+date: 2016-05-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -34,6 +34,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md