active_remote 5.0.1 → 5.1.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 13ac236138c203bfc5f5992a45160b4100090f1f75354eec968ae4ea9aa4b586
-  data.tar.gz: 372f5fd8259cc0d333f676949990f2d75ef412e47a1ec7fce6f86565ab3082c4
+  metadata.gz: b1d90749f5dc8c010ca745ccf81c9167918666d334121659fcc0139fd2cbf0d8
+  data.tar.gz: 1fd7090e3d4f5e2c7c5230dcb5cbdc14be2dde8e11741081a77c60deb0c5088b
 SHA512:
-  metadata.gz: 62172bfc8d7eff79a0c69c5aed7a16bda69d5730e0085d16a569252018701fc863c7a65547f981efcd278dbf968ce1ed8ae81732c9bf308027842478c99bc413
-  data.tar.gz: 6851060fd28a08648c1c55c6e878af12b0509272a5d3690913a99b26808b67c885a10d614be7ce48c4d78a964584f967bd8748c899272316e95347364a11b565
+  metadata.gz: fbb5c5ec4d8f498e45db07b2e68af30542c76dde3c14008cebb5a70861c0768730e494af69d091026c83ad0449cc940a8f0f7c09b9e81c177a6afef61e79dd60
+  data.tar.gz: 17f944f3c0a44436bd0ab0d24d712bc1b420e5b1f90a2ea1d5bae8672320e4d3fea28efc5e86fcd24635198302c348a3a958cae9c068bdc28601ba12a5f982f2

data/active_remote.gemspec

@@ -20,8 +20,8 @@ Gem::Specification.new do |s|
   ##
   # Dependencies
   #
-  s.add_dependency "activemodel", ">= 5.0", "< 5.2"
-  s.add_dependency "activesupport", ">= 5.0"
+  s.add_dependency "activemodel", "~> 5.1.0"
+  s.add_dependency "activesupport", "~> 5.1.0"
   s.add_dependency "protobuf", ">= 3.0"
 
   ##

data/lib/active_remote/errors.rb

@@ -43,16 +43,6 @@ module ActiveRemote
   # Raised by ActiveRemove::Base.save! and ActiveRemote::Base.create! methods
   # when remote record cannot be saved because it is invalid.
   class RemoteRecordNotSaved < ActiveRemoteError
-    attr_reader :record
-
-    def initialize(message_or_record = nil)
-      message = message_or_record
-      if message_or_record.is_a?(::ActiveRemote::Base)
-        @record = message_or_record
-        message = @record.errors.full_messages.join(", ")
-      end
-      super(message)
-    end
   end
 
   class UnknownAttributeError < ActiveRemoteError

data/lib/active_remote/persistence.rb

@@ -198,7 +198,7 @@ module ActiveRemote
     # Also runs any before/after save callbacks that are defined.
     #
     def save!(*args)
-      save(*args) || fail(RemoteRecordNotSaved, self)
+      save(*args) || raise(RemoteRecordNotSaved)
     end
 
     # Returns true if the record doesn't have errors; otherwise, returns false.

data/lib/active_remote/version.rb

@@ -1,3 +1,3 @@
 module ActiveRemote
-  VERSION = "5.0.1"
+  VERSION = "5.1.0.rc1"
 end

data/spec/lib/active_remote/persistence_spec.rb

@@ -314,16 +314,9 @@ describe ::ActiveRemote::Persistence do
     end
 
     context "when the record is not saved" do
-      let(:errors) {
-        [Generic::Error.new(:field => "name", :message => "Error one!"),
-         Generic::Error.new(:field => "name", :message => "Error two!")]
-      }
-      let(:response) { Generic::Remote::Tag.new(:errors => errors) }
-      before { allow(rpc).to receive(:execute).and_return(response) }
-
       it "raises an exception" do
-        expect { subject.save! }
-          .to raise_error(ActiveRemote::RemoteRecordNotSaved, "Name Error one!, Name Error two!")
+        allow(subject).to receive(:save).and_return(false)
+        expect { subject.save! }.to raise_error(ActiveRemote::RemoteRecordNotSaved)
       end
     end
   end

metadata

@@ -1,49 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: active_remote
 version: !ruby/object:Gem::Version
-  version: 5.0.1
+  version: 5.1.0.rc1
 platform: ruby
 authors:
 - Adam Hutchison
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-16 00:00:00.000000000 Z
+date: 2019-01-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '5.0'
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: 5.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '5.0'
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: 5.1.0
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: 5.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: 5.1.0
 - !ruby/object:Gem::Dependency
   name: protobuf
   requirement: !ruby/object:Gem::Requirement
@@ -234,7 +228,6 @@ files:
 - spec/lib/active_remote/base_spec.rb
 - spec/lib/active_remote/dirty_spec.rb
 - spec/lib/active_remote/dsl_spec.rb
-- spec/lib/active_remote/errors_spec.rb
 - spec/lib/active_remote/integration_spec.rb
 - spec/lib/active_remote/persistence_spec.rb
 - spec/lib/active_remote/primary_key_spec.rb
@@ -284,12 +277,11 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.2
 signing_key: 
 specification_version: 4
 summary: Active Record for your platform
@@ -299,7 +291,6 @@ test_files:
 - spec/lib/active_remote/base_spec.rb
 - spec/lib/active_remote/dirty_spec.rb
 - spec/lib/active_remote/dsl_spec.rb
-- spec/lib/active_remote/errors_spec.rb
 - spec/lib/active_remote/integration_spec.rb
 - spec/lib/active_remote/persistence_spec.rb
 - spec/lib/active_remote/primary_key_spec.rb

data/spec/lib/active_remote/errors_spec.rb

@@ -1,31 +0,0 @@
-require "spec_helper"
-
-describe ::ActiveRemote::RemoteRecordNotSaved do
-  let(:record) { ::Tag.new }
-
-  before do
-    record.errors[:base] << "Some error one!"
-    record.errors[:base] << "Some error two!"
-  end
-
-  context "when an active remote record is used" do
-    it "uses embedded errors in message" do
-      expect { fail(::ActiveRemote::RemoteRecordNotSaved, record) }
-        .to raise_error(ActiveRemote::RemoteRecordNotSaved, "Some error one!, Some error two!")
-    end
-  end
-
-  context "when a string is used" do
-    it "uses the string in the error message" do
-      expect { fail(::ActiveRemote::RemoteRecordNotSaved, "something bad happened") }
-        .to raise_error(ActiveRemote::RemoteRecordNotSaved, "something bad happened")
-    end
-  end
-
-  context "when no message is used" do
-    it "raises the error" do
-      expect { raise(::ActiveRemote::RemoteRecordNotSaved) }
-        .to raise_error(ActiveRemote::RemoteRecordNotSaved)
-    end
-  end
-end