active_remote 5.0.0 → 5.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 58889edff927bdb8d472856d1a3823030f4e860609d0eb0b58252d97472fd7c0
-  data.tar.gz: c4cd26a134675a3d9b58fcd32d27819fb80ad266346f8f6e80b805951f5d8ab8
+  metadata.gz: 13ac236138c203bfc5f5992a45160b4100090f1f75354eec968ae4ea9aa4b586
+  data.tar.gz: 372f5fd8259cc0d333f676949990f2d75ef412e47a1ec7fce6f86565ab3082c4
 SHA512:
-  metadata.gz: 22d2776f3f15bec08625aa63518547b5e57039ab9ba29198b30b49bb0a071980689e42abda4910c0e8c03602965bf8e18e54a4b492f54fc913dcb8eb7365a314
-  data.tar.gz: 5e4fc4af095d9f5528a546a624d1c177d146a1b2d1aa54345b2c68f909682c51692a7a089dc064eefca6e1ed8d1b954ec1e8a457a61573bf45b79595285c3c1b
+  metadata.gz: 62172bfc8d7eff79a0c69c5aed7a16bda69d5730e0085d16a569252018701fc863c7a65547f981efcd278dbf968ce1ed8ae81732c9bf308027842478c99bc413
+  data.tar.gz: 6851060fd28a08648c1c55c6e878af12b0509272a5d3690913a99b26808b67c885a10d614be7ce48c4d78a964584f967bd8748c899272316e95347364a11b565

data/lib/active_remote/errors.rb

@@ -43,6 +43,16 @@ module ActiveRemote
   # Raised by ActiveRemove::Base.save! and ActiveRemote::Base.create! methods
   # when remote record cannot be saved because it is invalid.
   class RemoteRecordNotSaved < ActiveRemoteError
+    attr_reader :record
+
+    def initialize(message_or_record = nil)
+      message = message_or_record
+      if message_or_record.is_a?(::ActiveRemote::Base)
+        @record = message_or_record
+        message = @record.errors.full_messages.join(", ")
+      end
+      super(message)
+    end
   end
 
   class UnknownAttributeError < ActiveRemoteError

data/lib/active_remote/persistence.rb

@@ -198,7 +198,7 @@ module ActiveRemote
     # Also runs any before/after save callbacks that are defined.
     #
     def save!(*args)
-      save(*args) || raise(RemoteRecordNotSaved)
+      save(*args) || fail(RemoteRecordNotSaved, self)
     end
 
     # Returns true if the record doesn't have errors; otherwise, returns false.

data/lib/active_remote/version.rb

@@ -1,3 +1,3 @@
 module ActiveRemote
-  VERSION = "5.0.0"
+  VERSION = "5.0.1"
 end

data/spec/lib/active_remote/errors_spec.rb

@@ -0,0 +1,31 @@
+require "spec_helper"
+
+describe ::ActiveRemote::RemoteRecordNotSaved do
+  let(:record) { ::Tag.new }
+
+  before do
+    record.errors[:base] << "Some error one!"
+    record.errors[:base] << "Some error two!"
+  end
+
+  context "when an active remote record is used" do
+    it "uses embedded errors in message" do
+      expect { fail(::ActiveRemote::RemoteRecordNotSaved, record) }
+        .to raise_error(ActiveRemote::RemoteRecordNotSaved, "Some error one!, Some error two!")
+    end
+  end
+
+  context "when a string is used" do
+    it "uses the string in the error message" do
+      expect { fail(::ActiveRemote::RemoteRecordNotSaved, "something bad happened") }
+        .to raise_error(ActiveRemote::RemoteRecordNotSaved, "something bad happened")
+    end
+  end
+
+  context "when no message is used" do
+    it "raises the error" do
+      expect { raise(::ActiveRemote::RemoteRecordNotSaved) }
+        .to raise_error(ActiveRemote::RemoteRecordNotSaved)
+    end
+  end
+end

data/spec/lib/active_remote/persistence_spec.rb

@@ -314,9 +314,16 @@ describe ::ActiveRemote::Persistence do
     end
 
     context "when the record is not saved" do
+      let(:errors) {
+        [Generic::Error.new(:field => "name", :message => "Error one!"),
+         Generic::Error.new(:field => "name", :message => "Error two!")]
+      }
+      let(:response) { Generic::Remote::Tag.new(:errors => errors) }
+      before { allow(rpc).to receive(:execute).and_return(response) }
+
       it "raises an exception" do
-        allow(subject).to receive(:save).and_return(false)
-        expect { subject.save! }.to raise_error(ActiveRemote::RemoteRecordNotSaved)
+        expect { subject.save! }
+          .to raise_error(ActiveRemote::RemoteRecordNotSaved, "Name Error one!, Name Error two!")
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_remote
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 5.0.1
 platform: ruby
 authors:
 - Adam Hutchison
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-26 00:00:00.000000000 Z
+date: 2019-04-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -234,6 +234,7 @@ files:
 - spec/lib/active_remote/base_spec.rb
 - spec/lib/active_remote/dirty_spec.rb
 - spec/lib/active_remote/dsl_spec.rb
+- spec/lib/active_remote/errors_spec.rb
 - spec/lib/active_remote/integration_spec.rb
 - spec/lib/active_remote/persistence_spec.rb
 - spec/lib/active_remote/primary_key_spec.rb
@@ -287,7 +288,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubyforge_project: 
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Active Record for your platform
@@ -297,6 +299,7 @@ test_files:
 - spec/lib/active_remote/base_spec.rb
 - spec/lib/active_remote/dirty_spec.rb
 - spec/lib/active_remote/dsl_spec.rb
+- spec/lib/active_remote/errors_spec.rb
 - spec/lib/active_remote/integration_spec.rb
 - spec/lib/active_remote/persistence_spec.rb
 - spec/lib/active_remote/primary_key_spec.rb