active_remote 3.2.2 → 3.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2878525c112088bd33495008b9b277abc79d5e5eea871d9e54e9fd9e63f44db8
-  data.tar.gz: f06dac077bfcd9d1662d74631c859d96a9959904bc3502328ea8fa2c90757ec9
+  metadata.gz: ae8cf64c394e8f550a86ae5249454544d8a80c26f895f5358cd553a45d7d7a4c
+  data.tar.gz: 6ebd6029726c068e9f08ee8ec77e89309f9582c4b35f870b38edfd1b154a1138
 SHA512:
-  metadata.gz: 38159822cec60490ba7ae82bc8cedc3c65aefa0991d50ac849630ebfbec47c5896a341786914ac70f4b4e5b3991d37d7c899bbd19f7dd055618d95d0579a0d8f
-  data.tar.gz: cee03e271600b1dc3edadba8934e2fa77500918fe8945c004ab2b8cc6cc54c7188119bba524339217dfeb4a5c30f8515f3a5e07ac41e35185084c79ac88187fb
+  metadata.gz: bf3efedb46cd28754bc7ddad9c7c8a5b69483c8c68d77df57423ae34f60bccc98215a0239a920831ae92e1fab52fa2cd7e58a5788d0908df33569a75338d85f2
+  data.tar.gz: 553dc23127a1dd631ca176a427c08110295cbc128d38119eb4597fe520642b9ed700a41f3a629bdcc6de52883b8f411b1afe476e2d2050b23a7f24a129717afb

data/CHANGES.md

@@ -1,5 +1,49 @@
 # ActiveRemote Changes
 
+3.3.0
+----------
+
+- Add support for registering types that can be used to define attributes without using the existing `:type` or
+  `:typecaster` options  `attribute :name, :string` [#69]
+
+3.2.2
+----------
+
+- Speed up boolean typecasting [#67, @abrandoned]
+
+3.2.1
+----------
+
+- Use `:remote_call` instead of of `rpc.execute` in persistence, search
+
+3.2.0
+----------
+
+- Add ability to override default RPC endpoints [#66]
+- Require Active Model 4.x to 5.1 for compatibility
+
+3.1.3
+----------
+
+- Require Active Model 4.x for compatibility
+- Cache and dup default attributes instead of building from scratch (4x speed boost on initialize) [#63, @film42]
+
+3.1.2
+----------
+
+- Allow primary_key to be set on create [#61, @mattnichols]
+- Change the behavior of DateTime types to gracefully handle invalid dates [#62, @brianstien]
+
+3.1.1
+----------
+
+- Guard against undefined method errors in the Protobuf adapter [#59, @brianstien]
+
+3.1.0
+----------
+
+- Bubble up the type of error given from Protobuf instead of a generic `ActiveRemoteError` [#58, @ryanbjones]
+
 3.0.0
 ----------
 

data/active_remote.gemspec

@@ -33,4 +33,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency "pry"
   s.add_development_dependency "protobuf-rspec", ">= 1.1.2"
   s.add_development_dependency "simplecov"
+  s.add_development_dependency "benchmark-ips"
 end

data/bin/benchmark

@@ -0,0 +1,36 @@
+#!/usr/bin/env ruby
+
+require "bundler/setup"
+
+require "active_remote"
+require "benchmark/ips"
+
+require "./spec/support/models/typecasted_author"
+
+ATTRIBUTES = {
+  :guid => "0c030733-3b78-4587-b94b-5e0cf26497c5",
+  :name => "Charles Dickens",
+  :age => 68,
+  :birthday => "1812-02-07 00:00:00",
+  :writes_fiction => true,
+  :net_sales => 1_000_000.0
+}
+
+::Benchmark.ips do |x|
+  x.config(:time => 20, :warmup => 10)
+  x.report("initialize") do
+    ::TypecastedAuthor.new(ATTRIBUTES)
+  end
+
+  x.report("instantiate") do
+    ::TypecastedAuthor.instantiate(ATTRIBUTES)
+  end
+
+  x.report("init attributes") do
+    ::TypecastedAuthor.new(ATTRIBUTES).attributes
+  end
+
+  x.report("inst attributes") do
+    ::TypecastedAuthor.instantiate(ATTRIBUTES).attributes
+  end
+end

data/lib/active_remote/attribute_definition.rb

@@ -1,3 +1,5 @@
+require "active_remote/type"
+
 module ActiveRemote
   # Represents an attribute for reflection
   #
@@ -47,15 +49,17 @@ module ActiveRemote
     #   AttributeDefinition.new(:amount)
     #
     # @param [Symbol, String, #to_sym] name attribute name
+    # @param [Symbol] type attribute type
     # @param [Hash{Symbol => Object}] options attribute options
     #
     # @return [ActiveAttr::AttributeDefinition]
     #
     # @since 0.2.0
-    def initialize(name, options={})
+    def initialize(name, type = :unknown, **options)
       raise TypeError, "can't convert #{name.class} into Symbol" unless name.respond_to? :to_sym
       @name = name.to_sym
       @options = options
+      @options[:typecaster] = ::ActiveRemote::Type.lookup(type) unless type == :unknown
 
       if @options[:type]
         typecaster = ::ActiveRemote::Typecasting::TYPECASTER_MAP[@options[:type]]
@@ -101,6 +105,6 @@ module ActiveRemote
 
     # The attribute options
     # @since 0.5.0
-    attr_reader :options
+    attr_reader :options, :type
   end
 end

data/lib/active_remote/serializers/protobuf.rb

@@ -1,28 +1,32 @@
-require "active_remote/typecasting"
+require "active_remote/type"
 
 module ActiveRemote
   module Serializers
     module Protobuf
       extend ActiveSupport::Concern
 
-      TYPECASTER_MAP = {
-        ::Protobuf::Field::BoolField     => ActiveRemote::Typecasting::BooleanTypecaster,
-        ::Protobuf::Field::BytesField    => ActiveRemote::Typecasting::StringTypecaster,
-        ::Protobuf::Field::DoubleField   => ActiveRemote::Typecasting::FloatTypecaster,
-        ::Protobuf::Field::Fixed32Field  => ActiveRemote::Typecasting::IntegerTypecaster,
-        ::Protobuf::Field::Fixed64Field  => ActiveRemote::Typecasting::IntegerTypecaster,
-        ::Protobuf::Field::FloatField    => ActiveRemote::Typecasting::FloatTypecaster,
-        ::Protobuf::Field::Int32Field    => ActiveRemote::Typecasting::IntegerTypecaster,
-        ::Protobuf::Field::Int64Field    => ActiveRemote::Typecasting::IntegerTypecaster,
-        ::Protobuf::Field::Sfixed32Field => ActiveRemote::Typecasting::IntegerTypecaster,
-        ::Protobuf::Field::Sfixed64Field => ActiveRemote::Typecasting::IntegerTypecaster,
-        ::Protobuf::Field::Sint32Field   => ActiveRemote::Typecasting::IntegerTypecaster,
-        ::Protobuf::Field::Sint64Field   => ActiveRemote::Typecasting::IntegerTypecaster,
-        ::Protobuf::Field::StringField   => ActiveRemote::Typecasting::StringTypecaster,
-        ::Protobuf::Field::Uint32Field   => ActiveRemote::Typecasting::IntegerTypecaster,
-        ::Protobuf::Field::Uint64Field   => ActiveRemote::Typecasting::IntegerTypecaster
+      FIELD_TYPE_MAP = {
+        ::Protobuf::Field::BoolField => :boolean,
+        ::Protobuf::Field::BytesField => :string,
+        ::Protobuf::Field::DoubleField => :float,
+        ::Protobuf::Field::Fixed32Field => :float,
+        ::Protobuf::Field::Fixed64Field => :float,
+        ::Protobuf::Field::FloatField => :float,
+        ::Protobuf::Field::Int32Field => :integer,
+        ::Protobuf::Field::Int64Field => :integer,
+        ::Protobuf::Field::Sfixed32Field => :float,
+        ::Protobuf::Field::Sfixed64Field => :float,
+        ::Protobuf::Field::Sint32Field => :integer,
+        ::Protobuf::Field::Sint64Field => :integer,
+        ::Protobuf::Field::StringField => :string,
+        ::Protobuf::Field::Uint32Field => :integer,
+        ::Protobuf::Field::Uint64Field => :integer
       }
 
+      def self.type_name_for_field(field)
+        FIELD_TYPE_MAP[field.type_class]
+      end
+
       module ClassMethods
         def fields_from_attributes(message_class, attributes)
           Fields.from_attributes(message_class, attributes)
@@ -118,6 +122,10 @@ module ActiveRemote
           value.is_a?(Array) ? value : [ value ]
         end
 
+        def type_name
+          Serializers::Protobuf.type_name_for_field(field)
+        end
+
         def typecast(value)
           return value if value.nil?
 
@@ -129,7 +137,7 @@ module ActiveRemote
         end
 
         def typecaster
-          @typecaster ||= TYPECASTER_MAP[field.type_class]
+          @typecaster ||= Type.lookup(type_name)
         end
 
         def typecaster?

data/lib/active_remote/type.rb

@@ -0,0 +1,35 @@
+# Based on the type registry from Rails 5.0
+# https://github.com/rails/rails/blob/5-0-stable/activemodel/lib/active_model/type.rb
+#
+# TODO: Replace this with the Active Model type registry once Rails 4.2 support is dropped.
+#
+require "active_remote/type/registry"
+require "active_remote/typecasting"
+
+module ActiveRemote
+  module Type
+    @registry = Registry.new
+
+    class << self
+      attr_accessor :registry # :nodoc:
+
+      # Add a new type to the registry, allowing it to be gotten through ActiveRemote::Type#lookup
+      def register(type_name, klass)
+        registry.register(type_name, klass)
+      end
+
+      def lookup(type_name) # :nodoc:
+        registry.lookup(type_name)
+      end
+    end
+
+    register(:boolean, Typecasting::BooleanTypecaster)
+    register(:date, Typecasting::DateTypecaster)
+    register(:datetime, Typecasting::DateTimeTypecaster)
+    register(:decimal, Typecasting::BigDecimalTypecaster)
+    register(:float, Typecasting::FloatTypecaster)
+    register(:integer, Typecasting::IntegerTypecaster)
+    register(:object, Typecasting::ObjectTypecaster)
+    register(:string, Typecasting::StringTypecaster)
+  end
+end

data/lib/active_remote/type/registry.rb

@@ -0,0 +1,45 @@
+module ActiveRemote
+  module Type
+    class Registry
+      attr_reader :registrations
+
+      def initialize
+        @registrations = []
+      end
+
+      def register(type_name, typecaster)
+        registrations << registration_klass.new(type_name, typecaster)
+      end
+
+      def lookup(symbol)
+        registration = find_registration(symbol)
+        raise ArgumentError, "Unknown type #{symbol.inspect}" unless registration
+
+        registration.typecaster
+      end
+
+    private
+
+      def registration_klass
+        Registration
+      end
+
+      def find_registration(symbol)
+        registrations.find { |r| r.matches?(symbol) }
+      end
+    end
+
+    class Registration
+      attr_reader :name, :typecaster
+
+      def initialize(name, typecaster)
+        @name = name
+        @typecaster = typecaster
+      end
+
+      def matches?(type_name)
+        type_name == name
+      end
+    end
+  end
+end

data/lib/active_remote/version.rb

@@ -1,3 +1,3 @@
 module ActiveRemote
-  VERSION = "3.2.2"
+  VERSION = "3.3.0"
 end

data/spec/support/models/typecasted_author.rb

@@ -1,8 +1,8 @@
 class TypecastedAuthor < ::ActiveRemote::Base
   attribute :guid, :type => String
   attribute :name, :typecaster => StringTypecaster
-  attribute :age, :type => Integer
+  attribute :age, :integer
   attribute :birthday, :type => DateTime
-  attribute :writes_fiction, :type => Boolean
-  attribute :net_sales, :type => Float
+  attribute :writes_fiction, :boolean
+  attribute :net_sales, :typecaster => FloatTypecaster
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_remote
 version: !ruby/object:Gem::Version
-  version: 3.2.2
+  version: 3.3.0
 platform: ruby
 authors:
 - Adam Hutchison
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-31 00:00:00.000000000 Z
+date: 2019-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -156,12 +156,27 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: benchmark-ips
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Active Remote provides Active Record-like object-relational mapping over
   RPC. It was written for use with Google Protocol Buffers, but could be extended
   to use any RPC data format.
 email:
 - liveh2o@gmail.com
 executables:
+- benchmark
 - console
 extensions: []
 extra_rdoc_files: []
@@ -175,6 +190,7 @@ files:
 - README.md
 - Rakefile
 - active_remote.gemspec
+- bin/benchmark
 - bin/console
 - lib/active_remote.rb
 - lib/active_remote/association.rb
@@ -197,6 +213,8 @@ files:
 - lib/active_remote/search.rb
 - lib/active_remote/serialization.rb
 - lib/active_remote/serializers/protobuf.rb
+- lib/active_remote/type.rb
+- lib/active_remote/type/registry.rb
 - lib/active_remote/typecasting.rb
 - lib/active_remote/typecasting/big_decimal_typecaster.rb
 - lib/active_remote/typecasting/boolean.rb