active_remote 3.1.3 → 3.2.0.pre

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 072cf73e10eb058b67165e9e6743007a85e735a8
-  data.tar.gz: 40f741027abc44045d101767f1023ffa5980ba9c
+SHA256:
+  metadata.gz: 92f1ee499d90fb4274a13471bdb2759a522f703cfe5a7843b272842489ae6c78
+  data.tar.gz: b21aa7a6088c87be266c731780eafd9a770c4e6ac68c944e1ad6c80179d8e7c9
 SHA512:
-  metadata.gz: 371144c02d30eda9c90b25ed7b7b7f64068e4d584e956b451e8f5b48117d72cc49882330936fe7e5d258e31492fc1fb3a5c899db2127ba52af01897dc81ef0ae
-  data.tar.gz: a0eeea285d561ef98c25f0b1b813737c52323ef6cd01b84890065ff945041e715825cc79041b2a6cc45af694dbc0dac91d0662094b59888a789e61c34c607de3
+  metadata.gz: 1cf5c43c7455d6398eb78231df7743a3f70ab5c3d9265af63be031732c74d02ffd393271d8fb6e0e48c86a347c63027c5885a10a8fdedfac97c6d3e6a5b832d1
+  data.tar.gz: e9ae862fabefcd03f2a7fa98819efb8606d15f0310e6e34817b19f5050be0527167f0cbe3dce6a00c136e6fd655650bd6be4886c3b29649ace25c2bb47110134

data/Rakefile

@@ -1,6 +1,7 @@
 #!/usr/bin/env rake
 require "bundler/gem_tasks"
-require 'rspec/core/rake_task'
+require "protobuf/tasks"
+require "rspec/core/rake_task"
 
 desc "Run specs"
 RSpec::Core::RakeTask.new(:spec)
@@ -15,7 +16,6 @@ task :clean do
 end
 
 desc "Compile spec/support protobuf definitions"
-task :compile, [] => :clean do
-  cmd = "protoc --ruby_out=spec/support/protobuf --proto_path=spec/support/definitions spec/support/definitions/*.proto"
-  sh(cmd)
+task :compile do
+  ::Rake::Task["protobuf:compile"].invoke("", "spec/support/definitions", "spec/support/protobuf")
 end

data/active_remote.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |s|
   ##
   # Dependencies
   #
-  s.add_dependency "activemodel", ">= 4.0", "< 5"
+  s.add_dependency "activemodel", ">= 4.0", "< 5.2"
   s.add_dependency "activesupport", ">= 4.0"
   s.add_dependency "protobuf", ">= 3.0"
 

data/lib/active_remote/dsl.rb

@@ -20,6 +20,38 @@ module ActiveRemote
         @publishable_attributes += attributes
       end
 
+      def endpoint_for_create(endpoint)
+        endpoints :create => endpoint
+      end
+
+      def endpoint_for_delete(endpoint)
+        endpoints :delete => endpoint
+      end
+
+      def endpoint_for_destroy(endpoint)
+        endpoints :destroy => endpoint
+      end
+
+      def endpoint_for_search(endpoint)
+        endpoints :search => endpoint
+      end
+
+      def endpoint_for_update(endpoint)
+        endpoints :update => endpoint
+      end
+
+      def endpoints(endpoints_hash = nil)
+        @endpoints ||= {
+          :create  => :create,
+          :delete  => :delete,
+          :destroy => :destroy,
+          :search  => :search,
+          :update  => :update
+        }
+        @endpoints.merge!(endpoints_hash) if endpoints_hash.present?
+        @endpoints
+      end
+
       # Set the namespace for the underlying RPC service class. If no namespace
       # is given, then none will be used.
       #
@@ -105,6 +137,10 @@ module ActiveRemote
 
     # Private convenience methods for accessing DSL methods in instances
     #
+    def _endpoints
+      self.class.endpoints
+    end
+
     def _publishable_attributes
       self.class.publishable_attributes
     end

data/lib/active_remote/rpc.rb

@@ -34,7 +34,7 @@ module ActiveRemote
       end
 
       def rpc
-        rpc_adapter.new(service_class)
+        rpc_adapter.new(service_class, endpoints)
       end
 
       def rpc_adapter
@@ -58,6 +58,10 @@ module ActiveRemote
       end
     end
 
+    def remote_call(rpc_method, request_args)
+      self.class.remote_call(rpc_method, request_args)
+    end
+
     def rpc
       self.class.rpc
     end

data/lib/active_remote/rpc_adapters/protobuf_adapter.rb

@@ -6,20 +6,25 @@ module ActiveRemote
       include Serializers::Protobuf
 
       attr_reader :last_request, :last_response, :service_class
+      attr_accessor :endpoints
+
+      delegate :client, :to => :service_class
 
       ##
       # Constructor!
       #
-      def initialize(service_class)
+      def initialize(service_class, endpoints)
         @service_class = service_class
+        @endpoints = endpoints
       end
 
       # Invoke an RPC call to the service for the given rpc method.
       #
-      def execute(rpc_method, request_args)
+      def execute(endpoint, request_args)
+        rpc_method = endpoints.fetch(endpoint) { endpoint }
         @last_request = request(rpc_method, request_args)
 
-        service_class.client.__send__(rpc_method, @last_request) do |c|
+        client.__send__(rpc_method, @last_request) do |c|
           # In the event of service failure, raise the error.
           c.on_failure do |error|
             protobuf_error = protobuf_error_class(error)
@@ -35,7 +40,7 @@ module ActiveRemote
         @last_response
       end
 
-      private
+    private
 
       def protobuf_error_class(error)
         return ::ActiveRemote::ActiveRemoteError unless error.respond_to?(:error_type)

data/lib/active_remote/version.rb

@@ -1,3 +1,3 @@
 module ActiveRemote
-  VERSION = "3.1.3"
+  VERSION = "3.2.0.pre"
 end

data/spec/lib/active_remote/dsl_spec.rb

@@ -21,6 +21,27 @@ describe ActiveRemote::DSL do
     end
   end
 
+  describe ".endpoints" do
+    it "has default values" do
+      expect(Tag.endpoints).to eq({
+        :create => :create,
+        :delete => :delete,
+        :destroy => :destroy,
+        :search => :search,
+        :update => :update
+      })
+    end
+
+    context "given a new value for an endpoint" do
+      after { Tag.endpoints(:create => :create) }
+
+      it "overwrites default values" do
+        Tag.endpoints(:create => :register)
+        expect(Tag.endpoints[:create]).to eq(:register)
+      end
+    end
+  end
+
   describe ".namespace" do
     context "when given a value" do
       it "sets @namespace to the value" do

data/spec/lib/active_remote/persistence_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe ::ActiveRemote::Persistence do
   let(:response_without_errors) { ::HashWithIndifferentAccess.new(:errors => []) }
-  let(:rpc) { ::ActiveRemote::RPCAdapters::ProtobufAdapter.new(::Tag.service_class) }
+  let(:rpc) { ::ActiveRemote::RPCAdapters::ProtobufAdapter.new(::Tag.service_class, ::Tag.endpoints) }
 
   subject { ::Tag.new }
 

data/spec/lib/active_remote/rpc_adapters/protobuf_adapter_spec.rb

@@ -0,0 +1,24 @@
+require "spec_helper"
+
+describe ActiveRemote::RPCAdapters::ProtobufAdapter do
+  let(:adapter) { ActiveRemote::RPCAdapters::ProtobufAdapter.new(Tag.service_class, Tag.endpoints) }
+  let(:client) { double(:client) }
+
+  subject { adapter }
+
+  # The Protobuf RPC client relies on method missing and delegations
+  # Provide a client double to make it possible to add expectations that specific methods are called
+  before { allow(adapter).to receive(:client).and_return(client) }
+
+  describe "#execute" do
+    context "when a custom endpoint is defined" do
+      before { adapter.endpoints[:create] = :register }
+      after { adapter.endpoints[:create] = :create }
+
+      it "calls the custom endpoint" do
+        expect(adapter.client).to receive(:register)
+        adapter.execute(:create, { :name => "foo" })
+      end
+    end
+  end
+end

data/spec/lib/active_remote/rpc_spec.rb

@@ -35,7 +35,7 @@ describe ::ActiveRemote::RPC do
     let(:args) { double(:args) }
     let(:response) { double(:response) }
 
-    let(:rpc) { ::ActiveRemote::RPCAdapters::ProtobufAdapter.new(::Tag.service_class) }
+    let(:rpc) { ::ActiveRemote::RPCAdapters::ProtobufAdapter.new(::Tag.service_class, ::Tag.endpoints) }
 
     before { allow(rpc).to receive(:execute).and_return(response) }
     before { allow(::Tag).to receive(:rpc).and_return(rpc) }

data/spec/lib/active_remote/search_spec.rb

@@ -41,7 +41,7 @@ describe ActiveRemote::Search do
 
     context "given args that respond to :to_hash" do
       let(:args) { Hash.new }
-      let(:rpc) { ::ActiveRemote::RPCAdapters::ProtobufAdapter.new(::Tag.service_class) }
+      let(:rpc) { ::ActiveRemote::RPCAdapters::ProtobufAdapter.new(::Tag.service_class, ::Tag.endpoints) }
 
       before { allow(rpc).to receive(:execute).and_return(response) }
       before { allow(::Tag).to receive(:rpc).and_return(rpc) }

data/spec/support/definitions/tag.proto

@@ -22,6 +22,7 @@ service TagService {
   rpc Create (Tag) returns (Tag);
   rpc Update (Tag) returns (Tag);
   rpc Delete (Tag) returns (Tag);
+  rpc Register (Tag) returns (Tag);
   rpc CreateAll (Tags) returns (Tags);
   rpc UpdateAll (Tags) returns (Tags);
   rpc DeleteAll (Tags) returns (Tags);

data/spec/support/protobuf/author.pb.rb

@@ -1,7 +1,9 @@
+# encoding: utf-8
+
 ##
 # This file is auto-generated. DO NOT EDIT!
 #
-require 'protobuf/message'
+require 'protobuf'
 require 'protobuf/rpc/service'
 
 
@@ -12,6 +14,7 @@ require 'error.pb'
 
 module Generic
   module Remote
+    ::Protobuf::Optionable.inject(self) { ::Google::Protobuf::FileOptions }
 
     ##
     # Message Classes

data/spec/support/protobuf/category.pb.rb

@@ -1,7 +1,9 @@
+# encoding: utf-8
+
 ##
 # This file is auto-generated. DO NOT EDIT!
 #
-require 'protobuf/message'
+require 'protobuf'
 require 'protobuf/rpc/service'
 
 
@@ -12,6 +14,7 @@ require 'error.pb'
 
 module Generic
   module Remote
+    ::Protobuf::Optionable.inject(self) { ::Google::Protobuf::FileOptions }
 
     ##
     # Message Classes

data/spec/support/protobuf/error.pb.rb

@@ -1,9 +1,12 @@
+# encoding: utf-8
+
 ##
 # This file is auto-generated. DO NOT EDIT!
 #
-require 'protobuf/message'
+require 'protobuf'
 
 module Generic
+  ::Protobuf::Optionable.inject(self) { ::Google::Protobuf::FileOptions }
 
   ##
   # Message Classes

data/spec/support/protobuf/post.pb.rb

@@ -1,7 +1,9 @@
+# encoding: utf-8
+
 ##
 # This file is auto-generated. DO NOT EDIT!
 #
-require 'protobuf/message'
+require 'protobuf'
 require 'protobuf/rpc/service'
 
 
@@ -13,6 +15,7 @@ require 'category.pb'
 
 module Generic
   module Remote
+    ::Protobuf::Optionable.inject(self) { ::Google::Protobuf::FileOptions }
 
     ##
     # Message Classes

data/spec/support/protobuf/serializer.pb.rb

@@ -1,7 +1,9 @@
+# encoding: utf-8
+
 ##
 # This file is auto-generated. DO NOT EDIT!
 #
-require 'protobuf/message'
+require 'protobuf'
 
 
 ##

data/spec/support/protobuf/tag.pb.rb

@@ -1,7 +1,9 @@
+# encoding: utf-8
+
 ##
 # This file is auto-generated. DO NOT EDIT!
 #
-require 'protobuf/message'
+require 'protobuf'
 require 'protobuf/rpc/service'
 
 
@@ -12,6 +14,7 @@ require 'error.pb'
 
 module Generic
   module Remote
+    ::Protobuf::Optionable.inject(self) { ::Google::Protobuf::FileOptions }
 
     ##
     # Message Classes
@@ -48,6 +51,7 @@ module Generic
       rpc :create, ::Generic::Remote::Tag, ::Generic::Remote::Tag
       rpc :update, ::Generic::Remote::Tag, ::Generic::Remote::Tag
       rpc :delete, ::Generic::Remote::Tag, ::Generic::Remote::Tag
+      rpc :register, ::Generic::Remote::Tag, ::Generic::Remote::Tag
       rpc :create_all, ::Generic::Remote::Tags, ::Generic::Remote::Tags
       rpc :update_all, ::Generic::Remote::Tags, ::Generic::Remote::Tags
       rpc :delete_all, ::Generic::Remote::Tags, ::Generic::Remote::Tags

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_remote
 version: !ruby/object:Gem::Version
-  version: 3.1.3
+  version: 3.2.0.pre
 platform: ruby
 authors:
 - Adam Hutchison
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-10 00:00:00.000000000 Z
+date: 2018-08-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -19,7 +19,7 @@ dependencies:
         version: '4.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5'
+        version: '5.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: '4.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5'
+        version: '5.2'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -218,6 +218,7 @@ files:
 - spec/lib/active_remote/persistence_spec.rb
 - spec/lib/active_remote/primary_key_spec.rb
 - spec/lib/active_remote/query_attribute_spec.rb
+- spec/lib/active_remote/rpc_adapters/protobuf_adapter_spec.rb
 - spec/lib/active_remote/rpc_spec.rb
 - spec/lib/active_remote/scope_keys_spec.rb
 - spec/lib/active_remote/search_spec.rb
@@ -263,13 +264,54 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: Active Record for your platform
-test_files: []
+test_files:
+- spec/lib/active_remote/association_spec.rb
+- spec/lib/active_remote/attributes_spec.rb
+- spec/lib/active_remote/base_spec.rb
+- spec/lib/active_remote/dirty_spec.rb
+- spec/lib/active_remote/dsl_spec.rb
+- spec/lib/active_remote/integration_spec.rb
+- spec/lib/active_remote/persistence_spec.rb
+- spec/lib/active_remote/primary_key_spec.rb
+- spec/lib/active_remote/query_attribute_spec.rb
+- spec/lib/active_remote/rpc_adapters/protobuf_adapter_spec.rb
+- spec/lib/active_remote/rpc_spec.rb
+- spec/lib/active_remote/scope_keys_spec.rb
+- spec/lib/active_remote/search_spec.rb
+- spec/lib/active_remote/serialization_spec.rb
+- spec/lib/active_remote/serializers/protobuf_spec.rb
+- spec/lib/active_remote/typecasting_spec.rb
+- spec/lib/active_remote/validations_spec.rb
+- spec/spec_helper.rb
+- spec/support/definitions/author.proto
+- spec/support/definitions/category.proto
+- spec/support/definitions/error.proto
+- spec/support/definitions/post.proto
+- spec/support/definitions/serializer.proto
+- spec/support/definitions/tag.proto
+- spec/support/helpers.rb
+- spec/support/models.rb
+- spec/support/models/author.rb
+- spec/support/models/category.rb
+- spec/support/models/default_author.rb
+- spec/support/models/message_with_options.rb
+- spec/support/models/no_attributes.rb
+- spec/support/models/post.rb
+- spec/support/models/tag.rb
+- spec/support/models/typecasted_author.rb
+- spec/support/protobuf.rb
+- spec/support/protobuf/author.pb.rb
+- spec/support/protobuf/category.pb.rb
+- spec/support/protobuf/error.pb.rb
+- spec/support/protobuf/post.pb.rb
+- spec/support/protobuf/serializer.pb.rb
+- spec/support/protobuf/tag.pb.rb