active_remote 1.7.0 → 1.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a53038e5bd4f39ffbba6356eaeeb8de9c55ee2aa
-  data.tar.gz: 694f516e1adb22e5fd3ed9c68395b6081a54d389
+  metadata.gz: 4e0a0b815dc24d0ba8c884b135055cc9fb42fbc0
+  data.tar.gz: 59144b3bb85ecebf7e660e0b5a93a27db60f7751
 SHA512:
-  metadata.gz: 179ff3825b682860f3600cf90735a783c49f175f764ed56779d859b230da021961f7124faac2561fbc029d0ee9924f37c00532b2190a11d4495f1e5525c25fd9
-  data.tar.gz: 1f3d111e0cc746926899f9aba30f2c82e32caeb4eddca8250debdcf1830c877588d4e0c29cc3a36352e253c98562d21ea5ee34de1ed8aa8831ebbef34116f8f8
+  metadata.gz: ac81f4a6f6f7206306e2712a0fb5fe6d90f72228ce63667f480f609d32243e3bee20ad3465cd2766893994ee01c34733a411c9ee5e047cb89781de47d4262d78
+  data.tar.gz: 471a29c7b76006c8d8fd86835196a3ad5dbbbe76c419c9e5cca6d7f1b86e195fb9b2b149185348fa34df1e8875aba8260a9821838e689ced9d75c9b2b0cd3062

data/active_remote.gemspec

@@ -26,6 +26,7 @@ Gem::Specification.new do |s|
   ##
   # Development Dependencies
   #
+  s.add_development_dependency "better_receive"
   s.add_development_dependency "rake"
   s.add_development_dependency "rspec"
   s.add_development_dependency "rspec-pride"

data/lib/active_remote/base.rb

@@ -38,6 +38,7 @@ module ActiveRemote
 
     def initialize(*)
       @attributes ||= {}
+      @new_record = true
 
       skip_dirty_tracking do
         run_callbacks :initialize do

data/lib/active_remote/persistence.rb

@@ -119,11 +119,25 @@ module ActiveRemote
         return respond_to?(:errors) && errors.present?
       end
 
+      # Instantiate a record with the given remote attributes. Generally used
+      # when retrieving records that already exist, so @new_record is set to false.
+      #
+      def instantiate(record)
+        skip_dirty_tracking do
+          assign_attributes(record)
+        end
+
+        run_callbacks :initialize
+
+        @new_record = false
+        self
+      end
+
       # Returns true if the remote record hasn't been saved yet; otherwise,
       # returns false.
       #
       def new_record?
-        return self[:guid].nil?
+        @new_record
       end
 
       # Returns true if the remote record has been saved; otherwise, returns false.
@@ -207,6 +221,7 @@ module ActiveRemote
           assign_attributes(last_response.to_hash)
           add_errors_from_response
 
+          @new_record = has_errors?
           success?
         end
       end

data/lib/active_remote/serialization.rb

@@ -31,9 +31,10 @@ module ActiveRemote
     def serialize_records
       return nil unless last_response.respond_to?(:records)
 
-      last_response.records.map do |record|
-        remote = self.class.new(record.to_hash)
-        remote
+      last_response.records.map do |remote_record|
+        record = self.class.allocate
+        record.instantiate(remote_record.to_hash)
+        record
       end
     end
   end

data/lib/active_remote/version.rb

@@ -1,3 +1,3 @@
 module ActiveRemote
-  VERSION = "1.7.0"
+  VERSION = "1.7.1"
 end

data/spec/lib/active_remote/persistence_spec.rb

@@ -146,7 +146,7 @@ describe ActiveRemote::Persistence do
 
   describe "#new_record?" do
     context "when the record is persisted" do
-      subject { Tag.new(:guid => 'foo') }
+      subject { Tag.allocate.instantiate(:guid => 'foo') }
 
       its(:new_record?) { should be_false }
     end
@@ -159,13 +159,13 @@ describe ActiveRemote::Persistence do
   end
 
   describe "#persisted?" do
-    context "when the record has a guid" do
-      subject { Tag.new(:guid => 'foo') }
+    context "when the record is persisted" do
+      subject { Tag.allocate.instantiate(:guid => 'foo') }
 
       its(:persisted?) { should be_true }
     end
 
-    context "when the record does not have a guid" do
+    context "when the record is not persisted" do
       subject { Tag.new }
 
       its(:persisted?) { should be_false }
@@ -194,7 +194,7 @@ describe ActiveRemote::Persistence do
     context "when the record is not new" do
       let(:attributes) { { 'guid' => 'foo' } }
 
-      subject { Tag.new(attributes) }
+      subject { Tag.allocate.instantiate(attributes) }
 
       it "updates the record" do
         subject.should_receive(:execute).with(:update, attributes)
@@ -204,14 +204,14 @@ describe ActiveRemote::Persistence do
 
     context "when the record is saved" do
       it "returns true" do
-        subject.should_receive(:has_errors?) { false }
+        subject.better_stub(:has_errors?) { false }
         subject.save.should be_true
       end
     end
 
     context "when the record is not saved" do
       it "returns false" do
-        subject.should_receive(:has_errors?) { true }
+        subject.better_stub(:has_errors?) { true }
         subject.save.should be_false
       end
     end
@@ -267,7 +267,7 @@ describe ActiveRemote::Persistence do
     after { Tag.any_instance.unstub(:execute) }
 
     it "runs update callbacks" do
-      tag = Tag.new({:guid => "123"})
+      tag = Tag.allocate.instantiate({:guid => "123"})
       tag.should_receive(:after_update_callback)
       tag.update_attributes({})
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_remote
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 1.7.1
 platform: ruby
 authors:
 - Adam Hutchison
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-24 00:00:00.000000000 Z
+date: 2013-11-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_attr
@@ -52,6 +52,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: better_receive
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -226,8 +240,41 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.1.11
 signing_key: 
 specification_version: 4
 summary: Active Record for your platform
-test_files: []
+test_files:
+- spec/core_ext/date_time_spec.rb
+- spec/lib/active_remote/association_spec.rb
+- spec/lib/active_remote/base_spec.rb
+- spec/lib/active_remote/bulk_spec.rb
+- spec/lib/active_remote/dirty_spec.rb
+- spec/lib/active_remote/dsl_spec.rb
+- spec/lib/active_remote/integration_spec.rb
+- spec/lib/active_remote/persistence_spec.rb
+- spec/lib/active_remote/publication_spec.rb
+- spec/lib/active_remote/rpc_spec.rb
+- spec/lib/active_remote/search_spec.rb
+- spec/lib/active_remote/serialization_spec.rb
+- spec/lib/active_remote/serializers/json_spec.rb
+- spec/lib/active_remote/serializers/protobuf_spec.rb
+- spec/spec_helper.rb
+- spec/support/definitions/author.proto
+- spec/support/definitions/post.proto
+- spec/support/definitions/support/protobuf/category.proto
+- spec/support/definitions/support/protobuf/error.proto
+- spec/support/definitions/tag.proto
+- spec/support/helpers.rb
+- spec/support/models.rb
+- spec/support/models/author.rb
+- spec/support/models/category.rb
+- spec/support/models/message_with_options.rb
+- spec/support/models/post.rb
+- spec/support/models/tag.rb
+- spec/support/protobuf.rb
+- spec/support/protobuf/author.pb.rb
+- spec/support/protobuf/category.pb.rb
+- spec/support/protobuf/error.pb.rb
+- spec/support/protobuf/post.pb.rb
+- spec/support/protobuf/tag.pb.rb