active_record_survey 0.1.6 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cc0440e0c23ed5d966185f62fe83619c7d50fa01
-  data.tar.gz: b0e93efb11a6994878ce6c3d5d948043525125a3
+  metadata.gz: 07f6faab384d06f3ef40dd8786143e54b36bc195
+  data.tar.gz: 47f1f3bc3f2a8319d3978cc94388ebbfdde81f82
 SHA512:
-  metadata.gz: 81b0ea583a5d440eddb185547a584dcf471d8f1618a4f8a0e80406882d7a866c5391851e9eb962f28a90f6308bd3c2aba0c30891b700e28a9737acf19fc04f1e
-  data.tar.gz: 64b747965c5c7bcefe1753f4518f5f4dcbf5279339c459ed1c60a64d854854f77f88ba12410cbd76bb8fd02da05d671fdf1098405405c82384fe19d750eefad8
+  metadata.gz: 502f9da2618cd7e84441668135c5d1678f49fc382e729e04e8fd1eeba374a8049049b6ec2a012205d69cff2352865d217e890a3da85fcb26f8bb82c74c4e4ac7
+  data.tar.gz: 552fc36dfacb68835174cc6e8f53151b2def44c6f0a789befee1aa49225f5bb3409084e8f88363632620a4849cee5a81c08b25428ec57df85f956f85ca658914

data/lib/active_record_survey/instance_node.rb

@@ -12,18 +12,18 @@ module ActiveRecordSurvey
 				instance_node.errors[:base] << "NO_PATH"
 			end
 
+			parent_nodes = self.node.node_maps.collect { |j| j.parent }
+
 			# Two instance_nodes on the same node for this instance
 			if self.instance.instance_nodes.select { |i|
+					# And the two arrays
 					# Two votes share a parent (this means a question has two answers for this instance)
-					(i.node.node_maps.collect { |j|
-						j.parent
-					} & self.node.node_maps.collect { |j|
-						j.parent
-					}).length > 0
+					(i.node.node_maps.collect { |j| j.parent } & parent_nodes).length > 0
 				}.length > 1
 				instance_node.errors[:base] << "DUPLICATE_PATH"
 			end
 
+			# Validate against the associated node
 			if !self.node.validate_instance_node(self)
 				instance_node.errors[:base] << "INVALID"
 			end

data/lib/active_record_survey/node/answer/rank.rb

@@ -11,6 +11,14 @@ module ActiveRecordSurvey
 			instance_node.value.to_i <= self.max_rank
 		end
 
+		# Rank answers are considered answered if they have a value of greater than "0"
+		def is_answered_for_instance?(instance)
+			if instance_node = self.instance_node_for_instance(instance)
+				# Answered if > 0
+				instance_node.value.to_i > 0
+			end
+		end
+
 		protected
 
 		# Calculate the number of Rank nodes above this one

data/lib/active_record_survey/node/answer/scale.rb

@@ -7,5 +7,15 @@ module ActiveRecordSurvey
 			super &&
 			(instance_node.value.to_s.empty? || !instance_node.value.to_s.match(/^(\d+(\.\d+)?)$/).nil?)
 		end
+
+		# Scale answers are considered answered if they have a value of greater than "0"
+		def is_answered_for_instance?(instance)
+			if instance_node = self.instance_node_for_instance(instance)
+				# Answered if not empty and > 0
+				!instance_node.value.to_s.empty? && instance_node.value.to_i >= 0
+			else
+				false
+			end
+		end
 	end
 end

data/lib/active_record_survey/node/answer/text.rb

@@ -1,5 +1,12 @@
 module ActiveRecordSurvey
 	# Text answers are... text answers
 	class Node::Answer::Text < Node::Answer
+		# Text answers are considered answered if they have text entered
+		def is_answered_for_instance?(instance)
+			if instance_node = self.instance_node_for_instance(instance)
+				# Answered if has text
+				instance_node.value.to_s.strip.length > 0
+			end
+		end
 	end
 end

data/lib/active_record_survey/node.rb

@@ -32,12 +32,13 @@ module ActiveRecordSurvey
 
 		# Run all validations applied to this node
 		def validate_instance_node(instance_node)
-			# UGH - so bsaically this validation doesn't know about the non-saved validation..
-			#puts "Valdating #{self.id} - #{self.text} - total validations are - #{self.node_validations(true).length}"
+			# Basically this cache is messed up? Why? TODO.
+			# Reloading in the spec seems to fix this... but... this could be a booby trap for others
+			#self.node_validations(true)
+
 			!self.node_validations.collect { |node_validation|
 				node_validation.validate_instance_node(instance_node, self)
-			}.include?(false) &&
-			!self.node_maps.collect { |node_map|
+			}.include?(false) &&  !self.node_maps.collect { |node_map|
 				if node_map.parent
 					node_map.parent.node.validate_instance_node(instance_node)
 				# Hit top node

data/lib/active_record_survey/node_validation/maximum_answer.rb

@@ -3,10 +3,7 @@ module ActiveRecordSurvey
 	class NodeValidation::MaximumAnswer < NodeValidation
 		# Validate the instance_node to ensure a maximum number of answers are made
 		def validate_instance_node(instance_node, question_node = nil)
-			#puts "-------------------------------------------"
-			#puts "runnin min answer validation"
-			
-			# Only makes sense for questions to have minimum answers
+			# Only makes sense for questions to have maximum answers
 			if !question_node.class.ancestors.include?(::ActiveRecordSurvey::Node::Question)
 				return false 
 			end

data/lib/active_record_survey/node_validation/minimum_answer.rb

@@ -3,9 +3,6 @@ module ActiveRecordSurvey
 	class NodeValidation::MinimumAnswer < NodeValidation
 		# Validate the instance_node to ensure a minimum number of answers are made
 		def validate_instance_node(instance_node, question_node = nil)
-			#puts "-------------------------------------------"
-			#puts "runnin min answer validation"
-			
 			# Only makes sense for questions to have minimum answers
 			if !question_node.class.ancestors.include?(::ActiveRecordSurvey::Node::Question)
 				return false 

data/lib/active_record_survey/node_validation.rb

@@ -8,9 +8,10 @@ module ActiveRecordSurvey
 		def validate_instance_node(instance_node)
 			true
 		end
-		
+
+		# By default everything is valid! WOOO!
 		def validate_node(instance_node, node)
-			#code
+			true
 		end
 	end
 end

data/lib/active_record_survey/version.rb

@@ -1,3 +1,3 @@
 module ActiveRecordSurvey
-	VERSION = "0.1.6"
+	VERSION = "0.1.7"
 end

data/spec/active_record_survey/node/answer/boolean_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe ActiveRecordSurvey::Node::Answer::Boolean, :focus => true do
+describe ActiveRecordSurvey::Node::Answer::Boolean, :boolean_spec => true do
 	describe 'a boolean survey is' do
 		before(:all) do
 			@survey = ActiveRecordSurvey::Survey.new
@@ -18,15 +18,6 @@ describe ActiveRecordSurvey::Node::Answer::Boolean, :focus => true do
 			nodes = @survey.build_question(@q1_a4, [], nodes[0])
 			nodes = @survey.build_question(@q1_a5, [], nodes[0])
 
-			@q1.node_validations << ActiveRecordSurvey::NodeValidation::MinimumAnswer.new(
-				:node => @q1,
-				:value => 1 # min 1 of the 3 answers must be "answered"
-			)
-			@q1.node_validations << ActiveRecordSurvey::NodeValidation::MaximumAnswer.new(
-				:node => @q1,
-				:value => 3 # max 2 of the 3 answers must be "answered"
-			)
-
 			@survey.save
 		end
 
@@ -109,123 +100,142 @@ describe ActiveRecordSurvey::Node::Answer::Boolean, :focus => true do
 			end
 		end
 
-		describe ActiveRecordSurvey::NodeValidation::MinimumAnswer do
-			describe 'valid when' do
-				it 'has a value greater than the minimum' do
-					instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
-					instance.instance_nodes.build(
-						:instance => instance,
-						:node => @q1_a1,
-						:value => 1,
-					)
-					instance.instance_nodes.build(
-						:instance => instance,
-						:node => @q1_a2,
-						:value => 0,
-					)
-					instance.instance_nodes.build(
-						:instance => instance,
-						:node => @q1_a3,
-						:value => 1,
-					)
-					instance.save
-	
-					expect(instance.valid?).to be(true)
-				end
-			end
+		describe ActiveRecordSurvey::NodeValidation do
+			before(:all) do
+				@q1.node_validations.build(
+					:type => 'ActiveRecordSurvey::NodeValidation::MinimumAnswer',
+					:node => @q1,
+					:value => 1 # min 1 of the 3 answers must be "answered"
+				)
+				@q1.node_validations.build(
+					:type => 'ActiveRecordSurvey::NodeValidation::MaximumAnswer',
+					:node => @q1,
+					:value => 3 # max 2 of the 3 answers must be "answered"
+				)
+				@q1.save
 
-			describe 'invalid when' do
-				it 'has a value less than the minimum' do
-					instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
-					instance.instance_nodes.build(
-						:instance => instance,
-						:node => @q1_a1,
-						:value => 0,
-					)
-					instance.instance_nodes.build(
-						:instance => instance,
-						:node => @q1_a2,
-						:value => 0,
-					)
-					instance.instance_nodes.build(
-						:instance => instance,
-						:node => @q1_a3,
-						:value => 0,
-					)
-					instance.save
-	
-					expect(instance.valid?).to be(false)
-				end
+				# Weird caching is happening
+				@q1_a1.reload
 			end
-		end
 
+			describe ActiveRecordSurvey::NodeValidation::MinimumAnswer do
+				describe 'valid when' do
+					it 'has a value greater than the minimum' do
+						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a1,
+							:value => 1,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a2,
+							:value => 0,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a3,
+							:value => 1,
+						)
+						instance.save
+
+						expect(instance.valid?).to be(true)
+					end
+				end
 
-		describe ActiveRecordSurvey::NodeValidation::MaximumAnswer do
-			describe 'valid when' do
-				it 'has a value less than the maximum' do
-					instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
-					instance.instance_nodes.build(
-						:instance => instance,
-						:node => @q1_a1,
-						:value => 1,
-					)
-					instance.instance_nodes.build(
-						:instance => instance,
-						:node => @q1_a2,
-						:value => 0,
-					)
-					instance.instance_nodes.build(
-						:instance => instance,
-						:node => @q1_a3,
-						:value => 1,
-					)
-					instance.instance_nodes.build(
-						:instance => instance,
-						:node => @q1_a4,
-						:value => 1,
-					)
-					instance.instance_nodes.build(
-						:instance => instance,
-						:node => @q1_a5,
-						:value => 0,
-					)
-					instance.save
-	
-					expect(instance.valid?).to be(true)
+				describe 'invalid when' do
+					it 'has a value less than the minimum' do
+						@q1.node_validations(true)
+						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a1,
+							:value => 0,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a2,
+							:value => 0,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a3,
+							:value => 0,
+						)
+						instance.save
+
+						expect(instance.valid?).to be(false)
+					end
 				end
 			end
 
-			describe 'invalid when' do
-				it 'has a value greater than the maximum' do
-					instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
-					instance.instance_nodes.build(
-						:instance => instance,
-						:node => @q1_a1,
-						:value => 1,
-					)
-					instance.instance_nodes.build(
-						:instance => instance,
-						:node => @q1_a2,
-						:value => 1,
-					)
-					instance.instance_nodes.build(
-						:instance => instance,
-						:node => @q1_a3,
-						:value => 1,
-					)
-					instance.instance_nodes.build(
-						:instance => instance,
-						:node => @q1_a4,
-						:value => 1,
-					)
-					instance.instance_nodes.build(
-						:instance => instance,
-						:node => @q1_a5,
-						:value => 1,
-					)
-					instance.save
-	
-					expect(instance.valid?).to be(false)
+			describe ActiveRecordSurvey::NodeValidation::MaximumAnswer do
+				describe 'valid when' do
+					it 'has a value less than the maximum' do
+						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a1,
+							:value => 1,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a2,
+							:value => 0,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a3,
+							:value => 1,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a4,
+							:value => 1,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a5,
+							:value => 0,
+						)
+						instance.save
+
+						expect(instance.valid?).to be(true)
+					end
+				end
+
+				describe 'invalid when' do
+					it 'has a value greater than the maximum' do
+						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a1,
+							:value => 1,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a2,
+							:value => 1,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a3,
+							:value => 1,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a4,
+							:value => 1,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a5,
+							:value => 1,
+						)
+						instance.save
+
+						expect(instance.valid?).to be(false)
+					end
 				end
 			end
 		end

data/spec/active_record_survey/node/answer/rank_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe ActiveRecordSurvey::Node::Answer::Rank do
+describe ActiveRecordSurvey::Node::Answer::Rank, :rank_spec => true do
 	describe 'survey is' do
 		before(:all) do
 			@survey = ActiveRecordSurvey::Survey.new
@@ -217,5 +217,129 @@ describe ActiveRecordSurvey::Node::Answer::Rank do
 				expect(instance.valid?).to be(false)
 			end
 		end
+
+		describe ActiveRecordSurvey::NodeValidation	do
+			before(:all) do
+				@q1.node_validations << ActiveRecordSurvey::NodeValidation::MinimumAnswer.new(
+					:node => @q1,
+					:value => 2 # min 1 of the 3 answers must be "answered"
+				)
+				@q1.node_validations << ActiveRecordSurvey::NodeValidation::MaximumAnswer.new(
+					:node => @q1,
+					:value => 3 # max 2 of the 3 answers must be "answered"
+				)
+
+				# Weird caching is happening
+				@q1_a1.reload
+			end
+
+			describe ActiveRecordSurvey::NodeValidation::MinimumAnswer do
+				describe 'valid when' do
+					it 'has a value greater than the minimum' do
+						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a1,
+							:value => 1,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a2,
+							:value => 2,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a3,
+							:value => 3,
+						)
+						instance.save
+
+						expect(instance.valid?).to be(true)
+					end
+				end
+
+				describe 'invalid when' do
+					it 'has a value less than the minimum' do
+						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a1,
+							:value => 1,
+						)
+						instance.save
+
+						expect(instance.valid?).to be(false)
+					end
+				end
+			end
+
+			describe ActiveRecordSurvey::NodeValidation::MaximumAnswer do
+				describe 'valid when' do
+					it 'has a value less than the maximum' do
+						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a1,
+							:value => 1,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a2,
+							:value => 2,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a3,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a4,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a5,
+							:value => 3,
+						)
+						instance.save
+
+						expect(instance.valid?).to be(true)
+					end
+				end
+
+				describe 'invalid when' do
+					it 'has a value greater than the maximum' do
+						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a1,
+							:value => 1,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a2,
+							:value => 2,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a3,
+							:value => 3,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a4,
+							:value => 4,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a5,
+							:value => 5,
+						)
+						instance.save
+
+						expect(instance.valid?).to be(false)
+					end
+				end
+			end
+		end
 	end
 end

data/spec/active_record_survey/node/answer/scale_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe ActiveRecordSurvey::Node::Answer::Scale do
+describe ActiveRecordSurvey::Node::Answer::Scale, :scale_spec => true do
 	describe 'survey is' do
 		before(:all) do
 			@survey = ActiveRecordSurvey::Survey.new
@@ -80,78 +80,176 @@ describe ActiveRecordSurvey::Node::Answer::Scale do
 			end
 		end
 
-		describe ActiveRecordSurvey::NodeValidation::MinimumValue do
-			describe 'valid when' do
-				it 'has a value greater than the minimum' do
-					@q1_a1.node_validations << ActiveRecordSurvey::NodeValidation::MinimumValue.new(
-						:node => @q1_a1,
-						:value => 4
-					)
-					instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
-					instance.instance_nodes.build(
-						:instance => instance,
-						:node => @q1_a1,
-						:value => 5,
+		describe ActiveRecordSurvey::NodeValidation do
+			describe ActiveRecordSurvey::NodeValidation::MinimumAnswer do
+				before(:all) do
+					@q1.node_validations << ActiveRecordSurvey::NodeValidation::MinimumAnswer.new(
+						:node => @q1,
+						:value => 1
 					)
-					instance.save
+
+					# Weird caching is happening
+					@q1_a1.reload
+				end
+
+				describe 'valid when' do
+					it 'has a value greater than the minimum' do
+						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a1,
+							:value => 5,
+						)
+						instance.save
+		
+						expect(instance.valid?).to be(true)
+					end
+				end
+
+				describe 'invalid when' do
+					it 'has a value less than the minimum' do
+						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a1,
+						)
+						instance.save
 	
-					expect(instance.valid?).to be(true)
+						expect(instance.valid?).to be(false)
+					end
 				end
 			end
 
-			describe 'invalid when' do
-				it 'has a value less than the minimum' do
-					@q1_a1.node_validations << ActiveRecordSurvey::NodeValidation::MinimumValue.new(
-						:node => @q1_a1,
-						:value => 6
+			describe ActiveRecordSurvey::NodeValidation::MaximumAnswer do
+				before(:all) do
+					@q1.node_validations << ActiveRecordSurvey::NodeValidation::MaximumAnswer.new(
+						:node => @q1,
+						:value => 2
 					)
-					instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
-					instance.instance_nodes.build(
-						:instance => instance,
-						:node => @q1_a1,
-						:value => 5,
-					)
-					instance.save
 
-					expect(instance.valid?).to be(false)
+					# Weird caching is happening
+					@q1_a1.reload
+				end
+
+				describe 'valid when' do
+					it 'has a value less than the maximum' do
+						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a1,
+							:value => 8,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a2,
+							:value => 9,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a3,
+						)
+						instance.save
+
+						expect(instance.valid?).to be(true)
+					end
+				end
+
+				describe 'invalid when' do
+					it 'has a value greater than the maximum' do
+						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a1,
+							:value => 8,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a2,
+							:value => 9,
+						)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a3,
+							:value => 10,
+						)
+						instance.save
+
+						expect(instance.valid?).to be(false)
+					end
 				end
 			end
-		end
 
-		describe ActiveRecordSurvey::NodeValidation::MaximumValue do
-			describe 'valid when' do
-				it 'has a value less than the maximum' do
-					@q1_a1.node_validations << ActiveRecordSurvey::NodeValidation::MaximumValue.new(
-						:node => @q1_a1,
-						:value => 15
-					)
-					instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
-					instance.instance_nodes.build(
-						:instance => instance,
+			describe ActiveRecordSurvey::NodeValidation::MinimumValue do
+				before(:all) do
+					@q1_a1.node_validations << ActiveRecordSurvey::NodeValidation::MinimumValue.new(
 						:node => @q1_a1,
-						:value => 8,
+						:value => 4
 					)
-					instance.save
+				end
 
-					expect(instance.valid?).to be(true)
+				describe 'valid when' do
+					it 'has a value greater than the minimum' do
+						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a1,
+							:value => 5,
+						)
+						instance.save
+		
+						expect(instance.valid?).to be(true)
+					end
+				end
+
+				describe 'invalid when' do
+					it 'has a value less than the minimum' do
+						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a1,
+							:value => 3,
+						)
+						instance.save
+	
+						expect(instance.valid?).to be(false)
+					end
 				end
 			end
 
-			describe 'invalid when' do
-				it 'has a value greater than the maximum' do
+			describe ActiveRecordSurvey::NodeValidation::MaximumValue do
+				before(:all) do
 					@q1_a1.node_validations << ActiveRecordSurvey::NodeValidation::MaximumValue.new(
 						:node => @q1_a1,
 						:value => 15
 					)
-					instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
-					instance.instance_nodes.build(
-						:instance => instance,
-						:node => @q1_a1,
-						:value => 20,
-					)
-					instance.save
+				end
+
+				describe 'valid when' do
+					it 'has a value less than the maximum' do
+						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a1,
+							:value => 8,
+						)
+						instance.save
+
+						expect(instance.valid?).to be(true)
+					end
+				end
+
+				describe 'invalid when' do
+					it 'has a value greater than the maximum' do
+						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a1,
+							:value => 20,
+						)
+						instance.save
 
-					expect(instance.valid?).to be(false)
+						expect(instance.valid?).to be(false)
+					end
 				end
 			end
 		end

data/spec/active_record_survey/node/answer/text_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe ActiveRecordSurvey::Node::Answer::Text, :test => true do
+describe ActiveRecordSurvey::Node::Answer::Text do
 	describe 'a text survey is' do
 		before(:all) do
 			@survey = ActiveRecordSurvey::Survey.new

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_record_survey
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors:
 - Butch Marshall
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-27 00:00:00.000000000 Z
+date: 2015-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord