active_record_survey 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5e14e2ac1a5afccd6174d0c4a6a6d63eaf299648
-  data.tar.gz: 851b819031bbf4121f31003892eed93168ba0bb6
+  metadata.gz: 89488bc6129619788df343d2782e6e5789b63ea9
+  data.tar.gz: 734de7ad575ef2049f491cc289ddfc798e7f4c30
 SHA512:
-  metadata.gz: 96cd0a3783d52e6a472229deea9782fb11b46fa8e71a24739eefab6d2be7c6fc8080531fdc01c4532600094da451b05d9e57c5f6d00dee308dc3b2a554eb6140
-  data.tar.gz: 61fa51b61fe2e0de0e7b6fe9c0fa5f0de3fa9e1348f65d78a69e0458ee49f99c0a5f96f153bdc1916c32931826a4c35b8cc9bc9177ac8a5c3edd993a1b9e798d
+  metadata.gz: 5c5dd82b54caf2511537e2b3261ff0f90329241500fa4ebe3c83830486e5b3a626ae149a5d59cc9477dbb3a97cde32072f48e85258dc3ff76dd95e284b7dc424
+  data.tar.gz: bbd6dd35bd48ba070e2379ee38a1360fbbaf5e7e027f73c6f10607104d3b2b9886966d423e31ed9772fd84013d1f0794c5a7a504fa184fc996d58c6ed0e71d09

data/lib/active_record_survey.rb

@@ -24,6 +24,8 @@ require "active_record_survey/node_validation/minimum_value"
 require "active_record_survey/node_validation/maximum_value"
 require "active_record_survey/node_validation/maximum_length"
 require "active_record_survey/node_validation/minimum_length"
+require "active_record_survey/node_validation/minimum_answer"
+require "active_record_survey/node_validation/maximum_answer"
 
 require "active_record_survey/instance"
 require "active_record_survey/instance_node"

data/lib/active_record_survey/node_validation/maximum_answer.rb

@@ -0,0 +1,10 @@
+module ActiveRecordSurvey
+	# Ensure the a maximum number of answers are made
+	class NodeValidation::MaximumAnswer < NodeValidation
+		# Validate the instance_node to ensure a maximum number of answers are made
+		def validate_instance_node(instance_node, node = nil)
+			!instance_node.value.to_s.empty? &&
+			instance_node.value.to_f >= self.value.to_f
+		end
+	end
+end

data/lib/active_record_survey/node_validation/maximum_length.rb

@@ -3,7 +3,7 @@ module ActiveRecordSurvey
 	class NodeValidation::MaximumLength < NodeValidation
 		# Validate the instance_node value
 		def validate_instance_node(instance_node, node = nil)
-			instance_node.value.to_s.length <= self.value.to_i
+			(self.value.to_i >= instance_node.value.to_s.length.to_i)
 		end
 	end
 end

data/lib/active_record_survey/node_validation/minimum_answer.rb

@@ -0,0 +1,10 @@
+module ActiveRecordSurvey
+	# Ensure the a minimum number of answers are made
+	class NodeValidation::MinimumAnswer < NodeValidation
+		# Validate the instance_node to ensure a minimum number of answers are made
+		def validate_instance_node(instance_node, node = nil)
+			!instance_node.value.to_s.empty? &&
+			instance_node.value.to_f >= self.value.to_f
+		end
+	end
+end

data/lib/active_record_survey/version.rb

@@ -1,3 +1,3 @@
 module ActiveRecordSurvey
-	VERSION = "0.1.4"
+	VERSION = "0.1.5"
 end

data/spec/active_record_survey/node/answer/boolean_spec.rb

@@ -90,5 +90,44 @@ describe ActiveRecordSurvey::Node::Answer::Boolean do
 				expect(instance.valid?).to be(false)
 			end
 		end
+
+		describe ActiveRecordSurvey::NodeValidation::MinimumAnswer do
+			describe 'valid when' do
+				it 'has a value greater than the minimum' do
+					@q1.node_validations << ActiveRecordSurvey::NodeValidation::MinimumAnswer.new(
+						:node => @q1,
+						:value => 2 # 2 of the 3 answers must be "answered"
+					)
+					instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+					instance.instance_nodes.build(
+						:instance => instance,
+						:node => @q1_a1,
+						:value => "this is greater than minimum length",
+					)
+					instance.save
+	
+					#expect(instance.valid?).to be(true)
+				end
+			end
+=begin
+			describe 'invalid when' do
+				it 'has a value less than the minimum' do
+					@q1_a1.node_validations << ActiveRecordSurvey::NodeValidation::MinimumLength.new(
+						:node => @q1_a1,
+						:value => 3
+					)
+					instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+					instance.instance_nodes.build(
+						:instance => instance,
+						:node => @q1_a1,
+						:value => "12",
+					)
+					instance.save
+
+					expect(instance.valid?).to be(false)
+				end
+			end
+=end
+		end
 	end
 end

data/spec/active_record_survey/node/answer/rank_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe ActiveRecordSurvey::Node::Answer::Rank, :focus => true do
+describe ActiveRecordSurvey::Node::Answer::Rank do
 	describe 'survey is' do
 		before(:all) do
 			@survey = ActiveRecordSurvey::Survey.new

data/spec/active_record_survey/node/answer/scale_spec.rb

@@ -52,82 +52,6 @@ describe ActiveRecordSurvey::Node::Answer::Scale do
 
 				expect(instance.valid?).to be(true)
 			end
-
-			describe ActiveRecordSurvey::NodeValidation::MinimumValue do
-				describe 'valid when' do
-					it 'has a value greater than the minimum' do
-						@q1_a1.node_validations << ActiveRecordSurvey::NodeValidation::MinimumValue.new(
-							:node => @q1_a1,
-							:value => 4
-						)
-						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
-						instance.instance_nodes.build(
-							:instance => instance,
-							:node => @q1_a1,
-							:value => 5,
-						)
-						instance.save
-		
-						expect(instance.valid?).to be(true)
-					end
-				end
-
-				describe 'invalid when' do
-					it 'has a value less than the minimum' do
-						@q1_a1.node_validations << ActiveRecordSurvey::NodeValidation::MinimumValue.new(
-							:node => @q1_a1,
-							:value => 6
-						)
-						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
-						instance.instance_nodes.build(
-							:instance => instance,
-							:node => @q1_a1,
-							:value => 5,
-						)
-						instance.save
-
-						expect(instance.valid?).to be(false)
-					end
-				end
-			end
-
-			describe ActiveRecordSurvey::NodeValidation::MaximumValue do
-				describe 'valid when' do
-					it 'has a value less than the maximum' do
-						@q1_a1.node_validations << ActiveRecordSurvey::NodeValidation::MaximumValue.new(
-							:node => @q1_a1,
-							:value => 15
-						)
-						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
-						instance.instance_nodes.build(
-							:instance => instance,
-							:node => @q1_a1,
-							:value => 8,
-						)
-						instance.save
-
-						expect(instance.valid?).to be(true)
-					end
-				end
-
-				describe 'invalid when' do
-					it 'has a value greater than the maximum' do
-						@q1_a1.node_validations << ActiveRecordSurvey::NodeValidation::MaximumValue.new(
-							:node => @q1_a1,
-							:value => 15
-						)
-						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
-						instance.instance_nodes.build(
-							:instance => instance,
-							:node => @q1_a1,
-							:value => 20,
-						)
-						instance.save
-
-						expect(instance.valid?).to be(false)
-					end
-				end
-			end
 		end
 
 		describe 'invalid when' do
@@ -155,5 +79,81 @@ describe ActiveRecordSurvey::Node::Answer::Scale do
 				expect(instance.valid?).to be(false)
 			end
 		end
+
+		describe ActiveRecordSurvey::NodeValidation::MinimumValue do
+			describe 'valid when' do
+				it 'has a value greater than the minimum' do
+					@q1_a1.node_validations << ActiveRecordSurvey::NodeValidation::MinimumValue.new(
+						:node => @q1_a1,
+						:value => 4
+					)
+					instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+					instance.instance_nodes.build(
+						:instance => instance,
+						:node => @q1_a1,
+						:value => 5,
+					)
+					instance.save
+	
+					expect(instance.valid?).to be(true)
+				end
+			end
+
+			describe 'invalid when' do
+				it 'has a value less than the minimum' do
+					@q1_a1.node_validations << ActiveRecordSurvey::NodeValidation::MinimumValue.new(
+						:node => @q1_a1,
+						:value => 6
+					)
+					instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+					instance.instance_nodes.build(
+						:instance => instance,
+						:node => @q1_a1,
+						:value => 5,
+					)
+					instance.save
+
+					expect(instance.valid?).to be(false)
+				end
+			end
+		end
+
+		describe ActiveRecordSurvey::NodeValidation::MaximumValue do
+			describe 'valid when' do
+				it 'has a value less than the maximum' do
+					@q1_a1.node_validations << ActiveRecordSurvey::NodeValidation::MaximumValue.new(
+						:node => @q1_a1,
+						:value => 15
+					)
+					instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+					instance.instance_nodes.build(
+						:instance => instance,
+						:node => @q1_a1,
+						:value => 8,
+					)
+					instance.save
+
+					expect(instance.valid?).to be(true)
+				end
+			end
+
+			describe 'invalid when' do
+				it 'has a value greater than the maximum' do
+					@q1_a1.node_validations << ActiveRecordSurvey::NodeValidation::MaximumValue.new(
+						:node => @q1_a1,
+						:value => 15
+					)
+					instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+					instance.instance_nodes.build(
+						:instance => instance,
+						:node => @q1_a1,
+						:value => 20,
+					)
+					instance.save
+
+					expect(instance.valid?).to be(false)
+				end
+			end
+		end
 	end
 end

data/spec/active_record_survey/node/answer/text_spec.rb

@@ -0,0 +1,129 @@
+require 'spec_helper'
+
+describe ActiveRecordSurvey::Node::Answer::Text, :test => true do
+	describe 'a text survey is' do
+		before(:all) do
+			@survey = ActiveRecordSurvey::Survey.new
+
+			@q1 = ActiveRecordSurvey::Node::Question.new(:text => "What... what do you think?")
+			@q1_a1 = ActiveRecordSurvey::Node::Answer::Text.new()
+
+			@survey.build_question(@q1, [@q1_a1])
+
+			@survey.save
+		end
+
+		describe 'valid' do
+			it 'when empty' do
+				instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+				instance.instance_nodes.build(
+					:instance => instance,
+					:node => @q1_a1,
+					:value => ""
+				)
+				instance.save
+
+				expect(instance.valid?).to be(true)
+			end
+
+			it 'when not specified' do
+				instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+				instance.instance_nodes.build(
+					:instance => instance,
+					:node => @q1_a1,
+				)
+				instance.save
+
+				expect(instance.valid?).to be(true)
+			end
+
+			it 'when has content' do
+				instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+				instance.instance_nodes.build(
+					:instance => instance,
+					:node => @q1_a1,
+					:value => "We have some content here!",
+				)
+				instance.save
+
+				expect(instance.valid?).to be(true)
+			end
+		end
+
+		describe ActiveRecordSurvey::NodeValidation::MinimumLength do
+			describe 'valid when' do
+				it 'has a value greater than the minimum' do
+					@q1_a1.node_validations << ActiveRecordSurvey::NodeValidation::MinimumLength.new(
+						:node => @q1_a1,
+						:value => 3
+					)
+					instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+					instance.instance_nodes.build(
+						:instance => instance,
+						:node => @q1_a1,
+						:value => "this is greater than minimum length",
+					)
+					instance.save
+	
+					expect(instance.valid?).to be(true)
+				end
+			end
+
+			describe 'invalid when' do
+				it 'has a value less than the minimum' do
+					@q1_a1.node_validations << ActiveRecordSurvey::NodeValidation::MinimumLength.new(
+						:node => @q1_a1,
+						:value => 3
+					)
+					instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+					instance.instance_nodes.build(
+						:instance => instance,
+						:node => @q1_a1,
+						:value => "12",
+					)
+					instance.save
+
+					expect(instance.valid?).to be(false)
+				end
+			end
+		end
+
+		describe ActiveRecordSurvey::NodeValidation::MaximumLength do
+			describe 'invalid when' do
+				it 'has a value greater than the maximum' do
+					@q1_a1.node_validations << ActiveRecordSurvey::NodeValidation::MaximumLength.new(
+						:node => @q1_a1,
+						:value => 15
+					)
+					instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+					instance.instance_nodes.build(
+						:instance => instance,
+						:node => @q1_a1,
+						:value => "123456789111213141516",
+					)
+					instance.save
+
+					expect(instance.valid?).to be(false)
+				end
+			end
+
+			describe 'valid when' do
+				it 'has a value less than the maximum' do
+					@q1_a1.node_validations << ActiveRecordSurvey::NodeValidation::MaximumLength.new(
+						:node => @q1_a1,
+						:value => 15
+					)
+					instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+					instance.instance_nodes.build(
+						:instance => instance,
+						:node => @q1_a1,
+						:value => "test",
+					)
+					instance.save
+
+					expect(instance.valid?).to be(true)
+				end
+			end
+		end
+	end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_record_survey
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Butch Marshall
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-24 00:00:00.000000000 Z
+date: 2015-09-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -132,8 +132,10 @@ files:
 - lib/active_record_survey/node/question.rb
 - lib/active_record_survey/node_map.rb
 - lib/active_record_survey/node_validation.rb
+- lib/active_record_survey/node_validation/maximum_answer.rb
 - lib/active_record_survey/node_validation/maximum_length.rb
 - lib/active_record_survey/node_validation/maximum_value.rb
+- lib/active_record_survey/node_validation/minimum_answer.rb
 - lib/active_record_survey/node_validation/minimum_length.rb
 - lib/active_record_survey/node_validation/minimum_value.rb
 - lib/active_record_survey/survey.rb
@@ -146,6 +148,7 @@ files:
 - spec/active_record_survey/node/answer/boolean_spec.rb
 - spec/active_record_survey/node/answer/rank_spec.rb
 - spec/active_record_survey/node/answer/scale_spec.rb
+- spec/active_record_survey/node/answer/text_spec.rb
 - spec/active_record_survey/survey_spec.rb
 - spec/active_record_survey_spec.rb
 - spec/spec_helper.rb
@@ -177,6 +180,7 @@ test_files:
 - spec/active_record_survey/node/answer/boolean_spec.rb
 - spec/active_record_survey/node/answer/rank_spec.rb
 - spec/active_record_survey/node/answer/scale_spec.rb
+- spec/active_record_survey/node/answer/text_spec.rb
 - spec/active_record_survey/survey_spec.rb
 - spec/active_record_survey_spec.rb
 - spec/spec_helper.rb