active_record_shards 2.6.3 → 2.6.4

data/lib/active_record_shards/shard_selection.rb

@@ -30,15 +30,19 @@ module ActiveRecordShards
     end
 
     def shard_name(klass = nil, try_slave = true)
-      s = ActiveRecordShards.rails_env.dup
-      if the_shard = shard(klass)
-        s << '_shard_'
-        s << the_shard
-      end
-      if @on_slave && try_slave
-        s << "_slave" if @on_slave
+      the_shard = shard(klass)
+
+      # Tradeoff: An Array is a slower Hash key, but joining its elements into
+      # one string would generate 3 new String objects needing GC later.
+      key = [the_shard, try_slave, @on_slave]
+
+      @shard_names      ||= {}
+      @shard_names[key] ||= begin
+        s = ActiveRecordShards.rails_env.dup
+        s << "_shard_#{the_shard}" if the_shard
+        s << "_slave"              if @on_slave && try_slave
+        s
       end
-      s
     end
 
     def options

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_record_shards
 version: !ruby/object:Gem::Version
-  version: 2.6.3
+  version: 2.6.4
   prerelease: 
 platform: ruby
 authors:
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-05-10 00:00:00.000000000 Z
+date: 2012-06-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -224,18 +224,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 2639893449143032567
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 2639893449143032567
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24