active_record_proxy_adapters 0.4.2 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1dbad1d7e12818f5671c53475572a48f6ad2645ac528410d96dd851760cce2f5
-  data.tar.gz: 51d8be8b3b36f5c7590d7d804427fdad95d4753c66cee3c3453fafb17d68c36c
+  metadata.gz: 299fa220d8633ce3fe600183dd0dfa78232a48500b8d45fb39f74d15a48189ad
+  data.tar.gz: 9436980b06fadd82948a0d4110c00490fd32d61512ecb9fee07eb94c7c2dd22a
 SHA512:
-  metadata.gz: ccb3f7e1347e7d21a79c36fbf39740f58188d215b7929b2e1926cbe7142bd5f97afebf2ddbc0cfbdf0a8dd4536d18f1586f3f63464b8f3fde096545eb0696431
-  data.tar.gz: 3e9646ced949036ef60f27e0dd2dbf973e75f81efc1be3be90cbb6713b7647b74b1ba2d993d8edd448a0709fae7c70ed7c6d9f68041f2ed34d7b53d54ccbb759
+  metadata.gz: 0fb16ad43cbbfc1053e3b5d82ac856f5f490712a2415b5b85c348a27e87a831ebf72ea212ac5e4b453bcb762e7affb999758c2af4e4334fe6395cb8dc7959a5c
+  data.tar.gz: 32204c72f50b05e5a5a1babb7c478b9c871591b9294744e00c1459657f8aedcf1f1ebde239314515a65769986825d7682bc3e3975c1a44e7e1f54a52f1c96c1a

data/lib/active_record_proxy_adapters/primary_replica_proxy.rb

@@ -50,6 +50,22 @@ module ActiveRecordProxyAdapters
     delegate :connection_handler, to: :connection_class
     delegate :reading_role, :writing_role, to: :active_record_context
 
+    # We need to call .verify! to ensure `configure_connection` is called on the instance before attempting to use it.
+    # This is necessary because the connection may have been lazily initialized and is an unintended side effect from a
+    # change in Rails to defer connection verification: https://github.com/rails/rails/pull/44576
+    # verify! cannot be called before the object is initialized and because of how the proxy hooks into the connection
+    # instance, it has to be done lazily (hence the memoization). Ideally, we shouldn't have to worry about this at all
+    # But there is tight coupling between methods in ActiveRecord::ConnectionAdapters::AbstractAdapter and
+    # its descendants which will require significant refactoring to be decoupled.
+    # See https://github.com/rails/rails/issues/51780
+    def verified_primary_connection
+      @verified_primary_connection ||= begin
+        connected_to(role: writing_role) { primary_connection.verify! }
+
+        primary_connection
+      end
+    end
+
     def replica_pool_unavailable?
       !replica_pool
     end
@@ -120,7 +136,8 @@ module ActiveRecordProxyAdapters
     end
 
     def connection_for(role, sql_string)
-      connection = primary_connection if role == writing_role || replica_pool_unavailable?
+      connection = verified_primary_connection if role == writing_role || replica_pool_unavailable?
+
       connection ||= checkout_replica_connection
 
       result = connected_to(role:) { yield connection }

data/lib/active_record_proxy_adapters/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveRecordProxyAdapters
-  VERSION = "0.4.2"
+  VERSION = "0.4.3"
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: active_record_proxy_adapters
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
 platform: ruby
 authors:
 - Matt Cruz
 bindir: exe
 cert_chain: []
-date: 2025-02-25 00:00:00.000000000 Z
+date: 2025-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord