active_record_proxy_adapters 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2af4688cfe39f70ecd6e984f379b9af4a0bc72970e753393fc23d491b0471a35
-  data.tar.gz: e18681c7b4ed95185bdfa2bd36121c438b113d592223b8cf3838848e530dfd7a
+  metadata.gz: fb04343dd0cca68ac16cbea842d12bc6c85b399883d132cf6b41c82623eb297f
+  data.tar.gz: 684848e566a132de37149d5873619b18a5a671cf7e86d3c09dd4b43d1d36c02e
 SHA512:
-  metadata.gz: 6e0b74329b3de7b75b990fb80ce09b848e605f43b0adbb91f21eed1f01009849f0de2fe8184a21736f5b4515a2f0b71c1a5287fe81aa0e0a189f07dd789dac9e
-  data.tar.gz: 17ff6ee897897fdcbb3b0d2c16bf1c17cd84f6168cb0015ed3c17de90796fb988e82995835f82585d026db0f842cd020fcfe5d2c5c05c70606ff00407742b0bc
+  metadata.gz: c61315b442612b8ac1d28c13dd4d2bf70f7862b1cad438c3603693bec744f73c54dd031bf99da16863ed5caf171def7210f35274735077652799ab4a31c643a8
+  data.tar.gz: 7264ea8bdcfb2e58bd1fa1e61498f97503b9694a9b38ac9d04828b200756d476711085d3528d2b08b260de24d0b8a0f58ecbe10222a0431d4f7a6474d6ec5001

data/lib/active_record_proxy_adapters/primary_replica_proxy.rb

@@ -50,6 +50,22 @@ module ActiveRecordProxyAdapters
     delegate :connection_handler, to: :connection_class
     delegate :reading_role, :writing_role, to: :active_record_context
 
+    # We need to call .verify! to ensure `configure_connection` is called on the instance before attempting to use it.
+    # This is necessary because the connection may have been lazily initialized and is an unintended side effect from a
+    # change in Rails to defer connection verification: https://github.com/rails/rails/pull/44576
+    # verify! cannot be called before the object is initialized and because of how the proxy hooks into the connection
+    # instance, it has to be done lazily (hence the memoization). Ideally, we shouldn't have to worry about this at all
+    # But there is tight coupling between methods in ActiveRecord::ConnectionAdapters::AbstractAdapter and
+    # its descendants which will require significant refactoring to be decoupled.
+    # See https://github.com/rails/rails/issues/51780
+    def verified_primary_connection
+      @verified_primary_connection ||= begin
+        connected_to(role: writing_role) { primary_connection.verify! }
+
+        primary_connection
+      end
+    end
+
     def replica_pool_unavailable?
       !replica_pool
     end
@@ -120,7 +136,8 @@ module ActiveRecordProxyAdapters
     end
 
     def connection_for(role, sql_string)
-      connection = primary_connection if role == writing_role || replica_pool_unavailable?
+      connection = verified_primary_connection if role == writing_role || replica_pool_unavailable?
+
       connection ||= checkout_replica_connection
 
       result = connected_to(role:) { yield connection }

data/lib/active_record_proxy_adapters/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveRecordProxyAdapters
-  VERSION = "0.3.2"
+  VERSION = "0.3.3"
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: active_record_proxy_adapters
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Matt Cruz
 bindir: exe
 cert_chain: []
-date: 2025-02-25 00:00:00.000000000 Z
+date: 2025-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord