active_record_proxy_adapters 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 630c835cd426944c7470317a3d7b632f9c186ab69ed0a4a83edba43d53f47a7e
-  data.tar.gz: 9216867b94293dc0c97c182496140034adf937f7ad92ef6413e4b34631d2f86c
+  metadata.gz: 42b29e68243d909c2468eef3501991bb52739e27d2044074fa8c1e966624662a
+  data.tar.gz: 213bd155fb956b0c51301cafed3f40512de73bad86a99bf1a793adc3f88c6027
 SHA512:
-  metadata.gz: 52f97bb0c97da6ab617d1d8c696423f45564886af3fde305ea3c69278fdfad685220ee977d6a5f52b7b7a151f5ad8714ba3426ae873918e34b85200a81b8a731
-  data.tar.gz: 160d527d9ac1ab6804cf55a3edef741d18c881e9dec8a9e4cde43e81d2ef8ee810c2e02b61bbe32b0072ac9a8ef206265a4a929869fcba1747200031baa8c95f
+  metadata.gz: 7bcad1261a91b872a84c2107fd85edda12dd6d4c84109b64049d9f049f4e1f1350670340d14339b19dd418c4923b7f169151f06beb91aff884f10054fad96725
+  data.tar.gz: bba06f23acec24b1b86d56030513fb7d69465dcc96bb04999328c3c0efce0300ed0000c2fe483793b67e2cde518dd213c729112d6b28d37a11c4f5a69a512b03

data/lib/active_record_proxy_adapters/primary_replica_proxy.rb

@@ -65,6 +65,22 @@ module ActiveRecordProxyAdapters
     delegate :connection_handler, to: :connection_class
     delegate :reading_role, :writing_role, to: :active_record_context
 
+    # We need to call .verify! to ensure `configure_connection` is called on the instance before attempting to use it.
+    # This is necessary because the connection may have been lazily initialized and is an unintended side effect from a
+    # change in Rails to defer connection verification: https://github.com/rails/rails/pull/44576
+    # verify! cannot be called before the object is initialized and because of how the proxy hooks into the connection
+    # instance, it has to be done lazily (hence the memoization). Ideally, we shouldn't have to worry about this at all
+    # But there is tight coupling between methods in ActiveRecord::ConnectionAdapters::AbstractAdapter and
+    # its descendants which will require significant refactoring to be decoupled.
+    # See https://github.com/rails/rails/issues/51780
+    def verified_primary_connection
+      @verified_primary_connection ||= begin
+        connected_to(role: writing_role) { primary_connection.verify! }
+
+        primary_connection
+      end
+    end
+
     def replica_pool_unavailable?
       !replica_pool
     end
@@ -135,7 +151,8 @@ module ActiveRecordProxyAdapters
     end
 
     def connection_for(role, sql_string)
-      connection = primary_connection if role == writing_role || replica_pool_unavailable?
+      connection = verified_primary_connection if role == writing_role || replica_pool_unavailable?
+
       connection ||= checkout_replica_connection
 
       result = connected_to(role:) { yield connection }

data/lib/active_record_proxy_adapters/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveRecordProxyAdapters
-  VERSION = "0.2.3"
+  VERSION = "0.2.4"
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: active_record_proxy_adapters
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Matt Cruz
 bindir: exe
 cert_chain: []
-date: 2025-02-25 00:00:00.000000000 Z
+date: 2025-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord