active_record_host_pool 0.7.0 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3afb58583904ec2e606e050f1a2a13dff283d13e
-  data.tar.gz: 28250948075a9e1e29778b2fdd4a08075da2d4f7
+  metadata.gz: 189352faaaca1fbd14c44dc39277909a0be585c4
+  data.tar.gz: b9a1e4b29d44072e893942b7eadebde7d1d870ca
 SHA512:
-  metadata.gz: 30de25c6e3cc4f8caf0a1f89ed2d07eda70288e4860728190e8efdd0b82cb1b27010399d35c98465319099526bbe124672d05655f52b474c1bc6e13661eaa557
-  data.tar.gz: 11d9b5be51cae0d7e23924cf054a6baca3ba4a3ab1080b55b5a73a42213c094106b157d0ae55cb622d627f7627c3df5a3959d770791b429f93918c378cbb6f06
+  metadata.gz: 1c9b52b4a9c8f5b72612724533465196755022c1d90bfcdf547f8400e296afce14c20b3462a7ef111cf63477f70ad43188eec099072718b04bdf2ac44fb632ec
+  data.tar.gz: 6622d980e61a09900e7ea4810e69fde2e164ca781f347d4727a660095a668fed4ec5e922fa1d5847c12d9999388bf5b347fe9e3eb8fd396ddd6026cf9de83dbf

data/lib/active_record_host_pool/connection_proxy.rb

@@ -32,6 +32,23 @@ module ActiveRecordHostPool
       @cx.send(:expects, *args)
     end
 
+    # Override Delegator#respond_to_missing? to allow private methods to be accessed without warning
+    def respond_to_missing?(m, include_private)
+      __getobj__.respond_to?(m, include_private)
+    end
+
+    def private_methods(all=true)
+      __getobj__.private_methods(all) | super
+    end
+
+    def send(symbol, *args, &blk)
+      if respond_to?(symbol, true) && !__getobj__.respond_to?(symbol, true)
+        super
+      else
+        __getobj__.send(symbol, *args, &blk)
+      end
+    end
+
     private
     def select(*args)
       @cx.__send__(:select, *args)

data/test/helper.rb

@@ -26,7 +26,7 @@ module ARHPTestSetup
       next if name =~ /not_there/
       `echo "drop DATABASE IF EXISTS #{conf['database']}" | mysql --user=#{conf['username']}`
       `echo "create DATABASE #{conf['database']}" | mysql --user=#{conf['username']}`
-      ActiveRecord::Base.establish_connection(name)
+      ActiveRecord::Base.establish_connection(name.to_sym)
       ActiveRecord::Migration.verbose = false
       load(File.dirname(__FILE__) + "/schema.rb")
     end
@@ -43,27 +43,27 @@ module ARHPTestSetup
     eval <<-EOL
       class Test1 < ActiveRecord::Base
         self.table_name = "tests"
-        establish_connection("test_host_1_db_1")
+        establish_connection(:test_host_1_db_1)
       end
 
       class Test2 < ActiveRecord::Base
         self.table_name =  "tests"
-        establish_connection("test_host_1_db_2")
+        establish_connection(:test_host_1_db_2)
       end
 
       class Test3 < ActiveRecord::Base
         self.table_name = "tests"
-        establish_connection("test_host_2_db_3")
+        establish_connection(:test_host_2_db_3)
       end
 
       class Test4 < ActiveRecord::Base
         self.table_name = "tests"
-        establish_connection("test_host_2_db_4")
+        establish_connection(:test_host_2_db_4)
       end
 
       class Test5 < ActiveRecord::Base
         self.table_name = "tests"
-        establish_connection("test_host_2_db_5")
+        establish_connection(:test_host_2_db_5)
       end
     EOL
   end

data/test/test_arhp.rb

@@ -32,6 +32,20 @@ class ActiveRecordHostPoolTest < MiniTest::Unit::TestCase
     assert Test1.connection.is_a?(ActiveRecordHostPool::ConnectionProxy)
   end
 
+  def test_connection_proxy_handles_private_methods
+    # Relies on connection.class returning the real class
+    Test1.connection.class.class_eval do
+      private
+      def test_private_method
+        true
+      end
+    end
+    assert Test1.connection.respond_to?(:test_private_method, true)
+    refute Test1.connection.respond_to?(:test_private_method)
+    assert_includes(Test1.connection.private_methods, :test_private_method)
+    assert(Test1.connection.send(:test_private_method) == true)
+  end
+
   def test_should_not_share_a_query_cache
     Test1.create(:val => 'foo')
     Test2.create(:val => 'foobar')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_record_host_pool
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.1
 platform: ruby
 authors:
 - Ben Osheroff
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: wwtd
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: ''
 email:
 - ben@gimbo.net