active_record_host_pool 0.5.0 → 0.5.1

data/lib/active_record_host_pool/pool_proxy.rb

@@ -67,7 +67,7 @@ module ActiveRecordHostPool
     end
 
     def _pool_key
-      [@config[:host], @config[:port], @config[:socket]]
+      [@config[:host], @config[:port], @config[:socket], @config[:username]]
     end
 
     def _connection_pool

data/test/database.yml

@@ -35,3 +35,13 @@ test_host_2_db_4:
   host: 127.0.0.1
   port: 3306
   reconnect: true
+
+test_host_2_db_5:
+  adapter: mysql
+  encoding: utf8
+  database: arhp_test_4
+  username: snoopy
+  password:
+  host: 127.0.0.1
+  port: 3306
+  reconnect: true

data/test/helper.rb

@@ -34,7 +34,7 @@ class ActiveSupport::TestCase
 
   def arhp_drop_databases
     ActiveRecord::Base.configurations.each do |name, conf|
-      ActiveRecord::Base.connection.execute("DROP DATABASE #{conf['database']}")
+      ActiveRecord::Base.connection.execute("DROP DATABASE if exists #{conf['database']}")
     end
   end
 
@@ -60,6 +60,11 @@ class ActiveSupport::TestCase
         set_table_name "tests"
         establish_connection("test_host_2_db_4")
       end
+
+      class Test5 < ActiveRecord::Base
+        set_table_name "tests"
+        establish_connection("test_host_2_db_5")
+      end
     EOL
   end
 

data/test/test_arhp.rb

@@ -15,6 +15,10 @@ class ActiveRecordHostPoolTest < ActiveSupport::TestCase
     assert(Test1.connection.raw_connection != Test4.connection.raw_connection)
   end
 
+  def test_models_without_matching_usernames_should_not_share_a_connection
+    assert(Test4.connection.raw_connection != Test5.connection.raw_connection)
+  end
+
   def test_should_select_on_correct_database
     action_should_use_correct_database(:select_all, "select 1")
   end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: active_record_host_pool
 version: !ruby/object:Gem::Version 
-  hash: 11
+  hash: 9
   prerelease: 
   segments: 
   - 0
   - 5
-  - 0
-  version: 0.5.0
+  - 1
+  version: 0.5.1
 platform: ruby
 authors: 
 - Ben Osheroff